)]}'
{"nova/exception.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"b7395fe19981f929417b3a77019b28319072497c","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        super(NovaException, self).__init__(message)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def format_message(self):"},{"line_number":165,"context_line":"        if self.__class__.__name__.endswith(\u0027_Remote\u0027):"},{"line_number":166,"context_line":"            try:"},{"line_number":167,"context_line":"                return self.message % self.kwargs"},{"line_number":168,"context_line":"            except (AttributeError, KeyError):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2FzjI%3D","line":165,"updated":"2013-03-26 20:47:17.000000000","message":"The use of \"_Remote\" seems troublesome because that behavior is defined in oslo, not Nova.  I wonder if NovaException should inherit from an exception class in oslo that could hold this sort of method.","commit_id":"e79cde947ae6da980568bb2cbc2f6e4fd935a9b1"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"b7395fe19981f929417b3a77019b28319072497c","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    def format_message(self):"},{"line_number":165,"context_line":"        if self.__class__.__name__.endswith(\u0027_Remote\u0027):"},{"line_number":166,"context_line":"            try:"},{"line_number":167,"context_line":"                return self.message % self.kwargs"},{"line_number":168,"context_line":"            except (AttributeError, KeyError):"},{"line_number":169,"context_line":"                # Return only the message if format failed"},{"line_number":170,"context_line":"                return self.message"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2Fzis%3D","line":167,"updated":"2013-03-26 20:47:17.000000000","message":"Is this interpolation necessary?  It duplicates what happens in __init__ or overwrites the message passed in.","commit_id":"e79cde947ae6da980568bb2cbc2f6e4fd935a9b1"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"f9a5ea03e8ee34e8b9e761a6a4b7991112d12dac","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    def format_message(self):"},{"line_number":165,"context_line":"        if self.__class__.__name__.endswith(\u0027_Remote\u0027):"},{"line_number":166,"context_line":"            try:"},{"line_number":167,"context_line":"                return self.message % self.kwargs"},{"line_number":168,"context_line":"            except (AttributeError, KeyError):"},{"line_number":169,"context_line":"                # Return only the message if format failed"},{"line_number":170,"context_line":"                return self.message"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2FzaU%3D","line":167,"in_reply_to":"AAAAOH%2F%2FzdI%3D","updated":"2013-03-26 22:01:41.000000000","message":"on closer look - this could be replaced with:\n\n    return self.args[0]\n\nWill update the patch for this!","commit_id":"e79cde947ae6da980568bb2cbc2f6e4fd935a9b1"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"42a206a2661b2350bb2a8b54f305b46a3239bbec","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    def format_message(self):"},{"line_number":165,"context_line":"        if self.__class__.__name__.endswith(\u0027_Remote\u0027):"},{"line_number":166,"context_line":"            try:"},{"line_number":167,"context_line":"                return self.message % self.kwargs"},{"line_number":168,"context_line":"            except (AttributeError, KeyError):"},{"line_number":169,"context_line":"                # Return only the message if format failed"},{"line_number":170,"context_line":"                return self.message"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2FzdI%3D","line":167,"in_reply_to":"AAAAOH%2F%2Fzis%3D","updated":"2013-03-26 21:32:46.000000000","message":"Sadly yes - the thing that happens in constructor is passed as an arg to the constructor of exception superclass. Exceptions in 2.x will respond to str() and unicode() by rpitning out their args, but if we override __str__ or __unicode___, this doesn\u0027t work and needs to happen again.","commit_id":"e79cde947ae6da980568bb2cbc2f6e4fd935a9b1"}]}