)]}'
{"nova/conf/configdrive.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"fe83c7bf3f8ac614c8011a50a1102bac04538074","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* ``nova-compute``"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Interdependencies to other options:"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* This option is meaningful with force_config_drive option set to true"},{"line_number":44,"context_line":"  or when --config-drive true flag is used with the nova boot command"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_d7d081f8","line":41,"updated":"2015-12-08 09:15:58.000000000","message":"We came to a conclusion in another review that \"related options\" is easier and sufficient as explanation.","commit_id":"6d59872bb2b82dfe2741b72f694c3c2fc74876ef"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c815b181592b475cac93ce6d464cf97784f35321","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"config_drive_format_opt \u003d cfg.StrOpt(\u0027config_drive_format\u0027,"},{"line_number":19,"context_line":"        default\u003d\u0027iso9660\u0027,"},{"line_number":20,"context_line":"        choices\u003d(\u0027iso9660\u0027, \u0027vfat\u0027),"},{"line_number":21,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a7e1126_77b2e2e6","line":18,"range":{"start_line":18,"start_character":37,"end_line":18,"end_character":59},"updated":"2015-12-21 09:41:50.000000000","message":"nit: I don\u0027t know why the flake8 check for this is disabled, but this is eminently more readable if put on the next line like everything else","commit_id":"069cd6bee0e45b27b7e21ebdf0f62085350332a3"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"ae435d88148027910c0b1169011f0dbbe2dc3432","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"config_drive_format_opt \u003d cfg.StrOpt(\u0027config_drive_format\u0027,"},{"line_number":19,"context_line":"        default\u003d\u0027iso9660\u0027,"},{"line_number":20,"context_line":"        choices\u003d(\u0027iso9660\u0027, \u0027vfat\u0027),"},{"line_number":21,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a7e1126_1ad2a528","line":18,"range":{"start_line":18,"start_character":37,"end_line":18,"end_character":59},"in_reply_to":"3a7e1126_77b2e2e6","updated":"2015-12-21 09:58:25.000000000","message":"The pep8 check isn\u0027t disabled AFAIK. I don\u0027t see the need for another patch set here.","commit_id":"069cd6bee0e45b27b7e21ebdf0f62085350332a3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c815b181592b475cac93ce6d464cf97784f35321","unresolved":false,"context_lines":[{"line_number":18,"context_line":"config_drive_format_opt \u003d cfg.StrOpt(\u0027config_drive_format\u0027,"},{"line_number":19,"context_line":"        default\u003d\u0027iso9660\u0027,"},{"line_number":20,"context_line":"        choices\u003d(\u0027iso9660\u0027, \u0027vfat\u0027),"},{"line_number":21,"context_line":"        help\u003d\"\"\""},{"line_number":22,"context_line":"Configuration drive format"},{"line_number":23,"context_line":"\"\"\")"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a7e1126_7784220a","line":21,"updated":"2015-12-21 09:41:50.000000000","message":"nit: Do we strip whitespace from these strings? If not, you may want to delete the newline","commit_id":"069cd6bee0e45b27b7e21ebdf0f62085350332a3"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"ae435d88148027910c0b1169011f0dbbe2dc3432","unresolved":false,"context_lines":[{"line_number":18,"context_line":"config_drive_format_opt \u003d cfg.StrOpt(\u0027config_drive_format\u0027,"},{"line_number":19,"context_line":"        default\u003d\u0027iso9660\u0027,"},{"line_number":20,"context_line":"        choices\u003d(\u0027iso9660\u0027, \u0027vfat\u0027),"},{"line_number":21,"context_line":"        help\u003d\"\"\""},{"line_number":22,"context_line":"Configuration drive format"},{"line_number":23,"context_line":"\"\"\")"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a7e1126_1afdc5b3","line":21,"in_reply_to":"3a7e1126_7784220a","updated":"2015-12-21 09:58:25.000000000","message":"The output of the \"gate-nova-docs\" job [1] shows that the new line at the beginning isn\u0027t stripped. I see no harm in this behavior. \n\n[1] http://docs-draft.openstack.org/92/254092/5/check/gate-nova-docs/4d021d7//doc/build/html/sample_config.html","commit_id":"069cd6bee0e45b27b7e21ebdf0f62085350332a3"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"170a18ec62da1df95c025b3c5ed554ad53c7213a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 TUBITAK BILGEM"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":15,"id":"da0c15f0_839af812","line":1,"updated":"2016-03-25 15:48:27.000000000","message":"Honestly, I\u0027d really prefer you left off this copyright. You have just moved this code from one module to another and made minor changes.","commit_id":"224fefabc5649a40a5df420d23e0663af7fc6445"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e3fbda803d6008580d460a87127cbe385345faa1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 TUBITAK BILGEM"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a061dce_e2cac019","line":1,"in_reply_to":"ba0121b8_7badde30","updated":"2016-04-05 09:57:07.000000000","message":"I just ignore these lines, I would prefer if they were not here.","commit_id":"224fefabc5649a40a5df420d23e0663af7fc6445"},{"author":{"_account_id":18934,"name":"ecelik","email":"celik.esra@tubitak.gov.tr","username":"esracelik"},"change_message_id":"e5581ffceea7a827946fb185a8bf6b7f94480f3a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 TUBITAK BILGEM"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba0121b8_7badde30","line":1,"in_reply_to":"da0c15f0_839af812","updated":"2016-03-29 07:26:08.000000000","message":"Maybe I should have added this line at https://review.openstack.org/#/c/266875/","commit_id":"224fefabc5649a40a5df420d23e0663af7fc6445"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"af38136630975f0a1072610d5ae226536c3b6bce","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# All Rights Reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a061dce_89c800aa","line":1,"updated":"2016-04-06 12:37:53.000000000","message":"Nit: I think we should drop this line as well really.","commit_id":"eaeab5e93525725ec629253beac932301f3e94a1"}],"nova/hacking/checks.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"c9bcf1d406c6eba155b5ef528d11a75b649db985","unresolved":false,"context_lines":[{"line_number":568,"context_line":"    # check, which makes it flexible enough."},{"line_number":569,"context_line":"    cleaned_up \u003d [\"nova/console/serial.py\","},{"line_number":570,"context_line":"                  \"nova/cmd/serialproxy.py\","},{"line_number":571,"context_line":"                  \"nova/virt/configdrive.py\","},{"line_number":572,"context_line":"                  ]"},{"line_number":573,"context_line":"    if not any(c in filename for c in cleaned_up):"},{"line_number":574,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":9,"id":"da6ed579_e5774d38","line":571,"updated":"2016-01-13 15:40:18.000000000","message":"I realize now that git will have issues with it. I posted an explanation to the ML. I\u0027m really sorry about that.","commit_id":"0e64d2e551c8f7ba466290afcebcb166c3130cb0"}]}