)]}'
{"nova/virt/driver.py":[{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"b6ac302970ed109ba0e504cb26accb3c40914938","unresolved":false,"context_lines":[{"line_number":819,"context_line":"        raise NotImplementedError()"},{"line_number":820,"context_line":""},{"line_number":821,"context_line":"    def get_hypervisor_capabilities(self):"},{"line_number":822,"context_line":"        \"\"\"Returns a dictionary containing hypervisor related capabilities."},{"line_number":823,"context_line":"        \"\"\""},{"line_number":824,"context_line":"        return {}"},{"line_number":825,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_d1be9ad3","line":822,"updated":"2016-01-04 10:14:46.000000000","message":"Why not a NotImplementedError() for this method?\nAlso, could the docstring add a bit more info on the returned dictionary? As in a sample dictionary would be great.","commit_id":"1f0d075be213ce2f32f1911ea677820a85158c1e"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"a0ae2548fb3e4736985a84dd1cd4b824dc6e2fdf","unresolved":false,"context_lines":[{"line_number":819,"context_line":"        raise NotImplementedError()"},{"line_number":820,"context_line":""},{"line_number":821,"context_line":"    def get_hypervisor_capabilities(self):"},{"line_number":822,"context_line":"        \"\"\"Returns a dictionary containing hypervisor related capabilities."},{"line_number":823,"context_line":"        \"\"\""},{"line_number":824,"context_line":"        return {}"},{"line_number":825,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_38a4d5b7","line":822,"in_reply_to":"fa69d971_d1be9ad3","updated":"2016-01-27 09:28:43.000000000","message":"I am going to call this from the ResourceTracker. As there is no actual driver that implements this yet, it would fail every CI. IMO, {} is pretty reasonable return. Alternatively, we could return None, but I\u0027d have to check for None then.\n\nAs for the docstring, yeah, makes sense.","commit_id":"1f0d075be213ce2f32f1911ea677820a85158c1e"}]}
