)]}'
{"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f41b03a7ca068e26880c902308dff8528a004342","unresolved":false,"context_lines":[{"line_number":9075,"context_line":"        \"\"\""},{"line_number":9076,"context_line":"        (refs, resv_id) \u003d self.compute_api.create(self.context,"},{"line_number":9077,"context_line":"                flavors.get_default_flavor(),"},{"line_number":9078,"context_line":"                image_href\u003d\u0027f4000000-0000-0000-0000-000000000000\u0027)"},{"line_number":9079,"context_line":"        self.assertEqual(len(refs), 1)"},{"line_number":9080,"context_line":"        self.assertEqual(refs[0][\u0027reservation_id\u0027], resv_id)"},{"line_number":9081,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_35e759ad","line":9078,"updated":"2015-12-08 20:18:21.000000000","message":"Instance.image_ref isn\u0027t a UUIDField (yet). Did you really hit a failure because of these when running with the o.vo that enforces UUIDness?\n\nI think image_ref is always a uuid, which means we _should_ probably be making this change, but we should also make that field a UUIDField to make it clear.","commit_id":"c805293e772b5a560eae9c28c52b4ae1646f37ec"},{"author":{"_account_id":19619,"name":"Michal Pryc","email":"mpryc@redhat.com","username":"migi"},"change_message_id":"d4a2ac1b8fc6b608111766b4d633aeb0bf90505a","unresolved":false,"context_lines":[{"line_number":9075,"context_line":"        \"\"\""},{"line_number":9076,"context_line":"        (refs, resv_id) \u003d self.compute_api.create(self.context,"},{"line_number":9077,"context_line":"                flavors.get_default_flavor(),"},{"line_number":9078,"context_line":"                image_href\u003d\u0027f4000000-0000-0000-0000-000000000000\u0027)"},{"line_number":9079,"context_line":"        self.assertEqual(len(refs), 1)"},{"line_number":9080,"context_line":"        self.assertEqual(refs[0][\u0027reservation_id\u0027], resv_id)"},{"line_number":9081,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_b04837cd","line":9078,"in_reply_to":"7a740942_35e759ad","updated":"2015-12-08 20:37:13.000000000","message":"Running without UUID for image_href:\n\nTraceback (most recent call last):\n  File \"nova/tests/unit/compute/test_compute.py\", line 9101, in test_reservation_id_one_instance\n    image_href\u003d\u0027some-fake-image\u0027)\n  File \"nova/compute/cells_api.py\", line 199, in create\n    return super(ComputeCellsAPI, self).create(*args, **kwargs)\n  File \"nova/hooks.py\", line 149, in inner\n    rv \u003d f(*args, **kwargs)\n  File \"nova/compute/api.py\", line 1569, in create\n    check_server_group_quota\u003dcheck_server_group_quota)\n  File \"nova/compute/api.py\", line 1162, in _create_instance\n    auto_disk_config, reservation_id, max_count)\n  File \"nova/compute/api.py\", line 921, in _validate_and_build_base_options\n    image_meta \u003d objects.ImageMeta.from_dict(boot_meta)\n  File \"nova/objects/image_meta.py\", line 111, in from_dict\n    return cls(**image_meta)\n  File \"/usr/lib/python2.7/site-packages/oslo_versionedobjects/base.py\", line 303, in __init__\n    setattr(self, key, kwargs[key])\n  File \"/usr/lib/python2.7/site-packages/oslo_versionedobjects/base.py\", line 73, in setter\n    field_value \u003d field.coerce(self, name, value)\n  File \"/usr/lib/python2.7/site-packages/oslo_versionedobjects/fields.py\", line 192, in coerce\n    return self._type.coerce(obj, attr, value)\n  File \"/usr/lib/python2.7/site-packages/oslo_versionedobjects/fields.py\", line 317, in coerce\n    raise ValueError(msg)\nValueError: some-fake-image is not a valid UUID for id","commit_id":"c805293e772b5a560eae9c28c52b4ae1646f37ec"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d8ac992ad5440153e72d64a635c95010107a99d3","unresolved":false,"context_lines":[{"line_number":9075,"context_line":"        \"\"\""},{"line_number":9076,"context_line":"        (refs, resv_id) \u003d self.compute_api.create(self.context,"},{"line_number":9077,"context_line":"                flavors.get_default_flavor(),"},{"line_number":9078,"context_line":"                image_href\u003d\u0027f4000000-0000-0000-0000-000000000000\u0027)"},{"line_number":9079,"context_line":"        self.assertEqual(len(refs), 1)"},{"line_number":9080,"context_line":"        self.assertEqual(refs[0][\u0027reservation_id\u0027], resv_id)"},{"line_number":9081,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_90f41b5b","line":9078,"in_reply_to":"7a740942_35e759ad","updated":"2015-12-08 20:32:18.000000000","message":"Turns out it can be a uuid, id, or url, so .. converting this to a UUIDField would be problematic at this point.","commit_id":"c805293e772b5a560eae9c28c52b4ae1646f37ec"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"586757218affc0a632a2e3e2fb9b5218ea8bf55e","unresolved":false,"context_lines":[{"line_number":9075,"context_line":"        \"\"\""},{"line_number":9076,"context_line":"        (refs, resv_id) \u003d self.compute_api.create(self.context,"},{"line_number":9077,"context_line":"                flavors.get_default_flavor(),"},{"line_number":9078,"context_line":"                image_href\u003d\u0027f4000000-0000-0000-0000-000000000000\u0027)"},{"line_number":9079,"context_line":"        self.assertEqual(len(refs), 1)"},{"line_number":9080,"context_line":"        self.assertEqual(refs[0][\u0027reservation_id\u0027], resv_id)"},{"line_number":9081,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_fa3f7d84","line":9078,"in_reply_to":"7a740942_b04837cd","updated":"2015-12-08 20:44:10.000000000","message":"Ah, okay, this is because ImageMeta has a UUIDField and the ref we\u0027re passing ends up in that fake dict. So this is good.","commit_id":"c805293e772b5a560eae9c28c52b4ae1646f37ec"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f41b03a7ca068e26880c902308dff8528a004342","unresolved":false,"context_lines":[{"line_number":9504,"context_line":"        new_type \u003d flavors.get_flavor_by_flavor_id(\u00274\u0027)"},{"line_number":9505,"context_line":"        instance \u003d objects.Instance("},{"line_number":9506,"context_line":"                       uuid\u003d\u0027f0000000-0000-0000-0000-000000000000\u0027,"},{"line_number":9507,"context_line":"                       image_ref\u003d\u0027foo\u0027,"},{"line_number":9508,"context_line":"                       system_metadata\u003d{},"},{"line_number":9509,"context_line":"                       flavor\u003dnew_type)"},{"line_number":9510,"context_line":"        nwinfo \u003d [fake_network_cache_model.new_vif()]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_f03d5fc4","line":9507,"updated":"2015-12-08 20:18:21.000000000","message":"This is also an image_ref and is not converted. For consistency, we should either convert these or not.\n\nI think my preference would be to leave out the image_ref changes from this patch for now, and then follow up with a change to make that field actually a uuidfield, along with the test corrections to make it work. Either before or after this patch.\n\nIf you prefer to do them all in this patch, I think you should stack a change in front of this one to convert the field type (and deal with the special-case version number correction that will result) and then have this follow with the test conversions in anticipation of the o.vo change coming.","commit_id":"c805293e772b5a560eae9c28c52b4ae1646f37ec"},{"author":{"_account_id":19619,"name":"Michal Pryc","email":"mpryc@redhat.com","username":"migi"},"change_message_id":"d4a2ac1b8fc6b608111766b4d633aeb0bf90505a","unresolved":false,"context_lines":[{"line_number":9504,"context_line":"        new_type \u003d flavors.get_flavor_by_flavor_id(\u00274\u0027)"},{"line_number":9505,"context_line":"        instance \u003d objects.Instance("},{"line_number":9506,"context_line":"                       uuid\u003d\u0027f0000000-0000-0000-0000-000000000000\u0027,"},{"line_number":9507,"context_line":"                       image_ref\u003d\u0027foo\u0027,"},{"line_number":9508,"context_line":"                       system_metadata\u003d{},"},{"line_number":9509,"context_line":"                       flavor\u003dnew_type)"},{"line_number":9510,"context_line":"        nwinfo \u003d [fake_network_cache_model.new_vif()]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_d08dc3d3","line":9507,"in_reply_to":"7a740942_f03d5fc4","updated":"2015-12-08 20:37:13.000000000","message":"I prefer to first submit a patch that allows to run 100% tests and then if required change others. There are tons of other places where uuid is still \"fake\" and test passes as the \u0027uuid\u0027 code block is never met, so it doesn\u0027t affect running tests.\n\nIf we want to change all of those to UUID\u0027s then approach of string replace will take place rather then fixing only those places where the change will cause test to fail.","commit_id":"c805293e772b5a560eae9c28c52b4ae1646f37ec"}]}