)]}'
{"nova/image/glance.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"06133bb75b453617308d0e8f15475b06cd2909fa","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    :returns Integer version number or None if unable to determine version"},{"line_number":162,"context_line":"    \"\"\""},{"line_number":163,"context_line":"    http_client \u003d http.HTTPClient(endpoint, **kwargs)"},{"line_number":164,"context_line":"    try:"},{"line_number":165,"context_line":"        response, content \u003d http_client.get(\u0027/versions\u0027)"},{"line_number":166,"context_line":"        for version in content[\u0027versions\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_ecbecbd3","line":163,"updated":"2015-12-16 20:54:24.000000000","message":"passing arbitrary kwargs here seems like overkill, please pass only the arguments actually needed","commit_id":"56a571f8d9f024dfc368f18624f15ca56529ecee"},{"author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"change_message_id":"e24af92313a2c904939c6f61af56266195a8d1a6","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    :returns Integer version number or None if unable to determine version"},{"line_number":162,"context_line":"    \"\"\""},{"line_number":163,"context_line":"    http_client \u003d http.HTTPClient(endpoint, **kwargs)"},{"line_number":164,"context_line":"    try:"},{"line_number":165,"context_line":"        response, content \u003d http_client.get(\u0027/versions\u0027)"},{"line_number":166,"context_line":"        for version in content[\u0027versions\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_0c4eb7c1","line":163,"in_reply_to":"3a7e1126_ecbecbd3","updated":"2015-12-16 21:06:40.000000000","message":"Thanks.  This method is currently not called.  Once other change sets for Nova using V2 glance merge it will be called by _create_glance_client.  The **kwargs here is really **params as its passed on line 155 above.  I could change _determine_curr_major_version to take parameter named client_params which we would then pass as **client_params here if that helps.","commit_id":"56a571f8d9f024dfc368f18624f15ca56529ecee"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"dfd6c5212e54ab478efbbef811662c78f5ee4aac","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    :returns Integer version number or None if unable to determine version"},{"line_number":162,"context_line":"    \"\"\""},{"line_number":163,"context_line":"    http_client \u003d http.HTTPClient(endpoint, **client_parameters)"},{"line_number":164,"context_line":"    try:"},{"line_number":165,"context_line":"        response, content \u003d http_client.get(\u0027/versions\u0027)"},{"line_number":166,"context_line":"        for version in content[\u0027versions\u0027]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_67376cff","line":163,"updated":"2016-01-06 20:15:22.000000000","message":"this doesn\u0027t really change my concerns. My concern is we should explicitly send down every parameter and not allow for arbitrary pass through. Arbitrary pass couples this code so that it\u0027s never clear want you can and can not do with it later.","commit_id":"096a02fe92d94ae4a7d5289472cf5ada6d7f099d"}]}