)]}'
{"doc/api_samples/servers/v2.16/server-put-resp.json":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"879ed10707721a96e0468ee43409cba96b3cf5c7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"            ]"},{"line_number":12,"context_line":"        },"},{"line_number":13,"context_line":"        \"created\": \"2015-12-07T19:19:36Z\","},{"line_number":14,"context_line":"        \"description\": \"updated-server-description\","},{"line_number":15,"context_line":"        \"flavor\": {"},{"line_number":16,"context_line":"            \"id\": \"1\","},{"line_number":17,"context_line":"            \"links\": ["}],"source_content_type":"application/json","patch_set":5,"id":"da6ed579_031f9408","line":14,"range":{"start_line":14,"start_character":50,"end_line":14,"end_character":52},"updated":"2016-01-15 05:50:10.000000000","message":"Are we going to show this in PUT response also? i did not find that in spec. Please let me know if i missed anything","commit_id":"23afa92a5bbe33aead5502000bce6a3097d25fcc"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"a609f2bc92d0b5021002718bf4fa0ed6cd87eff5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"            ]"},{"line_number":12,"context_line":"        },"},{"line_number":13,"context_line":"        \"created\": \"2015-12-07T19:19:36Z\","},{"line_number":14,"context_line":"        \"description\": \"updated-server-description\","},{"line_number":15,"context_line":"        \"flavor\": {"},{"line_number":16,"context_line":"            \"id\": \"1\","},{"line_number":17,"context_line":"            \"links\": ["}],"source_content_type":"application/json","patch_set":5,"id":"da6ed579_dc8068f9","line":14,"range":{"start_line":14,"start_character":50,"end_line":14,"end_character":52},"in_reply_to":"da6ed579_031f9408","updated":"2016-01-15 13:45:15.000000000","message":"The update API calls show() and returns the results.  \n\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L790\n\nFor this microversion, it will return the description.\n\nI didn\u0027t realize it at the time I wrote the spec.  Is it ok?","commit_id":"23afa92a5bbe33aead5502000bce6a3097d25fcc"}],"doc/api_samples/servers/v2.16/servers-list-resp.json":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"879ed10707721a96e0468ee43409cba96b3cf5c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"da6ed579_c3d5fce4","updated":"2016-01-15 05:50:10.000000000","message":"I do not think we need this file as there is no change in this API and no tests","commit_id":"23afa92a5bbe33aead5502000bce6a3097d25fcc"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"341490c1f5dacd10bbe99bf22cae21f075a913fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"da6ed579_91989279","in_reply_to":"da6ed579_c3d5fce4","updated":"2016-01-15 15:36:44.000000000","message":"I added this file because the ServersSampleJson216Test inherits from ServersSampleJsonTest.  ServersSampleJson29Test also inherits from that.\n\nThe 2.9 folder also has a servers-list json:\nhttps://github.com/openstack/nova/blob/master/nova/tests/functional/api_sample_tests/api_samples/servers/v2.9/servers-list-resp.json.tpl\n...even though no test is added.","commit_id":"23afa92a5bbe33aead5502000bce6a3097d25fcc"}],"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"b4868a95c92abb6cd5bfa3ae09686635ea00efd6","unresolved":false,"context_lines":[{"line_number":514,"context_line":"    @validation.schema(schema_server_create, \u00272.1\u0027)"},{"line_number":515,"context_line":"    def create(self, req, body):"},{"line_number":516,"context_line":"        \"\"\"Creates a new server for a given user.\"\"\""},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":519,"context_line":"        server_dict \u003d body[\u0027server\u0027]"},{"line_number":520,"context_line":"        password \u003d self._get_server_admin_password(server_dict)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_6514d843","side":"PARENT","line":517,"updated":"2016-01-13 07:34:01.000000000","message":"This is unrelated change. We shouldn\u0027t touch","commit_id":"da17a368e6e22d59fb97fa78a88574c795105182"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"931ec9ba58852d55591d95aa87ad6bd1d29ce982","unresolved":false,"context_lines":[{"line_number":514,"context_line":"    @validation.schema(schema_server_create, \u00272.1\u0027)"},{"line_number":515,"context_line":"    def create(self, req, body):"},{"line_number":516,"context_line":"        \"\"\"Creates a new server for a given user.\"\"\""},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":519,"context_line":"        server_dict \u003d body[\u0027server\u0027]"},{"line_number":520,"context_line":"        password \u003d self._get_server_admin_password(server_dict)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_3602613e","side":"PARENT","line":517,"in_reply_to":"da6ed579_3c6fc92c","updated":"2016-01-14 02:38:03.000000000","message":"Sorry, I didn\u0027t describe cearly. I mean there is blank line removed (this line 517) this is unrelated change. We shouldn\u0027t remove this blank line","commit_id":"da17a368e6e22d59fb97fa78a88574c795105182"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"cd910cd7472aeb4468d86667484bcc609b95894c","unresolved":false,"context_lines":[{"line_number":514,"context_line":"    @validation.schema(schema_server_create, \u00272.1\u0027)"},{"line_number":515,"context_line":"    def create(self, req, body):"},{"line_number":516,"context_line":"        \"\"\"Creates a new server for a given user.\"\"\""},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":519,"context_line":"        server_dict \u003d body[\u0027server\u0027]"},{"line_number":520,"context_line":"        password \u003d self._get_server_admin_password(server_dict)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_3c6fc92c","side":"PARENT","line":517,"in_reply_to":"da6ed579_6514d843","updated":"2016-01-13 14:01:11.000000000","message":"I\u0027m not clear about this.  The change is add the description argument, so I need to change this function.","commit_id":"da17a368e6e22d59fb97fa78a88574c795105182"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"f46e37d2426d733a50a0467148e30fba63727101","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        if list(self.create_schema_manager):"},{"line_number":213,"context_line":"            self.create_schema_manager.map(self._create_extension_schema,"},{"line_number":214,"context_line":"                                           self.schema_server_create_v217,"},{"line_number":215,"context_line":"                                          \u00272.1\u0027)"},{"line_number":216,"context_line":"            self.create_schema_manager.map(self._create_extension_schema,"},{"line_number":217,"context_line":"                                           self.schema_server_create, \u00272.1\u0027)"},{"line_number":218,"context_line":"            self.create_schema_manager.map(self._create_extension_schema,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba63e191_d3854107","line":215,"range":{"start_line":215,"start_character":42,"end_line":215,"end_character":47},"updated":"2016-01-20 03:14:11.000000000","message":"I think we should pass \u00272.7\u0027 at here. Then each extension point will know which version requested","commit_id":"4470005c248acd408ec487b1094723d013af04c1"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"daaab46a0db75be292d29fc840b7b6a9f49d556d","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        if list(self.create_schema_manager):"},{"line_number":213,"context_line":"            self.create_schema_manager.map(self._create_extension_schema,"},{"line_number":214,"context_line":"                                           self.schema_server_create_v217,"},{"line_number":215,"context_line":"                                          \u00272.1\u0027)"},{"line_number":216,"context_line":"            self.create_schema_manager.map(self._create_extension_schema,"},{"line_number":217,"context_line":"                                           self.schema_server_create, \u00272.1\u0027)"},{"line_number":218,"context_line":"            self.create_schema_manager.map(self._create_extension_schema,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba63e191_a164e648","line":215,"range":{"start_line":215,"start_character":42,"end_line":215,"end_character":47},"in_reply_to":"ba63e191_d3854107","updated":"2016-01-20 12:18:54.000000000","message":"Done, but I had to change \nhttps://github.com/openstack/nova/blob/master/nova/tests/unit/api/openstack/compute/test_serversV21.py#L3706\nfor the unit tests to work.","commit_id":"4470005c248acd408ec487b1094723d013af04c1"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"f46e37d2426d733a50a0467148e30fba63727101","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        if list(self.update_schema_manager):"},{"line_number":233,"context_line":"            self.update_schema_manager.map(self._update_extension_schema,"},{"line_number":234,"context_line":"                                           self.schema_server_update_v217,"},{"line_number":235,"context_line":"                                           \u00272.1\u0027)"},{"line_number":236,"context_line":"            self.update_schema_manager.map(self._update_extension_schema,"},{"line_number":237,"context_line":"                                           self.schema_server_update, \u00272.1\u0027)"},{"line_number":238,"context_line":"            self.update_schema_manager.map(self._update_extension_schema,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba63e191_737d751b","line":235,"range":{"start_line":235,"start_character":43,"end_line":235,"end_character":48},"updated":"2016-01-20 03:14:11.000000000","message":"ditto","commit_id":"4470005c248acd408ec487b1094723d013af04c1"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"daaab46a0db75be292d29fc840b7b6a9f49d556d","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        if list(self.update_schema_manager):"},{"line_number":233,"context_line":"            self.update_schema_manager.map(self._update_extension_schema,"},{"line_number":234,"context_line":"                                           self.schema_server_update_v217,"},{"line_number":235,"context_line":"                                           \u00272.1\u0027)"},{"line_number":236,"context_line":"            self.update_schema_manager.map(self._update_extension_schema,"},{"line_number":237,"context_line":"                                           self.schema_server_update, \u00272.1\u0027)"},{"line_number":238,"context_line":"            self.update_schema_manager.map(self._update_extension_schema,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba63e191_2151d662","line":235,"range":{"start_line":235,"start_character":43,"end_line":235,"end_character":48},"in_reply_to":"ba63e191_737d751b","updated":"2016-01-20 12:18:54.000000000","message":"Done","commit_id":"4470005c248acd408ec487b1094723d013af04c1"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"f46e37d2426d733a50a0467148e30fba63727101","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        if list(self.rebuild_schema_manager):"},{"line_number":253,"context_line":"            self.rebuild_schema_manager.map(self._rebuild_extension_schema,"},{"line_number":254,"context_line":"                                            self.schema_server_rebuild_v217,"},{"line_number":255,"context_line":"                                            \u00272.1\u0027)"},{"line_number":256,"context_line":"            self.rebuild_schema_manager.map(self._rebuild_extension_schema,"},{"line_number":257,"context_line":"                                            self.schema_server_rebuild, \u00272.1\u0027)"},{"line_number":258,"context_line":"            self.rebuild_schema_manager.map(self._rebuild_extension_schema,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba63e191_5372b14a","line":255,"range":{"start_line":255,"start_character":44,"end_line":255,"end_character":49},"updated":"2016-01-20 03:14:11.000000000","message":"ditto","commit_id":"4470005c248acd408ec487b1094723d013af04c1"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"daaab46a0db75be292d29fc840b7b6a9f49d556d","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        if list(self.rebuild_schema_manager):"},{"line_number":253,"context_line":"            self.rebuild_schema_manager.map(self._rebuild_extension_schema,"},{"line_number":254,"context_line":"                                            self.schema_server_rebuild_v217,"},{"line_number":255,"context_line":"                                            \u00272.1\u0027)"},{"line_number":256,"context_line":"            self.rebuild_schema_manager.map(self._rebuild_extension_schema,"},{"line_number":257,"context_line":"                                            self.schema_server_rebuild, \u00272.1\u0027)"},{"line_number":258,"context_line":"            self.rebuild_schema_manager.map(self._rebuild_extension_schema,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba63e191_e14adeab","line":255,"range":{"start_line":255,"start_character":44,"end_line":255,"end_character":49},"in_reply_to":"ba63e191_5372b14a","updated":"2016-01-20 12:18:54.000000000","message":"Done","commit_id":"4470005c248acd408ec487b1094723d013af04c1"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"8de7f6fb12271a1df97f12cb6cfd8d44d2c39925","unresolved":false,"context_lines":[{"line_number":537,"context_line":"        name \u003d common.normalize_name(server_dict[\u0027name\u0027])"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"        req_version \u003d req.api_version_request"},{"line_number":540,"context_line":"        if req_version \u003e\u003d api_version_request.APIVersionRequest(\"2.17\"):"},{"line_number":541,"context_line":"            if \u0027description\u0027 in server_dict:"},{"line_number":542,"context_line":"                # This is allowed to be None"},{"line_number":543,"context_line":"                description \u003d server_dict[\u0027description\u0027]"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a68dd71_b5c0d07d","line":540,"range":{"start_line":540,"start_character":8,"end_line":540,"end_character":72},"updated":"2016-01-21 12:22:04.000000000","message":"nit: here can be changed like\n\n if api_version_request.is_supported(req, min_version\u003d\u00272.17\u0027):\n\nfor the readability.","commit_id":"88364a8d7e3f46e851f1133b0b5e998e886cc731"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"a41e6ede2752dedeed6a9ce5c271de99695d6e34","unresolved":false,"context_lines":[{"line_number":537,"context_line":"        name \u003d common.normalize_name(server_dict[\u0027name\u0027])"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"        req_version \u003d req.api_version_request"},{"line_number":540,"context_line":"        if req_version \u003e\u003d api_version_request.APIVersionRequest(\"2.17\"):"},{"line_number":541,"context_line":"            if \u0027description\u0027 in server_dict:"},{"line_number":542,"context_line":"                # This is allowed to be None"},{"line_number":543,"context_line":"                description \u003d server_dict[\u0027description\u0027]"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a68dd71_6b80cbc0","line":540,"range":{"start_line":540,"start_character":8,"end_line":540,"end_character":72},"in_reply_to":"9a68dd71_b5c0d07d","updated":"2016-01-23 16:18:14.000000000","message":"Addressed in the rebase to 2.18.","commit_id":"88364a8d7e3f46e851f1133b0b5e998e886cc731"}],"nova/api/openstack/compute/views/servers.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"879ed10707721a96e0468ee43409cba96b3cf5c7","unresolved":false,"context_lines":[{"line_number":310,"context_line":"                                          else False)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        if (request.api_version_request \u003e\u003d"},{"line_number":313,"context_line":"                api_version_request.APIVersionRequest(\"2.16\")):"},{"line_number":314,"context_line":"            server[\"server\"][\"description\"] \u003d instance.get("},{"line_number":315,"context_line":"                                                \"display_description\")"},{"line_number":316,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_e3c7e093","line":313,"range":{"start_line":313,"start_character":59,"end_line":313,"end_character":63},"updated":"2016-01-15 05:50:10.000000000","message":"Use this-\napi_version_request.is_supported(request, min_version\u003d\"2.16\")","commit_id":"23afa92a5bbe33aead5502000bce6a3097d25fcc"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"a609f2bc92d0b5021002718bf4fa0ed6cd87eff5","unresolved":false,"context_lines":[{"line_number":310,"context_line":"                                          else False)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        if (request.api_version_request \u003e\u003d"},{"line_number":313,"context_line":"                api_version_request.APIVersionRequest(\"2.16\")):"},{"line_number":314,"context_line":"            server[\"server\"][\"description\"] \u003d instance.get("},{"line_number":315,"context_line":"                                                \"display_description\")"},{"line_number":316,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_bca1f495","line":313,"range":{"start_line":313,"start_character":59,"end_line":313,"end_character":63},"in_reply_to":"da6ed579_e3c7e093","updated":"2016-01-15 13:45:15.000000000","message":"Ok, will do","commit_id":"23afa92a5bbe33aead5502000bce6a3097d25fcc"}],"nova/tests/functional/api_sample_tests/api_samples/servers/v2.16/server-get-resp.json.tpl":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"879ed10707721a96e0468ee43409cba96b3cf5c7","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        \"key_name\": null,"},{"line_number":37,"context_line":"        \"links\": ["},{"line_number":38,"context_line":"            {"},{"line_number":39,"context_line":"                \"href\": \"%(host)s/v2/openstack/servers/%(uuid)s\","},{"line_number":40,"context_line":"                \"rel\": \"self\""},{"line_number":41,"context_line":"            },"},{"line_number":42,"context_line":"            {"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"da6ed579_439b4c66","line":39,"range":{"start_line":39,"start_character":46,"end_line":39,"end_character":47},"updated":"2016-01-15 05:50:10.000000000","message":"Change  to %(host)s/v2/openstack -\u003e %(versioned_compute_endpoint)\n\nPlease refer latest sample files","commit_id":"23afa92a5bbe33aead5502000bce6a3097d25fcc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"879ed10707721a96e0468ee43409cba96b3cf5c7","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                \"rel\": \"self\""},{"line_number":41,"context_line":"            },"},{"line_number":42,"context_line":"            {"},{"line_number":43,"context_line":"                \"href\": \"%(host)s/openstack/servers/%(uuid)s\","},{"line_number":44,"context_line":"                \"rel\": \"bookmark\""},{"line_number":45,"context_line":"            }"},{"line_number":46,"context_line":"        ],"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"da6ed579_03a23499","line":43,"range":{"start_line":43,"start_character":25,"end_line":43,"end_character":43},"updated":"2016-01-15 05:50:10.000000000","message":"%(host)s/openstack -\u003e %(compute_endpoint)s","commit_id":"23afa92a5bbe33aead5502000bce6a3097d25fcc"}],"nova/tests/functional/api_sample_tests/api_samples/servers/v2.16/server-post-resp.json.tpl":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"879ed10707721a96e0468ee43409cba96b3cf5c7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"        \"id\": \"%(id)s\","},{"line_number":5,"context_line":"        \"links\": ["},{"line_number":6,"context_line":"            {"},{"line_number":7,"context_line":"                \"href\": \"http://openstack.example.com/v2/openstack/servers/%(uuid)s\","},{"line_number":8,"context_line":"                \"rel\": \"self\""},{"line_number":9,"context_line":"            },"},{"line_number":10,"context_line":"            {"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"da6ed579_63b9b0cb","line":7,"range":{"start_line":7,"start_character":83,"end_line":7,"end_character":85},"updated":"2016-01-15 05:50:10.000000000","message":"ditto","commit_id":"23afa92a5bbe33aead5502000bce6a3097d25fcc"}],"nova/tests/functional/api_sample_tests/api_samples/servers/v2.16/server-put-resp.json.tpl":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"879ed10707721a96e0468ee43409cba96b3cf5c7","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        },"},{"line_number":34,"context_line":"        \"links\": ["},{"line_number":35,"context_line":"            {"},{"line_number":36,"context_line":"                \"href\": \"%(host)s/v2/openstack/servers/%(uuid)s\","},{"line_number":37,"context_line":"                \"rel\": \"self\""},{"line_number":38,"context_line":"            },"},{"line_number":39,"context_line":"            {"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"da6ed579_43b26ce6","line":36,"range":{"start_line":36,"start_character":63,"end_line":36,"end_character":65},"updated":"2016-01-15 05:50:10.000000000","message":"ditto","commit_id":"23afa92a5bbe33aead5502000bce6a3097d25fcc"}],"nova/tests/functional/api_sample_tests/api_samples/servers/v2.16/servers-details-resp.json.tpl":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"879ed10707721a96e0468ee43409cba96b3cf5c7","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            \"key_name\": null,"},{"line_number":38,"context_line":"            \"links\": ["},{"line_number":39,"context_line":"                {"},{"line_number":40,"context_line":"                    \"href\": \"%(host)s/v2/openstack/servers/%(uuid)s\","},{"line_number":41,"context_line":"                    \"rel\": \"self\""},{"line_number":42,"context_line":"                },"},{"line_number":43,"context_line":"                {"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"da6ed579_a3c32837","line":40,"range":{"start_line":40,"start_character":67,"end_line":40,"end_character":69},"updated":"2016-01-15 05:50:10.000000000","message":"ditto. I think its in all place","commit_id":"23afa92a5bbe33aead5502000bce6a3097d25fcc"}],"nova/tests/functional/api_sample_tests/api_samples/servers/v2.16/servers-list-resp.json.tpl":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"879ed10707721a96e0468ee43409cba96b3cf5c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"da6ed579_43002c66","updated":"2016-01-15 05:50:10.000000000","message":"This too, not needed","commit_id":"23afa92a5bbe33aead5502000bce6a3097d25fcc"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"341490c1f5dacd10bbe99bf22cae21f075a913fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"da6ed579_31bc46ba","in_reply_to":"da6ed579_43002c66","updated":"2016-01-15 15:36:44.000000000","message":"Please see my comment/question doc file.","commit_id":"23afa92a5bbe33aead5502000bce6a3097d25fcc"}],"nova/tests/functional/api_sample_tests/test_servers.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"b4868a95c92abb6cd5bfa3ae09686635ea00efd6","unresolved":false,"context_lines":[{"line_number":120,"context_line":"class ServersSampleJson213Test(ServersSampleJsonTest):"},{"line_number":121,"context_line":"    request_api_version \u003d \u00272.13\u0027"},{"line_number":122,"context_line":"    sample_dir \u003d \u0027servers\u0027"},{"line_number":123,"context_line":"    scenarios \u003d [(\u0027v2_13\u0027, {})]"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def test_servers_post(self):"},{"line_number":126,"context_line":"        return self._post_server(False)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_6521384d","line":123,"updated":"2016-01-13 07:34:01.000000000","message":"There is a little change for how to write sample test, you will found that when you rebase. you can reference this https://github.com/openstack/nova/blob/master/nova/tests/functional/api_sample_tests/test_keypairs.py#L172-L175","commit_id":"4e178823ab08a8c1e5ec34966476410338169fe1"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"cd910cd7472aeb4468d86667484bcc609b95894c","unresolved":false,"context_lines":[{"line_number":120,"context_line":"class ServersSampleJson213Test(ServersSampleJsonTest):"},{"line_number":121,"context_line":"    request_api_version \u003d \u00272.13\u0027"},{"line_number":122,"context_line":"    sample_dir \u003d \u0027servers\u0027"},{"line_number":123,"context_line":"    scenarios \u003d [(\u0027v2_13\u0027, {})]"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def test_servers_post(self):"},{"line_number":126,"context_line":"        return self._post_server(False)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_3c04a948","line":123,"in_reply_to":"da6ed579_6521384d","updated":"2016-01-13 14:01:11.000000000","message":"ok","commit_id":"4e178823ab08a8c1e5ec34966476410338169fe1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"879ed10707721a96e0468ee43409cba96b3cf5c7","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        subs[\u0027mac_addr\u0027] \u003d \u0027(?:[a-f0-9]{2}:){5}[a-f0-9]{2}\u0027"},{"line_number":149,"context_line":"        subs[\u0027access_ip_v4\u0027] \u003d \u00271.2.3.4\u0027"},{"line_number":150,"context_line":"        subs[\u0027access_ip_v6\u0027] \u003d \u002780fe::\u0027"},{"line_number":151,"context_line":"        self._verify_response(\u0027servers-details-resp\u0027, subs, response, 200)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"class ServerSortKeysJsonTests(ServersSampleBase):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_c34f3c32","line":151,"range":{"start_line":151,"start_character":73,"end_line":151,"end_character":74},"updated":"2016-01-15 05:50:10.000000000","message":"Also add tests for show server too","commit_id":"23afa92a5bbe33aead5502000bce6a3097d25fcc"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"b08d49683a64ceccb08822ad1ed026e7b8e98548","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        subs[\u0027mac_addr\u0027] \u003d \u0027(?:[a-f0-9]{2}:){5}[a-f0-9]{2}\u0027"},{"line_number":149,"context_line":"        subs[\u0027access_ip_v4\u0027] \u003d \u00271.2.3.4\u0027"},{"line_number":150,"context_line":"        subs[\u0027access_ip_v6\u0027] \u003d \u002780fe::\u0027"},{"line_number":151,"context_line":"        self._verify_response(\u0027servers-details-resp\u0027, subs, response, 200)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"class ServerSortKeysJsonTests(ServersSampleBase):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_1f66e950","line":151,"range":{"start_line":151,"start_character":73,"end_line":151,"end_character":74},"in_reply_to":"da6ed579_7c713c0b","updated":"2016-01-15 16:04:10.000000000","message":"Looking at it again... I think this is covered by test_servers_get in ServersSampleJsonTest","commit_id":"23afa92a5bbe33aead5502000bce6a3097d25fcc"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"a609f2bc92d0b5021002718bf4fa0ed6cd87eff5","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        subs[\u0027mac_addr\u0027] \u003d \u0027(?:[a-f0-9]{2}:){5}[a-f0-9]{2}\u0027"},{"line_number":149,"context_line":"        subs[\u0027access_ip_v4\u0027] \u003d \u00271.2.3.4\u0027"},{"line_number":150,"context_line":"        subs[\u0027access_ip_v6\u0027] \u003d \u002780fe::\u0027"},{"line_number":151,"context_line":"        self._verify_response(\u0027servers-details-resp\u0027, subs, response, 200)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"class ServerSortKeysJsonTests(ServersSampleBase):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_7c713c0b","line":151,"range":{"start_line":151,"start_character":73,"end_line":151,"end_character":74},"in_reply_to":"da6ed579_c34f3c32","updated":"2016-01-15 13:45:15.000000000","message":"ok, will do","commit_id":"23afa92a5bbe33aead5502000bce6a3097d25fcc"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"f46e37d2426d733a50a0467148e30fba63727101","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        subs \u003d {"},{"line_number":132,"context_line":"            \u0027image_id\u0027: fake.get_valid_image_id(),"},{"line_number":133,"context_line":"            \u0027hostid\u0027: \u0027[a-f0-9]+\u0027,"},{"line_number":134,"context_line":"            \u0027compute_endpoint\u0027: self._get_compute_endpoint(),"},{"line_number":135,"context_line":"            \u0027versioned_compute_endpoint\u0027: self._get_vers_compute_endpoint(),"},{"line_number":136,"context_line":"            \u0027glance_host\u0027: self._get_glance_host(),"},{"line_number":137,"context_line":"            \u0027access_ip_v4\u0027: \u00271.2.3.4\u0027,"},{"line_number":138,"context_line":"            \u0027access_ip_v6\u0027: \u002780fe::\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba63e191_ae41460d","line":135,"range":{"start_line":134,"start_character":12,"end_line":135,"end_character":76},"updated":"2016-01-20 03:14:11.000000000","message":"in _verify_response, those two subs will get from https://github.com/openstack/nova/blob/master/nova/tests/functional/api_samples_test_base.py#L356-L357\n\nSo we don\u0027t need add them at here.","commit_id":"4470005c248acd408ec487b1094723d013af04c1"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"daaab46a0db75be292d29fc840b7b6a9f49d556d","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        subs \u003d {"},{"line_number":132,"context_line":"            \u0027image_id\u0027: fake.get_valid_image_id(),"},{"line_number":133,"context_line":"            \u0027hostid\u0027: \u0027[a-f0-9]+\u0027,"},{"line_number":134,"context_line":"            \u0027compute_endpoint\u0027: self._get_compute_endpoint(),"},{"line_number":135,"context_line":"            \u0027versioned_compute_endpoint\u0027: self._get_vers_compute_endpoint(),"},{"line_number":136,"context_line":"            \u0027glance_host\u0027: self._get_glance_host(),"},{"line_number":137,"context_line":"            \u0027access_ip_v4\u0027: \u00271.2.3.4\u0027,"},{"line_number":138,"context_line":"            \u0027access_ip_v6\u0027: \u002780fe::\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba63e191_e1c09e2c","line":135,"range":{"start_line":134,"start_character":12,"end_line":135,"end_character":76},"in_reply_to":"ba63e191_ae41460d","updated":"2016-01-20 12:18:54.000000000","message":"Done","commit_id":"4470005c248acd408ec487b1094723d013af04c1"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"f46e37d2426d733a50a0467148e30fba63727101","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        uuid \u003d self._post_server()"},{"line_number":263,"context_line":"        image \u003d fake.get_valid_image_id()"},{"line_number":264,"context_line":"        params \u003d {"},{"line_number":265,"context_line":"            \u0027host\u0027: self._get_host(),"},{"line_number":266,"context_line":"            \u0027compute_endpoint\u0027: self._get_compute_endpoint(),"},{"line_number":267,"context_line":"            \u0027versioned_compute_endpoint\u0027: self._get_vers_compute_endpoint(),"},{"line_number":268,"context_line":"            \u0027uuid\u0027: image,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba63e191_ce127a09","line":265,"range":{"start_line":265,"start_character":12,"end_line":265,"end_character":37},"updated":"2016-01-20 03:14:11.000000000","message":"the template didn\u0027t use this field","commit_id":"4470005c248acd408ec487b1094723d013af04c1"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"daaab46a0db75be292d29fc840b7b6a9f49d556d","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        uuid \u003d self._post_server()"},{"line_number":263,"context_line":"        image \u003d fake.get_valid_image_id()"},{"line_number":264,"context_line":"        params \u003d {"},{"line_number":265,"context_line":"            \u0027host\u0027: self._get_host(),"},{"line_number":266,"context_line":"            \u0027compute_endpoint\u0027: self._get_compute_endpoint(),"},{"line_number":267,"context_line":"            \u0027versioned_compute_endpoint\u0027: self._get_vers_compute_endpoint(),"},{"line_number":268,"context_line":"            \u0027uuid\u0027: image,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba63e191_81de820f","line":265,"range":{"start_line":265,"start_character":12,"end_line":265,"end_character":37},"in_reply_to":"ba63e191_ce127a09","updated":"2016-01-20 12:18:54.000000000","message":"Done","commit_id":"4470005c248acd408ec487b1094723d013af04c1"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"f46e37d2426d733a50a0467148e30fba63727101","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        image \u003d fake.get_valid_image_id()"},{"line_number":264,"context_line":"        params \u003d {"},{"line_number":265,"context_line":"            \u0027host\u0027: self._get_host(),"},{"line_number":266,"context_line":"            \u0027compute_endpoint\u0027: self._get_compute_endpoint(),"},{"line_number":267,"context_line":"            \u0027versioned_compute_endpoint\u0027: self._get_vers_compute_endpoint(),"},{"line_number":268,"context_line":"            \u0027uuid\u0027: image,"},{"line_number":269,"context_line":"            \u0027name\u0027: \u0027foobar\u0027,"},{"line_number":270,"context_line":"            \u0027description\u0027: \u0027description of foobar\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba63e191_0e62d2ad","line":267,"range":{"start_line":266,"start_character":12,"end_line":267,"end_character":76},"updated":"2016-01-20 03:14:11.000000000","message":"I didn\u0027t see the template use this two fields.","commit_id":"4470005c248acd408ec487b1094723d013af04c1"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"daaab46a0db75be292d29fc840b7b6a9f49d556d","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        image \u003d fake.get_valid_image_id()"},{"line_number":264,"context_line":"        params \u003d {"},{"line_number":265,"context_line":"            \u0027host\u0027: self._get_host(),"},{"line_number":266,"context_line":"            \u0027compute_endpoint\u0027: self._get_compute_endpoint(),"},{"line_number":267,"context_line":"            \u0027versioned_compute_endpoint\u0027: self._get_vers_compute_endpoint(),"},{"line_number":268,"context_line":"            \u0027uuid\u0027: image,"},{"line_number":269,"context_line":"            \u0027name\u0027: \u0027foobar\u0027,"},{"line_number":270,"context_line":"            \u0027description\u0027: \u0027description of foobar\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba63e191_a1e146d2","line":267,"range":{"start_line":266,"start_character":12,"end_line":267,"end_character":76},"in_reply_to":"ba63e191_0e62d2ad","updated":"2016-01-20 12:18:54.000000000","message":"Done","commit_id":"4470005c248acd408ec487b1094723d013af04c1"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"f46e37d2426d733a50a0467148e30fba63727101","unresolved":false,"context_lines":[{"line_number":269,"context_line":"            \u0027name\u0027: \u0027foobar\u0027,"},{"line_number":270,"context_line":"            \u0027description\u0027: \u0027description of foobar\u0027,"},{"line_number":271,"context_line":"            \u0027pass\u0027: \u0027seekr3t\u0027,"},{"line_number":272,"context_line":"            \u0027hostid\u0027: \u0027[a-f0-9]+\u0027,"},{"line_number":273,"context_line":"            \u0027access_ip_v4\u0027: \u00271.2.3.4\u0027,"},{"line_number":274,"context_line":"            \u0027access_ip_v6\u0027: \u002780fe::\u0027,"},{"line_number":275,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba63e191_ae262666","line":272,"range":{"start_line":272,"start_character":12,"end_line":272,"end_character":33},"updated":"2016-01-20 03:14:11.000000000","message":"ditto","commit_id":"4470005c248acd408ec487b1094723d013af04c1"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"daaab46a0db75be292d29fc840b7b6a9f49d556d","unresolved":false,"context_lines":[{"line_number":269,"context_line":"            \u0027name\u0027: \u0027foobar\u0027,"},{"line_number":270,"context_line":"            \u0027description\u0027: \u0027description of foobar\u0027,"},{"line_number":271,"context_line":"            \u0027pass\u0027: \u0027seekr3t\u0027,"},{"line_number":272,"context_line":"            \u0027hostid\u0027: \u0027[a-f0-9]+\u0027,"},{"line_number":273,"context_line":"            \u0027access_ip_v4\u0027: \u00271.2.3.4\u0027,"},{"line_number":274,"context_line":"            \u0027access_ip_v6\u0027: \u002780fe::\u0027,"},{"line_number":275,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba63e191_41ff2a67","line":272,"range":{"start_line":272,"start_character":12,"end_line":272,"end_character":33},"in_reply_to":"ba63e191_ae262666","updated":"2016-01-20 12:18:54.000000000","message":"The test failed after removing this, so I added it back.","commit_id":"4470005c248acd408ec487b1094723d013af04c1"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"dee92975659910d7f30da0bd0373c480ba3b7857","unresolved":false,"context_lines":[{"line_number":257,"context_line":"        uuid \u003d self._post_server()"},{"line_number":258,"context_line":"        image \u003d fake.get_valid_image_id()"},{"line_number":259,"context_line":"        params \u003d {"},{"line_number":260,"context_line":"            \u0027host\u0027: self._get_host(),"},{"line_number":261,"context_line":"            \u0027compute_endpoint\u0027: self._get_compute_endpoint(),"},{"line_number":262,"context_line":"            \u0027versioned_compute_endpoint\u0027: self._get_vers_compute_endpoint(),"},{"line_number":263,"context_line":"            \u0027uuid\u0027: image,"},{"line_number":264,"context_line":"            \u0027name\u0027: \u0027foobar\u0027,"},{"line_number":265,"context_line":"            \u0027description\u0027: \u0027description of foobar\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a68dd71_31b087f4","line":262,"range":{"start_line":260,"start_character":12,"end_line":262,"end_character":75},"updated":"2016-01-21 03:28:04.000000000","message":"you fix line 176, but forget this one. I will respin the patch quickly","commit_id":"103c0f5f4688f6df5113d95caeadf87450674fc3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ae0bf88347f4c415ea3e95adeeaddc25b879a5ba","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        }"},{"line_number":138,"context_line":"        self._verify_response(\u0027server-put-resp\u0027, subs, response, 200)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def test_servers_details(self):"},{"line_number":141,"context_line":"        uuid \u003d self.test_servers_post()"},{"line_number":142,"context_line":"        response \u003d self._do_get(\u0027servers/detail\u0027,"},{"line_number":143,"context_line":"                                api_version\u003dself.microversion)"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a68dd71_5582b495","line":140,"range":{"start_line":140,"start_character":33,"end_line":140,"end_character":35},"updated":"2016-01-21 12:09:24.000000000","message":"This tests too can be run from base class if you change L99 to uuid \u003d self.test_servers_post()\n\nSame like show tests but can be done later no big deal.","commit_id":"88364a8d7e3f46e851f1133b0b5e998e886cc731"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"a41e6ede2752dedeed6a9ce5c271de99695d6e34","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        }"},{"line_number":138,"context_line":"        self._verify_response(\u0027server-put-resp\u0027, subs, response, 200)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def test_servers_details(self):"},{"line_number":141,"context_line":"        uuid \u003d self.test_servers_post()"},{"line_number":142,"context_line":"        response \u003d self._do_get(\u0027servers/detail\u0027,"},{"line_number":143,"context_line":"                                api_version\u003dself.microversion)"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a68dd71_8be3bfa3","line":140,"range":{"start_line":140,"start_character":33,"end_line":140,"end_character":35},"in_reply_to":"9a68dd71_5582b495","updated":"2016-01-23 16:18:14.000000000","message":"Addressed in the 2.18 rebase.","commit_id":"88364a8d7e3f46e851f1133b0b5e998e886cc731"}],"nova/tests/functional/test_servers.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"b4868a95c92abb6cd5bfa3ae09686635ea00efd6","unresolved":false,"context_lines":[{"line_number":595,"context_line":"        self._headers \u003d {}"},{"line_number":596,"context_line":"        self._headers[\u0027X-OpenStack-Nova-API-Version\u0027] \u003d \u00272.13\u0027"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"        # Create a server with a description"},{"line_number":599,"context_line":"        self._create_server_and_verify(True, \u0027test description\u0027)"},{"line_number":600,"context_line":"        # Create a server with an empty description"},{"line_number":601,"context_line":"        self._create_server_and_verify(True, \u0027\u0027)"},{"line_number":602,"context_line":"        # Create a server with description set to None"},{"line_number":603,"context_line":"        self._create_server_and_verify()"},{"line_number":604,"context_line":"        # Create a server without setting the description"},{"line_number":605,"context_line":"        self._create_server_and_verify(False)"},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"    def test_update_server_with_description(self):"},{"line_number":608,"context_line":"        fake_network.set_stub_network_methods(self.stubs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_e5a1a8aa","line":605,"range":{"start_line":598,"start_character":8,"end_line":605,"end_character":45},"updated":"2016-01-13 07:34:01.000000000","message":"actually we can just write some unittest for those input validation test. The unittest at https://github.com/openstack/nova/blob/master/nova/tests/unit/api/openstack/compute/test_serversV21.py","commit_id":"4e178823ab08a8c1e5ec34966476410338169fe1"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"931ec9ba58852d55591d95aa87ad6bd1d29ce982","unresolved":false,"context_lines":[{"line_number":595,"context_line":"        self._headers \u003d {}"},{"line_number":596,"context_line":"        self._headers[\u0027X-OpenStack-Nova-API-Version\u0027] \u003d \u00272.13\u0027"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"        # Create a server with a description"},{"line_number":599,"context_line":"        self._create_server_and_verify(True, \u0027test description\u0027)"},{"line_number":600,"context_line":"        # Create a server with an empty description"},{"line_number":601,"context_line":"        self._create_server_and_verify(True, \u0027\u0027)"},{"line_number":602,"context_line":"        # Create a server with description set to None"},{"line_number":603,"context_line":"        self._create_server_and_verify()"},{"line_number":604,"context_line":"        # Create a server without setting the description"},{"line_number":605,"context_line":"        self._create_server_and_verify(False)"},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"    def test_update_server_with_description(self):"},{"line_number":608,"context_line":"        fake_network.set_stub_network_methods(self.stubs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_f6f7e956","line":605,"range":{"start_line":598,"start_character":8,"end_line":605,"end_character":45},"in_reply_to":"da6ed579_87845ed4","updated":"2016-01-14 02:38:03.000000000","message":"ok, more tests are better :)","commit_id":"4e178823ab08a8c1e5ec34966476410338169fe1"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"cd910cd7472aeb4468d86667484bcc609b95894c","unresolved":false,"context_lines":[{"line_number":595,"context_line":"        self._headers \u003d {}"},{"line_number":596,"context_line":"        self._headers[\u0027X-OpenStack-Nova-API-Version\u0027] \u003d \u00272.13\u0027"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"        # Create a server with a description"},{"line_number":599,"context_line":"        self._create_server_and_verify(True, \u0027test description\u0027)"},{"line_number":600,"context_line":"        # Create a server with an empty description"},{"line_number":601,"context_line":"        self._create_server_and_verify(True, \u0027\u0027)"},{"line_number":602,"context_line":"        # Create a server with description set to None"},{"line_number":603,"context_line":"        self._create_server_and_verify()"},{"line_number":604,"context_line":"        # Create a server without setting the description"},{"line_number":605,"context_line":"        self._create_server_and_verify(False)"},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"    def test_update_server_with_description(self):"},{"line_number":608,"context_line":"        fake_network.set_stub_network_methods(self.stubs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_87845ed4","line":605,"range":{"start_line":598,"start_character":8,"end_line":605,"end_character":45},"in_reply_to":"da6ed579_e5a1a8aa","updated":"2016-01-13 14:01:11.000000000","message":"I wanted these to test the round-trip of creating then getting the server, including database access.  So I think I should keep these tests, but I will also add unit tests.","commit_id":"4e178823ab08a8c1e5ec34966476410338169fe1"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"b4868a95c92abb6cd5bfa3ae09686635ea00efd6","unresolved":false,"context_lines":[{"line_number":613,"context_line":"        # Create a server with an initial description"},{"line_number":614,"context_line":"        server_id \u003d self._create_server(True, \u0027test desc 1\u0027)[1][\u0027id\u0027]"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        # Update the server with a description"},{"line_number":617,"context_line":"        self._update_server_and_verify(server_id, True, \u0027updated desc\u0027)"},{"line_number":618,"context_line":"        # Update the server name without changing the description"},{"line_number":619,"context_line":"        self._update_server_and_verify(server_id, False, \u0027updated desc\u0027)"},{"line_number":620,"context_line":"        # Update the server with an empty description"},{"line_number":621,"context_line":"        self._update_server_and_verify(server_id, True, \u0027\u0027)"},{"line_number":622,"context_line":"        # Update the server by removing the description (set to None)"},{"line_number":623,"context_line":"        self._update_server_and_verify(server_id)"},{"line_number":624,"context_line":"        # Update the server with a 2nd new description"},{"line_number":625,"context_line":"        self._update_server_and_verify(server_id, True, \u0027updated desc2\u0027)"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"        # Cleanup"},{"line_number":628,"context_line":"        self._delete_server(server_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_8591cc54","line":625,"range":{"start_line":616,"start_character":8,"end_line":625,"end_character":72},"updated":"2016-01-13 07:34:01.000000000","message":"ditto, unittests are enough for input valiation","commit_id":"4e178823ab08a8c1e5ec34966476410338169fe1"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"cd910cd7472aeb4468d86667484bcc609b95894c","unresolved":false,"context_lines":[{"line_number":613,"context_line":"        # Create a server with an initial description"},{"line_number":614,"context_line":"        server_id \u003d self._create_server(True, \u0027test desc 1\u0027)[1][\u0027id\u0027]"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        # Update the server with a description"},{"line_number":617,"context_line":"        self._update_server_and_verify(server_id, True, \u0027updated desc\u0027)"},{"line_number":618,"context_line":"        # Update the server name without changing the description"},{"line_number":619,"context_line":"        self._update_server_and_verify(server_id, False, \u0027updated desc\u0027)"},{"line_number":620,"context_line":"        # Update the server with an empty description"},{"line_number":621,"context_line":"        self._update_server_and_verify(server_id, True, \u0027\u0027)"},{"line_number":622,"context_line":"        # Update the server by removing the description (set to None)"},{"line_number":623,"context_line":"        self._update_server_and_verify(server_id)"},{"line_number":624,"context_line":"        # Update the server with a 2nd new description"},{"line_number":625,"context_line":"        self._update_server_and_verify(server_id, True, \u0027updated desc2\u0027)"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"        # Cleanup"},{"line_number":628,"context_line":"        self._delete_server(server_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_4756665d","line":625,"range":{"start_line":616,"start_character":8,"end_line":625,"end_character":72},"in_reply_to":"da6ed579_8591cc54","updated":"2016-01-13 14:01:11.000000000","message":"same reply as above.","commit_id":"4e178823ab08a8c1e5ec34966476410338169fe1"}],"releasenotes/notes/user-settable-server-description-89dcfc75677e31bc.yaml":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"b4868a95c92abb6cd5bfa3ae09686635ea00efd6","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    and was not visible to the user.  So, servers you"},{"line_number":14,"context_line":"    created with microversions prior to 2.13 will return"},{"line_number":15,"context_line":"    the description equals the name on server details"},{"line_number":16,"context_line":"    microversion 2.13.   "}],"source_content_type":"text/x-yaml","patch_set":2,"id":"da6ed579_a5997070","line":16,"updated":"2016-01-13 07:34:01.000000000","message":"extra blank space","commit_id":"4e178823ab08a8c1e5ec34966476410338169fe1"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"cd910cd7472aeb4468d86667484bcc609b95894c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    and was not visible to the user.  So, servers you"},{"line_number":14,"context_line":"    created with microversions prior to 2.13 will return"},{"line_number":15,"context_line":"    the description equals the name on server details"},{"line_number":16,"context_line":"    microversion 2.13.   "}],"source_content_type":"text/x-yaml","patch_set":2,"id":"da6ed579_876e9eff","line":16,"in_reply_to":"da6ed579_a5997070","updated":"2016-01-13 14:01:11.000000000","message":"ok","commit_id":"4e178823ab08a8c1e5ec34966476410338169fe1"}]}