)]}'
{"nova/conf/hyperv.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"67d1c9fdc5c0df7a4ed215f946f3aebcab3c889c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"hyperv_opt_group \u003d cfg.OptGroup(\"hyperv\","},{"line_number":20,"context_line":"                title\u003d\"The Hyper-V feature\","},{"line_number":21,"context_line":"                help\u003d\"\"\""},{"line_number":22,"context_line":"The hyperv feature allows you to configure"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_6d86cadc","line":19,"updated":"2015-12-18 16:05:45.000000000","message":"The group is new, but that\u0027s perfectly fine.","commit_id":"f4cdd5ed4c6ebe7198529860bd00fecf976e4c8b"},{"author":{"_account_id":18934,"name":"ecelik","email":"celik.esra@tubitak.gov.tr","username":"esracelik"},"change_message_id":"d0a57424c4201f29b52b6f46f4c35f7a5704e107","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"hyperv_opt_group \u003d cfg.OptGroup(\"hyperv\","},{"line_number":20,"context_line":"                title\u003d\"The Hyper-V feature\","},{"line_number":21,"context_line":"                help\u003d\"\"\""},{"line_number":22,"context_line":"The hyperv feature allows you to configure"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_a83ee089","line":19,"in_reply_to":"3a7e1126_6d86cadc","updated":"2015-12-18 16:15:49.000000000","message":"thanks, is it good to have a group for each config option section?","commit_id":"f4cdd5ed4c6ebe7198529860bd00fecf976e4c8b"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"7b40de33afe22be75616cc46e2c9ee85dcac0a48","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"hyperv_opt_group \u003d cfg.OptGroup(\"hyperv\","},{"line_number":20,"context_line":"                title\u003d\"The Hyper-V feature\","},{"line_number":21,"context_line":"                help\u003d\"\"\""},{"line_number":22,"context_line":"The hyperv feature allows you to configure"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_08613405","line":19,"in_reply_to":"3a7e1126_a83ee089","updated":"2015-12-18 16:34:46.000000000","message":"I think it will be useful in the future when we can emit it in the \"nova.conf.sample\" file. Right now we use a version of \"oslo.config\" which contains a bug which prevents that. As soon as we switch to a newer version we can expose the group help text to the ops. Until then we have documentation for the code contributors :)","commit_id":"f4cdd5ed4c6ebe7198529860bd00fecf976e4c8b"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"eb73ffc79ed59d4cdd6a51c4f4a48f5a0bd2dd18","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"def list_opts():"},{"line_number":160,"context_line":"    return {hyperv_opt_group.name: ALL_OPTS}"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_8f1310b8","line":160,"range":{"start_line":160,"start_character":28,"end_line":160,"end_character":33},"updated":"2016-01-13 15:15:30.000000000","message":"Nova uses now oslo.config 3.2.0 which includes the fix which makes it possible to use the OptGroup object here instead of its name. We can do that in a later patch, so no need to push a new patch set here.","commit_id":"eb3a2951a98462c2a3e26c7571b679cc4ba23794"},{"author":{"_account_id":18934,"name":"ecelik","email":"celik.esra@tubitak.gov.tr","username":"esracelik"},"change_message_id":"7e8bc7775429fc5f9c55b967f1bd5aaf417b0958","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"def list_opts():"},{"line_number":160,"context_line":"    return {hyperv_opt_group.name: ALL_OPTS}"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_f01b6871","line":160,"range":{"start_line":160,"start_character":28,"end_line":160,"end_character":33},"in_reply_to":"da6ed579_8f1310b8","updated":"2016-01-14 07:13:26.000000000","message":"OK, I will fix this now with checks.py change.","commit_id":"eb3a2951a98462c2a3e26c7571b679cc4ba23794"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"96105e591478e8cf179eb1b9d458bea04d5b6300","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a57f1b5_725108d8","line":1,"updated":"2016-02-10 18:27:29.000000000","message":"nit: it\u0027s 2016 already. :)","commit_id":"9e12e9be7ddfc33e7f48f2fbb6dffb382ffb2e5a"},{"author":{"_account_id":18934,"name":"ecelik","email":"celik.esra@tubitak.gov.tr","username":"esracelik"},"change_message_id":"268d96579ca928afaab93a248775e89c2610ea55","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a57f1b5_f5e082fc","line":1,"in_reply_to":"3a57f1b5_725108d8","updated":"2016-02-10 18:43:26.000000000","message":"Yes :) I had some more comments on this. I don\u0027t know this copyright thing.. I will learn and correct it soon.","commit_id":"9e12e9be7ddfc33e7f48f2fbb6dffb382ffb2e5a"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"96105e591478e8cf179eb1b9d458bea04d5b6300","unresolved":false,"context_lines":[{"line_number":34,"context_line":"implies 512MB of RAM allocated at startup"},{"line_number":35,"context_line":"\"\"\")"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"enable_instance_metrics_collection_opt \u003d \\"},{"line_number":38,"context_line":"                cfg.BoolOpt(\u0027enable_instance_metrics_collection\u0027,"},{"line_number":39,"context_line":"                default\u003dFalse,"},{"line_number":40,"context_line":"                help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a57f1b5_d2ab1c88","line":37,"updated":"2016-02-10 18:27:29.000000000","message":"hm, we tend not to use \\ for multiline statements, if we can help it. You could have instead:\n\n    enable_instance_metrics_collection_opt \u003d cfg.BoolOpt(\n        \u0027enable_instance_metrics_collection\u0027,\n        default\u003dFalse,\n        help\u003d\"\"\"\n    ...\n\nditto for other lines with \"\\\". If you going to apply this, then, for consistency, it should be done for each config option.","commit_id":"9e12e9be7ddfc33e7f48f2fbb6dffb382ffb2e5a"},{"author":{"_account_id":18934,"name":"ecelik","email":"celik.esra@tubitak.gov.tr","username":"esracelik"},"change_message_id":"268d96579ca928afaab93a248775e89c2610ea55","unresolved":false,"context_lines":[{"line_number":34,"context_line":"implies 512MB of RAM allocated at startup"},{"line_number":35,"context_line":"\"\"\")"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"enable_instance_metrics_collection_opt \u003d \\"},{"line_number":38,"context_line":"                cfg.BoolOpt(\u0027enable_instance_metrics_collection\u0027,"},{"line_number":39,"context_line":"                default\u003dFalse,"},{"line_number":40,"context_line":"                help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a57f1b5_f59c025f","line":37,"in_reply_to":"3a57f1b5_d2ab1c88","updated":"2016-02-10 18:43:26.000000000","message":"It was just for the max character length for this line. Your suggestion it better of course, thanks","commit_id":"9e12e9be7ddfc33e7f48f2fbb6dffb382ffb2e5a"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"7dd47f8c79ee8f77c904ba906636bbcdc0aaac09","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 TUBITAK BILGEM"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba0121b8_85105350","line":1,"updated":"2016-03-29 05:41:16.000000000","message":"Isn\u0027t this just a cut and paste effectively? Why the copyright notice change?","commit_id":"828fd83d9720f537b79c9d132b0a1160ae12cbcf"},{"author":{"_account_id":18934,"name":"ecelik","email":"celik.esra@tubitak.gov.tr","username":"esracelik"},"change_message_id":"79fad783e8767f021569486d202d5e9d6f127a37","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 TUBITAK BILGEM"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba0121b8_5b9f3a03","line":1,"in_reply_to":"ba0121b8_85105350","updated":"2016-03-29 07:24:55.000000000","message":"With the improvement of help texts it is a big change I think. Maybe I added the line earlier.","commit_id":"828fd83d9720f537b79c9d132b0a1160ae12cbcf"}],"nova/hacking/checks.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"eb73ffc79ed59d4cdd6a51c4f4a48f5a0bd2dd18","unresolved":false,"context_lines":[{"line_number":568,"context_line":"    # check, which makes it flexible enough."},{"line_number":569,"context_line":"    cleaned_up \u003d [\"nova/console/serial.py\","},{"line_number":570,"context_line":"                  \"nova/cmd/serialproxy.py\","},{"line_number":571,"context_line":"                  \"nova/virt/hyperv/\","},{"line_number":572,"context_line":"                  ]"},{"line_number":573,"context_line":"    if not any(c in filename for c in cleaned_up):"},{"line_number":574,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_cfc5883c","line":571,"updated":"2016-01-13 15:15:30.000000000","message":"yes, like that, very cool","commit_id":"eb3a2951a98462c2a3e26c7571b679cc4ba23794"}]}