)]}'
{"id":"openstack%2Fnova~25521","triplet_id":"openstack%2Fnova~milestone-proposed~I2ad7b02239baada5fd2174f5b61cdc90ec91e6f5","project":"openstack/nova","branch":"milestone-proposed","topic":"bug/1160489","hashtags":[],"change_id":"I2ad7b02239baada5fd2174f5b61cdc90ec91e6f5","subject":"Always store old instance_type during a migration","status":"MERGED","created":"2013-03-27 13:59:18.000000000","updated":"2013-03-27 17:28:40.000000000","submitted":"2013-03-27 17:28:38.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"944a9eb855a9b48e2bae8e6eaaade6eb2cab6bea","_number":25521,"virtual_id_number":25521,"owner":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},{"value":2,"date":"2013-03-27 17:28:38.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"value":0,"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"recommended":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"all":[{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":1,"date":"2013-03-27 15:20:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-03-27 15:09:12.000000000","_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"value":1,"date":"2013-03-27 16:53:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":1,"date":"2013-03-27 14:08:10.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"all":[{"value":0,"date":"2013-03-27 13:59:41.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-03-27 15:09:12.000000000","_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"value":0,"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":0,"date":"2013-03-27 13:59:18.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"value":0,"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-03-27 13:59:18.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2013-03-27 13:59:41.000000000","updated_by":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"reviewer":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"state":"REVIEWER"},{"updated":"2013-03-27 15:09:12.000000000","updated_by":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"reviewer":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"state":"REVIEWER"},{"updated":"2013-03-27 15:20:31.000000000","updated_by":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"reviewer":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"state":"REVIEWER"},{"updated":"2013-03-27 16:53:50.000000000","updated_by":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"reviewer":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"state":"REVIEWER"},{"updated":"2013-03-27 17:28:38.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"58c023c14992879959285274bd69f29d65e6010d","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2013-03-27 14:08:10.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"927038400730c1298ff0b7e3826e5b77bf53be8c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-27 14:39:30.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/25521/1/check/gate-nova-pep8/23689 : SUCCESS\n- http://logs.openstack.org/25521/1/check/gate-nova-docs/17984 : SUCCESS\n- http://logs.openstack.org/25521/1/check/gate-nova-python26/19392 : SUCCESS\n- http://logs.openstack.org/25521/1/check/gate-nova-python26-rhel6/185 : FAILURE (non-voting)\n- http://logs.openstack.org/25521/1/check/gate-nova-python27/19480 : SUCCESS\n- http://logs.openstack.org/25521/1/check/gate-tempest-devstack-vm-full/10698 : SUCCESS\n- http://logs.openstack.org/25521/1/check/gate-tempest-devstack-vm-postgres-full/10414 : SUCCESS\n- http://logs.openstack.org/25521/1/check/gate-tempest-devstack-vm-quantum/16263 : SUCCESS\n- http://logs.openstack.org/25521/1/check/gate-nova-pylint/9889 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"2b7b61220290da998708f60798be2b49f7b5d695","author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"date":"2013-03-27 15:09:12.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\ntargeted to rc2 and in master","accounts_in_message":[],"_revision_number":1},{"id":"ef41b3bfd978e7b4369a63cb61cda090d41c2089","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-27 15:09:35.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"f5cfcd181c4d96a4d1330beb5a1e6c7a773a3950","author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"date":"2013-03-27 15:20:31.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nI like simple.","accounts_in_message":[],"_revision_number":1},{"id":"e2c601c2b440d8f4581a48d9aee0ef7706fce80c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-27 15:41:03.000000000","message":"Patch Set 1: Fails\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/25521/1/gate/gate-nova-docs/17992 : SUCCESS\n- http://logs.openstack.org/25521/1/gate/gate-nova-pep8/23697 : SUCCESS\n- http://logs.openstack.org/25521/1/gate/gate-nova-python26/19400 : SUCCESS\n- http://logs.openstack.org/25521/1/gate/gate-nova-python27/19488 : SUCCESS\n- http://logs.openstack.org/25521/1/gate/gate-tempest-devstack-vm-full/10710 : FAILURE\n- http://logs.openstack.org/25521/1/gate/gate-tempest-devstack-vm-postgres-full/10426 : FAILURE\n- http://logs.openstack.org/25521/1/gate/gate-tempest-devstack-vm-quantum/16282 : FAILURE\n","accounts_in_message":[],"_revision_number":1},{"id":"117863938f6e00588862371f14e5269a32f023aa","author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"date":"2013-03-27 15:52:38.000000000","message":"Patch Set 1:\n\nreverify","accounts_in_message":[],"_revision_number":1},{"id":"9637ad9ade6297531622becde2b9036ec85c7b79","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-27 15:52:43.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"a6c817719300a0ff942c19244c743179fe2ac92f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-27 16:09:59.000000000","message":"Patch Set 1: Fails\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/25521/1/gate/gate-nova-docs/17994 : SUCCESS\n- http://logs.openstack.org/25521/1/gate/gate-nova-pep8/23699 : SUCCESS\n- http://logs.openstack.org/25521/1/gate/gate-nova-python26/19402 : SUCCESS\n- http://logs.openstack.org/25521/1/gate/gate-nova-python27/19490 : SUCCESS\n- http://logs.openstack.org/25521/1/gate/gate-tempest-devstack-vm-full/10716 : FAILURE\n- http://logs.openstack.org/25521/1/gate/gate-tempest-devstack-vm-postgres-full/10432 : FAILURE\n- http://logs.openstack.org/25521/1/gate/gate-tempest-devstack-vm-quantum/16288 : FAILURE\n","accounts_in_message":[],"_revision_number":1},{"id":"87354c886c6466b085f7b67ef6a4d9552acf93b7","author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"date":"2013-03-27 16:37:44.000000000","message":"Patch Set 1:\n\nreverify no bug","accounts_in_message":[],"_revision_number":1},{"id":"7a75048844d90a1cea857afb5dcaa37b29dfa088","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-27 16:37:49.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"133564c7bc820d7cb816868ad37ea236c03811f5","author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"date":"2013-03-27 16:53:50.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"65acddcb242d8ca017a46ec5fdbb4b94f4a08a6b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-27 17:28:38.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/25521/1/gate/gate-nova-docs/18006 : SUCCESS\n- http://logs.openstack.org/25521/1/gate/gate-nova-pep8/23713 : SUCCESS\n- http://logs.openstack.org/25521/1/gate/gate-nova-python26/19414 : SUCCESS\n- http://logs.openstack.org/25521/1/gate/gate-nova-python27/19502 : SUCCESS\n- http://logs.openstack.org/25521/1/gate/gate-tempest-devstack-vm-full/10734 : SUCCESS\n- http://logs.openstack.org/25521/1/gate/gate-tempest-devstack-vm-postgres-full/10450 : SUCCESS\n- http://logs.openstack.org/25521/1/gate/gate-tempest-devstack-vm-quantum/16310 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"e8c9f1acc54439d263d772cdfcdc7bd502e75519","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-27 17:28:40.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1fa7879071310fda7d8393716441dd02be38fc30","revisions":{"1fa7879071310fda7d8393716441dd02be38fc30":{"kind":"REWORK","_number":1,"created":"2013-03-27 13:59:18.000000000","uploader":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"ref":"refs/changes/21/25521/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/21/25521/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/25521/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/25521/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/25521/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/21/25521/1"}}},"commit":{"parents":[{"commit":"50f2537512d016b9bbfe1e10be240a09301e2aaa","subject":"Merge \"Pass project id in quantum driver secgroup list\" into milestone-proposed","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/50f2537512d016b9bbfe1e10be240a09301e2aaa"}]}],"author":{"name":"Dan Smith","email":"danms@us.ibm.com","date":"2013-03-26 20:14:56.000000000","tz":-420},"committer":{"name":"Russell Bryant","email":"rbryant@redhat.com","date":"2013-03-27 13:58:29.000000000","tz":-240},"subject":"Always store old instance_type during a migration","message":"Always store old instance_type during a migration\n\nPreviously, we were trying to optimize for the migration (as opposed\nto resize) case by not storing the old_ instance_type. However,\nthis is confusing to the vast amount of shared code that works on\nmigrations and resizes because the \"is old \u003d\u003d new\" logic must be\nreplicated everywhere. To cut our losses and hopefully avoid other\nhidden dragons, this patch removes the optimization and makes both\npaths the same.\n\nFixes bug #1160489\n\nChange-Id: I2ad7b02239baada5fd2174f5b61cdc90ec91e6f5\n(cherry picked from commit 985d703d2731fe9ec968ef6698bbf39743ede32a)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1fa7879071310fda7d8393716441dd02be38fc30"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1fa7879071310fda7d8393716441dd02be38fc30"}]},"branch":"refs/heads/milestone-proposed"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
