)]}'
{"nova/conf/scheduler.py":[{"author":{"_account_id":7111,"name":"hadi esiely","email":"hadi.esiely-barrera@jhuapl.edu","username":"HEsiely"},"change_message_id":"c7748bcba196e18d08a0af8432d68eeac9ae4740","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        default\u003d\"\","},{"line_number":226,"context_line":"        help\u003d\"\"\""},{"line_number":227,"context_line":"The absolute path to the scheduler configuration JSON file, if any. This file"},{"line_number":228,"context_line":"location is monitored by the scheduler for changes and reloads it if needed. It"},{"line_number":229,"context_line":"is converted from JSON to a Python data structure, and passed into the"},{"line_number":230,"context_line":"filtering and weighing functions of the scheduler, which can use it for dynamic"},{"line_number":231,"context_line":"configuration."}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_26092a32","line":228,"updated":"2015-12-09 22:51:38.000000000","message":"nit: since we are talking about the scheduler reloading as needed, it may be clearer to say:\n\n\"This file location is monitored by the scheduler for changes and is reloaded  if needed.\"","commit_id":"8ac4e1ab57be208d33f069f671b0fb0d8b98c38c"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"9616b857ade37918fe54990adb5749ef21b0e7dc","unresolved":false,"context_lines":[{"line_number":219,"context_line":"\"\"\")"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"scheduler_json_config_location_opt \u003d cfg.StrOpt("},{"line_number":222,"context_line":"        \"scheduler_json_config_location\","},{"line_number":223,"context_line":"        default\u003d\"\","},{"line_number":224,"context_line":"        help\u003d\"\"\""},{"line_number":225,"context_line":"The absolute path to the scheduler configuration JSON file, if any. This file"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba63e191_3e837dce","line":222,"updated":"2016-01-19 09:31:33.000000000","message":"nit: I added it to the config options which should be revisited. I couldn\u0027t figure out what the structure of the JSON file should look like. The docstring here describes good enough what its purpose is though.","commit_id":"112cc7d4d473046b1028b8a914563e5d125ba391"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"3706c9d55d5a3448f1843078cb10cc96134d73de","unresolved":false,"context_lines":[{"line_number":219,"context_line":"\"\"\")"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"scheduler_json_config_location_opt \u003d cfg.StrOpt("},{"line_number":222,"context_line":"        \"scheduler_json_config_location\","},{"line_number":223,"context_line":"        default\u003d\"\","},{"line_number":224,"context_line":"        help\u003d\"\"\""},{"line_number":225,"context_line":"The absolute path to the scheduler configuration JSON file, if any. This file"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba63e191_cb793395","line":222,"in_reply_to":"ba63e191_3e837dce","updated":"2016-01-19 14:02:57.000000000","message":"Yes, I looked around for examples but didn\u0027t find any. And we can always enhance docstrings in subsequent patches.","commit_id":"112cc7d4d473046b1028b8a914563e5d125ba391"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"277be5ee254adf3fbc08a3222068f5193ecd855e","unresolved":false,"context_lines":[{"line_number":207,"context_line":"This is the message queue topic that the scheduler \u0027listens\u0027 on. It is used"},{"line_number":208,"context_line":"when the scheduler service is started up to configure the queue, and whenever"},{"line_number":209,"context_line":"an RPC call to the scheduler is made. There is almost never any reason to ever"},{"line_number":210,"context_line":"change this value."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"* Services that use this:"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_85b90731","line":210,"updated":"2016-01-20 18:22:28.000000000","message":"Then why is it even a thing?!?","commit_id":"46076369794418ea001f5047b6f9eff8b27f2148"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"7518efe2cf44e0eaf7075b5e1e55356126f65c3f","unresolved":false,"context_lines":[{"line_number":207,"context_line":"This is the message queue topic that the scheduler \u0027listens\u0027 on. It is used"},{"line_number":208,"context_line":"when the scheduler service is started up to configure the queue, and whenever"},{"line_number":209,"context_line":"an RPC call to the scheduler is made. There is almost never any reason to ever"},{"line_number":210,"context_line":"change this value."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"* Services that use this:"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_7e11e2ab","line":210,"in_reply_to":"9a68dd71_85b90731","updated":"2016-01-21 08:57:03.000000000","message":"@Michael: I\u0027ve put it on the etherpad [1] which has a section called \"Config options to re-evaluate\". These \"*_topic\" options seem odd to me too, but I didn\u0027t yet dig into the git history why they got added. Right now, we just figure out what they do. After that we can ask ops if they really use that and then possibly remove the config options.\n\n[1] https://etherpad.openstack.org/p/config-options","commit_id":"46076369794418ea001f5047b6f9eff8b27f2148"}]}