)]}'
{"nova/conf/scheduler.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"21c4f358c413cd5e80e550326a8e4ee9e763cce1","unresolved":false,"context_lines":[{"line_number":332,"context_line":""},{"line_number":333,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":334,"context_line":"a different scheduler, this option has no effect. Also note that this setting"},{"line_number":335,"context_line":"only affects scheduling if the \u0027isolated_hosts_filter\u0027 filter is enabled."},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"* Services that use this:"},{"line_number":338,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba63e191_9af2ae99","line":335,"range":{"start_line":335,"start_character":31,"end_line":335,"end_character":54},"updated":"2016-01-19 11:26:38.000000000","message":"\u0027IsolatedHostsFilter\u0027 would be better instead of \u0027isolated_hosts_filter\u0027","commit_id":"4f9796fa6edaa40eefac3544bcefdb6353d5c9f1"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"4503898b80634d88ed0b8e4cef6d0b71bbdaaa2c","unresolved":false,"context_lines":[{"line_number":332,"context_line":""},{"line_number":333,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":334,"context_line":"a different scheduler, this option has no effect. Also note that this setting"},{"line_number":335,"context_line":"only affects scheduling if the \u0027isolated_hosts_filter\u0027 filter is enabled."},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"* Services that use this:"},{"line_number":338,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba63e191_0bef4be9","line":335,"range":{"start_line":335,"start_character":31,"end_line":335,"end_character":54},"in_reply_to":"ba63e191_9af2ae99","updated":"2016-01-19 14:07:06.000000000","message":"Done","commit_id":"4f9796fa6edaa40eefac3544bcefdb6353d5c9f1"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"21c4f358c413cd5e80e550326a8e4ee9e763cce1","unresolved":false,"context_lines":[{"line_number":352,"context_line":""},{"line_number":353,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":354,"context_line":"a different scheduler, this option has no effect. Also note that this setting"},{"line_number":355,"context_line":"only affects scheduling if the \u0027isolated_hosts_filter\u0027 filter is enabled."},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"* Services that use this:"},{"line_number":358,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba63e191_da3fc623","line":355,"range":{"start_line":355,"start_character":31,"end_line":355,"end_character":54},"updated":"2016-01-19 11:26:38.000000000","message":"ditto","commit_id":"4f9796fa6edaa40eefac3544bcefdb6353d5c9f1"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"4503898b80634d88ed0b8e4cef6d0b71bbdaaa2c","unresolved":false,"context_lines":[{"line_number":352,"context_line":""},{"line_number":353,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":354,"context_line":"a different scheduler, this option has no effect. Also note that this setting"},{"line_number":355,"context_line":"only affects scheduling if the \u0027isolated_hosts_filter\u0027 filter is enabled."},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"* Services that use this:"},{"line_number":358,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba63e191_8bb9fbeb","line":355,"range":{"start_line":355,"start_character":31,"end_line":355,"end_character":54},"in_reply_to":"ba63e191_da3fc623","updated":"2016-01-19 14:07:06.000000000","message":"Done","commit_id":"4f9796fa6edaa40eefac3544bcefdb6353d5c9f1"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"21c4f358c413cd5e80e550326a8e4ee9e763cce1","unresolved":false,"context_lines":[{"line_number":376,"context_line":""},{"line_number":377,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":378,"context_line":"a different scheduler, this option has no effect. Also note that this setting"},{"line_number":379,"context_line":"only affects scheduling if the \u0027isolated_hosts_filter\u0027 filter is enabled. Even"},{"line_number":380,"context_line":"then, this option doesn\u0027t affect the behavior of requests for isolated images,"},{"line_number":381,"context_line":"which will *always* be restricted to isolated hosts."},{"line_number":382,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba63e191_7a17baa3","line":379,"range":{"start_line":379,"start_character":31,"end_line":379,"end_character":54},"updated":"2016-01-19 11:26:38.000000000","message":"ditto","commit_id":"4f9796fa6edaa40eefac3544bcefdb6353d5c9f1"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"4503898b80634d88ed0b8e4cef6d0b71bbdaaa2c","unresolved":false,"context_lines":[{"line_number":376,"context_line":""},{"line_number":377,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":378,"context_line":"a different scheduler, this option has no effect. Also note that this setting"},{"line_number":379,"context_line":"only affects scheduling if the \u0027isolated_hosts_filter\u0027 filter is enabled. Even"},{"line_number":380,"context_line":"then, this option doesn\u0027t affect the behavior of requests for isolated images,"},{"line_number":381,"context_line":"which will *always* be restricted to isolated hosts."},{"line_number":382,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba63e191_2bcfaf80","line":379,"range":{"start_line":379,"start_character":31,"end_line":379,"end_character":54},"in_reply_to":"ba63e191_7a17baa3","updated":"2016-01-19 14:07:06.000000000","message":"Done","commit_id":"4f9796fa6edaa40eefac3544bcefdb6353d5c9f1"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"123b70fbb9de97de4ab1ef65f4738ceec5692456","unresolved":false,"context_lines":[{"line_number":328,"context_line":"        default\u003d[],"},{"line_number":329,"context_line":"        help\u003d\"\"\""},{"line_number":330,"context_line":"If there is a need to restrict some images to only run on certain designated"},{"line_number":331,"context_line":"hosts, list those image UUIDs here."},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":334,"context_line":"a different scheduler, this option has no effect. Also note that this setting"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_cf35b546","line":331,"updated":"2016-01-21 11:22:46.000000000","message":"Seriously? This is bonkers. We should work out if this can be replaced with a host aggregate or something like that.\n\nI\u0027m not blocking this review over this flag existing, because that is also bonkers, but we should somehow track that we should investigate if this can be removed in favour of something else more generic.","commit_id":"e10caf6c7c419f957d0f3b46a6872d531a6a4306"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"123b70fbb9de97de4ab1ef65f4738ceec5692456","unresolved":false,"context_lines":[{"line_number":348,"context_line":"        default\u003d[],"},{"line_number":349,"context_line":"        help\u003d\"\"\""},{"line_number":350,"context_line":"If there is a need to restrict some images to only run on certain designated"},{"line_number":351,"context_line":"hosts, list those host names here."},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":354,"context_line":"a different scheduler, this option has no effect. Also note that this setting"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_cf0cd596","line":351,"updated":"2016-01-21 11:22:46.000000000","message":"See rant above.","commit_id":"e10caf6c7c419f957d0f3b46a6872d531a6a4306"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"123b70fbb9de97de4ab1ef65f4738ceec5692456","unresolved":false,"context_lines":[{"line_number":372,"context_line":"non-isolated images on a host designated as an isolated host. When set to True"},{"line_number":373,"context_line":"(the default), non-isolated images will not be allowed to be built on isolated"},{"line_number":374,"context_line":"hosts. When False, non-isolated images can be built on both isolated and"},{"line_number":375,"context_line":"non-isolated hosts alike."},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":378,"context_line":"a different scheduler, this option has no effect. Also note that this setting"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_6f736916","line":375,"updated":"2016-01-21 11:22:46.000000000","message":"I am at a loss for words.","commit_id":"e10caf6c7c419f957d0f3b46a6872d531a6a4306"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2bf0021a68fe09bfc67fe43fe925511bfd59d05a","unresolved":false,"context_lines":[{"line_number":408,"context_line":""},{"line_number":409,"context_line":"This is rarely needed in practice as most deployments run a single scheduler."},{"line_number":410,"context_line":"It exists mainly for design compatibility with the other services, such as"},{"line_number":411,"context_line":"compute, which are routinely upgraded in a rolling fashion."},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"* Services that use this:"},{"line_number":414,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_10a0be9e","line":411,"updated":"2016-01-28 16:45:45.000000000","message":"This is more about running old and new scheduler processes as the same time. I guess this kinda covers this.\n\nWe should really describe the default here (using the newest RPC API version when talking to schedulers).\n\nBut lets do that as a follow up.","commit_id":"fe104303ca82274f3ba770f800f9a4e9dcb5f96f"}]}