)]}'
{"nova/tests/functional/api_sample_tests/api_sample_base.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3eee378bae51004af38e1820b69f3010bc98b40e","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            self.useFixture(api_paste_fixture.ApiPasteV21Fixture())"},{"line_number":65,"context_line":"            expected_middleware \u003d [compute.APIRouterV21]"},{"line_number":66,"context_line":"        elif self._test \u003d\u003d \u0027v2.1_compatible\u0027:"},{"line_number":67,"context_line":"            expected_middleware \u003d [openstack.LegacyV2CompatibleWrapper,"},{"line_number":68,"context_line":"                                   compute.APIRouterV21]"},{"line_number":69,"context_line":"        elif (self._test \u003d\u003d \u0027v2\u0027 and self._api_version \u003d\u003d \u0027v2\u0027):"},{"line_number":70,"context_line":"            # override /v2 in compatibility mode with v2 legacy"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_533b9a38","side":"PARENT","line":67,"updated":"2015-12-10 20:33:12.000000000","message":"We don\u0027t need either of these?","commit_id":"e31f9a9811478ab864adfff53d9e0266e35cab3d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2c7c80282eb3ebf21ed965fcbd11b5cd04aa7b62","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            self.useFixture(api_paste_fixture.ApiPasteV21Fixture())"},{"line_number":65,"context_line":"            expected_middleware \u003d [compute.APIRouterV21]"},{"line_number":66,"context_line":"        elif self._test \u003d\u003d \u0027v2.1_compatible\u0027:"},{"line_number":67,"context_line":"            expected_middleware \u003d [openstack.LegacyV2CompatibleWrapper,"},{"line_number":68,"context_line":"                                   compute.APIRouterV21]"},{"line_number":69,"context_line":"        elif (self._test \u003d\u003d \u0027v2\u0027 and self._api_version \u003d\u003d \u0027v2\u0027):"},{"line_number":70,"context_line":"            # override /v2 in compatibility mode with v2 legacy"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_8c77919e","side":"PARENT","line":67,"in_reply_to":"7a740942_3e21f54d","updated":"2015-12-11 05:00:30.000000000","message":"Yes that\u0027s right. Much clean way.","commit_id":"e31f9a9811478ab864adfff53d9e0266e35cab3d"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"d1f1e9ae0a08c13a168c6678ff003080ab118761","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            self.useFixture(api_paste_fixture.ApiPasteV21Fixture())"},{"line_number":65,"context_line":"            expected_middleware \u003d [compute.APIRouterV21]"},{"line_number":66,"context_line":"        elif self._test \u003d\u003d \u0027v2.1_compatible\u0027:"},{"line_number":67,"context_line":"            expected_middleware \u003d [openstack.LegacyV2CompatibleWrapper,"},{"line_number":68,"context_line":"                                   compute.APIRouterV21]"},{"line_number":69,"context_line":"        elif (self._test \u003d\u003d \u0027v2\u0027 and self._api_version \u003d\u003d \u0027v2\u0027):"},{"line_number":70,"context_line":"            # override /v2 in compatibility mode with v2 legacy"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_3e21f54d","side":"PARENT","line":67,"in_reply_to":"7a740942_533b9a38","updated":"2015-12-10 20:49:19.000000000","message":"I don\u0027t believe so, because the previous method was point everything at /v2, and muck with the paste fixture on every go.\n\nThe new approach is v2 compatibility is run on /v2, v2.1 on /v2.1, and the only time we need to modify paste is for the v2 legacy scenario.","commit_id":"e31f9a9811478ab864adfff53d9e0266e35cab3d"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"09c788fd33b92e244d67ee1652cab5868e282644","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            self.useFixture(api_paste_fixture.ApiPasteV21Fixture())"},{"line_number":65,"context_line":"            expected_middleware \u003d [compute.APIRouterV21]"},{"line_number":66,"context_line":"        elif self._test \u003d\u003d \u0027v2.1_compatible\u0027:"},{"line_number":67,"context_line":"            expected_middleware \u003d [openstack.LegacyV2CompatibleWrapper,"},{"line_number":68,"context_line":"                                   compute.APIRouterV21]"},{"line_number":69,"context_line":"        elif (self._test \u003d\u003d \u0027v2\u0027 and self._api_version \u003d\u003d \u0027v2\u0027):"},{"line_number":70,"context_line":"            # override /v2 in compatibility mode with v2 legacy"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_3220369b","side":"PARENT","line":67,"in_reply_to":"7a740942_8c77919e","updated":"2015-12-11 06:28:28.000000000","message":"yes, this needn\u0027t anymore","commit_id":"e31f9a9811478ab864adfff53d9e0266e35cab3d"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"633e52ac4b4f62c2b30e00a4767cd9cdb7fc9261","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        fake_utils.stub_out_utils_spawn_n(self.stubs)"},{"line_number":76,"context_line":"        self.generate_samples \u003d os.getenv(\u0027GENERATE_SAMPLES\u0027) is not None"},{"line_number":77,"context_line":"        if expected_middleware:"},{"line_number":78,"context_line":"            self._check_api_endpoint(\u0027/v2\u0027, expected_middleware)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_5c66622a","side":"PARENT","line":78,"updated":"2015-12-10 14:43:59.000000000","message":"Note, this is specifically removed. The fixtures should be independently tested.","commit_id":"e31f9a9811478ab864adfff53d9e0266e35cab3d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2c7c80282eb3ebf21ed965fcbd11b5cd04aa7b62","unresolved":false,"context_lines":[{"line_number":58,"context_line":"# microversions, then replace the ``scenarios`` class variable in that"},{"line_number":59,"context_line":"# test class with something like:"},{"line_number":60,"context_line":"#"},{"line_number":61,"context_line":"# [(\"v2_11\", {\u0027_api_version\u0027: \u0027v2.1\u0027, \u0027request_api_version\u0027, \u00272.11\u0027})]"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"class ApiSampleTestBaseV21(testscenarios.WithScenarios,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_41a5f201","line":61,"updated":"2015-12-11 05:00:30.000000000","message":"how about renaming \u0027request_api_version\u0027 to \u0027microversion\u0027 or  \u0027request_api_microversion\u0027  because \u0027_api_version\u0027 and \u0027request_api_version\u0027 are bit confusing.\n\nBut needs lot of changes so good to do it in follow up patch.","commit_id":"ede70a1973533dca2a38a501d246012eda74c739"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"09c788fd33b92e244d67ee1652cab5868e282644","unresolved":false,"context_lines":[{"line_number":58,"context_line":"# microversions, then replace the ``scenarios`` class variable in that"},{"line_number":59,"context_line":"# test class with something like:"},{"line_number":60,"context_line":"#"},{"line_number":61,"context_line":"# [(\"v2_11\", {\u0027_api_version\u0027: \u0027v2.1\u0027, \u0027request_api_version\u0027, \u00272.11\u0027})]"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"class ApiSampleTestBaseV21(testscenarios.WithScenarios,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_12641ae3","line":61,"in_reply_to":"7a740942_41a5f201","updated":"2015-12-11 06:28:28.000000000","message":"yes, really confused. Also I\u0027m thinking we should find out a different naming for api version v2.1/v2 and microversion\u0027s api version. Really hard to describe those in our document.","commit_id":"ede70a1973533dca2a38a501d246012eda74c739"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2c7c80282eb3ebf21ed965fcbd11b5cd04aa7b62","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"class ApiSampleTestBaseV21(testscenarios.WithScenarios,"},{"line_number":65,"context_line":"                          api_samples_test_base.ApiSampleTestBase):"},{"line_number":66,"context_line":"    _api_version \u003d \u0027v2\u0027"},{"line_number":67,"context_line":"    # any additional fixtures needed for this scenario"},{"line_number":68,"context_line":"    _additional_fixtures \u003d []"},{"line_number":69,"context_line":"    sample_dir \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_21ab06d8","line":66,"updated":"2015-12-11 05:00:30.000000000","message":"we can set this None here or remove it as all scenario has to define this.","commit_id":"ede70a1973533dca2a38a501d246012eda74c739"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"09c788fd33b92e244d67ee1652cab5868e282644","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"class ApiSampleTestBaseV21(testscenarios.WithScenarios,"},{"line_number":65,"context_line":"                          api_samples_test_base.ApiSampleTestBase):"},{"line_number":66,"context_line":"    _api_version \u003d \u0027v2\u0027"},{"line_number":67,"context_line":"    # any additional fixtures needed for this scenario"},{"line_number":68,"context_line":"    _additional_fixtures \u003d []"},{"line_number":69,"context_line":"    sample_dir \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_92a48ab9","line":66,"in_reply_to":"7a740942_21ab06d8","updated":"2015-12-11 06:28:28.000000000","message":"I prefer set this to \u0027v2.1\u0027","commit_id":"ede70a1973533dca2a38a501d246012eda74c739"}],"nova/tests/functional/api_sample_tests/test_fixed_ips.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2c7c80282eb3ebf21ed965fcbd11b5cd04aa7b62","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    # NOTE(gmann): microversion tests do not need to run for v2 API"},{"line_number":122,"context_line":"    # so defining scenarios only for v2.4 which will run the original tests"},{"line_number":123,"context_line":"    # by appending \u0027(v2_4)\u0027 in test_id."},{"line_number":124,"context_line":"    scenarios \u003d [(\u0027v2_4\u0027, {\u0027_api_version\u0027: \u0027v2.1\u0027})]"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def test_get_fixed_ip(self):"},{"line_number":127,"context_line":"        self._test_get_fixed_ip(reserved\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_61cd8eb6","line":124,"updated":"2015-12-11 05:00:30.000000000","message":"we can add this here request_api_version \u003d \u00272.4\u0027 as shown in example in base class","commit_id":"ede70a1973533dca2a38a501d246012eda74c739"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"09c788fd33b92e244d67ee1652cab5868e282644","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    # NOTE(gmann): microversion tests do not need to run for v2 API"},{"line_number":122,"context_line":"    # so defining scenarios only for v2.4 which will run the original tests"},{"line_number":123,"context_line":"    # by appending \u0027(v2_4)\u0027 in test_id."},{"line_number":124,"context_line":"    scenarios \u003d [(\u0027v2_4\u0027, {\u0027_api_version\u0027: \u0027v2.1\u0027})]"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def test_get_fixed_ip(self):"},{"line_number":127,"context_line":"        self._test_get_fixed_ip(reserved\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_92d6ca25","line":124,"in_reply_to":"7a740942_61cd8eb6","updated":"2015-12-11 06:28:28.000000000","message":"How about we didn\u0027t expose \u0027_api_version\u0027 for subclass. We set \u0027_api_version\u0027 as \u0027v2.1\u0027 in baseclass. Other developer just need provided one parameter \u0027request_api_version\u0027","commit_id":"ede70a1973533dca2a38a501d246012eda74c739"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"180ad958d10ac03b2802381b062898afd4792872","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    # NOTE(gmann): microversion tests do not need to run for v2 API"},{"line_number":122,"context_line":"    # so defining scenarios only for v2.4 which will run the original tests"},{"line_number":123,"context_line":"    # by appending \u0027(v2_4)\u0027 in test_id."},{"line_number":124,"context_line":"    scenarios \u003d [(\u0027v2_4\u0027, {\u0027_api_version\u0027: \u0027v2.1\u0027})]"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def test_get_fixed_ip(self):"},{"line_number":127,"context_line":"        self._test_get_fixed_ip(reserved\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_6ce489df","line":124,"in_reply_to":"7a740942_61cd8eb6","updated":"2015-12-11 15:26:11.000000000","message":"yes, we can, which is probably the right way to do these.","commit_id":"ede70a1973533dca2a38a501d246012eda74c739"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"521ce0418e61801c1c3a5eb8ccf6fc7247dcaa32","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    # NOTE(gmann): microversion tests do not need to run for v2 API"},{"line_number":122,"context_line":"    # so defining scenarios only for v2.4 which will run the original tests"},{"line_number":123,"context_line":"    # by appending \u0027(v2_4)\u0027 in test_id."},{"line_number":124,"context_line":"    scenarios \u003d [(\u0027v2_4\u0027, {\u0027_api_version\u0027: \u0027v2.1\u0027})]"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def test_get_fixed_ip(self):"},{"line_number":127,"context_line":"        self._test_get_fixed_ip(reserved\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_d54bd929","line":124,"in_reply_to":"7a740942_92d6ca25","updated":"2015-12-11 08:27:06.000000000","message":"actually for microversion tests we need to override  scenarios  to have version name appended with tests-id to get clear view of tests run for which microversions.","commit_id":"ede70a1973533dca2a38a501d246012eda74c739"}],"nova/tests/functional/api_sample_tests/test_used_limits.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2c7c80282eb3ebf21ed965fcbd11b5cd04aa7b62","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            f[\u0027osapi_compute_extension\u0027].append("},{"line_number":50,"context_line":"                \"nova.api.openstack.compute.\""},{"line_number":51,"context_line":"                \"legacy_v2.contrib.used_limits_for_admin.\""},{"line_number":52,"context_line":"                \"Used_limits_for_admin\")"},{"line_number":53,"context_line":"        return f"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def test_get_used_limits(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_a1d61625","line":52,"updated":"2015-12-11 05:00:30.000000000","message":"this list is bad in all tests, and will get disapear on sample tests with all extension work","commit_id":"ede70a1973533dca2a38a501d246012eda74c739"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"09c788fd33b92e244d67ee1652cab5868e282644","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            f[\u0027osapi_compute_extension\u0027].append("},{"line_number":50,"context_line":"                \"nova.api.openstack.compute.\""},{"line_number":51,"context_line":"                \"legacy_v2.contrib.used_limits_for_admin.\""},{"line_number":52,"context_line":"                \"Used_limits_for_admin\")"},{"line_number":53,"context_line":"        return f"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def test_get_used_limits(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_3299166f","line":52,"in_reply_to":"7a740942_a1d61625","updated":"2015-12-11 06:28:28.000000000","message":"++","commit_id":"ede70a1973533dca2a38a501d246012eda74c739"}],"nova/tests/functional/api_samples_test_base.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fdca5b398ecf1496df904179023fd71adcae742c","unresolved":false,"context_lines":[{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    def _update_links(self, sample_data):"},{"line_number":251,"context_line":"        \"\"\"Process sample data and update version specific links.\"\"\""},{"line_number":252,"context_line":"        url_re \u003d self._get_host() + \"/v(2|2\\.1)\""},{"line_number":253,"context_line":"        new_url \u003d self._get_host() + \"/\" + self._api_version"},{"line_number":254,"context_line":"        updated_data \u003d re.sub(url_re, new_url, sample_data)"},{"line_number":255,"context_line":"        return updated_data"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_69632c42","line":252,"updated":"2015-12-11 10:02:32.000000000","message":"it should be self._get_host() + \"/v(2\\.1|2) - 2/.1 first in search.\nOtherwise it replace \"../v2.1\" to \"../v2.1.1\" as it find \"/v2\" first. \n\nIt is working in this patch as all doc/api_samples/ files has /v2 in ref not /v2.1\nI will update this while updating doc/api_samples files with /v2.1 in ref as per below comments.","commit_id":"ede70a1973533dca2a38a501d246012eda74c739"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2c7c80282eb3ebf21ed965fcbd11b5cd04aa7b62","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        url_re \u003d self._get_host() + \"/v(2|2\\.1)\""},{"line_number":253,"context_line":"        new_url \u003d self._get_host() + \"/\" + self._api_version"},{"line_number":254,"context_line":"        updated_data \u003d re.sub(url_re, new_url, sample_data)"},{"line_number":255,"context_line":"        return updated_data"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def _verify_response(self, name, subs, response, exp_code):"},{"line_number":258,"context_line":"        self.assertEqual(exp_code, response.status_code)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_81bc3a6d","line":255,"updated":"2015-12-11 05:00:30.000000000","message":"It will keep the sample files under /doc/api_samples/ as it is if those are exist (which is not issue but those have /v2/ in ref).\n\nand those does not exist then it will write with the \"_api_version\" (/v2/ or /v2.1/) which tests (v2 or v2.1) gets executed first.\n\nHow about always writing the doc/api_samples files with /v2.1/. I mean let only v2.1 lets updated/generate these files?","commit_id":"ede70a1973533dca2a38a501d246012eda74c739"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"09c788fd33b92e244d67ee1652cab5868e282644","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        url_re \u003d self._get_host() + \"/v(2|2\\.1)\""},{"line_number":253,"context_line":"        new_url \u003d self._get_host() + \"/\" + self._api_version"},{"line_number":254,"context_line":"        updated_data \u003d re.sub(url_re, new_url, sample_data)"},{"line_number":255,"context_line":"        return updated_data"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def _verify_response(self, name, subs, response, exp_code):"},{"line_number":258,"context_line":"        self.assertEqual(exp_code, response.status_code)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_874d2a9b","line":255,"in_reply_to":"7a740942_81bc3a6d","updated":"2015-12-11 06:28:28.000000000","message":"+1 for write \u0027v2.1\u0027 in the sample files, but looks like can be done later patch. As it needs to update all the sample files.","commit_id":"ede70a1973533dca2a38a501d246012eda74c739"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"521ce0418e61801c1c3a5eb8ccf6fc7247dcaa32","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        url_re \u003d self._get_host() + \"/v(2|2\\.1)\""},{"line_number":253,"context_line":"        new_url \u003d self._get_host() + \"/\" + self._api_version"},{"line_number":254,"context_line":"        updated_data \u003d re.sub(url_re, new_url, sample_data)"},{"line_number":255,"context_line":"        return updated_data"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def _verify_response(self, name, subs, response, exp_code):"},{"line_number":258,"context_line":"        self.assertEqual(exp_code, response.status_code)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_15b401f0","line":255,"in_reply_to":"7a740942_874d2a9b","updated":"2015-12-11 08:27:06.000000000","message":"Sounds good. this is nice patch and we can get this in and do other cleanup later.","commit_id":"ede70a1973533dca2a38a501d246012eda74c739"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2c7c80282eb3ebf21ed965fcbd11b5cd04aa7b62","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        if (self.generate_samples and"},{"line_number":269,"context_line":"                not os.path.exists(self._get_sample("},{"line_number":270,"context_line":"                    name, self.request_api_version))):"},{"line_number":271,"context_line":"            self._write_sample(name, response_data)"},{"line_number":272,"context_line":"            sample_data \u003d response_data"},{"line_number":273,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_61158e47","line":270,"updated":"2015-12-11 05:00:30.000000000","message":"As per above comment, we can add another AND condition here (self._api_version \u003d\u003d \u0027v2.1\u0027)","commit_id":"ede70a1973533dca2a38a501d246012eda74c739"}]}