)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f14989a90e94b740f000f3f1881e524c0ac871a9","unresolved":false,"context_lines":[{"line_number":17,"context_line":"failures when someone attempted to call the method correctly.  So this"},{"line_number":18,"context_line":"patch fixes callers of getcallargs, and removes some code from the"},{"line_number":19,"context_line":"implementation that is not necessary once the usage is fixed."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I86eb59a2280961b809c1b4680012fab9566d60db"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_c304a6c7","line":20,"updated":"2015-12-10 16:17:21.000000000","message":"Do you plan on backporting this to stable? If so, we should have a bug.","commit_id":"57c56b6708a8a49447526a8602f0967d79a1a896"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"b28c5119a6b21310e814c3fbc4c4a04d6fe36c01","unresolved":false,"context_lines":[{"line_number":17,"context_line":"failures when someone attempted to call the method correctly.  So this"},{"line_number":18,"context_line":"patch fixes callers of getcallargs, and removes some code from the"},{"line_number":19,"context_line":"implementation that is not necessary once the usage is fixed."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I86eb59a2280961b809c1b4680012fab9566d60db"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_ae3dc1de","line":20,"in_reply_to":"7a740942_0ee73541","updated":"2015-12-10 16:44:54.000000000","message":"+1, I also want to point this","commit_id":"57c56b6708a8a49447526a8602f0967d79a1a896"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"e3a417b853ba7b715fd827952cdead3c374f37b6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"failures when someone attempted to call the method correctly.  So this"},{"line_number":18,"context_line":"patch fixes callers of getcallargs, and removes some code from the"},{"line_number":19,"context_line":"implementation that is not necessary once the usage is fixed."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I86eb59a2280961b809c1b4680012fab9566d60db"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_0ee73541","line":20,"in_reply_to":"7a740942_c304a6c7","updated":"2015-12-10 16:34:14.000000000","message":"I wasn\u0027t planning on that.  This fix is to help https://review.openstack.org/#/c/243496/ which won\u0027t be backported afaik so it\u0027s not necessary.\n\nI may open a bug for it anyways.","commit_id":"57c56b6708a8a49447526a8602f0967d79a1a896"}],"nova/safe_utils.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"3fa180f01c60af022d7b05f82022706e72304dd8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"def getcallargs(function, *args, **kwargs):"},{"line_number":24,"context_line":"    \"\"\"This is a simplified inspect.getcallargs (2.7+)."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    It should be replaced when python \u003e\u003d 2.7 is standard."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    This method can only properly grab arguments which are passed in as"},{"line_number":29,"context_line":"    keyword arguments, or given names by the method being called.  This means"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_01c41890","line":26,"updated":"2015-12-09 22:57:51.000000000","message":"So, that raises the question—is this even needed anymore, or could we switch to using inspect.getcallargs() straight up?","commit_id":"6b0f933398f7b66ac0f9d1a8b8ed7d7ecf7fad49"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"b0ccdc890751b41df37414841d438318de1267cc","unresolved":false,"context_lines":[{"line_number":23,"context_line":"def getcallargs(function, *args, **kwargs):"},{"line_number":24,"context_line":"    \"\"\"This is a simplified inspect.getcallargs (2.7+)."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    It should be replaced when python \u003e\u003d 2.7 is standard."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    This method can only properly grab arguments which are passed in as"},{"line_number":29,"context_line":"    keyword arguments, or given names by the method being called.  This means"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_264d8372","line":26,"in_reply_to":"7a740942_01c41890","updated":"2015-12-10 13:57:28.000000000","message":"I plan to research that next.  I know that someone looked into doing that already but stopped when it wasn\u0027t just a drop in replacement.  But it\u0027s possible that was the case because of the api mismatch that\u0027s being fixed here.\n\nI\u0027ll post a followup patch here switching to inspect.getcallargs and see what happens.","commit_id":"6b0f933398f7b66ac0f9d1a8b8ed7d7ecf7fad49"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fcd9b72e6af9a2ecd52c4631511f59bfde95c459","unresolved":false,"context_lines":[{"line_number":23,"context_line":"def getcallargs(function, *args, **kwargs):"},{"line_number":24,"context_line":"    \"\"\"This is a simplified inspect.getcallargs (2.7+)."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    It should be replaced when python \u003e\u003d 2.7 is standard."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    This method can only properly grab arguments which are passed in as"},{"line_number":29,"context_line":"    keyword arguments, or given names by the method being called.  This means"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_23156ae4","line":26,"updated":"2015-12-10 16:18:14.000000000","message":"Could we just replace this now that we don\u0027t support py26?","commit_id":"57c56b6708a8a49447526a8602f0967d79a1a896"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"e3a417b853ba7b715fd827952cdead3c374f37b6","unresolved":false,"context_lines":[{"line_number":23,"context_line":"def getcallargs(function, *args, **kwargs):"},{"line_number":24,"context_line":"    \"\"\"This is a simplified inspect.getcallargs (2.7+)."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    It should be replaced when python \u003e\u003d 2.7 is standard."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    This method can only properly grab arguments which are passed in as"},{"line_number":29,"context_line":"    keyword arguments, or given names by the method being called.  This means"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_ced28d34","line":26,"in_reply_to":"7a740942_23156ae4","updated":"2015-12-10 16:34:14.000000000","message":"I\u0027m going to test that.  I commented on the previous PS for this same question :)","commit_id":"57c56b6708a8a49447526a8602f0967d79a1a896"}]}