)]}'
{"nova/tests/functional/api_sample_tests/test_servers.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"96e0eeef6b16f40136201b7255ccaae4dfacd847","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        subs \u003d {"},{"line_number":37,"context_line":"            \u0027image_id\u0027: fake.get_valid_image_id(),"},{"line_number":38,"context_line":"            \u0027host\u0027: self._get_host(),"},{"line_number":39,"context_line":"            \u0027compute_endpoint\u0027: self._get_compute_endpoint(),"},{"line_number":40,"context_line":"            \u0027versioned_compute_endpoint\u0027: self._get_vers_compute_endpoint(),"},{"line_number":41,"context_line":"            \u0027glance_host\u0027: self._get_glance_host(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_f67ce9b6","line":38,"updated":"2015-12-11 03:14:31.000000000","message":"we can remove this now -\u0027host\u0027: self._get_host()","commit_id":"e31f9a9811478ab864adfff53d9e0266e35cab3d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"96e0eeef6b16f40136201b7255ccaae4dfacd847","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        uuid \u003d self._post_server()"},{"line_number":178,"context_line":"        image \u003d fake.get_valid_image_id()"},{"line_number":179,"context_line":"        subs \u003d {"},{"line_number":180,"context_line":"            \u0027host\u0027: self._get_host(),"},{"line_number":181,"context_line":"            \u0027compute_endpoint\u0027: self._get_compute_endpoint(),"},{"line_number":182,"context_line":"            \u0027versioned_compute_endpoint\u0027: self._get_vers_compute_endpoint(),"},{"line_number":183,"context_line":"            \u0027uuid\u0027: image,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_16b1758f","line":180,"updated":"2015-12-11 03:14:31.000000000","message":"we can remove this now \u0027host\u0027: self._get_host(),","commit_id":"e31f9a9811478ab864adfff53d9e0266e35cab3d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"96e0eeef6b16f40136201b7255ccaae4dfacd847","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        uuid \u003d self._post_server()"},{"line_number":199,"context_line":"        self._test_server_action(uuid, \"resize\","},{"line_number":200,"context_line":"                                 \u0027server-action-resize\u0027,"},{"line_number":201,"context_line":"                                 {\"id\": 2,"},{"line_number":202,"context_line":"                                  \"host\": self._get_host()})"},{"line_number":203,"context_line":"        return uuid"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_7670f9dc","line":201,"updated":"2015-12-11 03:14:31.000000000","message":"\u0027compute_endpoint\u0027: self._get_compute_endpoint(),","commit_id":"e31f9a9811478ab864adfff53d9e0266e35cab3d"}],"nova/tests/functional/api_samples_test_base.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"e41968ef0ad2dbbcdb8ed977552ad4cef6bfd161","unresolved":false,"context_lines":[{"line_number":335,"context_line":"            \u0027text\u0027: text,"},{"line_number":336,"context_line":"            \u0027int\u0027: \u0027[0-9]+\u0027,"},{"line_number":337,"context_line":"            \u0027user_id\u0027: text,"},{"line_number":338,"context_line":"            \u0027api_vers\u0027: self._api_version,"},{"line_number":339,"context_line":"            \u0027compute_endpoint\u0027: self._get_compute_endpoint(),"},{"line_number":340,"context_line":"            \u0027versioned_compute_endpoint\u0027: self._get_vers_compute_endpoint(),"},{"line_number":341,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_9e2fbb3d","line":338,"updated":"2015-12-11 03:48:16.000000000","message":"`_api_version` is really confused. We have `_api_version` and `request_api_version`. As I remember \u0027_api_version\u0027 is just a hack for helping us merge the v2 and v2.1 API sample tests.\n\nWe hack at here: https://github.com/openstack/nova/blob/master/nova/tests/functional/api_sample_tests/api_sample_base.py#L69   I thought we can remove this variable after we merged all the sample tests.\n\nBut I found there is another place begin to depend on this https://github.com/openstack/nova/blob/master/nova/tests/functional/integrated_helpers.py#L88\n\nFrom my understand, actually `_api_version` is used to control the url endpoint. In api sample tests, both v2 and v2.1 API are tested on endpoint \u0027http://..../v2\u0027. Only the functional tests use different endpoints for v2 and v2.1 API.\n\nSo I think we should rename `_api_version` as this is variable to control the endpoint.","commit_id":"e31f9a9811478ab864adfff53d9e0266e35cab3d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c94b1598882993f55a6c134cbc4da0f3b7e7b4cd","unresolved":false,"context_lines":[{"line_number":335,"context_line":"            \u0027text\u0027: text,"},{"line_number":336,"context_line":"            \u0027int\u0027: \u0027[0-9]+\u0027,"},{"line_number":337,"context_line":"            \u0027user_id\u0027: text,"},{"line_number":338,"context_line":"            \u0027api_vers\u0027: self._api_version,"},{"line_number":339,"context_line":"            \u0027compute_endpoint\u0027: self._get_compute_endpoint(),"},{"line_number":340,"context_line":"            \u0027versioned_compute_endpoint\u0027: self._get_vers_compute_endpoint(),"},{"line_number":341,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_7e18cf84","line":338,"in_reply_to":"7a740942_9e2fbb3d","updated":"2015-12-11 04:12:34.000000000","message":"Yea, so in dependent patch, \"_api_version\" is used for auth_url (where tests will request) on which endpoint (v2 and v2.1) and appending the same on sample files in ref.","commit_id":"e31f9a9811478ab864adfff53d9e0266e35cab3d"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"e41968ef0ad2dbbcdb8ed977552ad4cef6bfd161","unresolved":false,"context_lines":[{"line_number":342,"context_line":""},{"line_number":343,"context_line":"    def _get_compute_endpoint(self):"},{"line_number":344,"context_line":"        # NOTE(sdague): \"openstack\" is stand in for project_id, it"},{"line_number":345,"context_line":"        # should be more generic in future."},{"line_number":346,"context_line":"        return \u0027%s/%s\u0027 % (self._get_host(), \u0027openstack\u0027)"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    def _get_vers_compute_endpoint(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_36c0317c","line":345,"updated":"2015-12-11 03:48:16.000000000","message":"++","commit_id":"e31f9a9811478ab864adfff53d9e0266e35cab3d"}]}