)]}'
{"nova/conf/__init__.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fe2157e03de42baf91d59f6cfa31bb2d5c55598a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# from nova.conf import api_database"},{"line_number":24,"context_line":"# from nova.conf import aws"},{"line_number":25,"context_line":"# from nova.conf import barbican"},{"line_number":26,"context_line":"# from nova.conf import base"},{"line_number":27,"context_line":"# from nova.conf import cells"},{"line_number":28,"context_line":"# from nova.conf import cinder"},{"line_number":29,"context_line":"# from nova.conf import compute"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_f273724c","line":26,"updated":"2015-12-11 15:51:44.000000000","message":"whats those?","commit_id":"0f24ee9a5c75d07a020a0f9921dd47cc94db41a6"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"3b80f1bcb4e5f6b987b4768f08efb014a82577f0","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# from nova.conf import api_database"},{"line_number":24,"context_line":"# from nova.conf import aws"},{"line_number":25,"context_line":"# from nova.conf import barbican"},{"line_number":26,"context_line":"# from nova.conf import base"},{"line_number":27,"context_line":"# from nova.conf import cells"},{"line_number":28,"context_line":"# from nova.conf import cinder"},{"line_number":29,"context_line":"# from nova.conf import compute"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_3227bacb","line":26,"in_reply_to":"7a740942_f273724c","updated":"2015-12-11 15:57:47.000000000","message":"Those defined in the nova/ directory, i.e., not in nova/virt, nova/compute, etc. I\u0027d like a better name, but it was either that or \u0027root\u0027.","commit_id":"0f24ee9a5c75d07a020a0f9921dd47cc94db41a6"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"a77b35e0317396cff420dd379a3d1ba5b7f80421","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# from nova.conf import api"},{"line_number":23,"context_line":"# from nova.conf import api_database"},{"line_number":24,"context_line":"# from nova.conf import aws"},{"line_number":25,"context_line":"# from nova.conf import barbican"},{"line_number":26,"context_line":"# from nova.conf import base"},{"line_number":27,"context_line":"# from nova.conf import cells"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_cb1e7cba","line":24,"updated":"2015-12-14 12:38:54.000000000","message":"suggestions:\n\n    # from nova.conf import availability_zone","commit_id":"06e8f360c2ba57c06e012b1d6c5dd9a315b58061"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"a77b35e0317396cff420dd379a3d1ba5b7f80421","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# from nova.conf import api_database"},{"line_number":24,"context_line":"# from nova.conf import aws"},{"line_number":25,"context_line":"# from nova.conf import barbican"},{"line_number":26,"context_line":"# from nova.conf import base"},{"line_number":27,"context_line":"# from nova.conf import cells"},{"line_number":28,"context_line":"# from nova.conf import cinder"},{"line_number":29,"context_line":"# from nova.conf import compute"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_81c93328","line":26,"updated":"2015-12-14 12:38:54.000000000","message":"Some of the options can possibly be moved to other modules (like \"notification\", \"quota\", \"wsgi\") but it\u0027s reasonable to have this one. We will discover a better grouping when we take a closer look at them.","commit_id":"06e8f360c2ba57c06e012b1d6c5dd9a315b58061"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"7d23790b388591992d225bafe29f89b95cb33fa3","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# from nova.conf import barbican"},{"line_number":26,"context_line":"# from nova.conf import base"},{"line_number":27,"context_line":"# from nova.conf import cells"},{"line_number":28,"context_line":"# from nova.conf import cinder"},{"line_number":29,"context_line":"# from nova.conf import compute"},{"line_number":30,"context_line":"# from nova.conf import conductor"},{"line_number":31,"context_line":"# from nova.conf import cors"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_e77f27de","line":28,"updated":"2015-12-11 18:54:46.000000000","message":"can this be volume instead of cinder to match https://review.openstack.org/253747","commit_id":"06e8f360c2ba57c06e012b1d6c5dd9a315b58061"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"a77b35e0317396cff420dd379a3d1ba5b7f80421","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# from nova.conf import barbican"},{"line_number":26,"context_line":"# from nova.conf import base"},{"line_number":27,"context_line":"# from nova.conf import cells"},{"line_number":28,"context_line":"# from nova.conf import cinder"},{"line_number":29,"context_line":"# from nova.conf import compute"},{"line_number":30,"context_line":"# from nova.conf import conductor"},{"line_number":31,"context_line":"# from nova.conf import cors"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_01754362","line":28,"in_reply_to":"7a740942_e77f27de","updated":"2015-12-14 12:38:54.000000000","message":"@Tracy: +1 what Ed said. \"volume\" is the generic term, but the \"cinder\" group contains options specifically for *interacting* with Cinder. The move of the options to \"nova/conf/\" should contain as less changes as possible. The main goal is to provide better help texts and gain an overview of our config options to enable an improvement (grouping, naming, validations) in a later step.","commit_id":"06e8f360c2ba57c06e012b1d6c5dd9a315b58061"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"7d6ecad2b74c037861f469cfdc6bb691a542f144","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# from nova.conf import barbican"},{"line_number":26,"context_line":"# from nova.conf import base"},{"line_number":27,"context_line":"# from nova.conf import cells"},{"line_number":28,"context_line":"# from nova.conf import cinder"},{"line_number":29,"context_line":"# from nova.conf import compute"},{"line_number":30,"context_line":"# from nova.conf import conductor"},{"line_number":31,"context_line":"# from nova.conf import cors"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_e7c2c7e8","line":28,"in_reply_to":"7a740942_e77f27de","updated":"2015-12-11 19:00:26.000000000","message":"No, and here\u0027s why: any option groups will be in their own nova/conf/\u003cgroup\u003e.py file. There is an existing \u0027cinder\u0027 option group, and these will now live in nova/conf/cinder.py.\n\nAll \u0027DEFAULT\u0027 options will be moved (initially, at least) to a nova/conf/\u003cdirectory\u003e.py file, based on the directory they were originally defined in. So initially, the one other option defined in the nova/volume directory will live in nova/conf/volume.py. We may move them later, but this is step 1.","commit_id":"06e8f360c2ba57c06e012b1d6c5dd9a315b58061"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"a77b35e0317396cff420dd379a3d1ba5b7f80421","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# from nova.conf import barbican"},{"line_number":26,"context_line":"# from nova.conf import base"},{"line_number":27,"context_line":"# from nova.conf import cells"},{"line_number":28,"context_line":"# from nova.conf import cinder"},{"line_number":29,"context_line":"# from nova.conf import compute"},{"line_number":30,"context_line":"# from nova.conf import conductor"},{"line_number":31,"context_line":"# from nova.conf import cors"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_4e337a62","line":28,"in_reply_to":"7a740942_e7c2c7e8","updated":"2015-12-14 12:38:54.000000000","message":"suggestions:\n\n    # from nova.conf import cloudpipe","commit_id":"06e8f360c2ba57c06e012b1d6c5dd9a315b58061"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"a77b35e0317396cff420dd379a3d1ba5b7f80421","unresolved":false,"context_lines":[{"line_number":27,"context_line":"# from nova.conf import cells"},{"line_number":28,"context_line":"# from nova.conf import cinder"},{"line_number":29,"context_line":"# from nova.conf import compute"},{"line_number":30,"context_line":"# from nova.conf import conductor"},{"line_number":31,"context_line":"# from nova.conf import cors"},{"line_number":32,"context_line":"# from nova.conf import cors.subdomain"},{"line_number":33,"context_line":"# from nova.conf import database"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_0bd484e9","line":30,"updated":"2015-12-14 12:38:54.000000000","message":"suggestions:\n\n    # from nova.conf import configdrive\n    # from nova.conf import console","commit_id":"06e8f360c2ba57c06e012b1d6c5dd9a315b58061"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"a77b35e0317396cff420dd379a3d1ba5b7f80421","unresolved":false,"context_lines":[{"line_number":29,"context_line":"# from nova.conf import compute"},{"line_number":30,"context_line":"# from nova.conf import conductor"},{"line_number":31,"context_line":"# from nova.conf import cors"},{"line_number":32,"context_line":"# from nova.conf import cors.subdomain"},{"line_number":33,"context_line":"# from nova.conf import database"},{"line_number":34,"context_line":"# from nova.conf import ephemeral_storage_encryption"},{"line_number":35,"context_line":"# from nova.conf import glance"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_81061384","line":32,"updated":"2015-12-14 12:38:54.000000000","message":"suggestions:\n\n    # from nova.conf import crypto","commit_id":"06e8f360c2ba57c06e012b1d6c5dd9a315b58061"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"a77b35e0317396cff420dd379a3d1ba5b7f80421","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# from nova.conf import conductor"},{"line_number":31,"context_line":"# from nova.conf import cors"},{"line_number":32,"context_line":"# from nova.conf import cors.subdomain"},{"line_number":33,"context_line":"# from nova.conf import database"},{"line_number":34,"context_line":"# from nova.conf import ephemeral_storage_encryption"},{"line_number":35,"context_line":"# from nova.conf import glance"},{"line_number":36,"context_line":"# from nova.conf import guestfs"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_cbf0bc93","line":33,"updated":"2015-12-14 12:38:54.000000000","message":"suggestions:\n\n    # from nova.conf import ec2\n    # from nova.conf import disk","commit_id":"06e8f360c2ba57c06e012b1d6c5dd9a315b58061"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"a77b35e0317396cff420dd379a3d1ba5b7f80421","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# from nova.conf import cors"},{"line_number":32,"context_line":"# from nova.conf import cors.subdomain"},{"line_number":33,"context_line":"# from nova.conf import database"},{"line_number":34,"context_line":"# from nova.conf import ephemeral_storage_encryption"},{"line_number":35,"context_line":"# from nova.conf import glance"},{"line_number":36,"context_line":"# from nova.conf import guestfs"},{"line_number":37,"context_line":"# from nova.conf import hyperv"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_ce744a37","line":34,"updated":"2015-12-14 12:38:54.000000000","message":"suggestions:\n\n    # from nova.conf import exception\n    # from nova.conf import floating_ip","commit_id":"06e8f360c2ba57c06e012b1d6c5dd9a315b58061"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"8fbe7866844e0d1a0969b4727915ebb3294b7c9f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# from nova.conf import cors"},{"line_number":32,"context_line":"# from nova.conf import cors.subdomain"},{"line_number":33,"context_line":"# from nova.conf import database"},{"line_number":34,"context_line":"# from nova.conf import ephemeral_storage_encryption"},{"line_number":35,"context_line":"# from nova.conf import glance"},{"line_number":36,"context_line":"# from nova.conf import guestfs"},{"line_number":37,"context_line":"# from nova.conf import hyperv"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_9643926c","line":34,"in_reply_to":"7a740942_a9420da9","updated":"2015-12-14 18:28:46.000000000","message":"Yeah, but since that\u0027s in the nova/exception.py file, it should go in the nova/conf/base.py for now.","commit_id":"06e8f360c2ba57c06e012b1d6c5dd9a315b58061"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"d401e5808ad817dc25e41f12b8fcebc006e09c73","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# from nova.conf import cors"},{"line_number":32,"context_line":"# from nova.conf import cors.subdomain"},{"line_number":33,"context_line":"# from nova.conf import database"},{"line_number":34,"context_line":"# from nova.conf import ephemeral_storage_encryption"},{"line_number":35,"context_line":"# from nova.conf import glance"},{"line_number":36,"context_line":"# from nova.conf import guestfs"},{"line_number":37,"context_line":"# from nova.conf import hyperv"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_ee09fb31","line":34,"in_reply_to":"7a740942_ce744a37","updated":"2015-12-14 15:29:35.000000000","message":"Can\u0027t import \u0027exception\u0027, as that is a reserved word and would clobber the namespace. Do we really have any exception-related config settings?","commit_id":"06e8f360c2ba57c06e012b1d6c5dd9a315b58061"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"7132f50ec26cbe7f67428d4b4d1c4519ed93a984","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# from nova.conf import cors"},{"line_number":32,"context_line":"# from nova.conf import cors.subdomain"},{"line_number":33,"context_line":"# from nova.conf import database"},{"line_number":34,"context_line":"# from nova.conf import ephemeral_storage_encryption"},{"line_number":35,"context_line":"# from nova.conf import glance"},{"line_number":36,"context_line":"# from nova.conf import guestfs"},{"line_number":37,"context_line":"# from nova.conf import hyperv"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_a9420da9","line":34,"in_reply_to":"7a740942_ee09fb31","updated":"2015-12-14 15:37:57.000000000","message":"There is \"fatal_exception_format_errors\" but let\u0027s skip it for now. We find a better place later when we really work on that one.","commit_id":"06e8f360c2ba57c06e012b1d6c5dd9a315b58061"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"a77b35e0317396cff420dd379a3d1ba5b7f80421","unresolved":false,"context_lines":[{"line_number":33,"context_line":"# from nova.conf import database"},{"line_number":34,"context_line":"# from nova.conf import ephemeral_storage_encryption"},{"line_number":35,"context_line":"# from nova.conf import glance"},{"line_number":36,"context_line":"# from nova.conf import guestfs"},{"line_number":37,"context_line":"# from nova.conf import hyperv"},{"line_number":38,"context_line":"# from nova.conf import image_file_url"},{"line_number":39,"context_line":"# from nova.conf import ironic"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_2e006e33","line":36,"updated":"2015-12-14 12:38:54.000000000","message":"suggestions:\n\n    # from nova.conf import host\n\nMaybe for things like \"tempdir\" or \"fping\". We can remove it if turns out we won\u0027t need it.","commit_id":"06e8f360c2ba57c06e012b1d6c5dd9a315b58061"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"a77b35e0317396cff420dd379a3d1ba5b7f80421","unresolved":false,"context_lines":[{"line_number":34,"context_line":"# from nova.conf import ephemeral_storage_encryption"},{"line_number":35,"context_line":"# from nova.conf import glance"},{"line_number":36,"context_line":"# from nova.conf import guestfs"},{"line_number":37,"context_line":"# from nova.conf import hyperv"},{"line_number":38,"context_line":"# from nova.conf import image_file_url"},{"line_number":39,"context_line":"# from nova.conf import ironic"},{"line_number":40,"context_line":"# from nova.conf import keymgr"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_cb4c3cca","line":37,"updated":"2015-12-14 12:38:54.000000000","message":"suggestions:\n\n    # from nova.conf import image\n    # from nova.conf import imagecache","commit_id":"06e8f360c2ba57c06e012b1d6c5dd9a315b58061"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"a77b35e0317396cff420dd379a3d1ba5b7f80421","unresolved":false,"context_lines":[{"line_number":40,"context_line":"# from nova.conf import keymgr"},{"line_number":41,"context_line":"# from nova.conf import keystone_authtoken"},{"line_number":42,"context_line":"# from nova.conf import libvirt"},{"line_number":43,"context_line":"# from nova.conf import matchmaker_redis"},{"line_number":44,"context_line":"# from nova.conf import metrics"},{"line_number":45,"context_line":"# from nova.conf import network"},{"line_number":46,"context_line":"# from nova.conf import neutron"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_8bdf140c","line":43,"updated":"2015-12-14 12:38:54.000000000","message":"suggestions:\n\n    # from nova.conf import metadata","commit_id":"06e8f360c2ba57c06e012b1d6c5dd9a315b58061"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"a77b35e0317396cff420dd379a3d1ba5b7f80421","unresolved":false,"context_lines":[{"line_number":43,"context_line":"# from nova.conf import matchmaker_redis"},{"line_number":44,"context_line":"# from nova.conf import metrics"},{"line_number":45,"context_line":"# from nova.conf import network"},{"line_number":46,"context_line":"# from nova.conf import neutron"},{"line_number":47,"context_line":"# from nova.conf import osapi_v21"},{"line_number":48,"context_line":"# from nova.conf import oslo_concurrency"},{"line_number":49,"context_line":"# from nova.conf import oslo_log"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_ab09b096","line":46,"updated":"2015-12-14 12:38:54.000000000","message":"suggestions:\n\n    # from nova.conf import notifications","commit_id":"06e8f360c2ba57c06e012b1d6c5dd9a315b58061"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"d401e5808ad817dc25e41f12b8fcebc006e09c73","unresolved":false,"context_lines":[{"line_number":43,"context_line":"# from nova.conf import matchmaker_redis"},{"line_number":44,"context_line":"# from nova.conf import metrics"},{"line_number":45,"context_line":"# from nova.conf import network"},{"line_number":46,"context_line":"# from nova.conf import neutron"},{"line_number":47,"context_line":"# from nova.conf import osapi_v21"},{"line_number":48,"context_line":"# from nova.conf import oslo_concurrency"},{"line_number":49,"context_line":"# from nova.conf import oslo_log"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_aeea13d6","line":46,"in_reply_to":"7a740942_ab09b096","updated":"2015-12-14 15:29:35.000000000","message":"Added, but changed to singular \u0027notification\u0027 to be consistent.","commit_id":"06e8f360c2ba57c06e012b1d6c5dd9a315b58061"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"7132f50ec26cbe7f67428d4b4d1c4519ed93a984","unresolved":false,"context_lines":[{"line_number":43,"context_line":"# from nova.conf import matchmaker_redis"},{"line_number":44,"context_line":"# from nova.conf import metrics"},{"line_number":45,"context_line":"# from nova.conf import network"},{"line_number":46,"context_line":"# from nova.conf import neutron"},{"line_number":47,"context_line":"# from nova.conf import osapi_v21"},{"line_number":48,"context_line":"# from nova.conf import oslo_concurrency"},{"line_number":49,"context_line":"# from nova.conf import oslo_log"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_290dbd8e","line":46,"in_reply_to":"7a740942_aeea13d6","updated":"2015-12-14 15:37:57.000000000","message":"yepp, singular is better.","commit_id":"06e8f360c2ba57c06e012b1d6c5dd9a315b58061"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"a77b35e0317396cff420dd379a3d1ba5b7f80421","unresolved":false,"context_lines":[{"line_number":45,"context_line":"# from nova.conf import network"},{"line_number":46,"context_line":"# from nova.conf import neutron"},{"line_number":47,"context_line":"# from nova.conf import osapi_v21"},{"line_number":48,"context_line":"# from nova.conf import oslo_concurrency"},{"line_number":49,"context_line":"# from nova.conf import oslo_log"},{"line_number":50,"context_line":"# from nova.conf import oslo_messaging"},{"line_number":51,"context_line":"# from nova.conf import oslo_messaging_amqp"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_ee70260a","line":48,"updated":"2015-12-14 12:38:54.000000000","message":"The \"oslo.*\" opts get imported from the oslo libs and we probably won\u0027t have modules for that but that\u0027s a minor thing. If we see no need for these placeholders later, they will get removed.","commit_id":"06e8f360c2ba57c06e012b1d6c5dd9a315b58061"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"7132f50ec26cbe7f67428d4b4d1c4519ed93a984","unresolved":false,"context_lines":[{"line_number":45,"context_line":"# from nova.conf import network"},{"line_number":46,"context_line":"# from nova.conf import neutron"},{"line_number":47,"context_line":"# from nova.conf import osapi_v21"},{"line_number":48,"context_line":"# from nova.conf import oslo_concurrency"},{"line_number":49,"context_line":"# from nova.conf import oslo_log"},{"line_number":50,"context_line":"# from nova.conf import oslo_messaging"},{"line_number":51,"context_line":"# from nova.conf import oslo_messaging_amqp"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_69650543","line":48,"in_reply_to":"7a740942_0edb2750","updated":"2015-12-14 15:37:57.000000000","message":"Yeah, it\u0027s fair.","commit_id":"06e8f360c2ba57c06e012b1d6c5dd9a315b58061"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"d401e5808ad817dc25e41f12b8fcebc006e09c73","unresolved":false,"context_lines":[{"line_number":45,"context_line":"# from nova.conf import network"},{"line_number":46,"context_line":"# from nova.conf import neutron"},{"line_number":47,"context_line":"# from nova.conf import osapi_v21"},{"line_number":48,"context_line":"# from nova.conf import oslo_concurrency"},{"line_number":49,"context_line":"# from nova.conf import oslo_log"},{"line_number":50,"context_line":"# from nova.conf import oslo_messaging"},{"line_number":51,"context_line":"# from nova.conf import oslo_messaging_amqp"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_0edb2750","line":48,"in_reply_to":"7a740942_ee70260a","updated":"2015-12-14 15:29:35.000000000","message":"I got these from the sections in nova.conf.sample, but I see that they aren\u0027t declared anywhere inside of nova. I\u0027ll remove them.","commit_id":"06e8f360c2ba57c06e012b1d6c5dd9a315b58061"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"a77b35e0317396cff420dd379a3d1ba5b7f80421","unresolved":false,"context_lines":[{"line_number":54,"context_line":"# from nova.conf import oslo_periodic"},{"line_number":55,"context_line":"# from nova.conf import oslo_policy"},{"line_number":56,"context_line":"# from nova.conf import oslo_reports"},{"line_number":57,"context_line":"# from nova.conf import oslo_service"},{"line_number":58,"context_line":"# from nova.conf import rdp"},{"line_number":59,"context_line":"from nova.conf import scheduler"},{"line_number":60,"context_line":"# from nova.conf import security"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_6bb188df","line":57,"updated":"2015-12-14 12:38:54.000000000","message":"suggestions:\n\n    # from nova.conf import pci\n    # from nova.conf import permissions ? (rootwrap + privsep)\n    # from nova.conf import quota","commit_id":"06e8f360c2ba57c06e012b1d6c5dd9a315b58061"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"a77b35e0317396cff420dd379a3d1ba5b7f80421","unresolved":false,"context_lines":[{"line_number":55,"context_line":"# from nova.conf import oslo_policy"},{"line_number":56,"context_line":"# from nova.conf import oslo_reports"},{"line_number":57,"context_line":"# from nova.conf import oslo_service"},{"line_number":58,"context_line":"# from nova.conf import rdp"},{"line_number":59,"context_line":"from nova.conf import scheduler"},{"line_number":60,"context_line":"# from nova.conf import security"},{"line_number":61,"context_line":"from nova.conf import serial_console"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_abbbf0c2","line":58,"updated":"2015-12-14 12:38:54.000000000","message":"suggestions:\n\n    # from nova.conf import s3","commit_id":"06e8f360c2ba57c06e012b1d6c5dd9a315b58061"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"a77b35e0317396cff420dd379a3d1ba5b7f80421","unresolved":false,"context_lines":[{"line_number":66,"context_line":"# from nova.conf import virt"},{"line_number":67,"context_line":"# from nova.conf import vmware"},{"line_number":68,"context_line":"# from nova.conf import vnc"},{"line_number":69,"context_line":"# from nova.conf import volume"},{"line_number":70,"context_line":"# from nova.conf import workarounds"},{"line_number":71,"context_line":"# from nova.conf import xenserver"},{"line_number":72,"context_line":"# from nova.conf import zookeeper"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_ab1770a1","line":69,"updated":"2015-12-14 12:38:54.000000000","message":"suggestions:\n\n    # from nova.conf import wsgi","commit_id":"06e8f360c2ba57c06e012b1d6c5dd9a315b58061"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"a77b35e0317396cff420dd379a3d1ba5b7f80421","unresolved":false,"context_lines":[{"line_number":68,"context_line":"# from nova.conf import vnc"},{"line_number":69,"context_line":"# from nova.conf import volume"},{"line_number":70,"context_line":"# from nova.conf import workarounds"},{"line_number":71,"context_line":"# from nova.conf import xenserver"},{"line_number":72,"context_line":"# from nova.conf import zookeeper"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_6b366852","line":71,"updated":"2015-12-14 12:38:54.000000000","message":"suggestions:\n\n    # from nova.conf import xvp","commit_id":"06e8f360c2ba57c06e012b1d6c5dd9a315b58061"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"7d23790b388591992d225bafe29f89b95cb33fa3","unresolved":false,"context_lines":[{"line_number":79,"context_line":"# barbican.register_opts(CONF)"},{"line_number":80,"context_line":"# base.register_opts(CONF)"},{"line_number":81,"context_line":"# cells.register_opts(CONF)"},{"line_number":82,"context_line":"# cinder.register_opts(CONF)"},{"line_number":83,"context_line":"# compute.register_opts(CONF)"},{"line_number":84,"context_line":"# conductor.register_opts(CONF)"},{"line_number":85,"context_line":"# cors.register_opts(CONF)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_8780a3c0","line":82,"updated":"2015-12-11 18:54:46.000000000","message":"ditto","commit_id":"06e8f360c2ba57c06e012b1d6c5dd9a315b58061"}]}