)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"66c8f9a8364f10c66e85e7c8c2b62b8492a5d4ab","unresolved":false,"context_lines":[{"line_number":17,"context_line":"This change is mostly a copy of FibreChannel, as recommended by hemna."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I60477778a73701794db0c0860183ea9ab144040b"},{"line_number":20,"context_line":"Blueprint: https://blueprints.launchpad.net/cinder/+spec/drbd-transport"},{"line_number":21,"context_line":"Depends-On: I7c02850ba1e9626b99a295c72175815b3dd1bdf3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bab6814e_997a1bf0","line":20,"updated":"2016-05-19 14:54:18.000000000","message":"We need a nova blueprint for this. But we don\u0027t need a spec.","commit_id":"50814e85e98dc34c7602d9eb882ee290acd663fa"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"66c8f9a8364f10c66e85e7c8c2b62b8492a5d4ab","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I60477778a73701794db0c0860183ea9ab144040b"},{"line_number":20,"context_line":"Blueprint: https://blueprints.launchpad.net/cinder/+spec/drbd-transport"},{"line_number":21,"context_line":"Depends-On: I7c02850ba1e9626b99a295c72175815b3dd1bdf3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bab6814e_79cbf71e","line":21,"updated":"2016-05-19 14:54:18.000000000","message":"You can remove this. Just note the drbd connector in os-brick was released in 0.7.0.","commit_id":"50814e85e98dc34c7602d9eb882ee290acd663fa"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0922426c116ef137c8398baee8f4d0cc7df5355f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"of needing an iSCSI hop."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Please see"},{"line_number":14,"context_line":"  http://drbd.linbit.com/users-guide-9.0/s-openstack-transport-protocol.html"},{"line_number":15,"context_line":"for more details"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Co-Authored-By: Matt Riedemann \u003cmriedem.os@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"df140735_7d26cfd0","line":14,"updated":"2017-06-01 20:40:50.000000000","message":"This link is now broken.","commit_id":"35bbcbea59ca54e943a295fb931863913359675f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"27d69ee073c6449ba95959c9a4ac8e4ce9a33a63","unresolved":false,"context_lines":[{"line_number":11,"context_line":"of needing an iSCSI hop."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Please see"},{"line_number":14,"context_line":"  http://drbd.linbit.com/users-guide-9.0/s-openstack-transport-protocol.html"},{"line_number":15,"context_line":"for more details"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Co-Authored-By: Matt Riedemann \u003cmriedem.os@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"df140735_de90314d","line":14,"in_reply_to":"df140735_7d26cfd0","updated":"2017-06-01 22:14:46.000000000","message":"Should probably be:\n\nhttp://docs.linbit.com/docs/users-guide-9.0/p-apps/#ch-openstack\n\nI can fix this and add it to the release note.","commit_id":"35bbcbea59ca54e943a295fb931863913359675f"}],"etc/nova/rootwrap.d/compute.filters":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"66c8f9a8364f10c66e85e7c8c2b62b8492a5d4ab","unresolved":false,"context_lines":[{"line_number":207,"context_line":"vgc-cluster: CommandFilter, vgc-cluster, root"},{"line_number":208,"context_line":"# os_brick/initiator/connector.py"},{"line_number":209,"context_line":"drv_cfg: CommandFilter, /opt/emc/scaleio/sdc/bin/drv_cfg, root, /opt/emc/scaleio/sdc/bin/drv_cfg, --query_guid"},{"line_number":210,"context_line":"drbdadm: CommandFilter, drbdadm, root"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"# TODO(smcginnis) Temporary fix."},{"line_number":213,"context_line":"# Need to pull in os-brick os-brick.filters file instead and clean"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"bab6814e_d9e94382","line":210,"updated":"2016-05-19 14:54:18.000000000","message":"This is going to be a non-starter. You\u0027re going to need to use oslo.privsep for this.","commit_id":"50814e85e98dc34c7602d9eb882ee290acd663fa"}],"nova/tests/unit/virt/libvirt/volume/test_drbd.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"456683511e064c330a53d5a9bb13ba6d7fef90a6","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        test_volume.LibvirtVolumeBaseTestCase):"},{"line_number":25,"context_line":"    \"\"\"Tests the LibvirtDRBDVolumeDriver class.\"\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def test_libvirt_fibrechan_driver(self):"},{"line_number":28,"context_line":"        libvirt_driver \u003d drbd.LibvirtDRBDVolumeDriver(self.fake_conn)"},{"line_number":29,"context_line":"        self.assertIsInstance(libvirt_driver.connector,"},{"line_number":30,"context_line":"                              connector.DRBDConnector)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_bfc6d546","line":27,"range":{"start_line":27,"start_character":21,"end_line":27,"end_character":30},"updated":"2016-05-19 18:18:48.000000000","message":"wrong name\n\nHow about also testing connect/disconnect and get_config - you\u0027d have to mock the connection_info and the drbd connector, but you could assert the calls are made at least.","commit_id":"1905eecefdee94d36bebaf28ae94b43a75d8e6c0"},{"author":{"_account_id":14339,"name":"Philipp Marek","email":"philipp.marek@linbit.com","username":"pmarek"},"change_message_id":"e67c406d7d876afd4310017ccf0cb6fa6fdc8ab1","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        test_volume.LibvirtVolumeBaseTestCase):"},{"line_number":25,"context_line":"    \"\"\"Tests the LibvirtDRBDVolumeDriver class.\"\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def test_libvirt_fibrechan_driver(self):"},{"line_number":28,"context_line":"        libvirt_driver \u003d drbd.LibvirtDRBDVolumeDriver(self.fake_conn)"},{"line_number":29,"context_line":"        self.assertIsInstance(libvirt_driver.connector,"},{"line_number":30,"context_line":"                              connector.DRBDConnector)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_3d9c980e","line":27,"range":{"start_line":27,"start_character":21,"end_line":27,"end_character":30},"in_reply_to":"bab6814e_bfc6d546","updated":"2016-05-20 09:01:09.000000000","message":"Done\n\nI\u0027m shooting for a full stack test - Cinder, Nova, and os-brick inbetween.\n\nIMO it makes no sense to add tests that _only_ check the python codeflow -- there not a single if or while, so the control flow in the driver is rather fixed.","commit_id":"1905eecefdee94d36bebaf28ae94b43a75d8e6c0"}],"nova/virt/libvirt/volume/drbd.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8cc495cb10f94996d73cecb483a281786088c1de","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        self.connector \u003d connector.InitiatorConnector.factory("},{"line_number":31,"context_line":"            \u0027DRBD\u0027, utils.get_root_helper())"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def get_config(self, connection_info, disk_info):"},{"line_number":34,"context_line":"        \"\"\"Returns xml for libvirt.\"\"\""},{"line_number":35,"context_line":"        conf \u003d super(LibvirtDRBDVolumeDriver,"},{"line_number":36,"context_line":"                     self).get_config(connection_info, disk_info)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        conf.source_type \u003d \"block\""},{"line_number":39,"context_line":"        conf.source_path \u003d connection_info[\u0027data\u0027][\u0027device_path\u0027]"},{"line_number":40,"context_line":"        return conf"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def connect_volume(self, connection_info, disk_info):"},{"line_number":43,"context_line":"        \"\"\"Attach the volume to instance_name.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_c384e30e","line":40,"range":{"start_line":33,"start_character":4,"end_line":40,"end_character":19},"updated":"2017-06-01 16:48:10.000000000","message":"This is the exact same as in the LibvirtVolumeDriver class so we should just use that as the base class.","commit_id":"1905eecefdee94d36bebaf28ae94b43a75d8e6c0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"456683511e064c330a53d5a9bb13ba6d7fef90a6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        return conf"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def connect_volume(self, connection_info, disk_info):"},{"line_number":43,"context_line":"        \"\"\"Attach the volume to instance_name.\"\"\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        LOG.debug(\"Calling os-brick to attach DRBD Volume\")"},{"line_number":46,"context_line":"        device_info \u003d self.connector.connect_volume(connection_info[\u0027data\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_3f78258f","line":43,"range":{"start_line":43,"start_character":32,"end_line":43,"end_character":45},"updated":"2016-05-19 18:18:48.000000000","message":"Kind of weird.","commit_id":"1905eecefdee94d36bebaf28ae94b43a75d8e6c0"},{"author":{"_account_id":14339,"name":"Philipp Marek","email":"philipp.marek@linbit.com","username":"pmarek"},"change_message_id":"e67c406d7d876afd4310017ccf0cb6fa6fdc8ab1","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        return conf"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def connect_volume(self, connection_info, disk_info):"},{"line_number":43,"context_line":"        \"\"\"Attach the volume to instance_name.\"\"\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        LOG.debug(\"Calling os-brick to attach DRBD Volume\")"},{"line_number":46,"context_line":"        device_info \u003d self.connector.connect_volume(connection_info[\u0027data\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_fda5f046","line":43,"range":{"start_line":43,"start_character":32,"end_line":43,"end_character":45},"in_reply_to":"bab6814e_3f78258f","updated":"2016-05-20 09:01:09.000000000","message":"Yeah, same as in nova/virt/libvirt/volume/fibrechannel.py ;)\n\nDone.","commit_id":"1905eecefdee94d36bebaf28ae94b43a75d8e6c0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"456683511e064c330a53d5a9bb13ba6d7fef90a6","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def connect_volume(self, connection_info, disk_info):"},{"line_number":43,"context_line":"        \"\"\"Attach the volume to instance_name.\"\"\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        LOG.debug(\"Calling os-brick to attach DRBD Volume\")"},{"line_number":46,"context_line":"        device_info \u003d self.connector.connect_volume(connection_info[\u0027data\u0027])"},{"line_number":47,"context_line":"        LOG.debug(\"Attached DRBD volume %s\", device_info)"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_ffb5fd30","line":45,"range":{"start_line":45,"start_character":19,"end_line":45,"end_character":57},"updated":"2016-05-19 18:18:48.000000000","message":"I don\u0027t see this anywhere in the drbd job run:\n\nhttp://logs.openstack.org/49/318749/1/check/gate-tempest-dsvm-full-drbd-devstack-nv/1999e51/logs/screen-n-cpu.txt.gz\n\nSo it\u0027s not being tested. Can we get the drbd job to use this nova patch to test it out?\n\nThis is where a test is attaching a volume though:\n\nhttp://logs.openstack.org/49/318749/1/check/gate-tempest-dsvm-full-drbd-devstack-nv/1999e51/logs/screen-n-cpu.txt.gz#_2016-05-19_17_04_39_046\n\nFor instance: 2facd2cd-7e61-4195-b36d-7cccb351739b\n\nAnd it\u0027s attaching to iscsi:\n\nhttp://logs.openstack.org/49/318749/1/check/gate-tempest-dsvm-full-drbd-devstack-nv/1999e51/logs/screen-n-cpu.txt.gz#_2016-05-19_17_04_44_050\n\nNot the drbd connector.\n\nSo how do we get this tested in the drbd job?","commit_id":"1905eecefdee94d36bebaf28ae94b43a75d8e6c0"},{"author":{"_account_id":14339,"name":"Philipp Marek","email":"philipp.marek@linbit.com","username":"pmarek"},"change_message_id":"ad7416c46031f75a709cabc72d68bf616fe56ee6","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def connect_volume(self, connection_info, disk_info):"},{"line_number":43,"context_line":"        \"\"\"Attach the volume to instance_name.\"\"\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        LOG.debug(\"Calling os-brick to attach DRBD Volume\")"},{"line_number":46,"context_line":"        device_info \u003d self.connector.connect_volume(connection_info[\u0027data\u0027])"},{"line_number":47,"context_line":"        LOG.debug(\"Attached DRBD volume %s\", device_info)"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_38f81f49","line":45,"range":{"start_line":45,"start_character":19,"end_line":45,"end_character":57},"in_reply_to":"bab6814e_ffb5fd30","updated":"2016-05-20 09:06:09.000000000","message":"As for the \"technical\" how, please see http://git.openstack.org/cgit/openstack/drbd-devstack/tree/devstack/lib/drbd_devstack#n224","commit_id":"1905eecefdee94d36bebaf28ae94b43a75d8e6c0"},{"author":{"_account_id":14339,"name":"Philipp Marek","email":"philipp.marek@linbit.com","username":"pmarek"},"change_message_id":"e67c406d7d876afd4310017ccf0cb6fa6fdc8ab1","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def connect_volume(self, connection_info, disk_info):"},{"line_number":43,"context_line":"        \"\"\"Attach the volume to instance_name.\"\"\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        LOG.debug(\"Calling os-brick to attach DRBD Volume\")"},{"line_number":46,"context_line":"        device_info \u003d self.connector.connect_volume(connection_info[\u0027data\u0027])"},{"line_number":47,"context_line":"        LOG.debug(\"Attached DRBD volume %s\", device_info)"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_98a30bb2","line":45,"range":{"start_line":45,"start_character":19,"end_line":45,"end_character":57},"in_reply_to":"bab6814e_ffb5fd30","updated":"2016-05-20 09:01:09.000000000","message":"As long as the volume is needed on the same node, the DRBD cinder driver will return a local device path.\n\nSo we\u0027ll need to have a multi-node CI job - which is on my agenda anyway.","commit_id":"1905eecefdee94d36bebaf28ae94b43a75d8e6c0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"456683511e064c330a53d5a9bb13ba6d7fef90a6","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        LOG.debug(\"calling os-brick to detach DRBD Volume\")"},{"line_number":55,"context_line":"        self.connector.disconnect_volume(connection_info[\u0027data\u0027],"},{"line_number":56,"context_line":"                                         connection_info[\u0027data\u0027])"},{"line_number":57,"context_line":"        LOG.debug(\"Disconnected DRBD Volume %s\", disk_dev)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        super(LibvirtDRBDVolumeDriver,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_7fb46dd0","line":56,"range":{"start_line":56,"start_character":41,"end_line":56,"end_character":64},"updated":"2016-05-19 18:18:48.000000000","message":"This should be device_info, but it\u0027s unused so you could pass None.","commit_id":"1905eecefdee94d36bebaf28ae94b43a75d8e6c0"},{"author":{"_account_id":14339,"name":"Philipp Marek","email":"philipp.marek@linbit.com","username":"pmarek"},"change_message_id":"e67c406d7d876afd4310017ccf0cb6fa6fdc8ab1","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        LOG.debug(\"calling os-brick to detach DRBD Volume\")"},{"line_number":55,"context_line":"        self.connector.disconnect_volume(connection_info[\u0027data\u0027],"},{"line_number":56,"context_line":"                                         connection_info[\u0027data\u0027])"},{"line_number":57,"context_line":"        LOG.debug(\"Disconnected DRBD Volume %s\", disk_dev)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        super(LibvirtDRBDVolumeDriver,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_5d4cfc9d","line":56,"range":{"start_line":56,"start_character":41,"end_line":56,"end_character":64},"in_reply_to":"bab6814e_7fb46dd0","updated":"2016-05-20 09:01:09.000000000","message":"Done","commit_id":"1905eecefdee94d36bebaf28ae94b43a75d8e6c0"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ce5299da2d53b4b7a44e4d1fd49513cec7229cd7","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        :param instance: The nova.objects.Instance that is having a volume"},{"line_number":42,"context_line":"            connected to it."},{"line_number":43,"context_line":"        \"\"\""},{"line_number":44,"context_line":"        LOG.debug(\"Calling os-brick to attach DRBD Volume.\", instance\u003dinstance)"},{"line_number":45,"context_line":"        device_info \u003d self.connector.connect_volume(connection_info[\u0027data\u0027])"},{"line_number":46,"context_line":"        LOG.debug(\"Attached DRBD volume %s\", device_info, instance\u003dinstance)"},{"line_number":47,"context_line":"        connection_info[\u0027data\u0027][\u0027device_path\u0027] \u003d device_info[\u0027path\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"df140735_85636e42","line":44,"range":{"start_line":44,"start_character":61,"end_line":44,"end_character":78},"updated":"2017-06-02 14:00:40.000000000","message":"that is useless, you\u0027re not exposing it in the log","commit_id":"562a04091f398a1e8e5729bd3e30a23bec3edf27"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6eaac9ec00b202323fb26639f3793d7ba2e75c6f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        :param instance: The nova.objects.Instance that is having a volume"},{"line_number":42,"context_line":"            connected to it."},{"line_number":43,"context_line":"        \"\"\""},{"line_number":44,"context_line":"        LOG.debug(\"Calling os-brick to attach DRBD Volume.\", instance\u003dinstance)"},{"line_number":45,"context_line":"        device_info \u003d self.connector.connect_volume(connection_info[\u0027data\u0027])"},{"line_number":46,"context_line":"        LOG.debug(\"Attached DRBD volume %s\", device_info, instance\u003dinstance)"},{"line_number":47,"context_line":"        connection_info[\u0027data\u0027][\u0027device_path\u0027] \u003d device_info[\u0027path\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"df140735_e848bf2d","line":44,"range":{"start_line":44,"start_character":61,"end_line":44,"end_character":78},"in_reply_to":"df140735_85636e42","updated":"2017-06-02 14:10:45.000000000","message":"Stephen told me oslo.log formatter was exposing it tho.","commit_id":"562a04091f398a1e8e5729bd3e30a23bec3edf27"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0c10e713bb1171d7df1445cc0b915bbbcc67fda9","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        :param instance: The nova.objects.Instance that is having a volume"},{"line_number":42,"context_line":"            connected to it."},{"line_number":43,"context_line":"        \"\"\""},{"line_number":44,"context_line":"        LOG.debug(\"Calling os-brick to attach DRBD Volume.\", instance\u003dinstance)"},{"line_number":45,"context_line":"        device_info \u003d self.connector.connect_volume(connection_info[\u0027data\u0027])"},{"line_number":46,"context_line":"        LOG.debug(\"Attached DRBD volume %s\", device_info, instance\u003dinstance)"},{"line_number":47,"context_line":"        connection_info[\u0027data\u0027][\u0027device_path\u0027] \u003d device_info[\u0027path\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"df140735_e801df39","line":44,"range":{"start_line":44,"start_character":61,"end_line":44,"end_character":78},"in_reply_to":"df140735_c81e1bba","updated":"2017-06-02 14:29:04.000000000","message":"e.g. http://logs.openstack.org/92/256292/6/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/e56b8d2/logs/screen-n-cpu.txt.gz#_Jun_01_22_40_06_981438","commit_id":"562a04091f398a1e8e5729bd3e30a23bec3edf27"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"00dee94cf7b4acffd0deb6937015c79494b469d3","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        :param instance: The nova.objects.Instance that is having a volume"},{"line_number":42,"context_line":"            connected to it."},{"line_number":43,"context_line":"        \"\"\""},{"line_number":44,"context_line":"        LOG.debug(\"Calling os-brick to attach DRBD Volume.\", instance\u003dinstance)"},{"line_number":45,"context_line":"        device_info \u003d self.connector.connect_volume(connection_info[\u0027data\u0027])"},{"line_number":46,"context_line":"        LOG.debug(\"Attached DRBD volume %s\", device_info, instance\u003dinstance)"},{"line_number":47,"context_line":"        connection_info[\u0027data\u0027][\u0027device_path\u0027] \u003d device_info[\u0027path\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"df140735_c81e1bba","line":44,"range":{"start_line":44,"start_character":61,"end_line":44,"end_character":78},"in_reply_to":"df140735_e848bf2d","updated":"2017-06-02 14:25:00.000000000","message":"Yes, this is common everywhere in nova, it shows up in the log as [instance xyz] or whatever.","commit_id":"562a04091f398a1e8e5729bd3e30a23bec3edf27"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ce5299da2d53b4b7a44e4d1fd49513cec7229cd7","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        \"\"\""},{"line_number":44,"context_line":"        LOG.debug(\"Calling os-brick to attach DRBD Volume.\", instance\u003dinstance)"},{"line_number":45,"context_line":"        device_info \u003d self.connector.connect_volume(connection_info[\u0027data\u0027])"},{"line_number":46,"context_line":"        LOG.debug(\"Attached DRBD volume %s\", device_info, instance\u003dinstance)"},{"line_number":47,"context_line":"        connection_info[\u0027data\u0027][\u0027device_path\u0027] \u003d device_info[\u0027path\u0027]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def disconnect_volume(self, connection_info, disk_dev, instance):"}],"source_content_type":"text/x-python","patch_set":6,"id":"df140735_65685a1c","line":46,"updated":"2017-06-02 14:00:40.000000000","message":"ditto","commit_id":"562a04091f398a1e8e5729bd3e30a23bec3edf27"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ce5299da2d53b4b7a44e4d1fd49513cec7229cd7","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        :param instance: The nova.objects.Instance that is having a volume"},{"line_number":57,"context_line":"            disconnected from it."},{"line_number":58,"context_line":"        \"\"\""},{"line_number":59,"context_line":"        LOG.debug(\"Calling os-brick to detach DRBD Volume.\", instance\u003dinstance)"},{"line_number":60,"context_line":"        self.connector.disconnect_volume(connection_info[\u0027data\u0027], None)"},{"line_number":61,"context_line":"        LOG.debug(\"Disconnected DRBD Volume %s\", disk_dev, instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":6,"id":"df140735_2585c2cf","line":59,"range":{"start_line":59,"start_character":60,"end_line":59,"end_character":78},"updated":"2017-06-02 14:00:40.000000000","message":"ditto","commit_id":"562a04091f398a1e8e5729bd3e30a23bec3edf27"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ce5299da2d53b4b7a44e4d1fd49513cec7229cd7","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        \"\"\""},{"line_number":59,"context_line":"        LOG.debug(\"Calling os-brick to detach DRBD Volume.\", instance\u003dinstance)"},{"line_number":60,"context_line":"        self.connector.disconnect_volume(connection_info[\u0027data\u0027], None)"},{"line_number":61,"context_line":"        LOG.debug(\"Disconnected DRBD Volume %s\", disk_dev, instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":6,"id":"df140735_a570b209","line":61,"range":{"start_line":61,"start_character":59,"end_line":61,"end_character":76},"updated":"2017-06-02 14:00:40.000000000","message":"ditto","commit_id":"562a04091f398a1e8e5729bd3e30a23bec3edf27"}]}