)]}'
{"nova/conf/virt.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6d422aea9117d5c0f3b5a33e0065cc4a02d2e6e8","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def list_opts():"},{"line_number":31,"context_line":"    # TODO(sfinucan): This should be moved to a virt or hardware group"},{"line_number":32,"context_line":"    return (\"DEFAULT\", ALL_OPTS)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_679cb0c0","line":32,"updated":"2015-12-11 11:24:21.000000000","message":"not sure this works with how our list opts work, because we have stuff in default here.\n\nI suspect this ones we will just reference ALL_OPTS or something like that, inside the specific list opts function.","commit_id":"d141842e189bb3c5a9056693a5d898c59659638f"}],"nova/opts.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c42226cca08344a104d9fb584ce12d50c2e6986c","unresolved":false,"context_lines":[{"line_number":101,"context_line":"             nova.utils.utils_opts,"},{"line_number":102,"context_line":"             nova.vnc.xvp_proxy.xvp_proxy_opts,"},{"line_number":103,"context_line":"             nova.volume._volume_opts,"},{"line_number":104,"context_line":"             nova.wsgi.wsgi_opts,"},{"line_number":105,"context_line":"         )),"},{"line_number":106,"context_line":"        (\u0027barbican\u0027, nova.keymgr.barbican.barbican_opts),"},{"line_number":107,"context_line":"        (\u0027cinder\u0027, nova.volume.cinder.cinder_opts),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_c429e29c","line":104,"updated":"2015-12-11 11:18:23.000000000","message":"I think you need to add the opts into here, as its in the default section.","commit_id":"d141842e189bb3c5a9056693a5d898c59659638f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6d422aea9117d5c0f3b5a33e0065cc4a02d2e6e8","unresolved":false,"context_lines":[{"line_number":101,"context_line":"             nova.utils.utils_opts,"},{"line_number":102,"context_line":"             nova.vnc.xvp_proxy.xvp_proxy_opts,"},{"line_number":103,"context_line":"             nova.volume._volume_opts,"},{"line_number":104,"context_line":"             nova.wsgi.wsgi_opts,"},{"line_number":105,"context_line":"         )),"},{"line_number":106,"context_line":"        (\u0027barbican\u0027, nova.keymgr.barbican.barbican_opts),"},{"line_number":107,"context_line":"        (\u0027cinder\u0027, nova.volume.cinder.cinder_opts),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_a769388e","line":104,"in_reply_to":"7a740942_c429e29c","updated":"2015-12-11 11:24:21.000000000","message":"oops, totally wrong.","commit_id":"d141842e189bb3c5a9056693a5d898c59659638f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6d422aea9117d5c0f3b5a33e0065cc4a02d2e6e8","unresolved":false,"context_lines":[{"line_number":130,"context_line":"             [nova.console.rpcapi.rpcapi_cap_opt],"},{"line_number":131,"context_line":"             [nova.consoleauth.rpcapi.rpcapi_cap_opt],"},{"line_number":132,"context_line":"         )),"},{"line_number":133,"context_line":"        nova.conf.virt.list_opts(),"},{"line_number":134,"context_line":"        (\u0027vnc\u0027, nova.vnc.vnc_opts),"},{"line_number":135,"context_line":"        (\u0027workarounds\u0027, nova.utils.workarounds_opts),"},{"line_number":136,"context_line":"        (\u0027zookeeper\u0027, nova.servicegroup.drivers.zk.zk_driver_opts)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_67ea7011","line":133,"updated":"2015-12-11 11:24:21.000000000","message":"I think this should actually stay in its old listopts place","commit_id":"d141842e189bb3c5a9056693a5d898c59659638f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"70e7e686f72c64f690603aa951ed45c1e787c326","unresolved":false,"context_lines":[{"line_number":130,"context_line":"             [nova.console.rpcapi.rpcapi_cap_opt],"},{"line_number":131,"context_line":"             [nova.consoleauth.rpcapi.rpcapi_cap_opt],"},{"line_number":132,"context_line":"         )),"},{"line_number":133,"context_line":"        nova.conf.virt.list_opts(),"},{"line_number":134,"context_line":"        (\u0027vnc\u0027, nova.vnc.vnc_opts),"},{"line_number":135,"context_line":"        (\u0027workarounds\u0027, nova.utils.workarounds_opts),"},{"line_number":136,"context_line":"        (\u0027zookeeper\u0027, nova.servicegroup.drivers.zk.zk_driver_opts)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_07f7ec8b","line":133,"in_reply_to":"7a740942_67ea7011","updated":"2015-12-11 11:28:58.000000000","message":"Done","commit_id":"d141842e189bb3c5a9056693a5d898c59659638f"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"c6306dbe930a7027529dedf10200b7f240193a6c","unresolved":false,"context_lines":[{"line_number":287,"context_line":"CONF.import_opt(\u0027live_migration_retry_count\u0027, \u0027nova.compute.manager\u0027)"},{"line_number":288,"context_line":"CONF.import_opt(\u0027vncserver_proxyclient_address\u0027, \u0027nova.vnc\u0027, group\u003d\u0027vnc\u0027)"},{"line_number":289,"context_line":"CONF.import_opt(\u0027server_proxyclient_address\u0027, \u0027nova.spice\u0027, group\u003d\u0027spice\u0027)"},{"line_number":290,"context_line":"CONF.import_opt(\u0027vcpu_pin_set\u0027, \u0027nova.conf.virt\u0027)"},{"line_number":291,"context_line":"CONF.import_opt(\u0027vif_plugging_is_fatal\u0027, \u0027nova.virt.driver\u0027)"},{"line_number":292,"context_line":"CONF.import_opt(\u0027vif_plugging_timeout\u0027, \u0027nova.virt.driver\u0027)"},{"line_number":293,"context_line":"CONF.import_opt(\u0027hw_disk_discard\u0027, \u0027nova.virt.libvirt.imagebackend\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_230c5940","line":290,"updated":"2015-12-18 14:56:45.000000000","message":"That\u0027s ok. When I will move the libvirt options, I\u0027m going to remove that.","commit_id":"8e675a5ba4d539e2dd644079b201dad616db4868"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"59b0a5b48f7722de8002f9ff6cb45537c23ac40a","unresolved":false,"context_lines":[{"line_number":288,"context_line":"CONF.import_opt(\u0027live_migration_retry_count\u0027, \u0027nova.compute.manager\u0027)"},{"line_number":289,"context_line":"CONF.import_opt(\u0027vncserver_proxyclient_address\u0027, \u0027nova.vnc\u0027, group\u003d\u0027vnc\u0027)"},{"line_number":290,"context_line":"CONF.import_opt(\u0027server_proxyclient_address\u0027, \u0027nova.spice\u0027, group\u003d\u0027spice\u0027)"},{"line_number":291,"context_line":"CONF.import_opt(\u0027vcpu_pin_set\u0027, \u0027nova.conf.virt\u0027)"},{"line_number":292,"context_line":"CONF.import_opt(\u0027vif_plugging_is_fatal\u0027, \u0027nova.virt.driver\u0027)"},{"line_number":293,"context_line":"CONF.import_opt(\u0027vif_plugging_timeout\u0027, \u0027nova.virt.driver\u0027)"},{"line_number":294,"context_line":"CONF.import_opt(\u0027hw_disk_discard\u0027, \u0027nova.virt.libvirt.imagebackend\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_73dc4b73","line":291,"updated":"2016-01-05 17:16:48.000000000","message":"Nit: we could just remove this line I think, if we update where CONF is imported from.","commit_id":"75bea43b73ec89cfae151b19ca34eb0edcdcf4d3"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"556309533d9cb5a47970430e43040582de4e8c90","unresolved":false,"context_lines":[{"line_number":288,"context_line":"CONF.import_opt(\u0027live_migration_retry_count\u0027, \u0027nova.compute.manager\u0027)"},{"line_number":289,"context_line":"CONF.import_opt(\u0027vncserver_proxyclient_address\u0027, \u0027nova.vnc\u0027, group\u003d\u0027vnc\u0027)"},{"line_number":290,"context_line":"CONF.import_opt(\u0027server_proxyclient_address\u0027, \u0027nova.spice\u0027, group\u003d\u0027spice\u0027)"},{"line_number":291,"context_line":"CONF.import_opt(\u0027vcpu_pin_set\u0027, \u0027nova.conf.virt\u0027)"},{"line_number":292,"context_line":"CONF.import_opt(\u0027vif_plugging_is_fatal\u0027, \u0027nova.virt.driver\u0027)"},{"line_number":293,"context_line":"CONF.import_opt(\u0027vif_plugging_timeout\u0027, \u0027nova.virt.driver\u0027)"},{"line_number":294,"context_line":"CONF.import_opt(\u0027hw_disk_discard\u0027, \u0027nova.virt.libvirt.imagebackend\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"da6ed579_5e7147df","line":291,"in_reply_to":"fa69d971_73dc4b73","updated":"2016-01-13 16:44:55.000000000","message":"The follow up patch is available with review https://review.openstack.org/#/c/267022/","commit_id":"75bea43b73ec89cfae151b19ca34eb0edcdcf4d3"}],"nova/virt/opts.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6d422aea9117d5c0f3b5a33e0065cc4a02d2e6e8","unresolved":false,"context_lines":[{"line_number":51,"context_line":"import nova.virt.xenapi.volume_utils"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def list_opts():"},{"line_number":55,"context_line":"    return ["},{"line_number":56,"context_line":"        (\u0027DEFAULT\u0027,"},{"line_number":57,"context_line":"         itertools.chain("}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_672d9045","side":"PARENT","line":54,"updated":"2015-12-11 11:24:21.000000000","message":"eventually, we will probably move this whole thing into a central location, but easier to leave this here for now.","commit_id":"7b70d232e5cf576978b4baa86e6f6083f0ad3e05"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6d422aea9117d5c0f3b5a33e0065cc4a02d2e6e8","unresolved":false,"context_lines":[{"line_number":60,"context_line":"             nova.virt.disk.mount.nbd.nbd_opts,"},{"line_number":61,"context_line":"             nova.virt.driver.driver_opts,"},{"line_number":62,"context_line":"             nova.virt.firewall.firewall_opts,"},{"line_number":63,"context_line":"             nova.virt.hardware.virt_cpu_opts,"},{"line_number":64,"context_line":"             nova.virt.imagecache.imagecache_opts,"},{"line_number":65,"context_line":"             nova.virt.images.image_opts,"},{"line_number":66,"context_line":"             nova.virt.netutils.netutils_opts,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_07dccc71","side":"PARENT","line":63,"updated":"2015-12-11 11:24:21.000000000","message":"I think this should just get imported from the new location, and stay in here, so the opt appears in the correct example config file.","commit_id":"7b70d232e5cf576978b4baa86e6f6083f0ad3e05"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"70e7e686f72c64f690603aa951ed45c1e787c326","unresolved":false,"context_lines":[{"line_number":60,"context_line":"             nova.virt.disk.mount.nbd.nbd_opts,"},{"line_number":61,"context_line":"             nova.virt.driver.driver_opts,"},{"line_number":62,"context_line":"             nova.virt.firewall.firewall_opts,"},{"line_number":63,"context_line":"             nova.virt.hardware.virt_cpu_opts,"},{"line_number":64,"context_line":"             nova.virt.imagecache.imagecache_opts,"},{"line_number":65,"context_line":"             nova.virt.images.image_opts,"},{"line_number":66,"context_line":"             nova.virt.netutils.netutils_opts,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_a7eff8af","side":"PARENT","line":63,"in_reply_to":"7a740942_07dccc71","updated":"2015-12-11 11:28:58.000000000","message":"Done","commit_id":"7b70d232e5cf576978b4baa86e6f6083f0ad3e05"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fe8ccbd67663a470c8a01166e26decebeed24a29","unresolved":false,"context_lines":[{"line_number":65,"context_line":"             nova.virt.netutils.netutils_opts,"},{"line_number":66,"context_line":"         )),"},{"line_number":67,"context_line":"        (\u0027guestfs\u0027, nova.virt.disk.vfs.guestfs.guestfs_opts),"},{"line_number":68,"context_line":"        nova.conf.virt.list_opts(),"},{"line_number":69,"context_line":"        (\u0027hyperv\u0027,"},{"line_number":70,"context_line":"         itertools.chain("},{"line_number":71,"context_line":"             nova.virt.hyperv.pathutils.hyperv_opts,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_a71db8bf","line":68,"updated":"2015-12-11 11:30:07.000000000","message":"Not sure that works, as we end up with two DEFAULT sections?","commit_id":"f363b81da72ef136afc8fbc35289e8c63def9fdc"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e2a62e8915977f8d1e71a25a7e2497862e667046","unresolved":false,"context_lines":[{"line_number":65,"context_line":"             nova.virt.netutils.netutils_opts,"},{"line_number":66,"context_line":"         )),"},{"line_number":67,"context_line":"        (\u0027guestfs\u0027, nova.virt.disk.vfs.guestfs.guestfs_opts),"},{"line_number":68,"context_line":"        nova.conf.virt.list_opts(),"},{"line_number":69,"context_line":"        (\u0027hyperv\u0027,"},{"line_number":70,"context_line":"         itertools.chain("},{"line_number":71,"context_line":"             nova.virt.hyperv.pathutils.hyperv_opts,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_731312b9","line":68,"updated":"2015-12-11 13:00:35.000000000","message":"Does this work? I expected to see nova.conf.virt.ALL_OPTS being added into the existing default section.","commit_id":"c3a4c515650c041c4090c91ee5bbd7b0a11c4bef"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"b20d063b52f35ad8b5618b8b11d835ea8ff4ffe7","unresolved":false,"context_lines":[{"line_number":65,"context_line":"             nova.virt.netutils.netutils_opts,"},{"line_number":66,"context_line":"         )),"},{"line_number":67,"context_line":"        (\u0027guestfs\u0027, nova.virt.disk.vfs.guestfs.guestfs_opts),"},{"line_number":68,"context_line":"        nova.conf.virt.list_opts(),"},{"line_number":69,"context_line":"        (\u0027hyperv\u0027,"},{"line_number":70,"context_line":"         itertools.chain("},{"line_number":71,"context_line":"             nova.virt.hyperv.pathutils.hyperv_opts,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_ec5f190d","line":68,"in_reply_to":"7a740942_05e921e6","updated":"2015-12-11 15:20:59.000000000","message":"It does work; oslo_config does the right thing. This confused me at first, too, but testing with markus_z showed that it does indeed work.","commit_id":"c3a4c515650c041c4090c91ee5bbd7b0a11c4bef"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e4fd8bb6af6d5e4098190b59a35c4a2a3fde8124","unresolved":false,"context_lines":[{"line_number":65,"context_line":"             nova.virt.netutils.netutils_opts,"},{"line_number":66,"context_line":"         )),"},{"line_number":67,"context_line":"        (\u0027guestfs\u0027, nova.virt.disk.vfs.guestfs.guestfs_opts),"},{"line_number":68,"context_line":"        nova.conf.virt.list_opts(),"},{"line_number":69,"context_line":"        (\u0027hyperv\u0027,"},{"line_number":70,"context_line":"         itertools.chain("},{"line_number":71,"context_line":"             nova.virt.hyperv.pathutils.hyperv_opts,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_05e921e6","line":68,"in_reply_to":"7a740942_731312b9","updated":"2015-12-11 13:17:16.000000000","message":"It appears to, yes. There is only one [DEFAULT] section with all expected options including this one. The header looks like so:\n\n    #injected_network_template \u003d $pybasedir/nova/virt/interfaces.template\n    \n    #\n    # From nova.virt\n    #\n    \n    # Defines ...\n    #vcpu_pin_set \u003d \u003cNone\u003e\n\n    #\n    # From oslo.log","commit_id":"c3a4c515650c041c4090c91ee5bbd7b0a11c4bef"}]}