)]}'
{"nova/conf/__init__.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"fea6a4ba38718d170b142893d46d69ae8ed0b171","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# For more background see the blueprint \"centralize-config-options\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from nova.conf import glance"},{"line_number":23,"context_line":"from nova.conf import scheduler"},{"line_number":24,"context_line":"from nova.conf import serial_console"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_d3e565a8","line":21,"updated":"2016-01-19 14:57:58.000000000","message":"When you rebase this change, you will notice a lot of comments in this file and you just have to remove the two comments for your changes here.","commit_id":"49a1ffe3bc29bb659307e501f16e38438b4f50c6"}],"nova/conf/glance.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5dd3f0b100fdbad89408f3e943d567f28af012f8","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                     \u0027via the direct_url.  Currently supported schemes: \u0027"},{"line_number":49,"context_line":"                     \u0027[file].\u0027),"},{"line_number":50,"context_line":"    ]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def register_opts(conf):"},{"line_number":54,"context_line":"    conf.register_opts(glance_opts, \u0027glance\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a710552_f91df566","line":51,"updated":"2015-12-15 13:53:44.000000000","message":"Do you consider enhancing the help text similar to https://review.openstack.org/#/c/255512/2/nova/conf/scheduler.py,cm ?","commit_id":"49a1ffe3bc29bb659307e501f16e38438b4f50c6"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"9a3121feb37058c1124f5a51f72432aa7e9e040a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                     \u0027via the direct_url.  Currently supported schemes: \u0027"},{"line_number":49,"context_line":"                     \u0027[file].\u0027),"},{"line_number":50,"context_line":"    ]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def register_opts(conf):"},{"line_number":54,"context_line":"    conf.register_opts(glance_opts, \u0027glance\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_13969d4c","line":51,"in_reply_to":"5a710552_f91df566","updated":"2016-01-19 14:55:15.000000000","message":"That should be done in a follow up change.","commit_id":"49a1ffe3bc29bb659307e501f16e38438b4f50c6"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5dd3f0b100fdbad89408f3e943d567f28af012f8","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                     \u0027[file].\u0027),"},{"line_number":50,"context_line":"    ]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def register_opts(conf):"},{"line_number":54,"context_line":"    conf.register_opts(glance_opts, \u0027glance\u0027)"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a710552_6eb6198c","line":52,"updated":"2015-12-15 13:53:44.000000000","message":"I think there are missing glance related configs:\nDEFAULT.osapi_glance_link_prefix\nimage_file_url.filesystems","commit_id":"49a1ffe3bc29bb659307e501f16e38438b4f50c6"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"9a3121feb37058c1124f5a51f72432aa7e9e040a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                     \u0027[file].\u0027),"},{"line_number":50,"context_line":"    ]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def register_opts(conf):"},{"line_number":54,"context_line":"    conf.register_opts(glance_opts, \u0027glance\u0027)"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_932b6deb","line":52,"in_reply_to":"5a710552_58f5f580","updated":"2016-01-19 14:55:15.000000000","message":"We will handle \"osapi_glance_link_prefix\" in the \"nova/conf/api.py\" module. It could be in the glance module but I tend more to the api module.\n\nThe \"filesystems\" option is pretty weird as it seems it creates config options on the fly. I\u0027d like to take a closer look at that. Let\u0027s skip it here.\n\nIOW, I\u0027m fine with the selected config options in this module.","commit_id":"49a1ffe3bc29bb659307e501f16e38438b4f50c6"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"5ea14a5f02a8f9434d0b7ff438f2c720d80b7b20","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                     \u0027[file].\u0027),"},{"line_number":50,"context_line":"    ]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def register_opts(conf):"},{"line_number":54,"context_line":"    conf.register_opts(glance_opts, \u0027glance\u0027)"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a710552_58f5f580","line":52,"in_reply_to":"5a710552_6eb6198c","updated":"2015-12-16 08:20:12.000000000","message":"I\u0027m not sure whether it is better to put it here or in other file.","commit_id":"49a1ffe3bc29bb659307e501f16e38438b4f50c6"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5f86fb7d5b231ca3753e544f92728b96be5115f6","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"def list_opts():"},{"line_number":88,"context_line":"    return {glance_group.name: ALL_OPTS}"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa0719c6_b5234c55","line":88,"range":{"start_line":88,"start_character":25,"end_line":88,"end_character":29},"updated":"2016-03-24 12:21:08.000000000","message":"Nit: we can pass the group now, but lets do a global tidy up later on.","commit_id":"9cf05578884428308793766c1cead65a335b1785"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"73cda512fc3029ab8001b4197f323ca0cbd4dfc7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Huawei Technology corp."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":13,"id":"da0c15f0_b825a3ac","line":1,"updated":"2016-03-25 18:10:58.000000000","message":"Please remove this line.","commit_id":"7e0b68e75a98df5da4112f95c97817c6138d852a"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"eb5ee628235162742e3dc57638e7a22f037942ce","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Huawei Technology corp."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":15,"id":"da0c15f0_b2d3e85e","line":1,"updated":"2016-03-27 13:20:53.000000000","message":"Please remove the copyright line here. It is just moved code, not new code.","commit_id":"3a97a309b4c06fea165568937f7b09583daa27ff"}],"nova/image/glance.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5f86fb7d5b231ca3753e544f92728b96be5115f6","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    cfg.StrOpt(\u0027host\u0027,"},{"line_number":51,"context_line":"               default\u003d\u0027$my_ip\u0027,"},{"line_number":52,"context_line":"               # TODO(sdague): remove in N"},{"line_number":53,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":54,"context_line":"               help\u003d\u0027DEPRECATED: Glance server hostname or IP address. \u0027"},{"line_number":55,"context_line":"                    \u0027Use the \"api_servers\" option instead.\u0027),"},{"line_number":56,"context_line":"    cfg.IntOpt(\u0027port\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa0719c6_55df5039","side":"PARENT","line":53,"updated":"2016-03-24 12:21:08.000000000","message":"You have missed the changes that have happened here. A bad rebase prehaps?","commit_id":"c4763d46fe76c524363a0cf55d1e8afe4bd23f53"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"c237776392140bad9c87b49f40a5f9fab5bc157e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    cfg.StrOpt(\u0027host\u0027,"},{"line_number":51,"context_line":"               default\u003d\u0027$my_ip\u0027,"},{"line_number":52,"context_line":"               # TODO(sdague): remove in N"},{"line_number":53,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":54,"context_line":"               help\u003d\u0027DEPRECATED: Glance server hostname or IP address. \u0027"},{"line_number":55,"context_line":"                    \u0027Use the \"api_servers\" option instead.\u0027),"},{"line_number":56,"context_line":"    cfg.IntOpt(\u0027port\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa0719c6_55b2b0e5","side":"PARENT","line":53,"in_reply_to":"fa0719c6_55df5039","updated":"2016-03-24 12:23:08.000000000","message":"I will look into this","commit_id":"c4763d46fe76c524363a0cf55d1e8afe4bd23f53"}],"nova/opts.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"fea6a4ba38718d170b142893d46d69ae8ed0b171","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        (\u0027api_database\u0027, nova.db.sqlalchemy.api.api_db_opts),"},{"line_number":109,"context_line":"        (\u0027conductor\u0027, nova.conductor.api.conductor_opts),"},{"line_number":110,"context_line":"        (\u0027database\u0027, nova.db.sqlalchemy.api.oslo_db_options.database_opts),"},{"line_number":111,"context_line":"        (\u0027glance\u0027, nova.conf.glance.list_opts()),"},{"line_number":112,"context_line":"        (\u0027image_file_url\u0027, [nova.image.download.file.opt_group]),"},{"line_number":113,"context_line":"        (\u0027keymgr\u0027,"},{"line_number":114,"context_line":"         itertools.chain("}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_d377a500","line":111,"updated":"2016-01-19 14:57:58.000000000","message":"When you rebase this change, this line won\u0027t be necessary anymore and should be deleted. The \"nova/conf/opts.py\" does this automatically now.","commit_id":"49a1ffe3bc29bb659307e501f16e38438b4f50c6"}],"nova/virt/xenapi/image/glance.py":[{"author":{"_account_id":18723,"name":"Allen Gao","email":"wanlong.gao@gmail.com","username":"allen"},"change_message_id":"be53a5cc4ce6bc0912a581b7ba3c081ad1e5e9fc","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import functools"},{"line_number":17,"context_line":"import sys"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_config import cfg"},{"line_number":20,"context_line":"from oslo_log import log as logging"},{"line_number":21,"context_line":"import six"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"ba0121b8_c2e15a00","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":27},"updated":"2016-03-30 09:03:01.000000000","message":"should be removed.","commit_id":"61f139e5d8253a813d65f79835bbcbefbecadf93"},{"author":{"_account_id":18723,"name":"Allen Gao","email":"wanlong.gao@gmail.com","username":"allen"},"change_message_id":"be53a5cc4ce6bc0912a581b7ba3c081ad1e5e9fc","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from oslo_log import log as logging"},{"line_number":21,"context_line":"import six"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import nova.conf"},{"line_number":24,"context_line":"from nova.compute import utils as compute_utils"},{"line_number":25,"context_line":"from nova import exception"},{"line_number":26,"context_line":"from nova.image import glance"}],"source_content_type":"text/x-python","patch_set":18,"id":"ba0121b8_02cb5273","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":16},"updated":"2016-03-30 09:03:01.000000000","message":"the import order should after nova.compute.","commit_id":"61f139e5d8253a813d65f79835bbcbefbecadf93"}]}