)]}'
{"Authors":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"bb9995f2247c509288f255726e13b1207d3961d7","unresolved":false,"context_lines":[{"line_number":155,"context_line":"Zhixue Wu \u003cZhixue.Wu@citrix.com\u003e"},{"line_number":156,"context_line":"Zhongyue Luo \u003clzyeval@gmail.com\u003e"},{"line_number":157,"context_line":"Zed Shaw \u003czedshaw@zedshaw.com\u003e"},{"line_number":158,"context_line":"Joshua Harlow \u003charlowja@yahoo-inc.com\u003e"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"AAAADX%2F%2F%2F8I%3D","line":158,"updated":"2012-01-05 19:26:11.000000000","message":"The rest of this file is in alphabetical order.  Can you move your entry?","commit_id":"4966f75afc1cb202124a2452d8e0346371a1162a"}],"nova/flags.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"2817f402410a88b8c72fbe9af9f22e0d1e8e0536","unresolved":false,"context_lines":[{"line_number":298,"context_line":"DEFINE_string(\u0027rabbit_host\u0027, \u0027localhost\u0027, \u0027rabbit host\u0027)"},{"line_number":299,"context_line":"DEFINE_integer(\u0027rabbit_port\u0027, 5672, \u0027rabbit port\u0027)"},{"line_number":300,"context_line":"DEFINE_bool(\u0027rabbit_use_ssl\u0027, False, \u0027connect over SSL\u0027)"},{"line_number":301,"context_line":"DEFINE_string(\u0027kombu_ssl_version\u0027, \u0027\u0027, \u0027SSL version to use \u0027 "},{"line_number":302,"context_line":"                                            \u0027(valid only if SSL enabled)\u0027)"},{"line_number":303,"context_line":"DEFINE_string(\u0027kombu_ssl_keyfile\u0027, \u0027\u0027, \u0027SSL key file \u0027 "},{"line_number":304,"context_line":"                                            \u0027(valid only if SSL enabled)\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAADH%2F%2F%2BfM%3D","line":301,"updated":"2012-01-04 18:21:16.000000000","message":"Some whitespace at line endings here... pep8 will complain","commit_id":"0905f04823b8e1a46217bcc92caf72b4e357c8ca"}],"nova/rpc/impl_kombu.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"29298d0a275605df4f8ebc99f7e8bf271a30502b","unresolved":false,"context_lines":[{"line_number":311,"context_line":"                          password\u003dFLAGS.rabbit_password,"},{"line_number":312,"context_line":"                          virtual_host\u003dFLAGS.rabbit_virtual_host)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        if(FLAGS.rabbit_use_ssl):"},{"line_number":315,"context_line":"            self.using_ssl \u003d True"},{"line_number":316,"context_line":"            self.params[\u0027ssl\u0027] \u003d self._fetch_ssl_params()"},{"line_number":317,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F650%3D","line":314,"updated":"2011-12-22 21:31:35.000000000","message":"The parenthesis here, as well as other if statements, aren\u0027t necessary.","commit_id":"329bce1fff962d668e93e1fda4ecbeb72b4e230e"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"bb9995f2247c509288f255726e13b1207d3961d7","unresolved":false,"context_lines":[{"line_number":335,"context_line":"                          virtual_host\u003dFLAGS.rabbit_virtual_host)"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        if FLAGS.rabbit_use_ssl:"},{"line_number":338,"context_line":"            self.using_ssl \u003d True"},{"line_number":339,"context_line":"            self.params[\u0027ssl\u0027] \u003d self._fetch_ssl_params()"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        if FLAGS.fake_rabbit:"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAADX%2F%2F%2F78%3D","line":338,"updated":"2012-01-05 19:26:11.000000000","message":"It might be worth adding a comment here noting that this variable is checked from the unit test.  At first I thought it wasn\u0027t used anywhere and could be removed.","commit_id":"4966f75afc1cb202124a2452d8e0346371a1162a"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"48cb0e6d54f87e9a3cb190930116bcda3cd4c316","unresolved":false,"context_lines":[{"line_number":24,"context_line":"import time"},{"line_number":25,"context_line":"import traceback"},{"line_number":26,"context_line":"import uuid"},{"line_number":27,"context_line":"import ssl"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"import eventlet"},{"line_number":30,"context_line":"from eventlet import greenpool"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAD3%2F%2F%2BZU%3D","line":27,"updated":"2012-01-13 05:52:52.000000000","message":"HACKING violation.  ssl should be before sys.\n\n(I see the kombu imports also violate HACKING, but those could be fixed separately)","commit_id":"e09a70e8685e230214e5d48c5d3d7a93f2396ed7"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"48cb0e6d54f87e9a3cb190930116bcda3cd4c316","unresolved":false,"context_lines":[{"line_number":360,"context_line":"            ssl_params[\u0027keyfile\u0027] \u003d FLAGS.kombu_ssl_keyfile"},{"line_number":361,"context_line":"        if len(FLAGS.kombu_ssl_certfile):"},{"line_number":362,"context_line":"            ssl_params[\u0027certfile\u0027] \u003d FLAGS.kombu_ssl_certfile"},{"line_number":363,"context_line":"        if len(FLAGS.kombu_ssl_ca_certs):"},{"line_number":364,"context_line":"            ssl_params[\u0027ca_certs\u0027] \u003d FLAGS.kombu_ssl_ca_certs"},{"line_number":365,"context_line":"            # We might want to allow variations in the"},{"line_number":366,"context_line":"            # future with this?"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAD3%2F%2F%2BZQ%3D","line":363,"updated":"2012-01-13 05:52:52.000000000","message":"All of those if\u0027s would be better as:\nif FLAGS.\u003cwhatever\u003e:","commit_id":"e09a70e8685e230214e5d48c5d3d7a93f2396ed7"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"48cb0e6d54f87e9a3cb190930116bcda3cd4c316","unresolved":false,"context_lines":[{"line_number":366,"context_line":"            # future with this?"},{"line_number":367,"context_line":"            ssl_params[\u0027cert_reqs\u0027] \u003d ssl.CERT_REQUIRED"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        if len(ssl_params) \u003d\u003d 0:"},{"line_number":370,"context_line":"            # Just have the default behavior"},{"line_number":371,"context_line":"            return True"},{"line_number":372,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAD3%2F%2F%2BZI%3D","line":369,"updated":"2012-01-13 05:52:52.000000000","message":"same here.","commit_id":"e09a70e8685e230214e5d48c5d3d7a93f2396ed7"}],"nova/tests/rpc/test_kombu_ssl.py":[{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"13d9c78f63b52465fad4e0cd36840e11d5924864","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"FLAGS \u003d flags.FLAGS"},{"line_number":32,"context_line":"flags.DECLARE(\"rabbit_use_ssl\", \u0027\u0027)"},{"line_number":33,"context_line":"FLAGS[\u0027rabbit_use_ssl\u0027].SetDefault(True)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"SSL_VERSION \u003d \"SSLv2\""},{"line_number":36,"context_line":"flags.DECLARE(\"kombu_ssl_version\", \"\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAEX%2F%2F%2F%2FI%3D","line":33,"updated":"2012-02-01 23:43:32.000000000","message":"It\u0027s probably easier to use self.flags() in a setUp() method of your test class.","commit_id":"4ec4bb3f09d5b94e808df6c89cd73230752810b6"}]}