)]}'
{"nova/tests/functional/api_samples_test_base.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"13e8d847fad9eb5df76565e3856a3be7e8868747","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        \"\"\"Process sample data and update version specific links.\"\"\""},{"line_number":252,"context_line":"        updated_data \u003d sample_data"},{"line_number":253,"context_line":"        if update_links:"},{"line_number":254,"context_line":"            url_re \u003d self._get_host() + \"/v(2\\.1|2)\""},{"line_number":255,"context_line":"            new_url \u003d self._get_host() + \"/\" + self.api_major_version"},{"line_number":256,"context_line":"            updated_data \u003d re.sub(url_re, new_url, sample_data)"},{"line_number":257,"context_line":"        return updated_data"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_e77932c9","line":254,"updated":"2015-12-14 09:46:28.000000000","message":"Emm...I still think we shouldn\u0027t fix this in this patch, I tested this, remove this change, this patch still can pass the tests.","commit_id":"d60ebfff60a631ad0d0218482c1abc10080238d2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"893422f2432294c682658d09f0986b8e113ec1ed","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        \"\"\"Process sample data and update version specific links.\"\"\""},{"line_number":252,"context_line":"        updated_data \u003d sample_data"},{"line_number":253,"context_line":"        if update_links:"},{"line_number":254,"context_line":"            url_re \u003d self._get_host() + \"/v(2\\.1|2)\""},{"line_number":255,"context_line":"            new_url \u003d self._get_host() + \"/\" + self.api_major_version"},{"line_number":256,"context_line":"            updated_data \u003d re.sub(url_re, new_url, sample_data)"},{"line_number":257,"context_line":"        return updated_data"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a710552_7d6cac9c","line":254,"in_reply_to":"7a740942_e77932c9","updated":"2015-12-15 04:16:01.000000000","message":"Yea, this fix fail without version tests update, but yea its good idea to separate both","commit_id":"d60ebfff60a631ad0d0218482c1abc10080238d2"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"13e8d847fad9eb5df76565e3856a3be7e8868747","unresolved":false,"context_lines":[{"line_number":277,"context_line":"            with file(self._get_sample(name,"},{"line_number":278,"context_line":"                                       self.microversion)) as sample:"},{"line_number":279,"context_line":"                sample_data \u003d sample.read()"},{"line_number":280,"context_line":"                sample_data \u003d self._update_links(sample_data, update_links)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        try:"},{"line_number":283,"context_line":"            template_data \u003d self._objectify(template_data)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_076b1e1f","line":280,"updated":"2015-12-14 09:46:28.000000000","message":"Actually we should check \u0027update_links\u0027 at here.\n\nIf \u0027update_links\u0027 is False, then we needn\u0027t execute _update_links method. We can see \u0027_update_links\u0027 with \u0027update_links\u0027 is False, \u0027_update_links\u0027 will do nothing.","commit_id":"d60ebfff60a631ad0d0218482c1abc10080238d2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"893422f2432294c682658d09f0986b8e113ec1ed","unresolved":false,"context_lines":[{"line_number":277,"context_line":"            with file(self._get_sample(name,"},{"line_number":278,"context_line":"                                       self.microversion)) as sample:"},{"line_number":279,"context_line":"                sample_data \u003d sample.read()"},{"line_number":280,"context_line":"                sample_data \u003d self._update_links(sample_data, update_links)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        try:"},{"line_number":283,"context_line":"            template_data \u003d self._objectify(template_data)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a710552_5d0a10d4","line":280,"in_reply_to":"7a740942_076b1e1f","updated":"2015-12-15 04:16:01.000000000","message":"Nice way. Done","commit_id":"d60ebfff60a631ad0d0218482c1abc10080238d2"}]}