)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"e1856d1796f70bd4e023147abbdeb483999cbf8f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     linbing \u003chawkerous@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-18 15:05:12 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the TypeError：when all_cluster is None"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* when get vcenter of all cluster return None, it\u0027s  a NoneType, and"},{"line_number":10,"context_line":" could not be iterable, so it will cause error like ：“TypeError:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a7e1126_bad04df7","line":7,"updated":"2015-12-19 14:59:43.000000000","message":"Title like this would better:\nVMware: Fix bug when getting reference of vCenter cluster is None","commit_id":"104b3c10295861f181bc33e1923b7ad9b6dfd4b6"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"e1856d1796f70bd4e023147abbdeb483999cbf8f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the TypeError：when all_cluster is None"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* when get vcenter of all cluster return None, it\u0027s  a NoneType, and"},{"line_number":10,"context_line":" could not be iterable, so it will cause error like ：“TypeError:"},{"line_number":11,"context_line":" \u0027NoneType\u0027 object is not iterable ”"},{"line_number":12,"context_line":"* i have changed the modify in get_all_cluster_mors"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a7e1126_dafbd979","line":9,"updated":"2015-12-19 14:59:43.000000000","message":"When","commit_id":"104b3c10295861f181bc33e1923b7ad9b6dfd4b6"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"e1856d1796f70bd4e023147abbdeb483999cbf8f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"* when get vcenter of all cluster return None, it\u0027s  a NoneType, and"},{"line_number":10,"context_line":" could not be iterable, so it will cause error like ：“TypeError:"},{"line_number":11,"context_line":" \u0027NoneType\u0027 object is not iterable ”"},{"line_number":12,"context_line":"* i have changed the modify in get_all_cluster_mors"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1525913"},{"line_number":15,"context_line":"Change-Id: Ifcf0e1edf378f239030a27e40d5bed436876858b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a7e1126_7aed05b6","line":12,"updated":"2015-12-19 14:59:43.000000000","message":"You can change \"i have changed the modify in get_all_cluster_mors\" like this:\n\nThis patch add the situation of cluster reference is None, will return an empty list.","commit_id":"104b3c10295861f181bc33e1923b7ad9b6dfd4b6"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"c5cb9cb288e4f522a953e99860d522c1e5d600be","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     linbing \u003chawkerous@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-12 23:33:28 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: Fix bug of TypeError when getting reference of VCenter cluster"},{"line_number":8,"context_line":"is None."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"* When get VCenter of all cluster reference and return None, it\u0027s  a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da6ed579_e344c04a","line":7,"updated":"2016-01-15 05:34:42.000000000","message":"This line is too long.\n\nSee https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure\n\n\u003e The first line should be limited to 50 characters and should not end with a period.","commit_id":"87b8ed4307ae90ded70e1f986705b2be9b82765f"}],"nova/virt/vmwareapi/vm_util.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"a346d0f7174922e675db2fb6688a7837ea722769","unresolved":false,"context_lines":[{"line_number":1269,"context_line":"    \"\"\"Get reference to the vCenter cluster with the specified name.\"\"\""},{"line_number":1270,"context_line":"    all_clusters \u003d get_all_cluster_mors(session)"},{"line_number":1271,"context_line":"    if not all_clusters:"},{"line_number":1272,"context_line":"        return"},{"line_number":1273,"context_line":"    for cluster in all_clusters:"},{"line_number":1274,"context_line":"        if (hasattr(cluster, \u0027propSet\u0027) and"},{"line_number":1275,"context_line":"                    cluster.propSet[0].val \u003d\u003d cluster_name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_5cb382e9","line":1272,"updated":"2015-12-18 15:17:24.000000000","message":"ok, why not change it in get_all_cluster_mors, as this is the only caller for that. It seems like making it do the right thing would be better.","commit_id":"fe58cd2c4531a0e7730a85097e8ee8c77a23e5fa"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"c5cb9cb288e4f522a953e99860d522c1e5d600be","unresolved":false,"context_lines":[{"line_number":1264,"context_line":"        session._call_method(vutil, \u0027cancel_retrieval\u0027,"},{"line_number":1265,"context_line":"                             results)"},{"line_number":1266,"context_line":"        if results.objects is None:"},{"line_number":1267,"context_line":"\t    return []"},{"line_number":1268,"context_line":"        else:"},{"line_number":1269,"context_line":"            return results.objects"},{"line_number":1270,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_43ccacba","line":1267,"updated":"2016-01-15 05:34:42.000000000","message":"Use spaces instead of tab.","commit_id":"87b8ed4307ae90ded70e1f986705b2be9b82765f"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"4288c91efd7715150ccdbe16a1ab2caed46de951","unresolved":false,"context_lines":[{"line_number":1275,"context_line":"def get_cluster_ref_by_name(session, cluster_name):"},{"line_number":1276,"context_line":"    \"\"\"Get reference to the vCenter cluster with the specified name.\"\"\""},{"line_number":1277,"context_line":"    all_clusters \u003d get_all_cluster_mors(session)"},{"line_number":1278,"context_line":"    for cluster in all_clusters:"},{"line_number":1279,"context_line":"        if (hasattr(cluster, \u0027propSet\u0027) and"},{"line_number":1280,"context_line":"                    cluster.propSet[0].val \u003d\u003d cluster_name):"},{"line_number":1281,"context_line":"            return cluster.obj"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_03059e0f","line":1278,"range":{"start_line":1278,"start_character":4,"end_line":1278,"end_character":32},"updated":"2016-03-04 00:06:39.000000000","message":"or how about changing here like\n\n if all_clusters is not None:\n     for cluster in all_clusters:\n\n?\nbecause here is only caller of the method.","commit_id":"87b8ed4307ae90ded70e1f986705b2be9b82765f"}]}