)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"4c1a33818839604213e9b24810f13606d85f3b2d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Simply obey the comment that this should be removed \"after"},{"line_number":10,"context_line":"icehouse\". I think we\u0027ve reached that point now."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"I\u0027ve also removed the object primative in get_instance_diagnostics."},{"line_number":13,"context_line":"The API layer passes in an object (the common helper requests"},{"line_number":14,"context_line":"objects), it was just the unit test doing the old thing."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a7e1126_6bc59a3a","line":12,"updated":"2015-12-17 15:03:37.000000000","message":"As far as I can tell this change is okay because get_instance_diagnostics is not actually used by nova-api, not because an object is passed in.","commit_id":"8ced5451bb3ac01f2c324b5d5d5694804d396580"}],"nova/compute/manager.py":[{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"0237e3cb34245638c5a12a44a37ec9954505b9e0","unresolved":false,"context_lines":[{"line_number":1362,"context_line":"        \"\"\""},{"line_number":1363,"context_line":"        return self.driver.refresh_security_group_rules(security_group_id)"},{"line_number":1364,"context_line":""},{"line_number":1365,"context_line":"    @object_compat"},{"line_number":1366,"context_line":"    @wrap_exception()"},{"line_number":1367,"context_line":"    def refresh_instance_security_rules(self, context, instance):"},{"line_number":1368,"context_line":"        \"\"\"Tell the virtualization driver to refresh security rules for"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a710552_5787480f","side":"PARENT","line":1365,"updated":"2015-12-15 08:11:36.000000000","message":"Yes, this sends an instance object since liberty.","commit_id":"ededf5b4de81457bae74e97c7699185cabbbd24c"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"0237e3cb34245638c5a12a44a37ec9954505b9e0","unresolved":false,"context_lines":[{"line_number":4083,"context_line":"                state\u003dinstance.power_state,"},{"line_number":4084,"context_line":"                method\u003d\u0027get_diagnostics\u0027)"},{"line_number":4085,"context_line":""},{"line_number":4086,"context_line":"    @object_compat"},{"line_number":4087,"context_line":"    @wrap_exception()"},{"line_number":4088,"context_line":"    @wrap_instance_fault"},{"line_number":4089,"context_line":"    def get_instance_diagnostics(self, context, instance):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a710552_f7ce7482","side":"PARENT","line":4086,"updated":"2015-12-15 08:11:36.000000000","message":"Client side still sends a primitive here, but this should be ok since it hasn\u0027t been used for some time. This change however should fix the client side too. See https://github.com/openstack/nova/blob/master/nova/compute/rpcapi.py#L517\n\nThe reason this call is left in place looks to be a work in progress for defining a standard format for server diagnostics API. See https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/server_diagnostics.py#L39","commit_id":"ededf5b4de81457bae74e97c7699185cabbbd24c"}],"nova/compute/rpcapi.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"133f3fb1e0a80e381b0963fd3fa53b0e741342d4","unresolved":false,"context_lines":[{"line_number":516,"context_line":"    def get_instance_diagnostics(self, ctxt, instance):"},{"line_number":517,"context_line":"        # TODO(danms): This needs to be fixed for objects"},{"line_number":518,"context_line":"        instance_p \u003d jsonutils.to_primitive(instance)"},{"line_number":519,"context_line":"        kwargs \u003d {\u0027instance\u0027: instance_p}"},{"line_number":520,"context_line":"        version \u003d \u00274.0\u0027"},{"line_number":521,"context_line":"        cctxt \u003d self.client.prepare(server\u003d_compute_host(None, instance),"},{"line_number":522,"context_line":"                version\u003dversion)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_1fcc3069","side":"PARENT","line":519,"updated":"2016-01-04 15:14:01.000000000","message":"This means we\u0027re still sending the primitive, which means you can\u0027t remove it from the manager until we fix this with a minor change, and then remove it after a major one.","commit_id":"83e9a9a6059a32a4f3fcb661819fc42c89252d00"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"672a05450b4b486d7e0413e69a5bc79f4fa3f751","unresolved":false,"context_lines":[{"line_number":516,"context_line":"    def get_instance_diagnostics(self, ctxt, instance):"},{"line_number":517,"context_line":"        # TODO(danms): This needs to be fixed for objects"},{"line_number":518,"context_line":"        instance_p \u003d jsonutils.to_primitive(instance)"},{"line_number":519,"context_line":"        kwargs \u003d {\u0027instance\u0027: instance_p}"},{"line_number":520,"context_line":"        version \u003d \u00274.0\u0027"},{"line_number":521,"context_line":"        cctxt \u003d self.client.prepare(server\u003d_compute_host(None, instance),"},{"line_number":522,"context_line":"                version\u003dversion)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_d3071380","side":"PARENT","line":519,"in_reply_to":"fa69d971_1fcc3069","updated":"2016-01-06 11:40:20.000000000","message":"I had this same concern but I believe it\u0027s okay because there is no caller of get_instance_diagnostics.  It was used in API v3 but when moving to v2.1 the API had to switch back to another method in order to retain compat with v2.  That\u0027s why I picked on the commit message for the previous revision because it somewhat explained this but not properly.","commit_id":"83e9a9a6059a32a4f3fcb661819fc42c89252d00"}]}