)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"665908f08a2ea6d4c4e63b18fddaa3c72c72c14c","unresolved":false,"context_lines":[{"line_number":680,"context_line":"        attempts \u003d 0"},{"line_number":681,"context_line":"        start \u003d time.time()"},{"line_number":682,"context_line":"        while True:"},{"line_number":683,"context_line":"            if attempts \u003e\u003d max_tries:"},{"line_number":684,"context_line":"                duration \u003d int(time.time() - start)"},{"line_number":685,"context_line":"                raise exception.VolumeNotCreated(volume_id\u003dvol_id,"},{"line_number":686,"context_line":"                                                 seconds\u003dduration)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2FuE0%3D","line":683,"updated":"2013-04-01 18:53:52.000000000","message":"Make this condition be the condition of your while loop, then put the raise logic after the loop exits…","commit_id":"5a4121f12f8adf36e9ec04cb8cdabe272a68f9f5"},{"author":{"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"},"change_message_id":"dae3aab60a628e91747ee02a8ebf1d9088f2de71","unresolved":false,"context_lines":[{"line_number":680,"context_line":"        attempts \u003d 0"},{"line_number":681,"context_line":"        start \u003d time.time()"},{"line_number":682,"context_line":"        while True:"},{"line_number":683,"context_line":"            if attempts \u003e\u003d max_tries:"},{"line_number":684,"context_line":"                duration \u003d int(time.time() - start)"},{"line_number":685,"context_line":"                raise exception.VolumeNotCreated(volume_id\u003dvol_id,"},{"line_number":686,"context_line":"                                                 seconds\u003dduration)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2FtkQ%3D","line":683,"in_reply_to":"AAAAOH%2F%2FuE0%3D","updated":"2013-04-01 23:34:38.000000000","message":"a \"while less than max_tries\" with an else block raising would be perfect.","commit_id":"5a4121f12f8adf36e9ec04cb8cdabe272a68f9f5"}],"nova/tests/compute/test_compute.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"0b43b1c9bdb2fbf8089c5382ad55529adb4717a6","unresolved":false,"context_lines":[{"line_number":306,"context_line":"                                                     wait_between\u003d0.1)"},{"line_number":307,"context_line":"        self.assertEqual(attempts, 3)"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"        # This one is expected to raise, since 3 \u003e 2"},{"line_number":310,"context_line":"        self.fetched_attempts \u003d 0"},{"line_number":311,"context_line":"        self.stubs.Set(self.compute.volume_api, \u0027get\u0027, slow_get)"},{"line_number":312,"context_line":"        self.assertRaises(exception.VolumeNotCreated,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2Fs5c%3D","line":309,"updated":"2013-04-02 13:28:54.000000000","message":"I would prefer the following code in a new test method.  There\u0027s a standard pattern of testing a success condition and a failure condition in different tests.","commit_id":"0ad9453b122befb4d7be7b870e9bb8307f23ce0a"}]}