)]}'
{"nova/conf/virt.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6b0304cec145765fa91ffa5abcd891d2b58472e7","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"def list_opts():"},{"line_number":93,"context_line":"    # TODO(sfinucan): This should be moved to a virt or hardware group"},{"line_number":94,"context_line":"    return {\u0027DEFAULT\u0027, ALL_OPTS}"}],"source_content_type":"text/x-python","patch_set":14,"id":"da6ed579_a26c2b9d","line":94,"range":{"start_line":94,"start_character":13,"end_line":94,"end_character":20},"updated":"2016-01-12 15:25:36.000000000","message":"list_opts() should return a list of tuples:\n  return [(\u0027DEFAULT\u0027, ALL_OPTS)]","commit_id":"6dbfaef1610ed776332584bfc7b2f02d70fb4d43"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ea715c99cd90833a9be74308dbbc467dbbe8d4ca","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"def list_opts():"},{"line_number":93,"context_line":"    # TODO(sfinucan): This should be moved to a virt or hardware group"},{"line_number":94,"context_line":"    return {\u0027DEFAULT\u0027, ALL_OPTS}"}],"source_content_type":"text/x-python","patch_set":14,"id":"da6ed579_367ddc1c","line":94,"range":{"start_line":94,"start_character":13,"end_line":94,"end_character":20},"in_reply_to":"da6ed579_330dee3e","updated":"2016-01-12 16:46:38.000000000","message":"You are right, thanks.\n\nBut, at least this should be a dictionary initialization:\n  return {\u0027DEFAULT\u0027: ALL_OPTS}","commit_id":"6dbfaef1610ed776332584bfc7b2f02d70fb4d43"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5c972e580cbccd31e6b1e207719b459deb2342ae","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"def list_opts():"},{"line_number":93,"context_line":"    # TODO(sfinucan): This should be moved to a virt or hardware group"},{"line_number":94,"context_line":"    return {\u0027DEFAULT\u0027, ALL_OPTS}"}],"source_content_type":"text/x-python","patch_set":14,"id":"da6ed579_330dee3e","line":94,"range":{"start_line":94,"start_character":13,"end_line":94,"end_character":20},"in_reply_to":"da6ed579_a26c2b9d","updated":"2016-01-12 16:40:25.000000000","message":"Not anymore. See this:\n\nhttps://review.openstack.org/#/c/260015/","commit_id":"6dbfaef1610ed776332584bfc7b2f02d70fb4d43"}],"nova/virt/disk/api.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"47d8e66011b0403ccd4a3721f2b31bc1b2ef20d7","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"CONF \u003d cfg.CONF"},{"line_number":76,"context_line":"CONF.register_opts(disk_opts)"},{"line_number":77,"context_line":"CONF.import_opt(\u0027default_ephemeral_format\u0027, \u0027nova.conf.virt\u0027)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"_MKFS_COMMAND \u003d {}"},{"line_number":80,"context_line":"_DEFAULT_MKFS_COMMAND \u003d None"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_ce4fccbb","line":77,"updated":"2016-01-04 14:15:55.000000000","message":"This line will be removed in a later commit anyway (because of the config options declared here) and because of that it\u0027s no harm to do it this way instead of the \"import nova.conf\" way you did in the other modules.","commit_id":"a5e4f853ffe1b3932b52e37913ed1eb808fa8382"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e3944530c457f95052df6d5f8e4a77c640ebf7f3","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"CONF \u003d cfg.CONF"},{"line_number":76,"context_line":"CONF.register_opts(disk_opts)"},{"line_number":77,"context_line":"CONF.import_opt(\u0027default_ephemeral_format\u0027, \u0027nova.conf.virt\u0027)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"_MKFS_COMMAND \u003d {}"},{"line_number":80,"context_line":"_DEFAULT_MKFS_COMMAND \u003d None"}],"source_content_type":"text/x-python","patch_set":18,"id":"da6ed579_f50f9a34","line":77,"updated":"2016-01-15 04:44:21.000000000","message":"Why is this import_opt() necessary?","commit_id":"1789e9b95e4bbeddbe0976cf7e139e1283b471e1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e781cc49823c132db8575c9ee3df96aff3fd2f89","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"CONF \u003d cfg.CONF"},{"line_number":76,"context_line":"CONF.register_opts(disk_opts)"},{"line_number":77,"context_line":"CONF.import_opt(\u0027default_ephemeral_format\u0027, \u0027nova.conf.virt\u0027)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"_MKFS_COMMAND \u003d {}"},{"line_number":80,"context_line":"_DEFAULT_MKFS_COMMAND \u003d None"}],"source_content_type":"text/x-python","patch_set":18,"id":"da6ed579_826135ab","line":77,"in_reply_to":"da6ed579_f50f9a34","updated":"2016-01-15 09:55:49.000000000","message":"It isn\u0027t :) Removed","commit_id":"1789e9b95e4bbeddbe0976cf7e139e1283b471e1"}],"nova/virt/ironic/patcher.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"85e8b9c3f5704115e8b308510a6dfd8271c2f0d6","unresolved":false,"context_lines":[{"line_number":20,"context_line":"Helper classes for Ironic HTTP PATCH creation."},{"line_number":21,"context_line":"\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from oslo_config import cfg"},{"line_number":24,"context_line":"from oslo_serialization import jsonutils"},{"line_number":25,"context_line":"import six"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"CONF \u003d cfg.CONF"},{"line_number":28,"context_line":"CONF.import_opt(\u0027default_ephemeral_format\u0027, \u0027nova.conf.virt\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def create(node):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a7e1126_79be9066","line":28,"range":{"start_line":23,"start_character":0,"end_line":28,"end_character":61},"updated":"2015-12-18 15:11:09.000000000","message":"I would have expected something like this:\n\n    from oslo_serialization import jsonutils\n    import six\n\n    import nova.conf\n\n    CONF \u003d nova.conf.CONF\n\nFor the other modules as well, I just took this one as an example.","commit_id":"52b09bbf53e50b2d9a1b9145d9fbf67119f55a6b"}],"nova/virt/opts.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"85e8b9c3f5704115e8b308510a6dfd8271c2f0d6","unresolved":false,"context_lines":[{"line_number":64,"context_line":"             nova.virt.images.image_opts,"},{"line_number":65,"context_line":"             nova.virt.netutils.netutils_opts,"},{"line_number":66,"context_line":"         )),"},{"line_number":67,"context_line":"        (\u0027guestfs\u0027, nova.virt.disk.vfs.guestfs.guestfs_opts),"},{"line_number":68,"context_line":"        nova.conf.virt.list_opts(),"},{"line_number":69,"context_line":"        (\u0027hyperv\u0027,"},{"line_number":70,"context_line":"         itertools.chain("}],"source_content_type":"text/x-python","patch_set":4,"id":"3a7e1126_5c0ce23a","side":"PARENT","line":67,"updated":"2015-12-18 15:11:09.000000000","message":"This move is not necessary I guess? We will consolidate all \"nova/*/opts.py\" into one single \"nova/conf/opts.py\" [1] which means we don\u0027t have to reorder things here.\n\n[1] https://review.openstack.org/#/c/255436/","commit_id":"4e81e8bdae8c231de633c4f347e285a6dced1353"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"4ab42610b71c35702f6fab652ac7016f2eb96880","unresolved":false,"context_lines":[{"line_number":62,"context_line":"             nova.virt.netutils.netutils_opts,"},{"line_number":63,"context_line":"         )),"},{"line_number":64,"context_line":"        (\u0027guestfs\u0027, nova.virt.disk.vfs.guestfs.guestfs_opts),"},{"line_number":65,"context_line":"        nova.conf.virt.list_opts(),"},{"line_number":66,"context_line":"        (\u0027hyperv\u0027,"},{"line_number":67,"context_line":"         itertools.chain("},{"line_number":68,"context_line":"             nova.virt.hyperv.pathutils.hyperv_opts,"}],"source_content_type":"text/x-python","patch_set":16,"id":"da6ed579_dfa8a88f","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":35},"updated":"2016-01-14 10:17:19.000000000","message":"That\u0027s the issue. Remove the line, and everything\u0027s fine.\nThat came in with commit 75bea43b73ec where we had another approach to list the options.","commit_id":"363d518d96f601235c449fb94ed3f265a8aa9870"}]}