)]}'
{"nova/virt/hyperv/volumeops.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"90206f02b303d350ef1815a6bbb6a9951dc4c833","unresolved":false,"context_lines":[{"line_number":234,"context_line":"            data \u003d connection_info[\u0027data\u0027]"},{"line_number":235,"context_line":"            target_lun \u003d data[\u0027target_lun\u0027]"},{"line_number":236,"context_line":"            target_iqn \u003d data[\u0027target_iqn\u0027]"},{"line_number":237,"context_line":"            serial \u003d connection_info[\u0027serial\u0027]"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"            # Getting the mounted disk"},{"line_number":240,"context_line":"            mounted_disk_path \u003d self._get_mounted_disk_from_lun(target_iqn,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_9ba544a3","line":237,"updated":"2016-01-14 18:30:04.000000000","message":"Cinder drivers don\u0027t set this value.  I presume the connection_info in this case comes from cinder\u0027s initialize_connection call?\n\nAlso, is the intention of \u0027serial\u0027 here the unique scsi_id or wwn associated with page 0x83 on the scsi device/volume ?\n\nos-brick reads the scsi_id from the device itself during attaches/discovery.","commit_id":"4ce79961a919e2d0fc5ece8e018d69188142c2bc"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"e6fedb29898d91cfbae3619b85e8cab06851a75a","unresolved":false,"context_lines":[{"line_number":234,"context_line":"            data \u003d connection_info[\u0027data\u0027]"},{"line_number":235,"context_line":"            target_lun \u003d data[\u0027target_lun\u0027]"},{"line_number":236,"context_line":"            target_iqn \u003d data[\u0027target_iqn\u0027]"},{"line_number":237,"context_line":"            serial \u003d connection_info[\u0027serial\u0027]"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"            # Getting the mounted disk"},{"line_number":240,"context_line":"            mounted_disk_path \u003d self._get_mounted_disk_from_lun(target_iqn,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_a7f1066d","line":237,"in_reply_to":"da6ed579_9ba544a3","updated":"2016-01-14 20:24:33.000000000","message":"This is set by Nova here: https://github.com/openstack/nova/blob/master/nova/virt/block_device.py#L266\n\nBasically, we had issues when trying to identify which volume is attached to a specific slot, so we had to tag them.","commit_id":"4ce79961a919e2d0fc5ece8e018d69188142c2bc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b221dc89e697292a58a3c01a0bc147d398f4759f","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                                                      ctrller_path,"},{"line_number":257,"context_line":"                                                      slot,"},{"line_number":258,"context_line":"                                                      mounted_disk_path,"},{"line_number":259,"context_line":"                                                      serial\u003dserial)"},{"line_number":260,"context_line":"        except Exception:"},{"line_number":261,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":262,"context_line":"                LOG.error(_LE(\u0027Unable to attach volume to instance %s\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_b3517011","line":259,"updated":"2016-02-25 17:49:12.000000000","message":"serial is optional for this call, but are we sure that connection_info will have serial in it above?","commit_id":"82bf282dd599d9c1528a34a032513e6721ae9876"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fc1ed3311825f86c1c263a977848aa0d1ce9ffe5","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                                                      ctrller_path,"},{"line_number":257,"context_line":"                                                      slot,"},{"line_number":258,"context_line":"                                                      mounted_disk_path,"},{"line_number":259,"context_line":"                                                      serial\u003dserial)"},{"line_number":260,"context_line":"        except Exception:"},{"line_number":261,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":262,"context_line":"                LOG.error(_LE(\u0027Unable to attach volume to instance %s\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_3393a0a5","line":259,"in_reply_to":"9aed3d3a_b3517011","updated":"2016-02-25 17:51:49.000000000","message":"I guess it should be:\n\nhttps://github.com/openstack/nova/blob/f99077cf24ceee79d0abe84b5a53b82c7d64c5cb/nova/virt/block_device.py#L262-L266","commit_id":"82bf282dd599d9c1528a34a032513e6721ae9876"}]}