)]}'
{"nova/virt/hyperv/volumeops.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"79becd86298d584676c466b512a4978c585243f1","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        for serial, vm_disk in vm_disk_mapping.items():"},{"line_number":133,"context_line":"            actual_disk_path \u003d actual_disk_mapping[serial]"},{"line_number":134,"context_line":"            if vm_disk[\u0027mounted_disk_path\u0027] !\u003d actual_disk_path:"},{"line_number":135,"context_line":"                self._vmutils.set_disk_host_resource(vm_disk[\u0027resource_path\u0027],"},{"line_number":136,"context_line":"                                                     actual_disk_path)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def get_volume_connector(self, instance):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a7b0d38_eeda1678","line":135,"updated":"2015-12-23 11:29:09.000000000","message":"set_disk_host_res instead.","commit_id":"2ac1296d85277284cafd9005a261394cf08996d0"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"7efab1fc2bff0e848d96c426799d93dd1f0576d8","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        disk_path_mapping \u003d {}"},{"line_number":161,"context_line":"        for vol in block_mapping:"},{"line_number":162,"context_line":"            connection_info \u003d vol[\u0027connection_info\u0027]"},{"line_number":163,"context_line":"            disk_serial \u003d connection_info[\u0027serial\u0027]"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"            disk_path \u003d self.get_mounted_disk_path_from_volume(connection_info)"},{"line_number":166,"context_line":"            disk_path_mapping[disk_serial] \u003d disk_path"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_3b0bf88f","line":163,"updated":"2016-01-14 18:31:02.000000000","message":"cinder drivers don\u0027t set this value.  So, I\u0027m not sure where you are getting this from ?","commit_id":"15a089cc98b97a1580e2a599f366dc8776aacd5d"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"35e85a9d4533391fd5df2612b8f6b6a8e0b40ca5","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        disk_path_mapping \u003d {}"},{"line_number":161,"context_line":"        for vol in block_mapping:"},{"line_number":162,"context_line":"            connection_info \u003d vol[\u0027connection_info\u0027]"},{"line_number":163,"context_line":"            disk_serial \u003d connection_info[\u0027serial\u0027]"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"            disk_path \u003d self.get_mounted_disk_path_from_volume(connection_info)"},{"line_number":166,"context_line":"            disk_path_mapping[disk_serial] \u003d disk_path"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_c7c2fae8","line":163,"in_reply_to":"da6ed579_3b0bf88f","updated":"2016-01-14 20:25:09.000000000","message":"This is set by Nova here: https://github.com/openstack/nova/blob/master/nova/virt/block_device.py#L266\n\nBasically, we had issues when trying to identify which volume is attached to a specific slot, so we had to tag them.","commit_id":"15a089cc98b97a1580e2a599f366dc8776aacd5d"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"c0170a3b3858f75af37cdca6d5a52e2afd00d0e2","unresolved":false,"context_lines":[{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        target_iqn \u003d connection_info[\u0027data\u0027][\u0027target_iqn\u0027]"},{"line_number":303,"context_line":"        mounted_disk_path \u003d self.get_mounted_disk_path_from_volume("},{"line_number":304,"context_line":"                connection_info)"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        LOG.debug(\"Detaching physical disk from instance: %s\","},{"line_number":307,"context_line":"                  mounted_disk_path)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_7690ee43","line":304,"updated":"2016-01-04 18:08:54.000000000","message":"looks overindented.","commit_id":"15a089cc98b97a1580e2a599f366dc8776aacd5d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ac3c98a5d5bc70f05d4dd48cac56eb5254aa4e1e","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                                                  block_device_info)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def fix_instance_volume_disk_paths(self, instance_name, block_device_info):"},{"line_number":119,"context_line":"        mapping \u003d driver.block_device_info_get_mapping(block_device_info)"},{"line_number":120,"context_line":"        if not mapping:"},{"line_number":121,"context_line":"            return"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_bcc4fe5e","line":119,"updated":"2016-02-04 23:07:40.000000000","message":"This call will be made again inside self.get_disk_path_mapping(). Why not call self.get_disk_path_mapping() instead here and return if not actual_disk_mapping to avoid a needless extra call?","commit_id":"55c96371b44847fc82031b66cd603e9788cc6386"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"b13704410cb0590c302ebfd7b847d640781dfc8a","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                                                  block_device_info)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def fix_instance_volume_disk_paths(self, instance_name, block_device_info):"},{"line_number":119,"context_line":"        mapping \u003d driver.block_device_info_get_mapping(block_device_info)"},{"line_number":120,"context_line":"        if not mapping:"},{"line_number":121,"context_line":"            return"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_66b5d1cb","line":119,"in_reply_to":"5a5ae5dd_bcc4fe5e","updated":"2016-02-10 17:21:15.000000000","message":"Makes sense, I\u0027ll change this. Thanks for pointing this out!","commit_id":"55c96371b44847fc82031b66cd603e9788cc6386"}]}