)]}'
{"id":"openstack%2Fnova~25918","triplet_id":"openstack%2Fnova~master~Ifc6b6a8faadc2e97e09f9f6c975e52229f705789","project":"openstack/nova","branch":"master","topic":"bug/1163394","hashtags":[],"change_id":"Ifc6b6a8faadc2e97e09f9f6c975e52229f705789","subject":"Raise rather than generating millions of IPs.","status":"MERGED","created":"2013-04-02 16:26:26.000000000","updated":"2013-04-02 19:42:50.000000000","submitted":"2013-04-02 19:42:48.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4a555fa624dabe2521a771dd21cb5c884338a3d5","_number":25918,"virtual_id_number":25918,"owner":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},{"value":0,"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":1,"date":"2013-04-02 19:10:15.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":2,"date":"2013-04-02 19:42:48.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},"all":[{"value":0,"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},{"value":2,"date":"2013-04-02 19:02:54.000000000","_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},{"value":2,"date":"2013-04-02 18:52:48.000000000","_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"date":"2013-04-02 18:51:57.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":1,"date":"2013-04-02 18:58:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-04-02 19:06:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},"all":[{"value":0,"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},{"value":1,"date":"2013-04-02 19:02:54.000000000","_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},{"value":0,"date":"2013-04-02 18:52:48.000000000","_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},{"value":0,"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-04-02 18:09:48.000000000","updated_by":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"reviewer":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"state":"REVIEWER"},{"updated":"2013-04-02 18:52:48.000000000","updated_by":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"reviewer":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"state":"REVIEWER"},{"updated":"2013-04-02 18:58:13.000000000","updated_by":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"reviewer":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"state":"REVIEWER"},{"updated":"2013-04-02 19:02:54.000000000","updated_by":{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},"reviewer":{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},"state":"REVIEWER"},{"updated":"2013-04-02 19:06:39.000000000","updated_by":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"reviewer":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"state":"REVIEWER"},{"updated":"2013-04-02 19:10:15.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2013-04-02 19:42:48.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"b5f32743063c1575a814b55eb5305511740b01aa","author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"date":"2013-04-02 17:06:08.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nplease see suggestion inline","accounts_in_message":[],"_revision_number":1},{"id":"b82119a622c12e916e035a43459f4c2278ffc718","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-02 17:10:26.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/25918/1/check/gate-nova-pep8/23964 : SUCCESS\n- http://logs.openstack.org/25918/1/check/gate-nova-docs/18237 : SUCCESS\n- http://logs.openstack.org/25918/1/check/gate-nova-python26/19645 : SUCCESS\n- http://logs.openstack.org/25918/1/check/gate-nova-python26-rhel6/355 : SUCCESS (non-voting)\n- http://logs.openstack.org/25918/1/check/gate-nova-python27/19733 : SUCCESS\n- http://logs.openstack.org/25918/1/check/gate-tempest-devstack-vm-full/11274 : SUCCESS\n- http://logs.openstack.org/25918/1/check/gate-tempest-devstack-vm-postgres-full/10990 : SUCCESS\n- http://logs.openstack.org/25918/1/check/gate-tempest-devstack-vm-quantum/16956 : SUCCESS\n- http://logs.openstack.org/25918/1/check/gate-nova-pylint/10059 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"3426f6feab70b8c82c2e61fd7990d2d052956499","author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"date":"2013-04-02 18:01:24.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"cca61d222ad4d753c45a0068e64e42f43d1dd9d3","author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"date":"2013-04-02 18:01:46.000000000","message":"Patch Set 2:\n\nReworded error message per suggestion by Dims.","accounts_in_message":[],"_revision_number":2},{"id":"2da5eeceb4e26163bb01b2cec9aee8f151f25c4c","author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"date":"2013-04-02 18:09:48.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"170e2e24e5e79bc22c9359292d94058a5aee7700","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-04-02 18:37:00.000000000","message":"Patch Set 2: Works for me\n\nSmokeStack Results (patch set 2):\n\tLibvirt (Fedora 18) Success: http://smokestack.openstack.org/?go\u003d/jobs/81161\n\tXenServer 5.6 (F18 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/81162\n","accounts_in_message":[],"_revision_number":2},{"id":"d0d1c2cd799372db41fbc8036aaecbd27ba0177f","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2013-04-02 18:43:15.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\nLGTM, but as this it would be nice to explain why 1 million is too many in the actual code itself.  (As a note or in the error msg itself).","accounts_in_message":[],"_revision_number":2},{"id":"8158edba2117188ff7ea0dec562bb26734d9eb30","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-02 18:44:21.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/25918/2/check/gate-nova-pep8/23967 : SUCCESS\n- http://logs.openstack.org/25918/2/check/gate-nova-docs/18240 : SUCCESS\n- http://logs.openstack.org/25918/2/check/gate-nova-python26/19648 : SUCCESS\n- http://logs.openstack.org/25918/2/check/gate-nova-python26-rhel6/358 : SUCCESS (non-voting)\n- http://logs.openstack.org/25918/2/check/gate-nova-python27/19736 : SUCCESS\n- http://logs.openstack.org/25918/2/check/gate-tempest-devstack-vm-full/11282 : SUCCESS\n- http://logs.openstack.org/25918/2/check/gate-tempest-devstack-vm-postgres-full/10998 : SUCCESS\n- http://logs.openstack.org/25918/2/check/gate-tempest-devstack-vm-quantum/16970 : SUCCESS\n- http://logs.openstack.org/25918/2/check/gate-nova-pylint/10062 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"784e46a2e614bc2bc39e6e0878432616c87776c2","author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"date":"2013-04-02 18:51:36.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"3a38cf67c1e28704d4c35a8935eb550d3831d577","author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"date":"2013-04-02 18:51:57.000000000","message":"Patch Set 3:\n\nAdded a comment as Joe suggested.","accounts_in_message":[],"_revision_number":3},{"id":"efaeff97c31bd4b35da75b140d79312af44a7519","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2013-04-02 18:52:48.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\nThanks","accounts_in_message":[],"_revision_number":3},{"id":"3a69cb5e90e6906b3387cfb1d161210eeeb3259d","author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"date":"2013-04-02 18:58:13.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\nlgtm","accounts_in_message":[],"_revision_number":3},{"id":"5333bd8720a3492d72a068470cfa50f48a8f25a2","author":{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},"date":"2013-04-02 19:02:54.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"b9a9fd30e6bc2867b6a834fc55dffcfa9297e8ee","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-02 19:02:59.000000000","message":"Patch Set 3:\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"c8675e164efff3db60337233d2630a1c526e408c","author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"date":"2013-04-02 19:06:39.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\nNice find","accounts_in_message":[],"_revision_number":3},{"id":"ab4434deaaed1c4ecc1e2f60d76591454677ae98","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-04-02 19:10:15.000000000","message":"Patch Set 3: Works for me\n\nSmokeStack Results (patch set 3):\n\tLibvirt (Fedora 18) Success: http://smokestack.openstack.org/?go\u003d/jobs/81166\n\tXenServer 5.6 (F18 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/81167\n","accounts_in_message":[],"_revision_number":3},{"id":"96ae5e5c607e8765d8c8fa4e4f7cc7735fb33b4a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-02 19:35:48.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/25918/3/check/gate-nova-pep8/23969 : SUCCESS\n- http://logs.openstack.org/25918/3/check/gate-nova-docs/18242 : SUCCESS\n- http://logs.openstack.org/25918/3/check/gate-nova-python26/19650 : SUCCESS\n- http://logs.openstack.org/25918/3/check/gate-nova-python26-rhel6/360 : SUCCESS (non-voting)\n- http://logs.openstack.org/25918/3/check/gate-nova-python27/19738 : SUCCESS\n- http://logs.openstack.org/25918/3/check/gate-tempest-devstack-vm-full/11288 : SUCCESS\n- http://logs.openstack.org/25918/3/check/gate-tempest-devstack-vm-postgres-full/11004 : SUCCESS\n- http://logs.openstack.org/25918/3/check/gate-tempest-devstack-vm-quantum/16977 : SUCCESS\n- http://logs.openstack.org/25918/3/check/gate-nova-pylint/10064 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"0fd28569ac1198a8db80b7b4129569e692843326","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-02 19:42:48.000000000","message":"Patch Set 3: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/25918/3/gate/gate-nova-docs/18243 : SUCCESS\n- http://logs.openstack.org/25918/3/gate/gate-nova-pep8/23970 : SUCCESS\n- http://logs.openstack.org/25918/3/gate/gate-nova-python26/19651 : SUCCESS\n- http://logs.openstack.org/25918/3/gate/gate-nova-python27/19739 : SUCCESS\n- http://logs.openstack.org/25918/3/gate/gate-tempest-devstack-vm-full/11289 : SUCCESS\n- http://logs.openstack.org/25918/3/gate/gate-tempest-devstack-vm-postgres-full/11005 : SUCCESS\n- http://logs.openstack.org/25918/3/gate/gate-tempest-devstack-vm-quantum/16978 : SUCCESS\n","accounts_in_message":[],"_revision_number":3},{"id":"7b9b79a2c149a0a8fac6d8a2c470349724f09720","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-02 19:42:50.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"34de8d1529fb9a2e7fad096a6967b9a483ab0cb0","revisions":{"1784934de746947e241eadf74f58ad106e326de0":{"kind":"REWORK","_number":1,"created":"2013-04-02 16:26:26.000000000","uploader":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"ref":"refs/changes/18/25918/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/18/25918/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/18/25918/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/18/25918/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/18/25918/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/18/25918/1"}}},"commit":{"parents":[{"commit":"0ae8a9a7e7b0dce76b3530b99ce881da8285a0ce","subject":"Merge \"Remove print statements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0ae8a9a7e7b0dce76b3530b99ce881da8285a0ce"}]}],"author":{"name":"David Ripton","email":"dripton@redhat.com","date":"2013-04-02 16:19:17.000000000","tz":-240},"committer":{"name":"David Ripton","email":"dripton@redhat.com","date":"2013-04-02 16:19:17.000000000","tz":-240},"subject":"Raise rather than generating millions of IPs.","message":"Raise rather than generating millions of IPs.\n\nFixes bug #1163394\n\nFormerly if we tried to create many millions of floating IPs with a\nrange like \"192.168.2.224/2\", address_to_hosts would happily iterate\nover all of them (which would take a long time) and then nova-manage\nwould eventually crash with an OutOfMemoryError when we tried putting\nall of them in a list.  Or, if the initial list wasn\u0027t quite big\nenough to use all memory, it would blow up later (even more slowly)\nwhen we tried to put them in the database via SQLAlchemy.\n\nNow, raise exception.InvalidInput if the number of IPs is a million\nor more.  (A million is erring on the side of caution.)\n\nChange-Id: Ifc6b6a8faadc2e97e09f9f6c975e52229f705789\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1784934de746947e241eadf74f58ad106e326de0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1784934de746947e241eadf74f58ad106e326de0"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"0ae8a9a7e7b0dce76b3530b99ce881da8285a0ce","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"755254d4e7631ede097345c3b41ae96131007a21":{"kind":"REWORK","_number":2,"created":"2013-04-02 18:01:24.000000000","uploader":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"ref":"refs/changes/18/25918/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/18/25918/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/18/25918/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/18/25918/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/18/25918/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/18/25918/2"}}},"commit":{"parents":[{"commit":"0ae8a9a7e7b0dce76b3530b99ce881da8285a0ce","subject":"Merge \"Remove print statements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0ae8a9a7e7b0dce76b3530b99ce881da8285a0ce"}]}],"author":{"name":"David Ripton","email":"dripton@redhat.com","date":"2013-04-02 16:19:17.000000000","tz":-240},"committer":{"name":"David Ripton","email":"dripton@redhat.com","date":"2013-04-02 18:01:02.000000000","tz":-240},"subject":"Raise rather than generating millions of IPs.","message":"Raise rather than generating millions of IPs.\n\nFixes bug #1163394\n\nFormerly if we tried to create many millions of floating IPs with a\nrange like \"192.168.2.224/2\", address_to_hosts would happily iterate\nover all of them (which would take a long time) and then nova-manage\nwould eventually crash with an OutOfMemoryError when we tried putting\nall of them in a list.  Or, if the initial list wasn\u0027t quite big\nenough to use all memory, it would blow up later (even more slowly)\nwhen we tried to put them in the database via SQLAlchemy.\n\nNow, raise exception.InvalidInput if the number of IPs is a million\nor more.  (A million is erring on the side of caution.)\n\nChange-Id: Ifc6b6a8faadc2e97e09f9f6c975e52229f705789\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/755254d4e7631ede097345c3b41ae96131007a21"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/755254d4e7631ede097345c3b41ae96131007a21"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"0ae8a9a7e7b0dce76b3530b99ce881da8285a0ce","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"34de8d1529fb9a2e7fad096a6967b9a483ab0cb0":{"kind":"REWORK","_number":3,"created":"2013-04-02 18:51:36.000000000","uploader":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"ref":"refs/changes/18/25918/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/18/25918/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/18/25918/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/18/25918/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/18/25918/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/18/25918/3"}}},"commit":{"parents":[{"commit":"0ae8a9a7e7b0dce76b3530b99ce881da8285a0ce","subject":"Merge \"Remove print statements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0ae8a9a7e7b0dce76b3530b99ce881da8285a0ce"}]}],"author":{"name":"David Ripton","email":"dripton@redhat.com","date":"2013-04-02 16:19:17.000000000","tz":-240},"committer":{"name":"David Ripton","email":"dripton@redhat.com","date":"2013-04-02 18:51:16.000000000","tz":-240},"subject":"Raise rather than generating millions of IPs.","message":"Raise rather than generating millions of IPs.\n\nFixes bug #1163394\n\nFormerly if we tried to create many millions of floating IPs with a\nrange like \"192.168.2.224/2\", address_to_hosts would happily iterate\nover all of them (which would take a long time) and then nova-manage\nwould eventually crash with an OutOfMemoryError when we tried putting\nall of them in a list.  Or, if the initial list wasn\u0027t quite big\nenough to use all memory, it would blow up later (even more slowly)\nwhen we tried to put them in the database via SQLAlchemy.\n\nNow, raise exception.InvalidInput if the number of IPs is a million\nor more.  (A million is erring on the side of caution.)\n\nChange-Id: Ifc6b6a8faadc2e97e09f9f6c975e52229f705789\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/34de8d1529fb9a2e7fad096a6967b9a483ab0cb0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/34de8d1529fb9a2e7fad096a6967b9a483ab0cb0"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"0ae8a9a7e7b0dce76b3530b99ce881da8285a0ce","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}