)]}'
{"nova/tests/test_powervm.py":[{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"ec6e44e266eb2ca9eb0e058889a6100705b04dc1","unresolved":false,"context_lines":[{"line_number":385,"context_line":"        def fake_set_lpar_mac_base_value(*args, **kwargs):"},{"line_number":386,"context_line":"            mac_base_value \u003d args[1]"},{"line_number":387,"context_line":"            exp_mac \u003d \u0027fab9b80f98\u0027"},{"line_number":388,"context_line":"            self.assertEqual(exp_mac, mac_base_value)"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"        self.stubs.Set(self.powervm_connection._powervm, \u0027migrate_disk\u0027,"},{"line_number":391,"context_line":"                       fake_migrate_disk)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2FsOc%3D","line":388,"updated":"2013-04-02 21:44:16.000000000","message":"if you use the mac_for_instance method then change your assert to make sure is not equal to original since not you can\u0027t predict the mac","commit_id":"c961405d7c0dcbddb20ccf44a4258ff8f6221fea"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3d2998e4d6ad74459f4e09381f6ff550c04d985d","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        self.mox.ReplayAll()"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        self.powervm_connection.finish_revert_migration(inst, network_info,"},{"line_number":321,"context_line":"                                                        [])"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def test_finish_revert_migration_after_crash(self):"},{"line_number":324,"context_line":"        self._test_finish_revert_migration_after_crash(True, True)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOX%2F%2F%2B%2FY%3D","line":321,"updated":"2013-04-03 16:09:52.000000000","message":"Shouldn\u0027t we confirm that the revert reset the mac to the expected value?","commit_id":"5b556d059220e36a783a847c8670f8e84e39bd38"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"abb489a16feb8a05dcc6f72097a5afb62be9abe1","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        self.mox.ReplayAll()"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        self.powervm_connection.finish_revert_migration(inst, network_info,"},{"line_number":321,"context_line":"                                                        [])"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def test_finish_revert_migration_after_crash(self):"},{"line_number":324,"context_line":"        self._test_finish_revert_migration_after_crash(True, True)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOX%2F%2F%2Brs%3D","line":321,"in_reply_to":"AAAAOX%2F%2F%2B%2FY%3D","updated":"2013-04-03 19:03:31.000000000","message":"Done","commit_id":"5b556d059220e36a783a847c8670f8e84e39bd38"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"55e61bcbef9a39864aa235b3ffa1b30e344f44ef","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        self.mox.ReplayAll()"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        self.powervm_connection.finish_revert_migration(inst, network_info,"},{"line_number":321,"context_line":"                                                        [])"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def test_finish_revert_migration_after_crash(self):"},{"line_number":324,"context_line":"        self._test_finish_revert_migration_after_crash(True, True)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOX%2F%2F%2Bvw%3D","line":321,"in_reply_to":"AAAAOX%2F%2F%2B%2FY%3D","updated":"2013-04-03 18:16:08.000000000","message":"Reworking these, thanks for the input","commit_id":"5b556d059220e36a783a847c8670f8e84e39bd38"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3d2998e4d6ad74459f4e09381f6ff550c04d985d","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        def fake_set_lpar_mac_base_value(*args, **kwargs):"},{"line_number":397,"context_line":"            mac_base_value \u003d args[1]"},{"line_number":398,"context_line":"            original_mac \u003d \u0027fa89f08b9b\u0027"},{"line_number":399,"context_line":"            self.assertNotEqual(original_mac, mac_base_value)"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        self.stubs.Set(self.powervm_connection._powervm, \u0027migrate_disk\u0027,"},{"line_number":402,"context_line":"                       fake_migrate_disk)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOX%2F%2F%2B%2FU%3D","line":399,"updated":"2013-04-03 16:09:52.000000000","message":"We know the algorithm it\u0027s going to use, why not check it specifically? I mean, the function could be setting it to \"my-dear-aunt-suzie\" and this would pass the test.","commit_id":"5b556d059220e36a783a847c8670f8e84e39bd38"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"abb489a16feb8a05dcc6f72097a5afb62be9abe1","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        def fake_set_lpar_mac_base_value(*args, **kwargs):"},{"line_number":397,"context_line":"            mac_base_value \u003d args[1]"},{"line_number":398,"context_line":"            original_mac \u003d \u0027fa89f08b9b\u0027"},{"line_number":399,"context_line":"            self.assertNotEqual(original_mac, mac_base_value)"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        self.stubs.Set(self.powervm_connection._powervm, \u0027migrate_disk\u0027,"},{"line_number":402,"context_line":"                       fake_migrate_disk)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOX%2F%2F%2Bus%3D","line":399,"in_reply_to":"AAAAOX%2F%2F%2B%2FU%3D","updated":"2013-04-03 19:03:31.000000000","message":"Done","commit_id":"5b556d059220e36a783a847c8670f8e84e39bd38"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"55e61bcbef9a39864aa235b3ffa1b30e344f44ef","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        def fake_set_lpar_mac_base_value(*args, **kwargs):"},{"line_number":397,"context_line":"            mac_base_value \u003d args[1]"},{"line_number":398,"context_line":"            original_mac \u003d \u0027fa89f08b9b\u0027"},{"line_number":399,"context_line":"            self.assertNotEqual(original_mac, mac_base_value)"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        self.stubs.Set(self.powervm_connection._powervm, \u0027migrate_disk\u0027,"},{"line_number":402,"context_line":"                       fake_migrate_disk)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOX%2F%2F%2Bvs%3D","line":399,"in_reply_to":"AAAAOX%2F%2F%2B%2FU%3D","updated":"2013-04-03 18:16:08.000000000","message":"reworking, thanks for the input.","commit_id":"5b556d059220e36a783a847c8670f8e84e39bd38"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"95926450c85e705d051b7615bb5e53f5c060af0a","unresolved":false,"context_lines":[{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    def _test_finish_revert_migration_after_crash(self, backup_made, new_made):"},{"line_number":296,"context_line":"        inst \u003d {\u0027name\u0027: \u0027foo\u0027}"},{"line_number":297,"context_line":"        network_info \u003d {}"},{"line_number":298,"context_line":"        network_info[0] \u003d {}"},{"line_number":299,"context_line":"        network_info[0][\u0027address\u0027] \u003d \u0027fa:89:f0:8b:9b:39\u0027"},{"line_number":300,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOX%2F%2F%2BmQ%3D","line":297,"updated":"2013-04-03 20:23:09.000000000","message":"is network_info supposed to be a list? the next line indexes like a list.\n\nalso, suggest move network_info definition down to where it\u0027s used.","commit_id":"2fd17b8dca15ee31647eec0d95bfe7812193abf0"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"95926450c85e705d051b7615bb5e53f5c060af0a","unresolved":false,"context_lines":[{"line_number":322,"context_line":"        self.mox.ReplayAll()"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        self.powervm_connection.finish_revert_migration(inst, network_info,"},{"line_number":325,"context_line":"                                                        [])"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    def test_finish_revert_migration_after_crash(self):"},{"line_number":328,"context_line":"        self._test_finish_revert_migration_after_crash(True, True)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOX%2F%2F%2Blk%3D","line":325,"updated":"2013-04-03 20:23:09.000000000","message":"suggest use named actual for named formal, so change [] to block_device_info\u003d[]","commit_id":"2fd17b8dca15ee31647eec0d95bfe7812193abf0"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"95926450c85e705d051b7615bb5e53f5c060af0a","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        context \u003d \u0027fake_context\u0027"},{"line_number":376,"context_line":"        dest \u003d \u002710.8.46.20\u0027  # Some fake dest IP"},{"line_number":377,"context_line":"        instance_type \u003d \u0027fake_instance_type\u0027"},{"line_number":378,"context_line":"        network_info \u003d {}"},{"line_number":379,"context_line":"        network_info[0] \u003d {}"},{"line_number":380,"context_line":"        network_info[0][\u0027address\u0027] \u003d \u0027fa:89:f0:8b:9b:39\u0027"},{"line_number":381,"context_line":"        block_device_info \u003d None"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOX%2F%2F%2Blc%3D","line":378,"updated":"2013-04-03 20:23:09.000000000","message":"is network_info supposed to be a list? the next line indexes like a list.","commit_id":"2fd17b8dca15ee31647eec0d95bfe7812193abf0"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"95926450c85e705d051b7615bb5e53f5c060af0a","unresolved":false,"context_lines":[{"line_number":379,"context_line":"        network_info[0] \u003d {}"},{"line_number":380,"context_line":"        network_info[0][\u0027address\u0027] \u003d \u0027fa:89:f0:8b:9b:39\u0027"},{"line_number":381,"context_line":"        block_device_info \u003d None"},{"line_number":382,"context_line":"        self.flags(powervm_mgr\u003d\u002710.8.46.20\u0027)"},{"line_number":383,"context_line":"        fake_noop \u003d lambda *args, **kwargs: None"},{"line_number":384,"context_line":"        fake_get_ip \u003d lambda *args, **kwargs: \u002710.8.46.20\u0027"},{"line_number":385,"context_line":"        fake_op \u003d self.powervm_connection._powervm._operator"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOX%2F%2F%2Bkk%3D","line":382,"updated":"2013-04-03 20:23:09.000000000","message":"is this dest?","commit_id":"2fd17b8dca15ee31647eec0d95bfe7812193abf0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8125d523dffc9e4fe64a3b53fd16fe00d6db02ee","unresolved":false,"context_lines":[{"line_number":379,"context_line":"        network_info[0] \u003d {}"},{"line_number":380,"context_line":"        network_info[0][\u0027address\u0027] \u003d \u0027fa:89:f0:8b:9b:39\u0027"},{"line_number":381,"context_line":"        block_device_info \u003d None"},{"line_number":382,"context_line":"        self.flags(powervm_mgr\u003d\u002710.8.46.20\u0027)"},{"line_number":383,"context_line":"        fake_noop \u003d lambda *args, **kwargs: None"},{"line_number":384,"context_line":"        fake_get_ip \u003d lambda *args, **kwargs: \u002710.8.46.20\u0027"},{"line_number":385,"context_line":"        fake_op \u003d self.powervm_connection._powervm._operator"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOX%2F%2F%2Biw%3D","line":382,"in_reply_to":"AAAAOX%2F%2F%2Bkk%3D","updated":"2013-04-03 20:30:10.000000000","message":"Yes in this case we are resizing to the same host, so the source is equal to the destination. We can control what the destination passed in is (see line 376). Here were just want to make sure the host we get back is the same, that way we know the logic we are introducing gets tested since this only effects the case where the end user is resizing to the same host and allowing it to happen.","commit_id":"2fd17b8dca15ee31647eec0d95bfe7812193abf0"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"95926450c85e705d051b7615bb5e53f5c060af0a","unresolved":false,"context_lines":[{"line_number":381,"context_line":"        block_device_info \u003d None"},{"line_number":382,"context_line":"        self.flags(powervm_mgr\u003d\u002710.8.46.20\u0027)"},{"line_number":383,"context_line":"        fake_noop \u003d lambda *args, **kwargs: None"},{"line_number":384,"context_line":"        fake_get_ip \u003d lambda *args, **kwargs: \u002710.8.46.20\u0027"},{"line_number":385,"context_line":"        fake_op \u003d self.powervm_connection._powervm._operator"},{"line_number":386,"context_line":"        self.stubs.Set(fake_op, \u0027get_vhost_by_instance_id\u0027, fake_noop)"},{"line_number":387,"context_line":"        self.stubs.Set(fake_op, \u0027get_disk_name_by_vhost\u0027, fake_noop)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOX%2F%2F%2Bko%3D","line":384,"updated":"2013-04-03 20:23:09.000000000","message":"is \u002710.8.46.20\u0027 dest? if so, change to dest.","commit_id":"2fd17b8dca15ee31647eec0d95bfe7812193abf0"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"95926450c85e705d051b7615bb5e53f5c060af0a","unresolved":false,"context_lines":[{"line_number":398,"context_line":"            return disk_info"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        def fake_set_lpar_mac_base_value(*args, **kwargs):"},{"line_number":401,"context_line":"            mac_base_value \u003d args[1]"},{"line_number":402,"context_line":"            exp_mac \u003d \u0027FA98642B29\u0027"},{"line_number":403,"context_line":"            self.assertEqual(exp_mac, mac_base_value)"},{"line_number":404,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOX%2F%2F%2Bks%3D","line":401,"updated":"2013-04-03 20:23:09.000000000","message":"suggest change declaration to have mac_base_value as argument rather than extract it here, so change 400 to \n\n def fake_set_lpar_mac_base_value(arg0, mac_base_value, *args, **kwargs):","commit_id":"2fd17b8dca15ee31647eec0d95bfe7812193abf0"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"95926450c85e705d051b7615bb5e53f5c060af0a","unresolved":false,"context_lines":[{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        def fake_set_lpar_mac_base_value(*args, **kwargs):"},{"line_number":401,"context_line":"            mac_base_value \u003d args[1]"},{"line_number":402,"context_line":"            exp_mac \u003d \u0027FA98642B29\u0027"},{"line_number":403,"context_line":"            self.assertEqual(exp_mac, mac_base_value)"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"        self.stubs.Set(self.powervm_connection._powervm, \u0027migrate_disk\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOX%2F%2F%2BkY%3D","line":402,"updated":"2013-04-03 20:23:09.000000000","message":"should I be able to figure out why this is 29? I couldn\u0027t.","commit_id":"2fd17b8dca15ee31647eec0d95bfe7812193abf0"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"95926450c85e705d051b7615bb5e53f5c060af0a","unresolved":false,"context_lines":[{"line_number":415,"context_line":"        mac_base_value \u003d \u0027fa89f08b9b\u0027"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"        def fake_run_vios_command(*args, **kwargs):"},{"line_number":418,"context_line":"            cmd \u003d args[0]"},{"line_number":419,"context_line":"            exp_cmd \u003d \u0027chsyscfg -r lpar -i \"name\u003dsome_instance, \u0027 \\"},{"line_number":420,"context_line":"                      \u0027virtual_eth_mac_base_value\u003dfa89f08b9b\"\u0027"},{"line_number":421,"context_line":"            assertEqual(exp_cmd, cmd)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOX%2F%2F%2BkA%3D","line":418,"updated":"2013-04-03 20:23:09.000000000","message":"suggest use cmd as first arg.","commit_id":"2fd17b8dca15ee31647eec0d95bfe7812193abf0"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"95926450c85e705d051b7615bb5e53f5c060af0a","unresolved":false,"context_lines":[{"line_number":416,"context_line":""},{"line_number":417,"context_line":"        def fake_run_vios_command(*args, **kwargs):"},{"line_number":418,"context_line":"            cmd \u003d args[0]"},{"line_number":419,"context_line":"            exp_cmd \u003d \u0027chsyscfg -r lpar -i \"name\u003dsome_instance, \u0027 \\"},{"line_number":420,"context_line":"                      \u0027virtual_eth_mac_base_value\u003dfa89f08b9b\"\u0027"},{"line_number":421,"context_line":"            assertEqual(exp_cmd, cmd)"},{"line_number":422,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOX%2F%2F%2BkE%3D","line":419,"updated":"2013-04-03 20:23:09.000000000","message":"use () to continue line rather than \\, see PEP8.","commit_id":"2fd17b8dca15ee31647eec0d95bfe7812193abf0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c21783f57dd76721718b5d86c67647f38396e30e","unresolved":false,"context_lines":[{"line_number":416,"context_line":""},{"line_number":417,"context_line":"        def fake_run_vios_command(*args, **kwargs):"},{"line_number":418,"context_line":"            cmd \u003d args[0]"},{"line_number":419,"context_line":"            exp_cmd \u003d \u0027chsyscfg -r lpar -i \"name\u003dsome_instance, \u0027 \\"},{"line_number":420,"context_line":"                      \u0027virtual_eth_mac_base_value\u003dfa89f08b9b\"\u0027"},{"line_number":421,"context_line":"            assertEqual(exp_cmd, cmd)"},{"line_number":422,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOX%2F%2F%2BdM%3D","line":419,"in_reply_to":"AAAAOX%2F%2F%2BkE%3D","updated":"2013-04-03 21:28:45.000000000","message":"Done","commit_id":"2fd17b8dca15ee31647eec0d95bfe7812193abf0"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"95926450c85e705d051b7615bb5e53f5c060af0a","unresolved":false,"context_lines":[{"line_number":417,"context_line":"        def fake_run_vios_command(*args, **kwargs):"},{"line_number":418,"context_line":"            cmd \u003d args[0]"},{"line_number":419,"context_line":"            exp_cmd \u003d \u0027chsyscfg -r lpar -i \"name\u003dsome_instance, \u0027 \\"},{"line_number":420,"context_line":"                      \u0027virtual_eth_mac_base_value\u003dfa89f08b9b\"\u0027"},{"line_number":421,"context_line":"            assertEqual(exp_cmd, cmd)"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        self.stubs.Set(self.powervm_connection._powervm._operator,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOX%2F%2F%2Bj4%3D","line":420,"updated":"2013-04-03 20:23:09.000000000","message":"suggest sub in mac_base_value and inst_name to this string.","commit_id":"2fd17b8dca15ee31647eec0d95bfe7812193abf0"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"2a8d91792d5d20f5ada0f2790cfb44abb7809b33","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    def rename_lpar(self, old, new):"},{"line_number":105,"context_line":"        pass"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def set_lpar_mac_base_value(self, instance_name, mac_base_value):"},{"line_number":108,"context_line":"        pass"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def get_logical_vol_size(self, diskname):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAOX%2F%2F%2BTg%3D","line":107,"updated":"2013-04-03 23:08:04.000000000","message":"should change this to match set_lpar_mac_base_value in nova/virt/powervm/operator.py, \"mac_base_value\" -\u003e \"mac\"","commit_id":"4d980e367c55f08add8df863d2abe19bd396d3f7"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"a258fa44ec098fc48131b13ae67091356ad98da2","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    def rename_lpar(self, old, new):"},{"line_number":105,"context_line":"        pass"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def set_lpar_mac_base_value(self, instance_name, mac_base_value):"},{"line_number":108,"context_line":"        pass"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def get_logical_vol_size(self, diskname):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAOX%2F%2F%2BSY%3D","line":107,"in_reply_to":"AAAAOX%2F%2F%2BTg%3D","updated":"2013-04-03 23:17:21.000000000","message":"Done","commit_id":"4d980e367c55f08add8df863d2abe19bd396d3f7"}],"nova/virt/powervm/driver.py":[{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"ec6e44e266eb2ca9eb0e058889a6100705b04dc1","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        # another LPAR is booted with the same mac address as the"},{"line_number":247,"context_line":"        # original LPAR"},{"line_number":248,"context_line":"        if (src_host \u003d\u003d dest):"},{"line_number":249,"context_line":"            mac \u003d network_info[0][\u0027address\u0027]"},{"line_number":250,"context_line":"            mac_base_value \u003d mac[:-2].replace(\u0027:\u0027, \u0027\u0027)"},{"line_number":251,"context_line":"            mac_base_value \u003d \u0027fa\u0027 + mac_base_value[-1:1:-1]"},{"line_number":252,"context_line":"            self._powervm._operator.set_lpar_mac_base_value(instance[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2FsP8%3D","line":249,"updated":"2013-04-02 21:44:16.000000000","message":"instead of doing this just call operator macs_for_instance to get a new mac, that function already handles uniqueness","commit_id":"c961405d7c0dcbddb20ccf44a4258ff8f6221fea"},{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"ec6e44e266eb2ca9eb0e058889a6100705b04dc1","unresolved":false,"context_lines":[{"line_number":272,"context_line":"            mac \u003d network_info[0][\u0027address\u0027]"},{"line_number":273,"context_line":"            mac_base_value \u003d mac[:-2].replace(\u0027:\u0027, \u0027\u0027)"},{"line_number":274,"context_line":"            self._powervm._operator.set_lpar_mac_base_value(instance[\u0027name\u0027],"},{"line_number":275,"context_line":"                                                            mac_base_value)"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        # if the current name would overflow with new tag"},{"line_number":278,"context_line":"        if ((len(instance_name) + len(name_tag)) \u003e 31):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2FsPY%3D","line":275,"updated":"2013-04-02 21:44:16.000000000","message":"remove this block from here, looks like a copy paste mistake","commit_id":"c961405d7c0dcbddb20ccf44a4258ff8f6221fea"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"9bfc6cec6de5fbc70b7405bcfac6aa5e2e9e3e22","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        # mac address to the source LPAR so we don\u0027t have a conflict when"},{"line_number":246,"context_line":"        # another LPAR is booted with the same mac address as the"},{"line_number":247,"context_line":"        # original LPAR"},{"line_number":248,"context_line":"        if (src_host \u003d\u003d dest):"},{"line_number":249,"context_line":"            macs \u003d self.macs_for_instance(instance)"},{"line_number":250,"context_line":"            mac \u003d macs.pop()"},{"line_number":251,"context_line":"            mac_base_value \u003d mac[:-2].replace(\u0027:\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOX%2F%2F%2FZs%3D","line":248,"updated":"2013-04-03 13:18:02.000000000","message":"(nit) remove ()s","commit_id":"58b99c1b78ac799fe2bb54866568f9542d6f0325"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"11218f336f0d9a2386676c99e30203b39b1416e3","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        # mac address to the source LPAR so we don\u0027t have a conflict when"},{"line_number":246,"context_line":"        # another LPAR is booted with the same mac address as the"},{"line_number":247,"context_line":"        # original LPAR"},{"line_number":248,"context_line":"        if (src_host \u003d\u003d dest):"},{"line_number":249,"context_line":"            macs \u003d self.macs_for_instance(instance)"},{"line_number":250,"context_line":"            mac \u003d macs.pop()"},{"line_number":251,"context_line":"            mac_base_value \u003d mac[:-2].replace(\u0027:\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOX%2F%2F%2FYI%3D","line":248,"in_reply_to":"AAAAOX%2F%2F%2FZs%3D","updated":"2013-04-03 13:31:55.000000000","message":"Done","commit_id":"58b99c1b78ac799fe2bb54866568f9542d6f0325"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"9bfc6cec6de5fbc70b7405bcfac6aa5e2e9e3e22","unresolved":false,"context_lines":[{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        new_name \u003d self._get_resize_name(instance[\u0027name\u0027])"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        # NOTE(ldbragst) Here we need to check it the migration or resize took"},{"line_number":322,"context_line":"        # place on the same host. If yes, then we need to replace the temp mac"},{"line_number":323,"context_line":"        # we set in migrate_disk_and_power_off() with the mac of the"},{"line_number":324,"context_line":"        # original instance"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOX%2F%2F%2FZg%3D","line":321,"updated":"2013-04-03 13:18:02.000000000","message":"\"check it the\" -\u003e \"check if the\"","commit_id":"58b99c1b78ac799fe2bb54866568f9542d6f0325"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"11218f336f0d9a2386676c99e30203b39b1416e3","unresolved":false,"context_lines":[{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        new_name \u003d self._get_resize_name(instance[\u0027name\u0027])"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        # NOTE(ldbragst) Here we need to check it the migration or resize took"},{"line_number":322,"context_line":"        # place on the same host. If yes, then we need to replace the temp mac"},{"line_number":323,"context_line":"        # we set in migrate_disk_and_power_off() with the mac of the"},{"line_number":324,"context_line":"        # original instance"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOX%2F%2F%2FYE%3D","line":321,"in_reply_to":"AAAAOX%2F%2F%2FZg%3D","updated":"2013-04-03 13:31:55.000000000","message":"Done","commit_id":"58b99c1b78ac799fe2bb54866568f9542d6f0325"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3d2998e4d6ad74459f4e09381f6ff550c04d985d","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            mac \u003d macs.pop()"},{"line_number":251,"context_line":"            mac_base_value \u003d mac[:-2].replace(\u0027:\u0027, \u0027\u0027)"},{"line_number":252,"context_line":"            self._powervm._operator.set_lpar_mac_base_value(instance[\u0027name\u0027],"},{"line_number":253,"context_line":"                                                            mac_base_value)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        disk_info \u003d self._powervm.migrate_disk("},{"line_number":256,"context_line":"                diskname, src_host, dest, CONF.powervm_img_remote_path,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOX%2F%2F%2B%2Fg%3D","line":253,"updated":"2013-04-03 16:09:52.000000000","message":"So, is this actually setting the mac, or setting some power-specific base mac? This is just snipping off the last octet and setting the mac to that, right? Does that have the effect of turning something like 11:22:33:44:55:66 to 11:22:33:44:55:00 or something? It\u0027s a bit confusing as it is, IMHO.","commit_id":"5b556d059220e36a783a847c8670f8e84e39bd38"},{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"6e54e2b43ab0741058ef3a70d9e23f85f643ab31","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            mac \u003d macs.pop()"},{"line_number":251,"context_line":"            mac_base_value \u003d mac[:-2].replace(\u0027:\u0027, \u0027\u0027)"},{"line_number":252,"context_line":"            self._powervm._operator.set_lpar_mac_base_value(instance[\u0027name\u0027],"},{"line_number":253,"context_line":"                                                            mac_base_value)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        disk_info \u003d self._powervm.migrate_disk("},{"line_number":256,"context_line":"                diskname, src_host, dest, CONF.powervm_img_remote_path,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOX%2F%2F%2Bwo%3D","line":253,"in_reply_to":"AAAAOX%2F%2F%2B%2Fg%3D","updated":"2013-04-03 18:09:37.000000000","message":"setting the mac base (mac without last two digits) essentially sets the mac, the other two digits of the mac come from slot it assigned to device","commit_id":"5b556d059220e36a783a847c8670f8e84e39bd38"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5c9fa5e89890aeaa2ec941a3ab69f888310cc058","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            mac \u003d macs.pop()"},{"line_number":251,"context_line":"            mac_base_value \u003d mac[:-2].replace(\u0027:\u0027, \u0027\u0027)"},{"line_number":252,"context_line":"            self._powervm._operator.set_lpar_mac_base_value(instance[\u0027name\u0027],"},{"line_number":253,"context_line":"                                                            mac_base_value)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        disk_info \u003d self._powervm.migrate_disk("},{"line_number":256,"context_line":"                diskname, src_host, dest, CONF.powervm_img_remote_path,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOX%2F%2F9To%3D","line":253,"in_reply_to":"AAAAOX%2F%2F%2BwE%3D","updated":"2013-04-04 16:03:19.000000000","message":"Oh, I missed that \"macs_for_instance()\" is really \"generate_random_macs_for this_instance()\". That\u0027s a really poorly-named function, IMHO :(\n\nI thought that it returned the macs assigned to the instance, so the code here seemed like a no-op. Makes sense now.","commit_id":"5b556d059220e36a783a847c8670f8e84e39bd38"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"55e61bcbef9a39864aa235b3ffa1b30e344f44ef","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            mac \u003d macs.pop()"},{"line_number":251,"context_line":"            mac_base_value \u003d mac[:-2].replace(\u0027:\u0027, \u0027\u0027)"},{"line_number":252,"context_line":"            self._powervm._operator.set_lpar_mac_base_value(instance[\u0027name\u0027],"},{"line_number":253,"context_line":"                                                            mac_base_value)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        disk_info \u003d self._powervm.migrate_disk("},{"line_number":256,"context_line":"                diskname, src_host, dest, CONF.powervm_img_remote_path,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOX%2F%2F%2BwE%3D","line":253,"in_reply_to":"AAAAOX%2F%2F%2Bwo%3D","updated":"2013-04-03 18:16:08.000000000","message":"The format of virtual_eth_mac_base_value in the VIOS for an LPAR is \u0027virtual_eth_mac_base_value\u003dFA92B24689\u0027 for example. What this does here is it grabs a new mac address, removes the \u0027:\u0027 for formatting purposes when running the vios command, and removes the last two characters, making it virtual_eth_mac_base_value format for the VIOS. \nSo an example would be, \nmac \u003d \u0027FA:98:64:2B:29:40\u0027 which would get turned into\nmac_base_value \u003d \u0027fa98642B29\u0027 and would be correctly formatted for the VIOS.\n\nTo answer your first question, it is setting a power-specific base mac address on the VIOS. Hope this helps clean up some of the confusion.","commit_id":"5b556d059220e36a783a847c8670f8e84e39bd38"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3d2998e4d6ad74459f4e09381f6ff550c04d985d","unresolved":false,"context_lines":[{"line_number":327,"context_line":"            mac \u003d network_info[0][\u0027address\u0027]"},{"line_number":328,"context_line":"            mac_base_value \u003d mac[:-2].replace(\u0027:\u0027, \u0027\u0027)"},{"line_number":329,"context_line":"            self._powervm._operator.set_lpar_mac_base_value(instance[\u0027name\u0027],"},{"line_number":330,"context_line":"                                                            mac_base_value)"},{"line_number":331,"context_line":"        # Make sure we don\u0027t have a failed same-host migration still"},{"line_number":332,"context_line":"        # hanging around"},{"line_number":333,"context_line":"        if self.instance_exists(new_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOX%2F%2F%2B%2BQ%3D","line":330,"updated":"2013-04-03 16:09:52.000000000","message":"isn\u0027t this the same operation as the migrate_disk_and_power_off() case is doing? I\u0027m confused.","commit_id":"5b556d059220e36a783a847c8670f8e84e39bd38"},{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"6e54e2b43ab0741058ef3a70d9e23f85f643ab31","unresolved":false,"context_lines":[{"line_number":327,"context_line":"            mac \u003d network_info[0][\u0027address\u0027]"},{"line_number":328,"context_line":"            mac_base_value \u003d mac[:-2].replace(\u0027:\u0027, \u0027\u0027)"},{"line_number":329,"context_line":"            self._powervm._operator.set_lpar_mac_base_value(instance[\u0027name\u0027],"},{"line_number":330,"context_line":"                                                            mac_base_value)"},{"line_number":331,"context_line":"        # Make sure we don\u0027t have a failed same-host migration still"},{"line_number":332,"context_line":"        # hanging around"},{"line_number":333,"context_line":"        if self.instance_exists(new_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOX%2F%2F%2Bwk%3D","line":330,"in_reply_to":"AAAAOX%2F%2F%2B%2BQ%3D","updated":"2013-04-03 18:09:37.000000000","message":"What I read is that is now setting the original in network_info, in migrate_disk_and_power_off it sets to new mac","commit_id":"5b556d059220e36a783a847c8670f8e84e39bd38"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"55e61bcbef9a39864aa235b3ffa1b30e344f44ef","unresolved":false,"context_lines":[{"line_number":327,"context_line":"            mac \u003d network_info[0][\u0027address\u0027]"},{"line_number":328,"context_line":"            mac_base_value \u003d mac[:-2].replace(\u0027:\u0027, \u0027\u0027)"},{"line_number":329,"context_line":"            self._powervm._operator.set_lpar_mac_base_value(instance[\u0027name\u0027],"},{"line_number":330,"context_line":"                                                            mac_base_value)"},{"line_number":331,"context_line":"        # Make sure we don\u0027t have a failed same-host migration still"},{"line_number":332,"context_line":"        # hanging around"},{"line_number":333,"context_line":"        if self.instance_exists(new_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOX%2F%2F%2Bv8%3D","line":330,"in_reply_to":"AAAAOX%2F%2F%2Bwk%3D","updated":"2013-04-03 18:16:08.000000000","message":"So what we are doing in migrate_disk_and_power_off is setting a \u0027temp\u0027 mac address to the original LPAR so that we avoid any conflicts in the case the resized LPAR is launched on the same VIOS, in which case you can\u0027t have two machines with the same mac address. Which is fine and dandy if the resize is confirmed since the original LPAR is deleted and the mac address of the original is launched with the resized LPAR. In the case of a revert, we need to grab the original mac that is stored in network_info[0][\u0027address\u0027] and replace the temp mac address. This will ensure the correct mac gets reassigned to the instance that is kept in the case of a revert. Does that help?","commit_id":"5b556d059220e36a783a847c8670f8e84e39bd38"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"95926450c85e705d051b7615bb5e53f5c060af0a","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        # original LPAR"},{"line_number":248,"context_line":"        if src_host \u003d\u003d dest:"},{"line_number":249,"context_line":"            macs \u003d self.macs_for_instance(instance)"},{"line_number":250,"context_line":"            mac \u003d macs.pop()"},{"line_number":251,"context_line":"            mac_base_value \u003d mac[:-2].replace(\u0027:\u0027, \u0027\u0027)"},{"line_number":252,"context_line":"            self._powervm._operator.set_lpar_mac_base_value(instance[\u0027name\u0027],"},{"line_number":253,"context_line":"                                                            mac_base_value)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOX%2F%2F%2BjQ%3D","line":250,"updated":"2013-04-03 20:23:09.000000000","message":"suggest call this temporary_mac","commit_id":"2fd17b8dca15ee31647eec0d95bfe7812193abf0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"36433aee668711e117edc8f2e7ed9ae296d431b1","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        # original LPAR"},{"line_number":248,"context_line":"        if src_host \u003d\u003d dest:"},{"line_number":249,"context_line":"            macs \u003d self.macs_for_instance(instance)"},{"line_number":250,"context_line":"            mac \u003d macs.pop()"},{"line_number":251,"context_line":"            mac_base_value \u003d mac[:-2].replace(\u0027:\u0027, \u0027\u0027)"},{"line_number":252,"context_line":"            self._powervm._operator.set_lpar_mac_base_value(instance[\u0027name\u0027],"},{"line_number":253,"context_line":"                                                            mac_base_value)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOX%2F%2F%2BgM%3D","line":250,"in_reply_to":"AAAAOX%2F%2F%2BjQ%3D","updated":"2013-04-03 20:56:25.000000000","message":"Done","commit_id":"2fd17b8dca15ee31647eec0d95bfe7812193abf0"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"95926450c85e705d051b7615bb5e53f5c060af0a","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            mac \u003d macs.pop()"},{"line_number":251,"context_line":"            mac_base_value \u003d mac[:-2].replace(\u0027:\u0027, \u0027\u0027)"},{"line_number":252,"context_line":"            self._powervm._operator.set_lpar_mac_base_value(instance[\u0027name\u0027],"},{"line_number":253,"context_line":"                                                            mac_base_value)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        disk_info \u003d self._powervm.migrate_disk("},{"line_number":256,"context_line":"                diskname, src_host, dest, CONF.powervm_img_remote_path,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOX%2F%2F%2Bjk%3D","line":253,"updated":"2013-04-03 20:23:09.000000000","message":"suggest have set_lpar_mac_base_value do the mac[:-2].replace(\u0027:\u0027, \u0027\u0027), since that\u0027s done in both places it\u0027s called (see line 329, too).","commit_id":"2fd17b8dca15ee31647eec0d95bfe7812193abf0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"36433aee668711e117edc8f2e7ed9ae296d431b1","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            mac \u003d macs.pop()"},{"line_number":251,"context_line":"            mac_base_value \u003d mac[:-2].replace(\u0027:\u0027, \u0027\u0027)"},{"line_number":252,"context_line":"            self._powervm._operator.set_lpar_mac_base_value(instance[\u0027name\u0027],"},{"line_number":253,"context_line":"                                                            mac_base_value)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        disk_info \u003d self._powervm.migrate_disk("},{"line_number":256,"context_line":"                diskname, src_host, dest, CONF.powervm_img_remote_path,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOX%2F%2F%2BgI%3D","line":253,"in_reply_to":"AAAAOX%2F%2F%2Bjk%3D","updated":"2013-04-03 20:56:25.000000000","message":"Done","commit_id":"2fd17b8dca15ee31647eec0d95bfe7812193abf0"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"95926450c85e705d051b7615bb5e53f5c060af0a","unresolved":false,"context_lines":[{"line_number":323,"context_line":"        # on the old instance that will be started"},{"line_number":324,"context_line":"        if (self._powervm.instance_exists(new_name) and"},{"line_number":325,"context_line":"                self._powervm.instance_exists(instance[\u0027name\u0027])):"},{"line_number":326,"context_line":"            mac \u003d network_info[0][\u0027address\u0027]"},{"line_number":327,"context_line":"            # NOTE(ldbragst) We only use the base mac value because the last"},{"line_number":328,"context_line":"            # byte is the slot id of the virtual NIC, which doesn\u0027t change."},{"line_number":329,"context_line":"            mac_base_value \u003d mac[:-2].replace(\u0027:\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOX%2F%2F%2Bjc%3D","line":326,"updated":"2013-04-03 20:23:09.000000000","message":"suggest call this original_mac.","commit_id":"2fd17b8dca15ee31647eec0d95bfe7812193abf0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"36433aee668711e117edc8f2e7ed9ae296d431b1","unresolved":false,"context_lines":[{"line_number":323,"context_line":"        # on the old instance that will be started"},{"line_number":324,"context_line":"        if (self._powervm.instance_exists(new_name) and"},{"line_number":325,"context_line":"                self._powervm.instance_exists(instance[\u0027name\u0027])):"},{"line_number":326,"context_line":"            mac \u003d network_info[0][\u0027address\u0027]"},{"line_number":327,"context_line":"            # NOTE(ldbragst) We only use the base mac value because the last"},{"line_number":328,"context_line":"            # byte is the slot id of the virtual NIC, which doesn\u0027t change."},{"line_number":329,"context_line":"            mac_base_value \u003d mac[:-2].replace(\u0027:\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOX%2F%2F%2BgQ%3D","line":326,"in_reply_to":"AAAAOX%2F%2F%2Bjc%3D","updated":"2013-04-03 20:56:25.000000000","message":"Done","commit_id":"2fd17b8dca15ee31647eec0d95bfe7812193abf0"}],"nova/virt/powervm/operator.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2e7a8938b88694d7d0e85d7e3601e7bae7631a4b","unresolved":false,"context_lines":[{"line_number":771,"context_line":"                        \u0027\"name\u003d%s,\u0027 % instance_name,"},{"line_number":772,"context_line":"                        \u0027virtual_eth_mac_base_value\u003d%s\"\u0027 % mac_base_value])"},{"line_number":773,"context_line":"        self.run_vios_command(cmd)"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"class IVMOperator(BaseOperator):"},{"line_number":777,"context_line":"    \"\"\"Integrated Virtualization Manager (IVM) Operator."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOX%2F%2F%2FTc%3D","line":774,"updated":"2013-04-03 14:11:33.000000000","message":"Please add a test for this new function.","commit_id":"92d51f35043d6aca6cbc38033e9cfdd3e24ae5f6"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"47bb35d5a291d75b6343a97bc213bba86b414e3e","unresolved":false,"context_lines":[{"line_number":771,"context_line":"                        \u0027\"name\u003d%s,\u0027 % instance_name,"},{"line_number":772,"context_line":"                        \u0027virtual_eth_mac_base_value\u003d%s\"\u0027 % mac_base_value])"},{"line_number":773,"context_line":"        self.run_vios_command(cmd)"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"class IVMOperator(BaseOperator):"},{"line_number":777,"context_line":"    \"\"\"Integrated Virtualization Manager (IVM) Operator."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOX%2F%2F%2FPY%3D","line":774,"in_reply_to":"AAAAOX%2F%2F%2FTc%3D","updated":"2013-04-03 14:35:24.000000000","message":"Done","commit_id":"92d51f35043d6aca6cbc38033e9cfdd3e24ae5f6"}]}