)]}'
{"nova/compute/resource_tracker.py":[{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"f480db914923f846bc43445ce6b7d30a7883ef26","unresolved":false,"context_lines":[{"line_number":459,"context_line":""},{"line_number":460,"context_line":"        for migration in filtered.values():"},{"line_number":461,"context_line":"            try:"},{"line_number":462,"context_line":"                instance \u003d migration[\u0027instance\u0027]"},{"line_number":463,"context_line":"                self._update_usage_from_migration(instance, resources,"},{"line_number":464,"context_line":"                                                  migration)"},{"line_number":465,"context_line":"            except exception.InstanceTypeNotFound:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2FsD4%3D","line":462,"updated":"2013-04-02 23:39:30.000000000","message":"I\u0027d have a slight preference for this being outside of the try/except, with the idea of keeping that as small as possible.\n\nIn this case, it wouldn\u0027t be a problem, but as a best-practice, that would help avoid accidentally swallowing of errors.","commit_id":"fb4c7c7ee301fabe477271894d0da1c4ea5592b1"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"b8540e695f6e572b68ab29555057648b9ad83348","unresolved":false,"context_lines":[{"line_number":459,"context_line":""},{"line_number":460,"context_line":"        for migration in filtered.values():"},{"line_number":461,"context_line":"            try:"},{"line_number":462,"context_line":"                instance \u003d migration[\u0027instance\u0027]"},{"line_number":463,"context_line":"                self._update_usage_from_migration(instance, resources,"},{"line_number":464,"context_line":"                                                  migration)"},{"line_number":465,"context_line":"            except exception.InstanceTypeNotFound:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2Fr%2Fg%3D","line":462,"in_reply_to":"AAAAOH%2F%2FsD4%3D","updated":"2013-04-03 00:48:00.000000000","message":"Good point, I typically push for the same thing.","commit_id":"fb4c7c7ee301fabe477271894d0da1c4ea5592b1"}]}