)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4419,"name":"Matthew Sherborne","email":"msherborne+openstack@gmail.com","username":"msherborne+openstack"},"change_message_id":"8d70f223c3c82187edc9db656bfa097cca67fb6c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"xenapi: Always set other_config for VDIs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The existing code only set other_config on a VDI when it was created"},{"line_number":10,"context_line":"using `create_vdi`. This patch updates the code so that `other_config`"},{"line_number":11,"context_line":"is also set when a VDI is created from a dom0 plugin or during a"},{"line_number":12,"context_line":"migration."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAOn%2F%2F984%3D","line":9,"updated":"2013-04-09 20:14:52.000000000","message":"quotes for `other_config` would be nice","commit_id":"19f64113d037389c0de279c999bbaa4f5921e25c"}],"nova/tests/xenapi/test_vm_utils.py":[{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"1361fe7d88e32de114292bcaa6a3f291e51ca037","unresolved":false,"context_lines":[{"line_number":308,"context_line":"    def test_create_vdi(self):"},{"line_number":309,"context_line":"        \"\"\"Some images are registered with XenServer explicitly by calling"},{"line_number":310,"context_line":"        `create_vdi`."},{"line_number":311,"context_line":"        \"\"\""},{"line_number":312,"context_line":"        vm_utils.create_vdi(self.session, \u0027sr_ref\u0027, self.fake_instance,"},{"line_number":313,"context_line":"                            \u0027myvdi\u0027, \u0027root\u0027, 1024, read_only\u003dTrue)"},{"line_number":314,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOX%2F%2F6kU%3D","line":311,"updated":"2013-04-07 00:53:25.000000000","message":"Please no doc comments for tests. It masks the name of the failing test in reports. Instead these should be comments.","commit_id":"19f64113d037389c0de279c999bbaa4f5921e25c"},{"author":{"_account_id":4419,"name":"Matthew Sherborne","email":"msherborne+openstack@gmail.com","username":"msherborne+openstack"},"change_message_id":"8d70f223c3c82187edc9db656bfa097cca67fb6c","unresolved":false,"context_lines":[{"line_number":308,"context_line":"    def test_create_vdi(self):"},{"line_number":309,"context_line":"        \"\"\"Some images are registered with XenServer explicitly by calling"},{"line_number":310,"context_line":"        `create_vdi`."},{"line_number":311,"context_line":"        \"\"\""},{"line_number":312,"context_line":"        vm_utils.create_vdi(self.session, \u0027sr_ref\u0027, self.fake_instance,"},{"line_number":313,"context_line":"                            \u0027myvdi\u0027, \u0027root\u0027, 1024, read_only\u003dTrue)"},{"line_number":314,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2F98o%3D","line":311,"in_reply_to":"AAAAOX%2F%2F5kQ%3D","updated":"2013-04-09 20:14:52.000000000","message":"+1 for Rick\u0027s comment.\n\nBut might be a good idea just to play ball for now to get the review in..","commit_id":"19f64113d037389c0de279c999bbaa4f5921e25c"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"81232051739286cc89c78c35648063d9767326aa","unresolved":false,"context_lines":[{"line_number":308,"context_line":"    def test_create_vdi(self):"},{"line_number":309,"context_line":"        \"\"\"Some images are registered with XenServer explicitly by calling"},{"line_number":310,"context_line":"        `create_vdi`."},{"line_number":311,"context_line":"        \"\"\""},{"line_number":312,"context_line":"        vm_utils.create_vdi(self.session, \u0027sr_ref\u0027, self.fake_instance,"},{"line_number":313,"context_line":"                            \u0027myvdi\u0027, \u0027root\u0027, 1024, read_only\u003dTrue)"},{"line_number":314,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOX%2F%2F5kQ%3D","line":311,"in_reply_to":"AAAAOX%2F%2F6kU%3D","updated":"2013-04-08 16:06:15.000000000","message":"Shouldn\u0027t we fix the tool instead of trying to hack around it?\n\nI know we modify test output quite heavily; if docstrings are muddying up results, we should be able to add a --no-docstring flag easily.\n\nTo me, that\u0027d be preferable to switching all test docstrings to comments, which a) seems like a hack and b) is a poor hack at that since docstrings and comments aren\u0027t semantically interchangeable: one describes whole-functions, the other annotates a set of lines.","commit_id":"19f64113d037389c0de279c999bbaa4f5921e25c"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"da62e313c7db2cf8bd1c17a130f1e78731982a96","unresolved":false,"context_lines":[{"line_number":308,"context_line":"    def test_create_vdi(self):"},{"line_number":309,"context_line":"        \"\"\"Some images are registered with XenServer explicitly by calling"},{"line_number":310,"context_line":"        `create_vdi`."},{"line_number":311,"context_line":"        \"\"\""},{"line_number":312,"context_line":"        vm_utils.create_vdi(self.session, \u0027sr_ref\u0027, self.fake_instance,"},{"line_number":313,"context_line":"                            \u0027myvdi\u0027, \u0027root\u0027, 1024, read_only\u003dTrue)"},{"line_number":314,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2F620%3D","line":311,"in_reply_to":"AAAAOX%2F%2F6kU%3D","updated":"2013-04-11 15:58:17.000000000","message":"Which reports are having issues?  I just tried artificially failing this test with run_tests.sh and tox and the docstring was not visible in either.","commit_id":"19f64113d037389c0de279c999bbaa4f5921e25c"}],"nova/virt/xenapi/vm_utils.py":[{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"3579fc46bca7c0d7cae1d319544788880403c060","unresolved":false,"context_lines":[{"line_number":595,"context_line":"    \"\"\"Return metadata to store in VDI\u0027s other_config attribute."},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"    `nova_instance_uuid` is used to associate a VDI with a particular instance"},{"line_number":598,"context_line":"    so that, if it becomes orpahned from an unclean shutdown of a"},{"line_number":599,"context_line":"    compute-worker, we can safely detach it."},{"line_number":600,"context_line":"    \"\"\""},{"line_number":601,"context_line":"    other_config \u003d {\u0027nova_disk_type\u0027: disk_type}"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOX%2F%2F%2FAw%3D","line":598,"updated":"2013-04-03 15:58:47.000000000","message":"orphaned","commit_id":"9f53a98087221daa0813fb1698b11e22d8735982"}],"tools/xenserver/populate_other_config.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"a5ac864b816295f5ee6d52d12c94cfa492d83cc6","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Run on compute-worker (not Dom0):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    python ./tools/xenserver/populate_other_config.py [--dry-run|--verbose]"},{"line_number":32,"context_line":"\"\"\""},{"line_number":33,"context_line":"import gettext"},{"line_number":34,"context_line":"gettext.install(\u0027nova\u0027, unicode\u003d1)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOX%2F%2F8nQ%3D","line":31,"updated":"2013-04-04 21:14:44.000000000","message":"--verbose isn\u0027t setup in cli_opts.","commit_id":"115d1037ba4f4031a0be92241d8d9455139cb8dd"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"79142f03cd4dffdc5c5dc740cd929de668c76e9a","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Run on compute-worker (not Dom0):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    python ./tools/xenserver/populate_other_config.py [--dry-run|--verbose]"},{"line_number":32,"context_line":"\"\"\""},{"line_number":33,"context_line":"import gettext"},{"line_number":34,"context_line":"gettext.install(\u0027nova\u0027, unicode\u003d1)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOX%2F%2F8PQ%3D","line":31,"in_reply_to":"AAAAOX%2F%2F8gY%3D","updated":"2013-04-05 00:48:45.000000000","message":"Interesting.  I always thought options had to be declared or brought in somehow, but haven\u0027t dug into it.  Good to know.","commit_id":"115d1037ba4f4031a0be92241d8d9455139cb8dd"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"93978aeeb2320dff44e5539f17642f067db6a07c","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Run on compute-worker (not Dom0):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    python ./tools/xenserver/populate_other_config.py [--dry-run|--verbose]"},{"line_number":32,"context_line":"\"\"\""},{"line_number":33,"context_line":"import gettext"},{"line_number":34,"context_line":"gettext.install(\u0027nova\u0027, unicode\u003d1)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOX%2F%2F8gY%3D","line":31,"in_reply_to":"AAAAOX%2F%2F8nQ%3D","updated":"2013-04-04 21:43:29.000000000","message":"It\u0027s included w/ default options, so no need to redefine.","commit_id":"115d1037ba4f4031a0be92241d8d9455139cb8dd"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"a5ac864b816295f5ee6d52d12c94cfa492d83cc6","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        # Parse out UUID"},{"line_number":82,"context_line":"        instance_uuid \u003d name_label.replace(\u0027instance-\u0027, \u0027\u0027)[:36]"},{"line_number":83,"context_line":"        if len(instance_uuid) !\u003d 36:"},{"line_number":84,"context_line":"            print \"error: name label \u0027%s\u0027 wasn\u0027t UUID-like\" % name_label"},{"line_number":85,"context_line":"            continue"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOX%2F%2F8nk%3D","line":83,"updated":"2013-04-04 21:14:44.000000000","message":"openstack/common/uuidutils.is_uuid_like() is a slightly better check.","commit_id":"115d1037ba4f4031a0be92241d8d9455139cb8dd"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"93978aeeb2320dff44e5539f17642f067db6a07c","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        # Parse out UUID"},{"line_number":82,"context_line":"        instance_uuid \u003d name_label.replace(\u0027instance-\u0027, \u0027\u0027)[:36]"},{"line_number":83,"context_line":"        if len(instance_uuid) !\u003d 36:"},{"line_number":84,"context_line":"            print \"error: name label \u0027%s\u0027 wasn\u0027t UUID-like\" % name_label"},{"line_number":85,"context_line":"            continue"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOX%2F%2F8f4%3D","line":83,"in_reply_to":"AAAAOX%2F%2F8nk%3D","updated":"2013-04-04 21:43:29.000000000","message":"Good call.","commit_id":"115d1037ba4f4031a0be92241d8d9455139cb8dd"}]}