)]}'
{"nova/tests/unit/test_signature_utils.py":[{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"cf245396f6068796d2aed9bbf4d298e92d4bc846","unresolved":false,"context_lines":[{"line_number":276,"context_line":"                               signature_utils.get_hash_method, \u0027SHA-2\u0027)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    def test_signature_key_type_lookup(self):"},{"line_number":279,"context_line":"        for sig_format in [\u0027RSA-PSS\u0027, \u0027DSA\u0027]:"},{"line_number":280,"context_line":"            sig_key_type \u003d signature_utils.SignatureKeyType.lookup(sig_format)"},{"line_number":281,"context_line":"            self.assertIsInstance(sig_key_type,"},{"line_number":282,"context_line":"                                  signature_utils.SignatureKeyType)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_1d9b31cb","line":279,"updated":"2015-12-22 20:36:03.000000000","message":"Instead of hard-coding \u0027RSA-PSS\u0027 and \u0027DSA\u0027, could we instead use signature_utils.RSA_PSS and signature_utils.DSA ?","commit_id":"7bba58d0ad86e4c66b96eb08402c44c3678ec83b"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"6a8f29bd4c7d7421e97fb6bcee4b790e74afde9e","unresolved":false,"context_lines":[{"line_number":276,"context_line":"                               signature_utils.get_hash_method, \u0027SHA-2\u0027)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    def test_signature_key_type_lookup(self):"},{"line_number":279,"context_line":"        for sig_format in [\u0027RSA-PSS\u0027, \u0027DSA\u0027]:"},{"line_number":280,"context_line":"            sig_key_type \u003d signature_utils.SignatureKeyType.lookup(sig_format)"},{"line_number":281,"context_line":"            self.assertIsInstance(sig_key_type,"},{"line_number":282,"context_line":"                                  signature_utils.SignatureKeyType)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_eb25325c","line":279,"in_reply_to":"1a7b0d38_1d9b31cb","updated":"2015-12-23 07:11:28.000000000","message":"\u0027RSA-PSS\u0027 and \u0027DSA\u0027 is hard-coded in a number of tests already - e.g. test_get_public_key_rsa()\n\nIt\u0027d be best to change them all together","commit_id":"7bba58d0ad86e4c66b96eb08402c44c3678ec83b"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"e12d4eb4f7159c2d647240349beba7328f7ea7ab","unresolved":false,"context_lines":[{"line_number":276,"context_line":"                               signature_utils.get_hash_method, \u0027SHA-2\u0027)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    def test_signature_key_type_lookup(self):"},{"line_number":279,"context_line":"        for sig_format in [\u0027RSA-PSS\u0027, \u0027DSA\u0027]:"},{"line_number":280,"context_line":"            sig_key_type \u003d signature_utils.SignatureKeyType.lookup(sig_format)"},{"line_number":281,"context_line":"            self.assertIsInstance(sig_key_type,"},{"line_number":282,"context_line":"                                  signature_utils.SignatureKeyType)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_81553751","line":279,"in_reply_to":"1a7b0d38_eb25325c","updated":"2015-12-24 15:33:24.000000000","message":"I\u0027ll fix this issue in my patch, since that patch is essentially a style update. Since this patch is a bug fix, let\u0027s just focus on getting the fix merged.","commit_id":"7bba58d0ad86e4c66b96eb08402c44c3678ec83b"}]}