)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4a4dc927ffbca4b0e940139cfbd610d7467b82db","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zte-hanrong \u003chan.rong3@zte.com.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-23 10:24:14 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Parameter instance of function get_vnc_connect_info need a objects.instance type, but when cell enviroment, this parameter is a db.model.instance type. So, we need to convert this db.model.instance type object to objects.instance type object when isinstance(instance, objects.Instance) is not True."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ie81975b0a97e8ee98f48bbcf2aadc364fd1530b5"},{"line_number":10,"context_line":"Closes-Bug: #1527108"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a7b0d38_9c463abe","line":7,"updated":"2015-12-23 02:59:36.000000000","message":"The summary line in the commit message is too long, see:\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages\n\nYou want a short summary line followed by a body that describes the bug and the fix.","commit_id":"68000e772c141b6447e952e7d56de913dc6f7b59"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"90907b5283a8986d29a5d5d26b1f1108b8c37e5f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ie81975b0a97e8ee98f48bbcf2aadc364fd1530b5"},{"line_number":10,"context_line":"Closes-Bug: #1527108"},{"line_number":11,"context_line":"Related-Bug: #1527108"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a7b0d38_7c4eeec2","line":11,"updated":"2015-12-23 03:00:14.000000000","message":"This is the same bug, you just need the Closes-Bug line.","commit_id":"68000e772c141b6447e952e7d56de913dc6f7b59"}],"nova/compute/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"62a0d7ee53ed2619eee3631ee9bb2e28bae8d3a0","unresolved":false,"context_lines":[{"line_number":2896,"context_line":"    @check_instance_host"},{"line_number":2897,"context_line":"    def get_vnc_connect_info(self, context, instance, console_type):"},{"line_number":2898,"context_line":"        \"\"\"Used in a child cell to get console info.\"\"\""},{"line_number":2899,"context_line":"        if not isinstance(instance, objects.Instance):"},{"line_number":2900,"context_line":"            instance_object \u003d instance_obj.Instance()"},{"line_number":2901,"context_line":"            instance_object \u003d instance_object.get_by_uuid(context,"},{"line_number":2902,"context_line":"                                                          instance.uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_1c17aa52","line":2899,"updated":"2015-12-23 03:16:19.000000000","message":"I sort of feel like we should be doing this in the cells API, the compute API is at a version now where I don\u0027t think we\u0027d get a dict for the instance, but it\u0027s not clear to me exactly how this should be handled in the cells API, or where the dict is coming from in that case.","commit_id":"68000e772c141b6447e952e7d56de913dc6f7b59"},{"author":{"_account_id":12813,"name":"Rong Han","email":"han.rong3@zte.com.cn","username":"hanrong-zte"},"change_message_id":"1b2777ea7414c9044abb95abf5420402b0a7c74d","unresolved":false,"context_lines":[{"line_number":2896,"context_line":"    @check_instance_host"},{"line_number":2897,"context_line":"    def get_vnc_connect_info(self, context, instance, console_type):"},{"line_number":2898,"context_line":"        \"\"\"Used in a child cell to get console info.\"\"\""},{"line_number":2899,"context_line":"        if not isinstance(instance, objects.Instance):"},{"line_number":2900,"context_line":"            instance_object \u003d instance_obj.Instance()"},{"line_number":2901,"context_line":"            instance_object \u003d instance_object.get_by_uuid(context,"},{"line_number":2902,"context_line":"                                                          instance.uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_cf085830","line":2899,"in_reply_to":"1a7b0d38_1c17aa52","updated":"2015-12-24 07:15:28.000000000","message":"That\u0027s basically what the above comment says. It is not changes code in kilo. Is it necessary to commit it into Kilo?","commit_id":"68000e772c141b6447e952e7d56de913dc6f7b59"},{"author":{"_account_id":17532,"name":"Tina Kevin","email":"song.ruixia@zte.com.cn","username":"SongRuixia"},"change_message_id":"66bc59eeb3badd61c319782e575bc474926dc2d6","unresolved":false,"context_lines":[{"line_number":2896,"context_line":"    @check_instance_host"},{"line_number":2897,"context_line":"    def get_vnc_connect_info(self, context, instance, console_type):"},{"line_number":2898,"context_line":"        \"\"\"Used in a child cell to get console info.\"\"\""},{"line_number":2899,"context_line":"        if not isinstance(instance, objects.Instance):"},{"line_number":2900,"context_line":"            instance_object \u003d instance_obj.Instance()"},{"line_number":2901,"context_line":"            instance_object \u003d instance_object.get_by_uuid(context,"},{"line_number":2902,"context_line":"                                                          instance.uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_4ff22871","line":2899,"in_reply_to":"1a7b0d38_1c17aa52","updated":"2015-12-24 07:08:01.000000000","message":"The new master branch has changes code in cells/messaging.py, it get instance object by object.Instance, not db.models.Instance .\nBut it is not changes code in kilo. Is it necessary to commit it into Kilo?","commit_id":"68000e772c141b6447e952e7d56de913dc6f7b59"},{"author":{"_account_id":12813,"name":"Rong Han","email":"han.rong3@zte.com.cn","username":"hanrong-zte"},"change_message_id":"407d477cafd3fadda798844eb4ed417a95947fa3","unresolved":false,"context_lines":[{"line_number":2896,"context_line":"    @check_instance_host"},{"line_number":2897,"context_line":"    def get_vnc_connect_info(self, context, instance, console_type):"},{"line_number":2898,"context_line":"        \"\"\"Used in a child cell to get console info.\"\"\""},{"line_number":2899,"context_line":"        if not isinstance(instance, objects.Instance):"},{"line_number":2900,"context_line":"            instance_object \u003d instance_obj.Instance()"},{"line_number":2901,"context_line":"            instance_object \u003d instance_object.get_by_uuid(context,"},{"line_number":2902,"context_line":"                                                          instance.uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_ef3bd4e9","line":2899,"in_reply_to":"1a7b0d38_4ff22871","updated":"2015-12-24 07:13:29.000000000","message":"That\u0027s basically what the above comment says. It is not changes code in kilo. Is it necessary to commit it into Kilo?","commit_id":"68000e772c141b6447e952e7d56de913dc6f7b59"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4a4dc927ffbca4b0e940139cfbd610d7467b82db","unresolved":false,"context_lines":[{"line_number":2898,"context_line":"        \"\"\"Used in a child cell to get console info.\"\"\""},{"line_number":2899,"context_line":"        if not isinstance(instance, objects.Instance):"},{"line_number":2900,"context_line":"            instance_object \u003d instance_obj.Instance()"},{"line_number":2901,"context_line":"            instance_object \u003d instance_object.get_by_uuid(context,"},{"line_number":2902,"context_line":"                                                          instance.uuid)"},{"line_number":2903,"context_line":"        else:"},{"line_number":2904,"context_line":"            instance_object \u003d instance"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_3c7946fd","line":2901,"updated":"2015-12-23 02:59:36.000000000","message":"Just convert the instance dict to an object using objects.Instance._from_db_object","commit_id":"68000e772c141b6447e952e7d56de913dc6f7b59"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4a4dc927ffbca4b0e940139cfbd610d7467b82db","unresolved":false,"context_lines":[{"line_number":2901,"context_line":"            instance_object \u003d instance_object.get_by_uuid(context,"},{"line_number":2902,"context_line":"                                                          instance.uuid)"},{"line_number":2903,"context_line":"        else:"},{"line_number":2904,"context_line":"            instance_object \u003d instance"},{"line_number":2905,"context_line":"        connect_info \u003d self.compute_rpcapi.get_vnc_console(context,"},{"line_number":2906,"context_line":"                instance\u003dinstance_object, console_type\u003dconsole_type)"},{"line_number":2907,"context_line":"        return connect_info"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_1c880ae7","line":2904,"updated":"2015-12-23 02:59:36.000000000","message":"Just re-assign the instance dict to an object above, we don\u0027t need a new variable for this.","commit_id":"68000e772c141b6447e952e7d56de913dc6f7b59"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"62a0d7ee53ed2619eee3631ee9bb2e28bae8d3a0","unresolved":false,"context_lines":[{"line_number":2924,"context_line":"    def get_spice_connect_info(self, context, instance, console_type):"},{"line_number":2925,"context_line":"        \"\"\"Used in a child cell to get console info.\"\"\""},{"line_number":2926,"context_line":"        connect_info \u003d self.compute_rpcapi.get_spice_console(context,"},{"line_number":2927,"context_line":"                instance\u003dinstance, console_type\u003dconsole_type)"},{"line_number":2928,"context_line":"        return connect_info"},{"line_number":2929,"context_line":""},{"line_number":2930,"context_line":"    @wrap_check_policy"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_bc7776d3","line":2927,"updated":"2015-12-23 03:16:19.000000000","message":"Wouldn\u0027t it also be a problem here?","commit_id":"68000e772c141b6447e952e7d56de913dc6f7b59"},{"author":{"_account_id":17532,"name":"Tina Kevin","email":"song.ruixia@zte.com.cn","username":"SongRuixia"},"change_message_id":"66bc59eeb3badd61c319782e575bc474926dc2d6","unresolved":false,"context_lines":[{"line_number":2924,"context_line":"    def get_spice_connect_info(self, context, instance, console_type):"},{"line_number":2925,"context_line":"        \"\"\"Used in a child cell to get console info.\"\"\""},{"line_number":2926,"context_line":"        connect_info \u003d self.compute_rpcapi.get_spice_console(context,"},{"line_number":2927,"context_line":"                instance\u003dinstance, console_type\u003dconsole_type)"},{"line_number":2928,"context_line":"        return connect_info"},{"line_number":2929,"context_line":""},{"line_number":2930,"context_line":"    @wrap_check_policy"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_4f51c80d","line":2927,"in_reply_to":"1a7b0d38_bc7776d3","updated":"2015-12-24 07:08:01.000000000","message":"yes,it aslo convert to objects.Instance object","commit_id":"68000e772c141b6447e952e7d56de913dc6f7b59"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"62a0d7ee53ed2619eee3631ee9bb2e28bae8d3a0","unresolved":false,"context_lines":[{"line_number":2945,"context_line":"    def get_rdp_connect_info(self, context, instance, console_type):"},{"line_number":2946,"context_line":"        \"\"\"Used in a child cell to get console info.\"\"\""},{"line_number":2947,"context_line":"        connect_info \u003d self.compute_rpcapi.get_rdp_console(context,"},{"line_number":2948,"context_line":"                instance\u003dinstance, console_type\u003dconsole_type)"},{"line_number":2949,"context_line":"        return connect_info"},{"line_number":2950,"context_line":""},{"line_number":2951,"context_line":"    @wrap_check_policy"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_dc74c2d0","line":2948,"updated":"2015-12-23 03:16:19.000000000","message":"And here?","commit_id":"68000e772c141b6447e952e7d56de913dc6f7b59"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"62a0d7ee53ed2619eee3631ee9bb2e28bae8d3a0","unresolved":false,"context_lines":[{"line_number":2953,"context_line":"    def get_serial_console(self, context, instance, console_type):"},{"line_number":2954,"context_line":"        \"\"\"Get a url to a serial console.\"\"\""},{"line_number":2955,"context_line":"        connect_info \u003d self.compute_rpcapi.get_serial_console(context,"},{"line_number":2956,"context_line":"                instance\u003dinstance, console_type\u003dconsole_type)"},{"line_number":2957,"context_line":""},{"line_number":2958,"context_line":"        self.consoleauth_rpcapi.authorize_console(context,"},{"line_number":2959,"context_line":"                connect_info[\u0027token\u0027], console_type,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_7c810e8f","line":2956,"updated":"2015-12-23 03:16:19.000000000","message":"And here?","commit_id":"68000e772c141b6447e952e7d56de913dc6f7b59"}]}