)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d0693efb12c9cdf2504a2c5a294cc094cf8dd5c3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP]Add config option \"scheduler_compute_node_update_interval\" for scheduler"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In nova-scheduler, we now uses"},{"line_number":10,"context_line":"scheduler/host_manager/update_from_compute_node()"},{"line_number":11,"context_line":"to update information about a host from a ComputeNode"},{"line_number":12,"context_line":"object. Currently, the information won\u0027t update"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa69d971_dfbb5f74","line":9,"updated":"2015-12-29 20:32:02.000000000","message":"s/uses/use/","commit_id":"1e88442c0daee34580cfd45ab5788956ae16d557"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"1eda55799d2a145d9eb2dad747b0af0a62596275","unresolved":false,"context_lines":[{"line_number":10,"context_line":"scheduler/host_manager/update_from_compute_node()"},{"line_number":11,"context_line":"to update information about a host from a ComputeNode"},{"line_number":12,"context_line":"object. Currently, the information won\u0027t update"},{"line_number":13,"context_line":"if the updated time in scheduler is latter than"},{"line_number":14,"context_line":"the updated_at time in compute:"},{"line_number":15,"context_line":"https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L162-L164"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a68dd71_3d3a35cd","line":13,"updated":"2016-01-22 17:05:51.000000000","message":"later","commit_id":"a5818c1692adaca8baac5c0200b77744d3ea37d4"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"1eda55799d2a145d9eb2dad747b0af0a62596275","unresolved":false,"context_lines":[{"line_number":25,"context_line":"there are no changes)."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"This patch adds a config option \"scheduler_compute_node_update_interval\"."},{"line_number":28,"context_line":"If the updated time in scheduler is latter than"},{"line_number":29,"context_line":"updated_at in compute but the difference bettween the"},{"line_number":30,"context_line":"updated time in scheduler and current time is larger"},{"line_number":31,"context_line":"than this interval, it will still update the information"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a68dd71_dd32f9f1","line":28,"updated":"2016-01-22 17:05:51.000000000","message":"later","commit_id":"a5818c1692adaca8baac5c0200b77744d3ea37d4"},{"author":{"_account_id":10669,"name":"Gang Wei","email":"gang.wei@intel.com","username":"gwei3"},"change_message_id":"9c6be9fe73391265469e3fa823a8963df8fbf1d1","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"This patch adds a config option \"scheduler_compute_node_update_interval\"."},{"line_number":28,"context_line":"If the updated time in scheduler is later than"},{"line_number":29,"context_line":"updated_at in compute but the difference bettween the"},{"line_number":30,"context_line":"updated time in scheduler and current time is larger"},{"line_number":31,"context_line":"than this interval, it will still update the information"},{"line_number":32,"context_line":"from compute to avoid inconsistency. The default value"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9a68dd71_0106b91f","line":29,"range":{"start_line":29,"start_character":41,"end_line":29,"end_character":49},"updated":"2016-01-25 08:27:04.000000000","message":"-\u003ebetween","commit_id":"39b9473a34b9e26ea433281f135e1e316ccf4511"}],"nova/conf/scheduler.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d0693efb12c9cdf2504a2c5a294cc094cf8dd5c3","unresolved":false,"context_lines":[{"line_number":125,"context_line":"update_interval_opt \u003d cfg.IntOpt(\"scheduler_compute_node_update_interval\","},{"line_number":126,"context_line":"        default\u003d300,"},{"line_number":127,"context_line":"        help\u003d\"Time limit (in seconds) to update information of compute \""},{"line_number":128,"context_line":"             \"node if the schedluer\u0027s updated time is later than the \""},{"line_number":129,"context_line":"             \"compute\u0027s updated time. This can avoid inconsistency \""},{"line_number":130,"context_line":"             \"between scheduler and compute.\")"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_ffc0a3e2","line":128,"updated":"2015-12-29 20:32:02.000000000","message":"\"scheduler\u0027s\"","commit_id":"1e88442c0daee34580cfd45ab5788956ae16d557"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d0693efb12c9cdf2504a2c5a294cc094cf8dd5c3","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        help\u003d\"Time limit (in seconds) to update information of compute \""},{"line_number":128,"context_line":"             \"node if the schedluer\u0027s updated time is later than the \""},{"line_number":129,"context_line":"             \"compute\u0027s updated time. This can avoid inconsistency \""},{"line_number":130,"context_line":"             \"between scheduler and compute.\")"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"# These opts are registered as a separate OptGroup"},{"line_number":133,"context_line":"trusted_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_9fb5e77f","line":130,"updated":"2015-12-29 20:32:02.000000000","message":"It might be more clear if you use the term \"compute node\" in both of these lines above","commit_id":"1e88442c0daee34580cfd45ab5788956ae16d557"}],"nova/scheduler/host_manager.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d0693efb12c9cdf2504a2c5a294cc094cf8dd5c3","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        now \u003d timeutils.utcnow().replace(tzinfo\u003diso8601.iso8601.Utc())"},{"line_number":166,"context_line":"        if (self.updated and compute.updated_at"},{"line_number":167,"context_line":"                and self.updated \u003e compute.updated_at"},{"line_number":168,"context_line":"                and self.updated - now \u003c update_interval):"},{"line_number":169,"context_line":"            return"},{"line_number":170,"context_line":"        all_ram_mb \u003d compute.memory_mb"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_bfba2b6d","line":168,"updated":"2015-12-29 20:32:02.000000000","message":"Is there an opportunity to use one of the helper utilities from olso_utils.timeutils here?","commit_id":"1e88442c0daee34580cfd45ab5788956ae16d557"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"420c21a80328e45e00746f6461b91d8a78c0154d","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        now \u003d timeutils.utcnow().replace(tzinfo\u003diso8601.iso8601.Utc())"},{"line_number":166,"context_line":"        if (self.updated and compute.updated_at"},{"line_number":167,"context_line":"                and self.updated \u003e compute.updated_at"},{"line_number":168,"context_line":"                and self.updated - now \u003c update_interval):"},{"line_number":169,"context_line":"            return"},{"line_number":170,"context_line":"        all_ram_mb \u003d compute.memory_mb"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_097f90e0","line":168,"in_reply_to":"fa69d971_bfba2b6d","updated":"2016-01-07 07:29:19.000000000","message":"What do you mean?","commit_id":"1e88442c0daee34580cfd45ab5788956ae16d557"},{"author":{"_account_id":19912,"name":"Xuanzhou Perry Dong","email":"oss_xzdong@163.com","username":"oss_xzdong"},"change_message_id":"94b25161393d2779c1ffea04a4e5752c5c62b6ff","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        now \u003d timeutils.utcnow().replace(tzinfo\u003diso8601.iso8601.Utc())"},{"line_number":187,"context_line":"        if (self.updated and compute.updated_at"},{"line_number":188,"context_line":"                and self.updated \u003e compute.updated_at"},{"line_number":189,"context_line":"                and self.updated - now \u003c update_interval):"},{"line_number":190,"context_line":"            return"},{"line_number":191,"context_line":"        all_ram_mb \u003d compute.memory_mb"},{"line_number":192,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9a68dd71_b285b9cf","line":189,"updated":"2016-01-25 09:29:14.000000000","message":"In general \"self.updated\" should be earlier in time than \"now\" since self.updated is written in the past using the past \"now\". So this test is invalid. Do you actually mean \"self.updated - compute.updated_at \u003c update_interval\"?","commit_id":"39b9473a34b9e26ea433281f135e1e316ccf4511"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"892a8bc4e5b128bd88c885d7bdb27fe4c879b9f6","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        now \u003d timeutils.utcnow().replace(tzinfo\u003diso8601.iso8601.Utc())"},{"line_number":187,"context_line":"        if (self.updated and compute.updated_at"},{"line_number":188,"context_line":"                and self.updated \u003e compute.updated_at"},{"line_number":189,"context_line":"                and self.updated - now \u003c update_interval):"},{"line_number":190,"context_line":"            return"},{"line_number":191,"context_line":"        all_ram_mb \u003d compute.memory_mb"},{"line_number":192,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9a68dd71_65b2ef4d","line":189,"in_reply_to":"9a68dd71_b285b9cf","updated":"2016-01-26 03:01:54.000000000","message":"thanks, that will be now - self.updated","commit_id":"39b9473a34b9e26ea433281f135e1e316ccf4511"}]}