)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"528e97a5c7c83d04c6b4cdcddbae016503887ba1","unresolved":false,"context_lines":[{"line_number":17,"context_line":"- os_interactive_serial_port"},{"line_number":18,"context_line":"- os_logging_serial_port"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Partially-implements: blueprint hyperv-serial-ports"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Ie522b6f4ce24cd75a42c8bc2ebf07fe51948bea1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1a122d0e_e1158849","line":20,"range":{"start_line":20,"start_character":32,"end_line":20,"end_character":38},"updated":"2016-04-18 14:31:21.000000000","message":"This blueprint was approved as a spec-less blueprint on the basis that it was just implementing serial console support on a par with other drivers. ie it would not need any extra stuff added to the object model\n\nNow you\u0027ve added this extra functionality that only exists in the Hyper-V impl, this is no longer just adding parity against other drivers.   These properties are not really something that is related to the choice of nova virt drivers, but rather something that is guest OS specific. ie it would apply to windows guest images regarldess of whether they\u0027re running on hyperv or kvm or xen.\n\nIOW, if we want to make the serial ports configurable in the way you\u0027re suggesting here, I think that should be a separate blueprint from the basic hyper serial port support. It is clear from the patch which actally uses these properties, this is not a core requirement for the hyperv serial port code to be usable, since your code happily falls back default behaviour if they\u0027re not set.\n\nSo please drop this patch from this series, and just implement the core serial console support for hyperv against this specless blueprint. Propose a new Nova spec to discuss this guest OS serial port usage customization.","commit_id":"73d036bf766aff6beb837ef78e39ed97ad331b61"}],"nova/objects/image_meta.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"20d20a3a5b12c10d42407462fd99b039e0001631","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    # Version 1.10: added hw_cpu_realtime_mask field"},{"line_number":162,"context_line":"    # Version 1.11: Added hw_firmware_type field"},{"line_number":163,"context_line":"    # Version 1.12: Added properties for image signature verification"},{"line_number":164,"context_line":"    # Version 1.13: Added interactive_serial_port, logging_serial_port fields"},{"line_number":165,"context_line":"    VERSION \u003d \u00271.13\u0027"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def obj_make_compatible(self, primitive, target_version):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_b4bade21","line":164,"range":{"start_line":164,"start_character":26,"end_line":164,"end_character":70},"updated":"2016-01-29 06:05:13.000000000","message":"They should be fixed.","commit_id":"bcfe637c756662ade10eb5ee1ef2f442330a762a"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"20d20a3a5b12c10d42407462fd99b039e0001631","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                                                        target_version)"},{"line_number":170,"context_line":"        target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":171,"context_line":"        if target_version \u003c (1, 13):"},{"line_number":172,"context_line":"            primitive.pop(\u0027interactive_serial_port\u0027, 1)"},{"line_number":173,"context_line":"            primitive.pop(\u0027logging_serial_port\u0027, 1)"},{"line_number":174,"context_line":"        if target_version \u003c (1, 11):"},{"line_number":175,"context_line":"            primitive.pop(\u0027hw_firmware_type\u0027, None)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_d45e7a11","line":172,"range":{"start_line":172,"start_character":27,"end_line":172,"end_character":50},"updated":"2016-01-29 06:05:13.000000000","message":"It should be \u0027os_interactive_serial_port\u0027.","commit_id":"bcfe637c756662ade10eb5ee1ef2f442330a762a"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"68fb40caf62d0cfd191c0ce255e643e43be3b995","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                                                        target_version)"},{"line_number":170,"context_line":"        target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":171,"context_line":"        if target_version \u003c (1, 13):"},{"line_number":172,"context_line":"            primitive.pop(\u0027interactive_serial_port\u0027, 1)"},{"line_number":173,"context_line":"            primitive.pop(\u0027logging_serial_port\u0027, 1)"},{"line_number":174,"context_line":"        if target_version \u003c (1, 11):"},{"line_number":175,"context_line":"            primitive.pop(\u0027hw_firmware_type\u0027, None)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_0a1dc60e","line":172,"range":{"start_line":172,"start_character":27,"end_line":172,"end_character":50},"in_reply_to":"7a5de9d1_d45e7a11","updated":"2016-01-29 08:35:10.000000000","message":"Thanks for pointing this out! I\u0027m fixing this right now.","commit_id":"bcfe637c756662ade10eb5ee1ef2f442330a762a"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"20d20a3a5b12c10d42407462fd99b039e0001631","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":171,"context_line":"        if target_version \u003c (1, 13):"},{"line_number":172,"context_line":"            primitive.pop(\u0027interactive_serial_port\u0027, 1)"},{"line_number":173,"context_line":"            primitive.pop(\u0027logging_serial_port\u0027, 1)"},{"line_number":174,"context_line":"        if target_version \u003c (1, 11):"},{"line_number":175,"context_line":"            primitive.pop(\u0027hw_firmware_type\u0027, None)"},{"line_number":176,"context_line":"        if target_version \u003c (1, 9):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_749c66c0","line":173,"range":{"start_line":173,"start_character":27,"end_line":173,"end_character":46},"updated":"2016-01-29 06:05:13.000000000","message":"It should be \u0027os_logging_serial_port\u0027.","commit_id":"bcfe637c756662ade10eb5ee1ef2f442330a762a"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"ae6a2fbf9ef4074a0d2860db24fd5ae8186613f5","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":172,"context_line":"        if target_version \u003c (1, 13):"},{"line_number":173,"context_line":"            primitive.pop(\u0027os_interactive_serial_port\u0027, 1)"},{"line_number":174,"context_line":"            primitive.pop(\u0027os_logging_serial_port\u0027, 1)"},{"line_number":175,"context_line":"        if target_version \u003c (1, 11):"},{"line_number":176,"context_line":"            primitive.pop(\u0027hw_firmware_type\u0027, None)"},{"line_number":177,"context_line":"        if target_version \u003c (1, 9):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a1b2928_d0895dcc","line":174,"updated":"2016-04-11 16:53:41.000000000","message":"Ahem, None.","commit_id":"b676a70a1242137776d301b0c5a6a8fe3e176aeb"}],"nova/tests/unit/objects/test_image_meta.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"756aa962683114103a2a21b1b14a9d5ad4ae45fe","unresolved":false,"context_lines":[{"line_number":294,"context_line":"            \u0027hw_vif_multiqueue_enabled\u0027: True,"},{"line_number":295,"context_line":"            \u0027img_hv_type\u0027: \u0027kvm\u0027,"},{"line_number":296,"context_line":"            \u0027img_hv_requested_version\u0027: \u0027\u003e\u003d 1.0\u0027,"},{"line_number":297,"context_line":"            \u0027os_require_quiesce\u0027: True,"},{"line_number":298,"context_line":"        }"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"        obj \u003d objects.ImageMetaProps(**props)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a061dce_19005a65","line":297,"updated":"2016-04-07 21:31:51.000000000","message":"I think we should add the serial port access fields here to test that they\u0027re removed during an object backport","commit_id":"c665dc7ad5dc9064df7ceb6ae42356784617db77"}]}