)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"2829605932f50c648ed342e657fb924405a88015","unresolved":false,"context_lines":[{"line_number":9,"context_line":"By default this is turned on and has equal weight to the"},{"line_number":10,"context_line":"ram weigher."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"DocImpact: Added the disk_weight_multiplier config option, analagous to the existing ram_weight_multiplier"},{"line_number":13,"context_line":"Bug: 1513654"},{"line_number":14,"context_line":"Change-Id: I29ce73122ad1860081b64b75646a297dfbb8d292"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da6ed579_35706972","line":12,"range":{"start_line":12,"start_character":76,"end_line":12,"end_character":84},"updated":"2016-01-12 19:43:36.000000000","message":"suggest to make the sentence max 80 chars to help the review..","commit_id":"5daf2e133aca88dc65ca5bb57f9645c12ebc2fb0"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"021c4c2f6a7163322934965fcf5cee9e02abd737","unresolved":false,"context_lines":[{"line_number":9,"context_line":"By default this is turned on and has equal weight to the"},{"line_number":10,"context_line":"ram weigher."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"DocImpact: Added the disk_weight_multiplier config option"},{"line_number":13,"context_line":"Bug: 1513654"},{"line_number":14,"context_line":"Change-Id: I29ce73122ad1860081b64b75646a297dfbb8d292"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a68dd71_bbed36f1","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":57},"updated":"2016-01-26 20:48:03.000000000","message":"From what I understand, we need to have a reno releasenote added to this patch instead of using this tag.\n\nI think the new config option would go in the features section [1].\n\nThe notes go in https://github.com/openstack/nova/tree/master/releasenotes/notes\n\nand this [2] looks like a good example similar to what you want to do.\n\n[1] http://docs.openstack.org/developer/reno/usage.html#editing-a-release-note\n\n[2] https://github.com/openstack/nova/blob/master/releasenotes/notes/versioned-notifications-423f4d8d2a3992c6.yaml","commit_id":"89e25575f5b78b5e6b80492b3bbda6a83b16b563"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"59a3c18ec4ac128c415e700987377a6859c6036b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"ram weigher."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"DocImpact: Added the disk_weight_multiplier config option"},{"line_number":13,"context_line":"Bug: 1513654"},{"line_number":14,"context_line":"Change-Id: I29ce73122ad1860081b64b75646a297dfbb8d292"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a5de9d1_345cf924","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":12},"updated":"2016-01-27 22:47:52.000000000","message":"I forgot to mention this in the last PS but I think this should be Closes-Bug: 1513654 since it would close the issue (and the bot would mark as Fix Committed after merge)","commit_id":"bbf2ee980de1e3cc82cdcf6eb2c29edc9c29dfa0"}],"doc/source/filter_scheduler.rst":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"021c4c2f6a7163322934965fcf5cee9e02abd737","unresolved":false,"context_lines":[{"line_number":379,"context_line":"  Sort with the largest weight winning. If the multiplier is negative, the"},{"line_number":380,"context_line":"  host with least RAM available will win (useful for stacking hosts, instead"},{"line_number":381,"context_line":"  of spreading)."},{"line_number":382,"context_line":"* |DiskWeigher| Hosts are weighted and sorted by free disk space with the largest"},{"line_number":383,"context_line":"  weight winning.  If the multiplier is negative, the host with less disk space available"},{"line_number":384,"context_line":"  will win (useful for stacking hosts, instead of spreading)."},{"line_number":385,"context_line":"* |MetricsWeigher| This weigher can compute the weight based on the compute node"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a68dd71_a5a67951","line":382,"range":{"start_line":382,"start_character":2,"end_line":382,"end_character":15},"updated":"2016-01-26 20:48:03.000000000","message":"I noticed this link isn\u0027t going anywhere [1] because you need to add a line at the bottom with the module\n\n[1] http://docs-draft.openstack.org/08/261108/4/check/gate-nova-docs/5d03e0f//doc/build/html/filter_scheduler.html#weights","commit_id":"89e25575f5b78b5e6b80492b3bbda6a83b16b563"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"021c4c2f6a7163322934965fcf5cee9e02abd737","unresolved":false,"context_lines":[{"line_number":457,"context_line":".. |MetricsWeigher| replace:: :class:`MetricsWeigher \u003cnova.scheduler.weights.metrics.MetricsWeigher\u003e`"},{"line_number":458,"context_line":".. |IoOpsWeigher| replace:: :class:`IoOpsWeigher \u003cnova.scheduler.weights.io_ops.IoOpsWeigher\u003e`"},{"line_number":459,"context_line":".. |ServerGroupSoftAffinityWeigher| replace:: :class:`ServerGroupSoftAffinityWeigher \u003cnova.scheduler.weights.affinity.ServerGroupSoftAffinityWeigher\u003e`"},{"line_number":460,"context_line":".. |ServerGroupSoftAntiAffinityWeigher| replace:: :class:`ServerGroupSoftAntiAffinityWeigher \u003cnova.scheduler.weights.affinity.ServerGroupSoftAntiAffinityWeigher\u003e`"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a68dd71_257129e1","line":460,"updated":"2016-01-26 20:48:03.000000000","message":"I think you need an entry here so the DiskWeigher link will point at the module doc [1]\n\n[1] http://docs-draft.openstack.org/08/261108/4/check/gate-nova-docs/5d03e0f//doc/build/html/api/nova.scheduler.weights.disk.html","commit_id":"89e25575f5b78b5e6b80492b3bbda6a83b16b563"}],"nova/scheduler/weights/disk.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"1a378fa73cfbfef9a4c839f956976a34e1f8cf8c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2011 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_c9c15482","line":1,"updated":"2015-12-30 13:55:01.000000000","message":"2015?","commit_id":"983a758e8b6cc6899d0cd4f3c82eb79bc7fa4b7b"}],"nova/tests/unit/scheduler/weights/test_weights_disk.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"1a378fa73cfbfef9a4c839f956976a34e1f8cf8c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2011-2012 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_a9c42092","line":1,"updated":"2015-12-30 13:55:01.000000000","message":"2015?","commit_id":"983a758e8b6cc6899d0cd4f3c82eb79bc7fa4b7b"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"021c4c2f6a7163322934965fcf5cee9e02abd737","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def _get_all_hosts(self):"},{"line_number":38,"context_line":"        host_values \u003d ["},{"line_number":39,"context_line":"            (\u0027host1\u0027, \u0027node1\u0027, {\u0027free_disk_mb\u0027: 5120}),"},{"line_number":40,"context_line":"            (\u0027host2\u0027, \u0027node2\u0027, {\u0027free_disk\u0027: 10240}),"},{"line_number":41,"context_line":"            (\u0027host3\u0027, \u0027node3\u0027, {\u0027free_disk_mb\u0027: 30720}),"},{"line_number":42,"context_line":"            (\u0027host4\u0027, \u0027node4\u0027, {\u0027free_disk_mb\u0027: 81920})"},{"line_number":43,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_6fbe20d6","line":40,"range":{"start_line":40,"start_character":32,"end_line":40,"end_character":43},"updated":"2016-01-26 20:48:03.000000000","message":"Shouldn\u0027t this be \u0027free_disk_mb\u0027?","commit_id":"89e25575f5b78b5e6b80492b3bbda6a83b16b563"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"60f45c198bb14d0e9d08ef47a2df8ba2c769e1d2","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def test_default_of_spreading_first(self):"},{"line_number":48,"context_line":"        hostinfo_list \u003d self._get_all_hosts()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        # host1: free_disk_mb\u003d5120"},{"line_number":51,"context_line":"        # host2: free_disk_mb\u003d10240"},{"line_number":52,"context_line":"        # host3: free_disk_mb\u003d30720"},{"line_number":53,"context_line":"        # host4: free_disk_mb\u003d81920"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        # so, host4 should win:"},{"line_number":56,"context_line":"        weighed_host \u003d self._get_weighed_host(hostinfo_list)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_4ba90723","line":53,"range":{"start_line":50,"start_character":0,"end_line":53,"end_character":35},"updated":"2016-01-15 15:11:36.000000000","message":"what purpose do these comments serve? I can figure this information out quite easily, imo","commit_id":"89e25575f5b78b5e6b80492b3bbda6a83b16b563"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"43a4aa7c6af2ff8051db5e47dc5741bfcdf99e17","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        # host1: free_disk_mb\u003d5120"},{"line_number":51,"context_line":"        # host2: free_disk_mb\u003d10240"},{"line_number":52,"context_line":"        # host3: free_disk_mb\u003d30720"},{"line_number":53,"context_line":"        # host4: free_disk_mb\u003d81920"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        # so, host4 should win:"},{"line_number":56,"context_line":"        weighed_host \u003d self._get_weighed_host(hostinfo_list)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba63e191_b138d03e","line":53,"in_reply_to":"ba63e191_9ffa87bc","updated":"2016-01-19 22:50:46.000000000","message":"Agree with Stephen. The values are declared just above. If clarification is needed, name the hosts:\n\nhost_5120free\nhost_10240free\n...etc.","commit_id":"89e25575f5b78b5e6b80492b3bbda6a83b16b563"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"021c4c2f6a7163322934965fcf5cee9e02abd737","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        # host1: free_disk_mb\u003d5120"},{"line_number":51,"context_line":"        # host2: free_disk_mb\u003d10240"},{"line_number":52,"context_line":"        # host3: free_disk_mb\u003d30720"},{"line_number":53,"context_line":"        # host4: free_disk_mb\u003d81920"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        # so, host4 should win:"},{"line_number":56,"context_line":"        weighed_host \u003d self._get_weighed_host(hostinfo_list)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_afc0982b","line":53,"in_reply_to":"ba63e191_b138d03e","updated":"2016-01-26 20:48:03.000000000","message":"FWIW, there\u0027s precedent of comments like this in test_weights_ram.py and also I think it\u0027s fine for making the tests easier to read and understand","commit_id":"89e25575f5b78b5e6b80492b3bbda6a83b16b563"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"edc436740c38cc1c24edbe3883c1133cfc4239d4","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        # host1: free_disk_mb\u003d5120"},{"line_number":51,"context_line":"        # host2: free_disk_mb\u003d10240"},{"line_number":52,"context_line":"        # host3: free_disk_mb\u003d30720"},{"line_number":53,"context_line":"        # host4: free_disk_mb\u003d81920"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        # so, host4 should win:"},{"line_number":56,"context_line":"        weighed_host \u003d self._get_weighed_host(hostinfo_list)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba63e191_9ffa87bc","line":53,"in_reply_to":"da6ed579_4ba90723","updated":"2016-01-19 17:38:09.000000000","message":"I have to admit I rather like the comments, makes the tests far more readable. Yes, it\u0027s redundant, but that\u0027s a small price to pay for tests that are easy to understand.","commit_id":"89e25575f5b78b5e6b80492b3bbda6a83b16b563"}]}