)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"4d5712a0746edeaf5ae6a6ec07ee00fa99bc53f1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"the floating IP with the first fixed IP of the instances"},{"line_number":13,"context_line":"(and to log a warning)"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This change introduces a new extension which wehn loaded adds a"},{"line_number":16,"context_line":"fixed IP address as an optional parameter, allowing the floating"},{"line_number":17,"context_line":"IP to be associated with a specific fixed IP."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"AAAAOn%2F%2FfFY%3D","line":15,"updated":"2013-05-08 07:40:52.000000000","message":"nit: when","commit_id":"2d45d710516e0a58eb4e785d66dff2a336a549b8"}],"nova/api/openstack/compute/contrib/floating_ips.py":[{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"0453a4632a41d214f647014076c1db155f383a42","unresolved":false,"context_lines":[{"line_number":230,"context_line":"            msg \u003d _(\u0027No fixed ips associated to instance\u0027)"},{"line_number":231,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        try:"},{"line_number":234,"context_line":"            fixed_address \u003d body[\u0027addFloatingIp\u0027][\u0027fixed_address\u0027]"},{"line_number":235,"context_line":"            found \u003d False"},{"line_number":236,"context_line":"            for fixed in fixed_ips:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2F3%2BI%3D","line":233,"updated":"2013-04-15 18:04:19.000000000","message":"Can this be more explicit?\n\n    if body.get(\u0027addFloatingIp\u0027, {}).get(\u0027fixed_address\u0027):\n\nWill do the same but the current solution will also trigger on unrelated errors.","commit_id":"5f240434058ba15bd2874b3056866252bfc7ac95"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"63279dba46c0904e4c9da2d5c96557efd678b6ba","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        try:"},{"line_number":234,"context_line":"            fixed_address \u003d body[\u0027addFloatingIp\u0027][\u0027fixed_address\u0027]"},{"line_number":235,"context_line":"            found \u003d False"},{"line_number":236,"context_line":"            for fixed in fixed_ips:"},{"line_number":237,"context_line":"                if fixed[\u0027address\u0027] \u003d\u003d fixed_address:"},{"line_number":238,"context_line":"                    found \u003d True"},{"line_number":239,"context_line":"            if not found:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2F4u8%3D","line":236,"updated":"2013-04-13 01:41:24.000000000","message":"nit consider (allows removing found variable).\n\nfor fixed in fixed_ips:\n    if fixed[\u0027address\u0027] \u003d\u003d fixed_address:\n        break # \u003c--- you should add:\nelse:\n    msg \u003d _(\u0027Specified fixed address not associated to instance\u0027)\n    raise webob.exc.HTTPBadRequest(explanation\u003dmsg)","commit_id":"5f240434058ba15bd2874b3056866252bfc7ac95"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"4d5712a0746edeaf5ae6a6ec07ee00fa99bc53f1","unresolved":false,"context_lines":[{"line_number":236,"context_line":"            if \u0027fixed_address\u0027 in body[\u0027addFloatingIp\u0027]:"},{"line_number":237,"context_line":"                fixed_address \u003d body[\u0027addFloatingIp\u0027][\u0027fixed_address\u0027]"},{"line_number":238,"context_line":"                found \u003d False"},{"line_number":239,"context_line":"                for fixed in fixed_ips:"},{"line_number":240,"context_line":"                    if fixed[\u0027address\u0027] \u003d\u003d fixed_address:"},{"line_number":241,"context_line":"                        found \u003d True"},{"line_number":242,"context_line":"                        break"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAOn%2F%2FfFc%3D","line":239,"updated":"2013-05-08 07:40:52.000000000","message":"If you want you could remove the found variable via;\n\nfor fixed in fixed_ips:\n    if fixed[\u0027address\u0027] \u003d\u003d fixed_address:\n        break\nelse: \n   msg \u003d _(\u0027Specified fixed address not assigned to instance\u0027)\n   raise webob.exc.HTTPBadRequest(explanation\u003dmsg)","commit_id":"2d45d710516e0a58eb4e785d66dff2a336a549b8"}],"nova/tests/integrated/test_api_samples.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"4d5712a0746edeaf5ae6a6ec07ee00fa99bc53f1","unresolved":false,"context_lines":[{"line_number":1354,"context_line":"        self.assertEqual(response.status, 202)"},{"line_number":1355,"context_line":""},{"line_number":1356,"context_line":""},{"line_number":1357,"context_line":"class ExtendedFloatingIpsJsonTest(ApiSampleTestBase):"},{"line_number":1358,"context_line":"    extends_name \u003d \"nova.api.openstack.compute.contrib.\" \\"},{"line_number":1359,"context_line":"        \"floating_ips.Floating_ips\""},{"line_number":1360,"context_line":"    extension_name \u003d \"nova.api.openstack.compute.contrib.\" \\"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAOn%2F%2FfEg%3D","line":1357,"updated":"2013-05-08 07:40:52.000000000","message":"We should change this to: \n\nclass ExtendedFloatingIpsJsonTest(FloatingIpsJsonTest): \n      extends_name \u003d (\"nova.api.openstack.compute.contrib.\" \n                                   \"floating_ips.Floating_ips\")\n      extension_name \u003d (\"nova.api.openstack.compute.contrib.\" \n                                      \"extended_floating_ips.Extended_floating_ips\")\n\nand remove the duplicated tests from 1363 -\u003e 1443.","commit_id":"2d45d710516e0a58eb4e785d66dff2a336a549b8"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"4d5712a0746edeaf5ae6a6ec07ee00fa99bc53f1","unresolved":false,"context_lines":[{"line_number":1356,"context_line":""},{"line_number":1357,"context_line":"class ExtendedFloatingIpsJsonTest(ApiSampleTestBase):"},{"line_number":1358,"context_line":"    extends_name \u003d \"nova.api.openstack.compute.contrib.\" \\"},{"line_number":1359,"context_line":"        \"floating_ips.Floating_ips\""},{"line_number":1360,"context_line":"    extension_name \u003d \"nova.api.openstack.compute.contrib.\" \\"},{"line_number":1361,"context_line":"        \"extended_floating_ips.Extended_floating_ips\""},{"line_number":1362,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAOn%2F%2FfD8%3D","line":1359,"updated":"2013-05-08 07:40:52.000000000","message":"nit remove \\ and warp with ( ) instead.","commit_id":"2d45d710516e0a58eb4e785d66dff2a336a549b8"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"9137d411d0bdee0d84497ee45673a8e2560b7dfe","unresolved":false,"context_lines":[{"line_number":1441,"context_line":"        self.assertEqual(response.status, 202)"},{"line_number":1442,"context_line":""},{"line_number":1443,"context_line":""},{"line_number":1444,"context_line":"class FloatingIpsXmlTest(FloatingIpsJsonTest):"},{"line_number":1445,"context_line":"    ctype \u003d \u0027xml\u0027"},{"line_number":1446,"context_line":""},{"line_number":1447,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAOn%2F%2FfDY%3D","line":1444,"updated":"2013-05-08 07:45:58.000000000","message":"missing: \n\nclass ExtendedFloatingIpsXmlTest(FloatingIpsJsonTest): \n  ctype \u003d \u0027xml\u0027","commit_id":"2d45d710516e0a58eb4e785d66dff2a336a549b8"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"b49150f399194394b67534e8ca60820b2da62e59","unresolved":false,"context_lines":[{"line_number":1356,"context_line":""},{"line_number":1357,"context_line":"class ExtendedFloatingIpsJsonTest(FloatingIpsJsonTest):"},{"line_number":1358,"context_line":"    extends_name \u003d (\"nova.api.openstack.compute.contrib.\""},{"line_number":1359,"context_line":"                         \"floating_ips.Floating_ips\")"},{"line_number":1360,"context_line":"    extension_name \u003d (\"nova.api.openstack.compute.contrib.\""},{"line_number":1361,"context_line":"                         \"extended_floating_ips.Extended_floating_ips\")"},{"line_number":1362,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAOn%2F%2Fa%2Fk%3D","line":1359,"updated":"2013-05-10 02:25:13.000000000","message":"nit would be nice if this text was aligned with above.","commit_id":"1b2c121f133b15d0fe3f6ebdb131ac9998bc4b83"}]}