)]}'
{"nova/virt/libvirt/host.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"aebb9824dd95b25f6b6d3c933354093629850ecd","unresolved":false,"context_lines":[{"line_number":653,"context_line":"            if error_code \u003d\u003d libvirt.VIR_ERR_NO_DOMAIN:"},{"line_number":654,"context_line":"                err \u003d (_(\"Instance %(instance_name)s could not be found\") %"},{"line_number":655,"context_line":"                        {\u0027instance_name\u0027: instance_name})"},{"line_number":656,"context_line":"                raise exception.InternalError(message\u003derr)"},{"line_number":657,"context_line":""},{"line_number":658,"context_line":"            msg \u003d (_(\u0027Error from libvirt while looking up %(instance_name)s: \u0027"},{"line_number":659,"context_line":"                     \u0027[Error Code %(error_code)s] %(ex)s\u0027) %"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_4ba3a79d","line":656,"range":{"start_line":656,"start_character":16,"end_line":656,"end_character":21},"updated":"2016-01-05 08:20:00.000000000","message":"we have multiple places use catch the InstanceNotFound exception. like this https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L802\n\nSo we only change what exception raised looks like not enough.","commit_id":"d8d3b64c7e791339f69256ec11a28c355bd7f30e"},{"author":{"_account_id":13525,"name":"Yusuke Ide","email":"idzzyzzbi@gmail.com","username":"idzzy"},"change_message_id":"7958c315baa768c20ff4872f16c98414232fe901","unresolved":false,"context_lines":[{"line_number":653,"context_line":"            if error_code \u003d\u003d libvirt.VIR_ERR_NO_DOMAIN:"},{"line_number":654,"context_line":"                err \u003d (_(\"Instance %(instance_name)s could not be found\") %"},{"line_number":655,"context_line":"                        {\u0027instance_name\u0027: instance_name})"},{"line_number":656,"context_line":"                raise exception.InternalError(message\u003derr)"},{"line_number":657,"context_line":""},{"line_number":658,"context_line":"            msg \u003d (_(\u0027Error from libvirt while looking up %(instance_name)s: \u0027"},{"line_number":659,"context_line":"                     \u0027[Error Code %(error_code)s] %(ex)s\u0027) %"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_16c14854","line":656,"range":{"start_line":656,"start_character":16,"end_line":656,"end_character":21},"in_reply_to":"fa69d971_4ba3a79d","updated":"2016-01-05 14:21:49.000000000","message":"Does it mean that it does not need to change exception type, only exception message should be changed?\n\nDue to the link as you mentioned, \nIs this modification correct?\n- does not need argument of InstanceNotFound exception\n- print appropriate message by LOG.info","commit_id":"d8d3b64c7e791339f69256ec11a28c355bd7f30e"}]}
