)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"c7e89a408a2e9ac078d6d27840395db6fad75199","unresolved":false,"context_lines":[{"line_number":4897,"context_line":"        #             connection from this host."},{"line_number":4898,"context_line":""},{"line_number":4899,"context_line":"        try:"},{"line_number":4900,"context_line":"            bdm \u003d objects.BlockDeviceMapping.get_by_volume_id("},{"line_number":4901,"context_line":"                    context, volume_id)"},{"line_number":4902,"context_line":"            self._driver_detach_volume(context, instance, bdm)"},{"line_number":4903,"context_line":"            connector \u003d self.driver.get_volume_connector(instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_e33ea9b7","side":"PARENT","line":4900,"range":{"start_line":4900,"start_character":45,"end_line":4900,"end_character":61},"updated":"2015-12-30 21:00:12.000000000","message":"This function has an instance_uuid as an optional parameter. This bug fix should be done on BDM level as opposed to here in order to solve the problem in a more generic way.","commit_id":"2c050707af8a2fa5640331063cf86de9814f2c72"},{"author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"change_message_id":"b6b629dcc91f912d5f9c6adcfefa34b3b16e3381","unresolved":false,"context_lines":[{"line_number":4910,"context_line":"        \"\"\"Helper function to retrieve the bdm for given volume and instance\"\"\""},{"line_number":4911,"context_line":"        # go get the bdm for this instance and volume id"},{"line_number":4912,"context_line":"        all_bdms \u003d objects.BlockDeviceMappingList.get_by_instance_uuid("},{"line_number":4913,"context_line":"            context, instance[\u0027uuid\u0027])"},{"line_number":4914,"context_line":"        bdm_lst \u003d None"},{"line_number":4915,"context_line":"        if all_bdms:"},{"line_number":4916,"context_line":"            bdm_lst \u003d [bdm for bdm in all_bdms if bdm[\u0027volume_id\u0027] and"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_fa956786","line":4913,"updated":"2015-12-29 12:34:49.000000000","message":"This should probably be instance.uuid","commit_id":"33dfe78f3534daee5da0db7c9387ac672f58dcf4"},{"author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"change_message_id":"b6b629dcc91f912d5f9c6adcfefa34b3b16e3381","unresolved":false,"context_lines":[{"line_number":4913,"context_line":"            context, instance[\u0027uuid\u0027])"},{"line_number":4914,"context_line":"        bdm_lst \u003d None"},{"line_number":4915,"context_line":"        if all_bdms:"},{"line_number":4916,"context_line":"            bdm_lst \u003d [bdm for bdm in all_bdms if bdm[\u0027volume_id\u0027] and"},{"line_number":4917,"context_line":"                bdm[\u0027volume_id\u0027] \u003d\u003d volume_id]"},{"line_number":4918,"context_line":"        return bdm_lst[0] if bdm_lst else None"},{"line_number":4919,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_5a84bb5c","line":4916,"updated":"2015-12-29 12:34:49.000000000","message":"You should treat the BDMs as objects instead of dictionaries.  The check should be \"if bdm.is_volume and bdm.volume_id \u003d\u003d volume_id\"","commit_id":"33dfe78f3534daee5da0db7c9387ac672f58dcf4"}]}