)]}'
{"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"3d36acc33dfefa805f2d0ebcf817e886fa655dc3","unresolved":false,"context_lines":[{"line_number":4033,"context_line":""},{"line_number":4034,"context_line":""},{"line_number":4035,"context_line":"@require_context"},{"line_number":4036,"context_line":"def block_device_mapping_get_by_instance_and_volume_id(context, volume_id,"},{"line_number":4037,"context_line":"                                                       instance_uuid,"},{"line_number":4038,"context_line":"                                                       columns_to_join\u003dNone):"},{"line_number":4039,"context_line":"    return _block_device_mapping_get_query(context,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba63e191_1a39c241","line":4036,"updated":"2016-01-19 18:44:49.000000000","message":"Was this skipped for a reason?","commit_id":"2023983ee632af183a248b74cb69fcb70a7b6a05"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"742a1efe07d815d26ad0106a6501ed4be1efc180","unresolved":false,"context_lines":[{"line_number":4033,"context_line":""},{"line_number":4034,"context_line":""},{"line_number":4035,"context_line":"@require_context"},{"line_number":4036,"context_line":"def block_device_mapping_get_by_instance_and_volume_id(context, volume_id,"},{"line_number":4037,"context_line":"                                                       instance_uuid,"},{"line_number":4038,"context_line":"                                                       columns_to_join\u003dNone):"},{"line_number":4039,"context_line":"    return _block_device_mapping_get_query(context,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_b65ed674","line":4036,"in_reply_to":"ba63e191_1a39c241","updated":"2016-01-20 13:34:05.000000000","message":"Nice catch, don\u0027t know how we missed it)","commit_id":"2023983ee632af183a248b74cb69fcb70a7b6a05"}],"nova/objects/block_device.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"3d36acc33dfefa805f2d0ebcf817e886fa655dc3","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        cells_create \u003d update_or_create or None"},{"line_number":135,"context_line":"        if update_or_create:"},{"line_number":136,"context_line":"            db_bdm \u003d db.block_device_mapping_update_or_create("},{"line_number":137,"context_line":"                    context, updates, legacy\u003dFalse)"},{"line_number":138,"context_line":"        else:"},{"line_number":139,"context_line":"            db_bdm \u003d db.block_device_mapping_create("}],"source_content_type":"text/x-python","patch_set":4,"id":"ba63e191_3a4b6689","line":136,"updated":"2016-01-19 18:44:49.000000000","message":"You missed all of the db calls in this Object class.","commit_id":"2023983ee632af183a248b74cb69fcb70a7b6a05"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"16b5b5166d18e049d0ae37ec280f23a0e6296396","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        cells_create \u003d update_or_create or None"},{"line_number":135,"context_line":"        if update_or_create:"},{"line_number":136,"context_line":"            db_bdm \u003d db.block_device_mapping_update_or_create("},{"line_number":137,"context_line":"                    context, updates, legacy\u003dFalse)"},{"line_number":138,"context_line":"        else:"},{"line_number":139,"context_line":"            db_bdm \u003d db.block_device_mapping_create("}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_33650645","line":136,"in_reply_to":"9a68dd71_9682b2c7","updated":"2016-01-20 17:42:51.000000000","message":"Okay, thanks for clarifying.","commit_id":"2023983ee632af183a248b74cb69fcb70a7b6a05"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"742a1efe07d815d26ad0106a6501ed4be1efc180","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        cells_create \u003d update_or_create or None"},{"line_number":135,"context_line":"        if update_or_create:"},{"line_number":136,"context_line":"            db_bdm \u003d db.block_device_mapping_update_or_create("},{"line_number":137,"context_line":"                    context, updates, legacy\u003dFalse)"},{"line_number":138,"context_line":"        else:"},{"line_number":139,"context_line":"            db_bdm \u003d db.block_device_mapping_create("}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_9682b2c7","line":136,"in_reply_to":"ba63e191_3a4b6689","updated":"2016-01-20 13:34:05.000000000","message":"Andrew, we should wrap only db calls that have \u0027use_slave\u0027 parameter and add \u0027@db.select_db_reader_mode\u0027 decorator to corresponding private functions. So this place is correct.","commit_id":"2023983ee632af183a248b74cb69fcb70a7b6a05"}]}