)]}'
{"nova/virt/hyperv/snapshotops.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"95cc5e8e80cda8fe6394afad2298d091914c6cc2","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                LOG.debug(\"Removing snapshot %s\", image_id)"},{"line_number":127,"context_line":"                self._vmutils.remove_vm_snapshot(snapshot_path)"},{"line_number":128,"context_line":"            except Exception as ex:"},{"line_number":129,"context_line":"                LOG.exception(six.text_type(ex))"},{"line_number":130,"context_line":"                LOG.warning(_LW(\u0027Failed to remove snapshot for VM %s\u0027),"},{"line_number":131,"context_line":"                            instance_name)"},{"line_number":132,"context_line":"            if export_dir:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_a9262b66","line":129,"updated":"2016-01-03 14:21:59.000000000","message":"This isn\u0027t aligned with the documentation: http://docs.openstack.org/developer/oslo.log/usage.html#no-more-implicit-conversion-to-unicode-str\n\nIn there is says that if you want to send just an exception then you want LOG.error(six.text_type(ex))\n\nIf you are using LOG.exception then the exception that is in scope will be handling by the logger and you should be passing an additional message as context.","commit_id":"06e6edfa1faab6826639ae4f38d0d2644bfcd8c7"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"e1b4b075c0fc7a6ffb5ee68d3444130796236cd6","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                LOG.debug(\"Removing snapshot %s\", image_id)"},{"line_number":127,"context_line":"                self._vmutils.remove_vm_snapshot(snapshot_path)"},{"line_number":128,"context_line":"            except Exception as ex:"},{"line_number":129,"context_line":"                LOG.exception(six.text_type(ex))"},{"line_number":130,"context_line":"                LOG.warning(_LW(\u0027Failed to remove snapshot for VM %s\u0027),"},{"line_number":131,"context_line":"                            instance_name)"},{"line_number":132,"context_line":"            if export_dir:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_26b561ed","line":129,"in_reply_to":"fa69d971_a9262b66","updated":"2016-01-04 19:09:50.000000000","message":"Agree with @cdent, LOG.exception doesn\u0027t take the exception, it takes a summary message about what failed. Realistically the LOG.warning should just be upgraded to LOG.exception here. There should only be one trip the the logger in this block.","commit_id":"06e6edfa1faab6826639ae4f38d0d2644bfcd8c7"}]}