)]}'
{"nova/network/model.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"b0153e55838599fe620b48246765708ffec92eb1","unresolved":false,"context_lines":[{"line_number":37,"context_line":"VIF_TYPE_802_QBG \u003d \u0027802.1qbg\u0027"},{"line_number":38,"context_line":"VIF_TYPE_802_QBH \u003d \u0027802.1qbh\u0027"},{"line_number":39,"context_line":"VIF_TYPE_HW_VEB \u003d \u0027hw_veb\u0027"},{"line_number":40,"context_line":"VIF_TYPE_HOSTDEV_PHY \u003d \u0027hostdev_physical\u0027"},{"line_number":41,"context_line":"VIF_TYPE_IB_HOSTDEV \u003d \u0027ib_hostdev\u0027"},{"line_number":42,"context_line":"VIF_TYPE_MIDONET \u003d \u0027midonet\u0027"},{"line_number":43,"context_line":"VIF_TYPE_VHOSTUSER \u003d \u0027vhostuser\u0027"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa0719c6_0b39b441","line":40,"updated":"2016-03-22 14:20:39.000000000","message":"I think VIF_TYPE_HOSTDEV would have been just as descriptive. :)","commit_id":"46e32428cfec9e3923622b516f0b258c93578ed4"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"28da42cb64d8ca1142f38b60e216dfe7ad6bcda6","unresolved":false,"context_lines":[{"line_number":37,"context_line":"VIF_TYPE_802_QBG \u003d \u0027802.1qbg\u0027"},{"line_number":38,"context_line":"VIF_TYPE_802_QBH \u003d \u0027802.1qbh\u0027"},{"line_number":39,"context_line":"VIF_TYPE_HW_VEB \u003d \u0027hw_veb\u0027"},{"line_number":40,"context_line":"VIF_TYPE_HOSTDEV_PHY \u003d \u0027hostdev_physical\u0027"},{"line_number":41,"context_line":"VIF_TYPE_IB_HOSTDEV \u003d \u0027ib_hostdev\u0027"},{"line_number":42,"context_line":"VIF_TYPE_MIDONET \u003d \u0027midonet\u0027"},{"line_number":43,"context_line":"VIF_TYPE_VHOSTUSER \u003d \u0027vhostuser\u0027"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa0719c6_463d61ba","line":40,"in_reply_to":"fa0719c6_0b39b441","updated":"2016-03-22 14:32:07.000000000","message":"Done","commit_id":"46e32428cfec9e3923622b516f0b258c93578ed4"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"fca0485d4b05181638f8a79c8915d81147c1402c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"VIF_TYPE_802_QBG \u003d \u0027802.1qbg\u0027"},{"line_number":38,"context_line":"VIF_TYPE_802_QBH \u003d \u0027802.1qbh\u0027"},{"line_number":39,"context_line":"VIF_TYPE_HW_VEB \u003d \u0027hw_veb\u0027"},{"line_number":40,"context_line":"VIF_TYPE_HOSTDEV \u003d \u0027hostdev_physical\u0027"},{"line_number":41,"context_line":"VIF_TYPE_IB_HOSTDEV \u003d \u0027ib_hostdev\u0027"},{"line_number":42,"context_line":"VIF_TYPE_MIDONET \u003d \u0027midonet\u0027"},{"line_number":43,"context_line":"VIF_TYPE_VHOSTUSER \u003d \u0027vhostuser\u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa0719c6_017193e0","line":40,"updated":"2016-03-22 14:47:51.000000000","message":"Can the string just be \u0027hostdev\u0027? :)","commit_id":"0fc1f42f576b12a3bd03200682d5adc6c30d696a"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"fe3f4b60457db8657f3b408cc1e13d5a2d45f6de","unresolved":false,"context_lines":[{"line_number":37,"context_line":"VIF_TYPE_802_QBG \u003d \u0027802.1qbg\u0027"},{"line_number":38,"context_line":"VIF_TYPE_802_QBH \u003d \u0027802.1qbh\u0027"},{"line_number":39,"context_line":"VIF_TYPE_HW_VEB \u003d \u0027hw_veb\u0027"},{"line_number":40,"context_line":"VIF_TYPE_HOSTDEV \u003d \u0027hostdev_physical\u0027"},{"line_number":41,"context_line":"VIF_TYPE_IB_HOSTDEV \u003d \u0027ib_hostdev\u0027"},{"line_number":42,"context_line":"VIF_TYPE_MIDONET \u003d \u0027midonet\u0027"},{"line_number":43,"context_line":"VIF_TYPE_VHOSTUSER \u003d \u0027vhostuser\u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa0719c6_5eac0934","line":40,"in_reply_to":"fa0719c6_017193e0","updated":"2016-03-22 15:16:28.000000000","message":"Not easily - this is already merged in Neutron:\n\nhttps://review.openstack.org/#/c/262604/6/neutron/plugins/ml2/drivers/mech_sriov/mech_driver/mech_driver.py","commit_id":"0fc1f42f576b12a3bd03200682d5adc6c30d696a"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"6992c8a6378e8ba9813eacc57612d4c15f0219fe","unresolved":false,"context_lines":[{"line_number":37,"context_line":"VIF_TYPE_802_QBG \u003d \u0027802.1qbg\u0027"},{"line_number":38,"context_line":"VIF_TYPE_802_QBH \u003d \u0027802.1qbh\u0027"},{"line_number":39,"context_line":"VIF_TYPE_HW_VEB \u003d \u0027hw_veb\u0027"},{"line_number":40,"context_line":"VIF_TYPE_HOSTDEV \u003d \u0027hostdev_physical\u0027"},{"line_number":41,"context_line":"VIF_TYPE_IB_HOSTDEV \u003d \u0027ib_hostdev\u0027"},{"line_number":42,"context_line":"VIF_TYPE_MIDONET \u003d \u0027midonet\u0027"},{"line_number":43,"context_line":"VIF_TYPE_VHOSTUSER \u003d \u0027vhostuser\u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"ba0121b8_49d5ad41","line":40,"in_reply_to":"fa0719c6_5eac0934","updated":"2016-03-29 09:56:54.000000000","message":"Agreed this naming is silly, but I\u0027m not bothered because os-vif is going to make it all obsolete soon. ie we\u0027ll have a VIF_TYPE_OS_VIF which just takes a serialized object, and all these existing VIF_TYPE* will get deprecated \u0026 eventually removed.","commit_id":"0fc1f42f576b12a3bd03200682d5adc6c30d696a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9f147648beac478106649c52312d4ea285c89d89","unresolved":false,"context_lines":[{"line_number":96,"context_line":"VNIC_TYPE_DIRECT_PHYSICAL \u003d \u0027direct-physical\u0027"},{"line_number":97,"context_line":"VNIC_TYPE_BAREMETAL \u003d \u0027baremetal\u0027"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"VNIC_TYPES_SRIOV \u003d (VNIC_TYPE_DIRECT, VNIC_TYPE_MACVTAP)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"# Constants for the \u0027vif_model\u0027 values"},{"line_number":102,"context_line":"VIF_MODEL_VIRTIO \u003d \u0027virtio\u0027"}],"source_content_type":"text/x-python","patch_set":23,"id":"ba0121b8_92407358","line":99,"updated":"2016-03-29 16:42:35.000000000","message":"Should it be in this list also?","commit_id":"32069c8f397e395134c3b1142c2d852640685fef"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"c09ad4759137f40c75758fa0df1eaaf7505ee900","unresolved":false,"context_lines":[{"line_number":96,"context_line":"VNIC_TYPE_DIRECT_PHYSICAL \u003d \u0027direct-physical\u0027"},{"line_number":97,"context_line":"VNIC_TYPE_BAREMETAL \u003d \u0027baremetal\u0027"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"VNIC_TYPES_SRIOV \u003d (VNIC_TYPE_DIRECT, VNIC_TYPE_MACVTAP)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"# Constants for the \u0027vif_model\u0027 values"},{"line_number":102,"context_line":"VIF_MODEL_VIRTIO \u003d \u0027virtio\u0027"}],"source_content_type":"text/x-python","patch_set":23,"id":"ba0121b8_80213e50","line":99,"in_reply_to":"ba0121b8_92407358","updated":"2016-03-29 16:46:36.000000000","message":"It\u0027s part of the next patch - we don\u0027t handle it as a port yet in this one.","commit_id":"32069c8f397e395134c3b1142c2d852640685fef"}],"nova/virt/libvirt/vif.py":[{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"327e696ebcb0241ebf96ff02fd5ac559b021bc6c","unresolved":false,"context_lines":[{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    def get_config_hostdev_physical(self, instance, vif, image_meta,"},{"line_number":334,"context_line":"                                    inst_type, virt_type, host):"},{"line_number":335,"context_line":"        if vif[\u0027vnic_type\u0027] \u003d\u003d network_model.VNIC_TYPE_DIRECT_PHYSICAL:"},{"line_number":336,"context_line":"            return self.get_base_hostdev_pci_config(instance, vif, image_meta,"},{"line_number":337,"context_line":"                                                    inst_type, virt_type)"},{"line_number":338,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_a45034d5","line":335,"range":{"start_line":335,"start_character":8,"end_line":335,"end_character":71},"updated":"2016-01-05 19:39:32.000000000","message":"I  don\u0027t think this is necessary check as neutron hostdev_physical vit type is  only correlate to VNIC_TYPE_DIRECT_PHYSICAL in your neutron commit","commit_id":"34eaf9e4f893d9bbc8af6814770d146e30a8d394"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"50109e380a332ac3516d7c955376b2055e3bcb6d","unresolved":false,"context_lines":[{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    def get_config_hostdev_physical(self, instance, vif, image_meta,"},{"line_number":334,"context_line":"                                    inst_type, virt_type, host):"},{"line_number":335,"context_line":"        if vif[\u0027vnic_type\u0027] \u003d\u003d network_model.VNIC_TYPE_DIRECT_PHYSICAL:"},{"line_number":336,"context_line":"            return self.get_base_hostdev_pci_config(instance, vif, image_meta,"},{"line_number":337,"context_line":"                                                    inst_type, virt_type)"},{"line_number":338,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_6cbac10c","line":335,"range":{"start_line":335,"start_character":8,"end_line":335,"end_character":71},"in_reply_to":"fa69d971_a45034d5","updated":"2016-01-07 17:15:10.000000000","message":"Right - it\u0027s still good to have the check though for the sake of the readers of the code (and yes there are better ways to document stuff like this, but this is how vif drivers work currently)","commit_id":"34eaf9e4f893d9bbc8af6814770d146e30a8d394"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"d5f7ce1193f632d438d11851178063069c2e902c","unresolved":false,"context_lines":[{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    def get_config_hostdev_physical(self, instance, vif, image_meta,"},{"line_number":334,"context_line":"                                    inst_type, virt_type, host):"},{"line_number":335,"context_line":"        if vif[\u0027vnic_type\u0027] \u003d\u003d network_model.VNIC_TYPE_DIRECT_PHYSICAL:"},{"line_number":336,"context_line":"            return self.get_base_hostdev_pci_config(instance, vif, image_meta,"},{"line_number":337,"context_line":"                                                    inst_type, virt_type)"},{"line_number":338,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba63e191_e4c0ac2c","line":335,"updated":"2016-01-20 12:07:23.000000000","message":"you have vif_type, why do you check vnic_type?","commit_id":"58ac67fa030c37869029b14dcc97dd380b6f7de1"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"34fd7e15158e358e392586fa2d7732af134c39a1","unresolved":false,"context_lines":[{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    def get_config_hostdev_physical(self, instance, vif, image_meta,"},{"line_number":334,"context_line":"                                    inst_type, virt_type, host):"},{"line_number":335,"context_line":"        if vif[\u0027vnic_type\u0027] \u003d\u003d network_model.VNIC_TYPE_DIRECT_PHYSICAL:"},{"line_number":336,"context_line":"            return self.get_base_hostdev_pci_config(instance, vif, image_meta,"},{"line_number":337,"context_line":"                                                    inst_type, virt_type)"},{"line_number":338,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"9a68dd71_15067cce","line":335,"in_reply_to":"ba63e191_e4c0ac2c","updated":"2016-01-21 11:55:36.000000000","message":"Yeah probably not really necessary - I think I saw it in one of the other vif drivers. could remove it I guess","commit_id":"58ac67fa030c37869029b14dcc97dd380b6f7de1"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"b0153e55838599fe620b48246765708ffec92eb1","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        return conf"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def get_base_hostdev_pci_config(self, instance, vif, image_meta,"},{"line_number":143,"context_line":"                                    inst_type, virt_type):"},{"line_number":144,"context_line":"        conf \u003d vconfig.LibvirtConfigGuestHostdevPCI()"},{"line_number":145,"context_line":"        pci_slot \u003d vif[\u0027profile\u0027][\u0027pci_slot\u0027]"},{"line_number":146,"context_line":"        designer.set_vif_host_backend_hostdev_pci_config(conf, pci_slot)"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa0719c6_2b363852","line":143,"updated":"2016-03-22 14:20:39.000000000","message":"instance, image_meta, inst_type, and virt_type are all unnecessary parameters. Recommend removing them.","commit_id":"46e32428cfec9e3923622b516f0b258c93578ed4"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"28da42cb64d8ca1142f38b60e216dfe7ad6bcda6","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        return conf"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def get_base_hostdev_pci_config(self, instance, vif, image_meta,"},{"line_number":143,"context_line":"                                    inst_type, virt_type):"},{"line_number":144,"context_line":"        conf \u003d vconfig.LibvirtConfigGuestHostdevPCI()"},{"line_number":145,"context_line":"        pci_slot \u003d vif[\u0027profile\u0027][\u0027pci_slot\u0027]"},{"line_number":146,"context_line":"        designer.set_vif_host_backend_hostdev_pci_config(conf, pci_slot)"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa0719c6_cb669c28","line":143,"in_reply_to":"fa0719c6_2b363852","updated":"2016-03-22 14:32:07.000000000","message":"Done","commit_id":"46e32428cfec9e3923622b516f0b258c93578ed4"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"6992c8a6378e8ba9813eacc57612d4c15f0219fe","unresolved":false,"context_lines":[{"line_number":331,"context_line":"    def get_config_hostdev_physical(self, instance, vif, image_meta,"},{"line_number":332,"context_line":"                                    inst_type, virt_type, host):"},{"line_number":333,"context_line":"        if vif[\u0027vnic_type\u0027] \u003d\u003d network_model.VNIC_TYPE_DIRECT_PHYSICAL:"},{"line_number":334,"context_line":"            return self.get_base_hostdev_pci_config(vif)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"    def get_config_macvtap(self, instance, vif, image_meta,"},{"line_number":337,"context_line":"                           inst_type, virt_type, host):"}],"source_content_type":"text/x-python","patch_set":21,"id":"ba0121b8_29baf923","line":334,"range":{"start_line":334,"start_character":55,"end_line":334,"end_character":56},"updated":"2016-03-29 09:56:54.000000000","message":"Are there other vnic_type values that neutron could supply here ? It seems we should really raise an exception for types we won\u0027t handle, because the calling code will crash \u0026 burn if this condition doesn\u0027t match because we return None implicitly, instead of a config object.","commit_id":"0fc1f42f576b12a3bd03200682d5adc6c30d696a"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"c92c2432b2cf0c623344916f50b6a8f6095a379d","unresolved":false,"context_lines":[{"line_number":331,"context_line":"    def get_config_hostdev_physical(self, instance, vif, image_meta,"},{"line_number":332,"context_line":"                                    inst_type, virt_type, host):"},{"line_number":333,"context_line":"        if vif[\u0027vnic_type\u0027] \u003d\u003d network_model.VNIC_TYPE_DIRECT_PHYSICAL:"},{"line_number":334,"context_line":"            return self.get_base_hostdev_pci_config(vif)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"    def get_config_macvtap(self, instance, vif, image_meta,"},{"line_number":337,"context_line":"                           inst_type, virt_type, host):"}],"source_content_type":"text/x-python","patch_set":21,"id":"ba0121b8_fe06f21e","line":334,"range":{"start_line":334,"start_character":55,"end_line":334,"end_character":56},"in_reply_to":"ba0121b8_29baf923","updated":"2016-03-29 10:58:25.000000000","message":"No currently there are not, however it was possible before the following patch:\n\nhttps://review.openstack.org/#/c/262604/6/neutron/plugins/ml2/drivers/mech_sriov/mech_driver/mech_driver.py\n\nSo I guess it actually does make sense to raise just in case we are running against old neutron ?","commit_id":"0fc1f42f576b12a3bd03200682d5adc6c30d696a"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"fb15f0dc463b79b36d71ddc2ad08f525ca6f2f8f","unresolved":false,"context_lines":[{"line_number":331,"context_line":"    def get_config_hostdev_physical(self, instance, vif, image_meta,"},{"line_number":332,"context_line":"                                    inst_type, virt_type, host):"},{"line_number":333,"context_line":"        if vif[\u0027vnic_type\u0027] \u003d\u003d network_model.VNIC_TYPE_DIRECT_PHYSICAL:"},{"line_number":334,"context_line":"            return self.get_base_hostdev_pci_config(vif)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"    def get_config_macvtap(self, instance, vif, image_meta,"},{"line_number":337,"context_line":"                           inst_type, virt_type, host):"}],"source_content_type":"text/x-python","patch_set":21,"id":"ba0121b8_1452a513","line":334,"range":{"start_line":334,"start_character":55,"end_line":334,"end_character":56},"in_reply_to":"ba0121b8_fe06f21e","updated":"2016-03-29 11:25:21.000000000","message":"Actually looking at this some more - unless we are running against the newer neutron - we won\u0027t even have the proper vif_type to dispatch to this method, so we should probably just remove the check.","commit_id":"0fc1f42f576b12a3bd03200682d5adc6c30d696a"}]}