)]}'
{"nova/network/neutronv2/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b417f72d71f1175774523d18ebf3e62e7ed60db5","unresolved":false,"context_lines":[{"line_number":1070,"context_line":"            pci_request_id \u003d None"},{"line_number":1071,"context_line":"            if vnic_type in network_model.VNIC_TYPES_SRIOV:"},{"line_number":1072,"context_line":"                spec \u003d {pci_request.PCI_NET_TAG: phynet_name}"},{"line_number":1073,"context_line":"                dev_type \u003d pci_request.DEVICE_TYPE_FOR_VNIC_TYPE.get(vnic_type)"},{"line_number":1074,"context_line":"                if dev_type:"},{"line_number":1075,"context_line":"                    spec[pci_request.PCI_DEVICE_TYPE_TAG] \u003d dev_type"},{"line_number":1076,"context_line":"                request \u003d objects.InstancePCIRequest("}],"source_content_type":"text/x-python","patch_set":23,"id":"ba0121b8_af7d4db3","line":1073,"range":{"start_line":1073,"start_character":69,"end_line":1073,"end_character":78},"updated":"2016-03-29 18:40:58.000000000","message":"So if this is \u0027direct-physical\u0027 we get \u0027type-PF\u0027 for the dev_type, where is that constant defined/used in neutron?","commit_id":"fa1f8dc6c7342a190e7c75bca97083c907dfac36"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"53b5a2856a5cbaafaf751b296ba1bfcc976252aa","unresolved":false,"context_lines":[{"line_number":1070,"context_line":"            pci_request_id \u003d None"},{"line_number":1071,"context_line":"            if vnic_type in network_model.VNIC_TYPES_SRIOV:"},{"line_number":1072,"context_line":"                spec \u003d {pci_request.PCI_NET_TAG: phynet_name}"},{"line_number":1073,"context_line":"                dev_type \u003d pci_request.DEVICE_TYPE_FOR_VNIC_TYPE.get(vnic_type)"},{"line_number":1074,"context_line":"                if dev_type:"},{"line_number":1075,"context_line":"                    spec[pci_request.PCI_DEVICE_TYPE_TAG] \u003d dev_type"},{"line_number":1076,"context_line":"                request \u003d objects.InstancePCIRequest("}],"source_content_type":"text/x-python","patch_set":23,"id":"ba0121b8_c392034b","line":1073,"range":{"start_line":1073,"start_character":69,"end_line":1073,"end_character":78},"in_reply_to":"ba0121b8_6a27a064","updated":"2016-03-30 08:30:31.000000000","message":"So type-PF is one of the allowed enum values on the dev_type object field which is used to match available devices when doing claims\n\nhttps://github.com/openstack/nova/blob/281ed64d1a29c27e13500d68a49f44e6049fbdbf/nova/objects/fields.py#L528","commit_id":"fa1f8dc6c7342a190e7c75bca97083c907dfac36"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"58cd18b030ce6681156815bdd259404a371bc3a8","unresolved":false,"context_lines":[{"line_number":1070,"context_line":"            pci_request_id \u003d None"},{"line_number":1071,"context_line":"            if vnic_type in network_model.VNIC_TYPES_SRIOV:"},{"line_number":1072,"context_line":"                spec \u003d {pci_request.PCI_NET_TAG: phynet_name}"},{"line_number":1073,"context_line":"                dev_type \u003d pci_request.DEVICE_TYPE_FOR_VNIC_TYPE.get(vnic_type)"},{"line_number":1074,"context_line":"                if dev_type:"},{"line_number":1075,"context_line":"                    spec[pci_request.PCI_DEVICE_TYPE_TAG] \u003d dev_type"},{"line_number":1076,"context_line":"                request \u003d objects.InstancePCIRequest("}],"source_content_type":"text/x-python","patch_set":23,"id":"ba0121b8_6a27a064","line":1073,"range":{"start_line":1073,"start_character":69,"end_line":1073,"end_character":78},"in_reply_to":"ba0121b8_af7d4db3","updated":"2016-03-29 19:53:31.000000000","message":"Nevermind, I checked the neutron code, that enum isn\u0027t used there, so I\u0027m assuming it\u0027s used somewhere in the bowels of nova, but I\u0027m not familiar with where. Since PCI_DEVICE_TYPE_TAG is new in this change, it must be used later in the series and I just haven\u0027t gotten that far yet.","commit_id":"fa1f8dc6c7342a190e7c75bca97083c907dfac36"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"5272f00b30c025307c22ea3e53d42c223a571156","unresolved":false,"context_lines":[{"line_number":1070,"context_line":"            pci_request_id \u003d None"},{"line_number":1071,"context_line":"            if vnic_type in network_model.VNIC_TYPES_SRIOV:"},{"line_number":1072,"context_line":"                spec \u003d {pci_request.PCI_NET_TAG: phynet_name}"},{"line_number":1073,"context_line":"                dev_type \u003d pci_request.DEVICE_TYPE_FOR_VNIC_TYPE.get(vnic_type)"},{"line_number":1074,"context_line":"                if dev_type:"},{"line_number":1075,"context_line":"                    spec[pci_request.PCI_DEVICE_TYPE_TAG] \u003d dev_type"},{"line_number":1076,"context_line":"                request \u003d objects.InstancePCIRequest("},{"line_number":1077,"context_line":"                    count\u003d1,"},{"line_number":1078,"context_line":"                    spec\u003d[spec],"}],"source_content_type":"text/x-python","patch_set":24,"id":"ba0121b8_f76ecc2d","line":1075,"range":{"start_line":1073,"start_character":0,"end_line":1075,"end_character":68},"updated":"2016-03-30 12:33:46.000000000","message":"maybe you should add a comment that you need the dev_type\nonly for direct-physical or maybe you can add the dev_type of direct/macvtap ports (type-VF) as well. (although it not used in direct/macvtap)\n\nby the way why not adding the dev_type to the pci_request object? (assuming that pci request is mapped to the same type of pci devices)","commit_id":"969a0c5a3037dd02a2d9682cd42ca400a97aefe3"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"ae3b85c6e0df41cd93f6336c7047489ba0f677ed","unresolved":false,"context_lines":[{"line_number":1070,"context_line":"            pci_request_id \u003d None"},{"line_number":1071,"context_line":"            if vnic_type in network_model.VNIC_TYPES_SRIOV:"},{"line_number":1072,"context_line":"                spec \u003d {pci_request.PCI_NET_TAG: phynet_name}"},{"line_number":1073,"context_line":"                dev_type \u003d pci_request.DEVICE_TYPE_FOR_VNIC_TYPE.get(vnic_type)"},{"line_number":1074,"context_line":"                if dev_type:"},{"line_number":1075,"context_line":"                    spec[pci_request.PCI_DEVICE_TYPE_TAG] \u003d dev_type"},{"line_number":1076,"context_line":"                request \u003d objects.InstancePCIRequest("},{"line_number":1077,"context_line":"                    count\u003d1,"},{"line_number":1078,"context_line":"                    spec\u003d[spec],"}],"source_content_type":"text/x-python","patch_set":24,"id":"ba0121b8_f1740a37","line":1075,"range":{"start_line":1073,"start_character":0,"end_line":1075,"end_character":68},"in_reply_to":"ba0121b8_f76ecc2d","updated":"2016-03-30 15:46:39.000000000","message":"\u003e maybe you should add a comment that you need the dev_type only for direct-physical or maybe you can add the dev_type of direct/macvtap ports (type-VF) as well. (although it not used in direct/macvtap)\n\nCurrently filtering out non-PF devices is hard coded in the PCI manager so we do not need to add type-VF\n\nhttps://github.com/openstack/nova/blob/f15d9a9693b19393fcde84cf4bc6f044d39ffdca/nova/pci/stats.py#L254\n\n\u003e by the way why not adding the dev_type to the pci_request object? (assuming that pci request is mapped to the same type of pci devices)\n\nNot sure I understand the question, but currently pci_request objects work by matching the spec attribute as a dict. Not brilliant - I agree, but hardly something we want to re-architect as part of this effort","commit_id":"969a0c5a3037dd02a2d9682cd42ca400a97aefe3"}]}