)]}'
{"nova/tests/unit/virt/xenapi/test_vm_utils.py":[{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"264b5cdd40e99b418b7c95749da7f04c59192786","unresolved":false,"context_lines":[{"line_number":1456,"context_line":"        self.assertEqual((\"k\", None), result)"},{"line_number":1457,"context_line":""},{"line_number":1458,"context_line":"    def _test_create_kernel_and_ramdisk(self, cache_images):"},{"line_number":1459,"context_line":"        instance \u003d {\u0027system_metadata\u0027: {\u0027image_cache_in_nova\u0027: True}}"},{"line_number":1460,"context_line":"        self.flags(cache_images\u003dcache_images, group\u003d\u0027xenserver\u0027)"},{"line_number":1461,"context_line":""},{"line_number":1462,"context_line":"        was \u003d {\u0027called\u0027: None}"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_e7f15bcf","line":1459,"updated":"2016-02-15 10:40:39.000000000","message":"Both instance[\u0027kernel_id\u0027] and instance[\u0027ramdisk_id\u0027] is None; I think the function which you touch won\u0027t be invoked at all.","commit_id":"849900eed472962815468058bb46691d696f38fa"},{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"264b5cdd40e99b418b7c95749da7f04c59192786","unresolved":false,"context_lines":[{"line_number":1464,"context_line":"        def fake_create_cached_image(*args):"},{"line_number":1465,"context_line":"            was[\u0027called\u0027] \u003d \u0027all\u0027"},{"line_number":1466,"context_line":"            return (False, {})"},{"line_number":1467,"context_line":"        self.stubs.Set(vm_utils, \u0027_create_cached_image\u0027,"},{"line_number":1468,"context_line":"                       fake_create_cached_image)"},{"line_number":1469,"context_line":""},{"line_number":1470,"context_line":"        def fake_fetch_disk_image(*args):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_079a7f14","line":1467,"updated":"2016-02-15 10:40:39.000000000","message":"confused by this stub; but I think you needn\u0027t track too deep but check if session.call_plugin(\u0027kernel\u0027, \u0027create_kernel_ramdisk\u0027, args) gets invoked?","commit_id":"849900eed472962815468058bb46691d696f38fa"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"ff4acc1665b19ead7621f7305036bf4c71c841f2","unresolved":false,"context_lines":[{"line_number":1459,"context_line":"        instance \u003d {\u0027system_metadata\u0027: {\u0027image_cache_in_nova\u0027: True}}"},{"line_number":1460,"context_line":"        self.flags(cache_images\u003dcache_images, group\u003d\u0027xenserver\u0027)"},{"line_number":1461,"context_line":""},{"line_number":1462,"context_line":"        was \u003d {\u0027called\u0027: None}"},{"line_number":1463,"context_line":""},{"line_number":1464,"context_line":"        def fake_call_plugin(*args):"},{"line_number":1465,"context_line":"            was[\u0027called\u0027] \u003d \u0027all\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_e6180187","line":1462,"updated":"2016-02-16 13:18:45.000000000","message":"just use a images_cached\u003dNone","commit_id":"b6ebb0fec3a648c08693af3d86b8f7cf2925938d"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"ff4acc1665b19ead7621f7305036bf4c71c841f2","unresolved":false,"context_lines":[{"line_number":1462,"context_line":"        was \u003d {\u0027called\u0027: None}"},{"line_number":1463,"context_line":""},{"line_number":1464,"context_line":"        def fake_call_plugin(*args):"},{"line_number":1465,"context_line":"            was[\u0027called\u0027] \u003d \u0027all\u0027"},{"line_number":1466,"context_line":"            return \"filename\""},{"line_number":1467,"context_line":"        self.stubs.Set(self.session, \u0027call_plugin\u0027,"},{"line_number":1468,"context_line":"                       fake_call_plugin)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_e92612b9","line":1465,"updated":"2016-02-16 13:18:45.000000000","message":"images_cached \u003d True","commit_id":"b6ebb0fec3a648c08693af3d86b8f7cf2925938d"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"ff4acc1665b19ead7621f7305036bf4c71c841f2","unresolved":false,"context_lines":[{"line_number":1472,"context_line":"        self.stubs.Set(uuid, \u0027uuid4\u0027, fake_uuid4)"},{"line_number":1473,"context_line":""},{"line_number":1474,"context_line":"        def fake_fetch_disk_image(*args):"},{"line_number":1475,"context_line":"            was[\u0027called\u0027] \u003d \u0027none\u0027"},{"line_number":1476,"context_line":"            return {}"},{"line_number":1477,"context_line":"        self.stubs.Set(vm_utils, \u0027_fetch_disk_image\u0027,"},{"line_number":1478,"context_line":"                       fake_fetch_disk_image)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_29211aa0","line":1475,"updated":"2016-02-16 13:18:45.000000000","message":"images_cached \u003d False","commit_id":"b6ebb0fec3a648c08693af3d86b8f7cf2925938d"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"ff4acc1665b19ead7621f7305036bf4c71c841f2","unresolved":false,"context_lines":[{"line_number":1480,"context_line":"        vm_utils._create_kernel_image(self.context, self.session, instance,"},{"line_number":1481,"context_line":"                              \u0027foo\u0027, \u0027bar\u0027, \u0027baz\u0027)"},{"line_number":1482,"context_line":""},{"line_number":1483,"context_line":"        self.assertEqual(was[\u0027called\u0027], cache_images)"},{"line_number":1484,"context_line":""},{"line_number":1485,"context_line":"    def test_create_kernel_image_cached(self):"},{"line_number":1486,"context_line":"        self._test_create_kernel_image(\u0027all\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_a9ba4a21","line":1483,"updated":"2016-02-16 13:18:45.000000000","message":"if cache_images \u003d\u003d \u0027all\u0027:\n  self.assertEqual(True, images_cached)\nelse:\n  self.assertEqual(False, images_cached)","commit_id":"b6ebb0fec3a648c08693af3d86b8f7cf2925938d"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"ff4acc1665b19ead7621f7305036bf4c71c841f2","unresolved":false,"context_lines":[{"line_number":1482,"context_line":""},{"line_number":1483,"context_line":"        self.assertEqual(was[\u0027called\u0027], cache_images)"},{"line_number":1484,"context_line":""},{"line_number":1485,"context_line":"    def test_create_kernel_image_cached(self):"},{"line_number":1486,"context_line":"        self._test_create_kernel_image(\u0027all\u0027)"},{"line_number":1487,"context_line":""},{"line_number":1488,"context_line":"    def test_create_kernel_image_uncached(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_69732281","line":1485,"updated":"2016-02-16 13:18:45.000000000","message":"The method needs to distinguish from the previous similarly named tests.\nPerhaps test_create_kernel_image_cached_config and test_create_kernel_image_uncached_config?","commit_id":"b6ebb0fec3a648c08693af3d86b8f7cf2925938d"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"4759d36348b1ae74f62fc5755e080ef724c61684","unresolved":false,"context_lines":[{"line_number":1477,"context_line":"        self.stubs.Set(vm_utils, \u0027_fetch_disk_image\u0027,"},{"line_number":1478,"context_line":"                       fake_fetch_disk_image)"},{"line_number":1479,"context_line":""},{"line_number":1480,"context_line":"        vm_utils._create_kernel_image(self.context, self.session, instance,"},{"line_number":1481,"context_line":"                                      \u0027foo\u0027, \u0027bar\u0027, \u0027baz\u0027)"},{"line_number":1482,"context_line":""},{"line_number":1483,"context_line":"        if cache_images \u003d\u003d \u0027all\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_3394a441","line":1480,"updated":"2016-02-17 14:37:26.000000000","message":"Actually I realised that you\u0027re not using mox here to verify the tests.  You need to follow the mox pattern of:\n1) Set up stubs\n2) \"Call\" expected methods (stubs)\n3) invoke self.mox.ReplayAll()\n4) Call the method your testing.\n\nIn this case, after setting the stubs, I think you need to check cache_images and invoke either fake_call_plugin or fake_fetch_disk_image\nThen do the replay all\nFinally invokve vm_utils._create_kernel_image\n\nMox will do all the testing for you.","commit_id":"366aeec11d0ac570c6e7625579cada913856c1aa"}],"nova/virt/xenapi/vm_utils.py":[{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"821b4987fdd39a136644370218decc34b52bd9a5","unresolved":false,"context_lines":[{"line_number":1182,"context_line":"    Returns: A list of dictionaries that describe VDIs"},{"line_number":1183,"context_line":"    \"\"\""},{"line_number":1184,"context_line":"    filename \u003d \"\""},{"line_number":1185,"context_line":"    if CONF.xenserver.cache_images.lower() !\u003d \u0027none\u0027:"},{"line_number":1186,"context_line":"        args \u003d {}"},{"line_number":1187,"context_line":"        args[\u0027cached-image\u0027] \u003d image_id"},{"line_number":1188,"context_line":"        args[\u0027new-image-uuid\u0027] \u003d str(uuid.uuid4())"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_b55bdcf5","line":1185,"updated":"2016-01-04 02:26:19.000000000","message":"Understood to disable cache by changing the configure to \u0027none\u0027; Just wondering if there is any doc impacting to record such configuration.","commit_id":"3f2bb1db66e7178d7f74c7c6f03079fbdedd7982"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"63619663f227da757ca55dbe36e2f12f04ba47f6","unresolved":false,"context_lines":[{"line_number":1182,"context_line":"    Returns: A list of dictionaries that describe VDIs"},{"line_number":1183,"context_line":"    \"\"\""},{"line_number":1184,"context_line":"    filename \u003d \"\""},{"line_number":1185,"context_line":"    if CONF.xenserver.cache_images.lower() !\u003d \u0027none\u0027:"},{"line_number":1186,"context_line":"        args \u003d {}"},{"line_number":1187,"context_line":"        args[\u0027cached-image\u0027] \u003d image_id"},{"line_number":1188,"context_line":"        args[\u0027new-image-uuid\u0027] \u003d str(uuid.uuid4())"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_6696f9f1","line":1185,"in_reply_to":"fa69d971_02e93e14","updated":"2016-01-04 19:19:05.000000000","message":"This seems extraordinarily goofy and unexpected. I\u0027d really like to only do this fix as part of a change that makes this show up as a real None here.","commit_id":"3f2bb1db66e7178d7f74c7c6f03079fbdedd7982"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"075fb57ddb2645288d88a1dd8ac168e0da6bb367","unresolved":false,"context_lines":[{"line_number":1182,"context_line":"    Returns: A list of dictionaries that describe VDIs"},{"line_number":1183,"context_line":"    \"\"\""},{"line_number":1184,"context_line":"    filename \u003d \"\""},{"line_number":1185,"context_line":"    if CONF.xenserver.cache_images.lower() !\u003d \u0027none\u0027:"},{"line_number":1186,"context_line":"        args \u003d {}"},{"line_number":1187,"context_line":"        args[\u0027cached-image\u0027] \u003d image_id"},{"line_number":1188,"context_line":"        args[\u0027new-image-uuid\u0027] \u003d str(uuid.uuid4())"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_6f5eb045","line":1185,"in_reply_to":"fa69d971_6696f9f1","updated":"2016-01-05 11:30:29.000000000","message":"Ok, I\u0027m fine with none as a string comparison, but the lower here seems odd, that should be removed.","commit_id":"3f2bb1db66e7178d7f74c7c6f03079fbdedd7982"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"6ca8e9ae34705bcf25cb898a6f3af1cd8149d825","unresolved":false,"context_lines":[{"line_number":1182,"context_line":"    Returns: A list of dictionaries that describe VDIs"},{"line_number":1183,"context_line":"    \"\"\""},{"line_number":1184,"context_line":"    filename \u003d \"\""},{"line_number":1185,"context_line":"    if CONF.xenserver.cache_images.lower() !\u003d \u0027none\u0027:"},{"line_number":1186,"context_line":"        args \u003d {}"},{"line_number":1187,"context_line":"        args[\u0027cached-image\u0027] \u003d image_id"},{"line_number":1188,"context_line":"        args[\u0027new-image-uuid\u0027] \u003d str(uuid.uuid4())"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_02e93e14","line":1185,"in_reply_to":"fa69d971_b55bdcf5","updated":"2016-01-04 11:26:54.000000000","message":"No docimpact - the documentation will be correct, based on the parameter config at line 65.  This fix just makes it work according to the documentation","commit_id":"3f2bb1db66e7178d7f74c7c6f03079fbdedd7982"}]}