)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ff4ac5ed1972a7d4771364b01212048f9d8ffdc0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deprecated option \u0027mkisofs_cmd\u0027 for removal"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"DocUpgrade:We only support `genisoimage` command for config option"},{"line_number":10,"context_line":"mkisofs_cmd, and hardcode its argument in code, so we don\u0027t"},{"line_number":11,"context_line":"support to customize the command which creates ISO image and"},{"line_number":12,"context_line":"remove the config option in N release."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3afc51ec_b2d01a55","line":9,"updated":"2016-03-12 15:52:17.000000000","message":"There is no DocUpgrade tag, you\u0027re probably mixing DocImpact and UpgradeImpact.\n\nYou probably don\u0027t need a DocImpact tag for this, but probably need a release note (using reno) in this change and put a note in the deprecations section of the release note.","commit_id":"53a760050c0ad0ff2899ab5b73b6d900d6b2f81b"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"7ec3b51f6ef9d99b1b5b7961a4377503fccd1b2e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deprecated option \u0027mkisofs_cmd\u0027 for removal"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"DocUpgrade:We only support `genisoimage` command for config option"},{"line_number":10,"context_line":"mkisofs_cmd, and hardcode its argument in code, so we don\u0027t"},{"line_number":11,"context_line":"support to customize the command which creates ISO image and"},{"line_number":12,"context_line":"remove the config option in N release."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa0719c6_9b5b21f6","line":9,"in_reply_to":"3afc51ec_b2d01a55","updated":"2016-03-23 11:29:36.000000000","message":"Done","commit_id":"53a760050c0ad0ff2899ab5b73b6d900d6b2f81b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"62cd0071dd765f39649b96122e95f3b5fb9d7a48","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-03-08 15:41:37 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deprecated option \u0027mkisofs_cmd\u0027 for removal"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"DocUpgrade:We only support `genisoimage` command for config option"},{"line_number":10,"context_line":"mkisofs_cmd, and hardcode its argument in code, so we don\u0027t"},{"line_number":11,"context_line":"support to customize the command which creates ISO image and"},{"line_number":12,"context_line":"remove the config option in N release."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ic1b97009fcfa3e07eab523de9a25656d069d0331"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5aef4532_5b8075c0","line":12,"range":{"start_line":8,"start_character":0,"end_line":12,"end_character":38},"updated":"2016-03-09 13:27:25.000000000","message":"nit: put this below the Change-Id","commit_id":"53a760050c0ad0ff2899ab5b73b6d900d6b2f81b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ff4ac5ed1972a7d4771364b01212048f9d8ffdc0","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-03-08 15:41:37 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deprecated option \u0027mkisofs_cmd\u0027 for removal"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"DocUpgrade:We only support `genisoimage` command for config option"},{"line_number":10,"context_line":"mkisofs_cmd, and hardcode its argument in code, so we don\u0027t"},{"line_number":11,"context_line":"support to customize the command which creates ISO image and"},{"line_number":12,"context_line":"remove the config option in N release."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ic1b97009fcfa3e07eab523de9a25656d069d0331"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3afc51ec_32deca6d","line":12,"range":{"start_line":8,"start_character":0,"end_line":12,"end_character":38},"in_reply_to":"5aef4532_5b8075c0","updated":"2016-03-12 15:52:17.000000000","message":"Why?","commit_id":"53a760050c0ad0ff2899ab5b73b6d900d6b2f81b"}],"nova/conf/configdrive.py":[{"author":{"_account_id":8989,"name":"xiao pei liu","email":"lxiaopei@vmware.com","username":"liuxpei"},"change_message_id":"87c4f18286cb37b1d83adef1e39d85a9cf25f575","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        deprecated_reason\u003d\u0027We only support command genisoimage and \u0027"},{"line_number":34,"context_line":"                          \u0027hardcode its argument in code, it is \u0027"},{"line_number":35,"context_line":"                          \u0027unnecessary to make it configurable, \u0027"},{"line_number":36,"context_line":"                          \u0027will remove the config option in O release.\u0027,"},{"line_number":37,"context_line":"        help\u003d\"\"\""},{"line_number":38,"context_line":"DEPRECATED: Name and optionally path of the tool used for ISO image creation"},{"line_number":39,"context_line":"\"\"\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a1b2928_c74b7e58","line":36,"range":{"start_line":36,"start_character":62,"end_line":36,"end_character":69},"updated":"2016-04-11 09:34:29.000000000","message":"in O release or N release? is it a typo?","commit_id":"8f6a495d4cab06379c9021e97f779f39d69df980"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"3091282d58b342bd4351641bf0959c85cd105c42","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        deprecated_reason\u003d\u0027We only support command genisoimage and \u0027"},{"line_number":34,"context_line":"                          \u0027hardcode its argument in code, it is \u0027"},{"line_number":35,"context_line":"                          \u0027unnecessary to make it configurable, \u0027"},{"line_number":36,"context_line":"                          \u0027will remove the config option in O release.\u0027,"},{"line_number":37,"context_line":"        help\u003d\"\"\""},{"line_number":38,"context_line":"DEPRECATED: Name and optionally path of the tool used for ISO image creation"},{"line_number":39,"context_line":"\"\"\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_77b2a807","line":36,"range":{"start_line":36,"start_character":62,"end_line":36,"end_character":69},"in_reply_to":"1a122d0e_90595701","updated":"2016-04-19 12:32:42.000000000","message":"Done","commit_id":"8f6a495d4cab06379c9021e97f779f39d69df980"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e80aab6204fbda5c8bfeaf6c70f695ffb8599b0a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        deprecated_reason\u003d\u0027We only support command genisoimage and \u0027"},{"line_number":34,"context_line":"                          \u0027hardcode its argument in code, it is \u0027"},{"line_number":35,"context_line":"                          \u0027unnecessary to make it configurable, \u0027"},{"line_number":36,"context_line":"                          \u0027will remove the config option in O release.\u0027,"},{"line_number":37,"context_line":"        help\u003d\"\"\""},{"line_number":38,"context_line":"DEPRECATED: Name and optionally path of the tool used for ISO image creation"},{"line_number":39,"context_line":"\"\"\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_90595701","line":36,"range":{"start_line":36,"start_character":62,"end_line":36,"end_character":69},"in_reply_to":"5a18252c_3e6528e1","updated":"2016-04-19 09:09:47.000000000","message":"Shall we use release numbers instead of release names?","commit_id":"8f6a495d4cab06379c9021e97f779f39d69df980"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"e9afd9a135946cf7bc67cfb96a524937d90f2a38","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        deprecated_reason\u003d\u0027We only support command genisoimage and \u0027"},{"line_number":34,"context_line":"                          \u0027hardcode its argument in code, it is \u0027"},{"line_number":35,"context_line":"                          \u0027unnecessary to make it configurable, \u0027"},{"line_number":36,"context_line":"                          \u0027will remove the config option in O release.\u0027,"},{"line_number":37,"context_line":"        help\u003d\"\"\""},{"line_number":38,"context_line":"DEPRECATED: Name and optionally path of the tool used for ISO image creation"},{"line_number":39,"context_line":"\"\"\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a18252c_3e6528e1","line":36,"range":{"start_line":36,"start_character":62,"end_line":36,"end_character":69},"in_reply_to":"7a1b2928_c74b7e58","updated":"2016-04-12 03:03:21.000000000","message":"In O release. We deprecate it in N release, and remove it in O release.","commit_id":"8f6a495d4cab06379c9021e97f779f39d69df980"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ec268f4772f9cc90eadfe7ed3fe5b3d6a3fa021e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                          \u0027unnecessary to make it configurable, \u0027"},{"line_number":36,"context_line":"                          \u0027will remove the config option in O release.\u0027,"},{"line_number":37,"context_line":"        help\u003d\"\"\""},{"line_number":38,"context_line":"DEPRECATED: Name and optionally path of the tool used for ISO image creation"},{"line_number":39,"context_line":"\"\"\")"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"ALL_OPTS \u003d [config_drive_format_opt,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_7d029470","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":12},"updated":"2016-04-19 08:57:52.000000000","message":"nit: This doesn\u0027t really need to be there, seeing as the help text contains \u0027This option is deprecated for removal\u0027.","commit_id":"8f6a495d4cab06379c9021e97f779f39d69df980"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"3091282d58b342bd4351641bf0959c85cd105c42","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                          \u0027unnecessary to make it configurable, \u0027"},{"line_number":36,"context_line":"                          \u0027will remove the config option in O release.\u0027,"},{"line_number":37,"context_line":"        help\u003d\"\"\""},{"line_number":38,"context_line":"DEPRECATED: Name and optionally path of the tool used for ISO image creation"},{"line_number":39,"context_line":"\"\"\")"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"ALL_OPTS \u003d [config_drive_format_opt,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_57b7acf4","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":12},"in_reply_to":"1a122d0e_7d029470","updated":"2016-04-19 12:32:42.000000000","message":"Done","commit_id":"8f6a495d4cab06379c9021e97f779f39d69df980"}],"nova/virt/configdrive.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bab25218417c9d49953ec3d559a9b75832c6b660","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    cfg.StrOpt(\u0027mkisofs_cmd\u0027,"},{"line_number":43,"context_line":"               default\u003d\u0027genisoimage\u0027,"},{"line_number":44,"context_line":"               deprecated_for_removal\u003d\u0027True\u0027,"},{"line_number":45,"context_line":"               help\u003d\u0027DEPRECATED:Name and optionally path of the tool used for \u0027"},{"line_number":46,"context_line":"                    \u0027ISO image creation\u0027)"},{"line_number":47,"context_line":"    ]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_1cc9bf78","line":46,"range":{"start_line":45,"start_character":20,"end_line":46,"end_character":40},"updated":"2016-01-28 15:46:11.000000000","message":"Can you provide a \u0027deprecated_reason\u0027 parameter explaining reason for this removal?\n\n    http://docs.openstack.org/developer/oslo.config/opts.html\n\nShould be same as reno file?","commit_id":"ddca5722a7cc31d8fe0bbbdcd1c18b8335d182ed"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"92cefc62cc7f87842982f64afcfb882d16a8ea31","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    cfg.StrOpt(\u0027mkisofs_cmd\u0027,"},{"line_number":43,"context_line":"               default\u003d\u0027genisoimage\u0027,"},{"line_number":44,"context_line":"               deprecated_for_removal\u003d\u0027True\u0027,"},{"line_number":45,"context_line":"               help\u003d\u0027DEPRECATED:Name and optionally path of the tool used for \u0027"},{"line_number":46,"context_line":"                    \u0027ISO image creation\u0027)"},{"line_number":47,"context_line":"    ]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_fdf4b687","line":46,"range":{"start_line":45,"start_character":20,"end_line":46,"end_character":40},"in_reply_to":"7a5de9d1_1cc9bf78","updated":"2016-01-29 09:02:42.000000000","message":"Done","commit_id":"ddca5722a7cc31d8fe0bbbdcd1c18b8335d182ed"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1b7bc9ccd212ec7d8074f81d25b8af7192bfc388","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                default\u003dFalse),"},{"line_number":38,"context_line":"    cfg.StrOpt(\u0027mkisofs_cmd\u0027,"},{"line_number":39,"context_line":"               default\u003d\u0027genisoimage\u0027,"},{"line_number":40,"context_line":"               deprecated_for_removal\u003d\u0027True\u0027,"},{"line_number":41,"context_line":"               deprecated_reason\u003d\u0027We only support command genisoimage and \u0027"},{"line_number":42,"context_line":"                                 \u0027hardcode its argument in code, it is \u0027"},{"line_number":43,"context_line":"                                 \u0027unnecessary to make it configurable, \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_b6fe58ac","line":40,"range":{"start_line":40,"start_character":38,"end_line":40,"end_character":44},"updated":"2016-01-29 10:50:09.000000000","message":"Should this not be a boolean rather than a string?","commit_id":"af851081da517d624b1035b42de9dbff91ccce87"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"21b5a8d19584bddf12c83cd24cb357c9c8b5d18d","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                default\u003dFalse),"},{"line_number":38,"context_line":"    cfg.StrOpt(\u0027mkisofs_cmd\u0027,"},{"line_number":39,"context_line":"               default\u003d\u0027genisoimage\u0027,"},{"line_number":40,"context_line":"               deprecated_for_removal\u003d\u0027True\u0027,"},{"line_number":41,"context_line":"               deprecated_reason\u003d\u0027We only support command genisoimage and \u0027"},{"line_number":42,"context_line":"                                 \u0027hardcode its argument in code, it is \u0027"},{"line_number":43,"context_line":"                                 \u0027unnecessary to make it configurable, \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_fa7fb8a8","line":40,"range":{"start_line":40,"start_character":38,"end_line":40,"end_character":44},"in_reply_to":"7a5de9d1_b6fe58ac","updated":"2016-01-29 21:36:45.000000000","message":"+1","commit_id":"af851081da517d624b1035b42de9dbff91ccce87"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"e53296e6bc669c1775da270f773736b51b3baace","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                default\u003dFalse),"},{"line_number":38,"context_line":"    cfg.StrOpt(\u0027mkisofs_cmd\u0027,"},{"line_number":39,"context_line":"               default\u003d\u0027genisoimage\u0027,"},{"line_number":40,"context_line":"               deprecated_for_removal\u003d\u0027True\u0027,"},{"line_number":41,"context_line":"               deprecated_reason\u003d\u0027We only support command genisoimage and \u0027"},{"line_number":42,"context_line":"                                 \u0027hardcode its argument in code, it is \u0027"},{"line_number":43,"context_line":"                                 \u0027unnecessary to make it configurable, \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_2e2cc049","line":40,"range":{"start_line":40,"start_character":38,"end_line":40,"end_character":44},"in_reply_to":"7a5de9d1_fa7fb8a8","updated":"2016-02-26 02:50:03.000000000","message":"Done","commit_id":"af851081da517d624b1035b42de9dbff91ccce87"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"21b5a8d19584bddf12c83cd24cb357c9c8b5d18d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"               deprecated_reason\u003d\u0027We only support command genisoimage and \u0027"},{"line_number":42,"context_line":"                                 \u0027hardcode its argument in code, it is \u0027"},{"line_number":43,"context_line":"                                 \u0027unnecessary to make it configurable, \u0027"},{"line_number":44,"context_line":"                                 \u0027will remove the config option in N release.\u0027,"},{"line_number":45,"context_line":"               help\u003d\u0027DEPRECATED:Name and optionally path of the tool used for \u0027"},{"line_number":46,"context_line":"                    \u0027ISO image creation\u0027)"},{"line_number":47,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_ba338013","line":44,"range":{"start_line":44,"start_character":68,"end_line":44,"end_character":69},"updated":"2016-01-29 21:36:45.000000000","message":"nit: maybe we can say 14.0 according to release number?","commit_id":"af851081da517d624b1035b42de9dbff91ccce87"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1b7bc9ccd212ec7d8074f81d25b8af7192bfc388","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                                 \u0027hardcode its argument in code, it is \u0027"},{"line_number":43,"context_line":"                                 \u0027unnecessary to make it configurable, \u0027"},{"line_number":44,"context_line":"                                 \u0027will remove the config option in N release.\u0027,"},{"line_number":45,"context_line":"               help\u003d\u0027DEPRECATED:Name and optionally path of the tool used for \u0027"},{"line_number":46,"context_line":"                    \u0027ISO image creation\u0027)"},{"line_number":47,"context_line":"    ]"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_d6fbd4bf","line":45,"range":{"start_line":45,"start_character":21,"end_line":45,"end_character":31},"updated":"2016-01-29 10:50:09.000000000","message":"I don\u0027t think this part is necessary - it should be added automatically. Maybe check with \u0027tox -e genconfig\u0027?","commit_id":"af851081da517d624b1035b42de9dbff91ccce87"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"e53296e6bc669c1775da270f773736b51b3baace","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                                 \u0027hardcode its argument in code, it is \u0027"},{"line_number":43,"context_line":"                                 \u0027unnecessary to make it configurable, \u0027"},{"line_number":44,"context_line":"                                 \u0027will remove the config option in N release.\u0027,"},{"line_number":45,"context_line":"               help\u003d\u0027DEPRECATED:Name and optionally path of the tool used for \u0027"},{"line_number":46,"context_line":"                    \u0027ISO image creation\u0027)"},{"line_number":47,"context_line":"    ]"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_893ea6b6","line":45,"range":{"start_line":45,"start_character":21,"end_line":45,"end_character":31},"in_reply_to":"7a5de9d1_9a3ec4d8","updated":"2016-02-26 02:50:03.000000000","message":"A statement like \n\"# This option is deprecated for removal\n# Its value may be silently ignored in the future\"\n\nwill be added if we set deprecated_for_removal \u003d True.","commit_id":"af851081da517d624b1035b42de9dbff91ccce87"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"21b5a8d19584bddf12c83cd24cb357c9c8b5d18d","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                                 \u0027hardcode its argument in code, it is \u0027"},{"line_number":43,"context_line":"                                 \u0027unnecessary to make it configurable, \u0027"},{"line_number":44,"context_line":"                                 \u0027will remove the config option in N release.\u0027,"},{"line_number":45,"context_line":"               help\u003d\u0027DEPRECATED:Name and optionally path of the tool used for \u0027"},{"line_number":46,"context_line":"                    \u0027ISO image creation\u0027)"},{"line_number":47,"context_line":"    ]"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_9a3ec4d8","line":45,"range":{"start_line":45,"start_character":21,"end_line":45,"end_character":31},"in_reply_to":"7a5de9d1_d6fbd4bf","updated":"2016-01-29 21:36:45.000000000","message":"you mean help string? guess it\u0027s needed?","commit_id":"af851081da517d624b1035b42de9dbff91ccce87"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3bb3553fef43b1847ba389de9f9cb1736b4c3cd5","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                                 \u0027hardcode its argument in code, it is \u0027"},{"line_number":43,"context_line":"                                 \u0027unnecessary to make it configurable, \u0027"},{"line_number":44,"context_line":"                                 \u0027will remove the config option in N release.\u0027,"},{"line_number":45,"context_line":"               help\u003d\u0027DEPRECATED: Name and optionally path of the tool used for\u0027"},{"line_number":46,"context_line":"                    \u0027 ISO image creation\u0027)"},{"line_number":47,"context_line":"    ]"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a061dce_5d690b8b","line":45,"range":{"start_line":45,"start_character":21,"end_line":45,"end_character":33},"updated":"2016-04-04 08:33:11.000000000","message":"This is not needed, IIRC. This prefix will be automatically added. You can test this with tox:\n\n    tox -e genconfig","commit_id":"603cdd5c86bd715b5aa336f9109514d664ff2bb9"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"2721352f993fe0cc5956fb9d89d33f827c758310","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                                 \u0027hardcode its argument in code, it is \u0027"},{"line_number":43,"context_line":"                                 \u0027unnecessary to make it configurable, \u0027"},{"line_number":44,"context_line":"                                 \u0027will remove the config option in N release.\u0027,"},{"line_number":45,"context_line":"               help\u003d\u0027DEPRECATED: Name and optionally path of the tool used for\u0027"},{"line_number":46,"context_line":"                    \u0027 ISO image creation\u0027)"},{"line_number":47,"context_line":"    ]"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a1b2928_760065ab","line":45,"range":{"start_line":45,"start_character":21,"end_line":45,"end_character":33},"in_reply_to":"9a061dce_5d690b8b","updated":"2016-04-11 07:40:10.000000000","message":"Do you mean https://github.com/openstack/oslo.config/blob/master/oslo_config/generator.py#L216 ?\n\nit doesn\u0027t set Opt\u0027s deprecated_opts, this is deprecated_for_removal, see https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L763","commit_id":"603cdd5c86bd715b5aa336f9109514d664ff2bb9"}],"releasenotes/notes/deprecated_for_removal_mkisofs_cmd-a1e4d5f77c60605a.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d9f430d304120aae6305530730788e2b0a00d802","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - We only support `genisoimage` command for config option"},{"line_number":4,"context_line":"    mkisofs_cmd, and hardcode its argument in code, so we don\u0027t"},{"line_number":5,"context_line":"    support to customize the command which creates ISO image and"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3afc51ec_52bc3605","line":2,"updated":"2016-03-12 15:53:19.000000000","message":"Seems this belongs under the \u0027deprecations\u0027 section rather than upgrade.","commit_id":"53a760050c0ad0ff2899ab5b73b6d900d6b2f81b"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"7ec3b51f6ef9d99b1b5b7961a4377503fccd1b2e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - We only support `genisoimage` command for config option"},{"line_number":4,"context_line":"    mkisofs_cmd, and hardcode its argument in code, so we don\u0027t"},{"line_number":5,"context_line":"    support to customize the command which creates ISO image and"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa0719c6_7b39eda3","line":2,"in_reply_to":"3afc51ec_52bc3605","updated":"2016-03-23 11:29:36.000000000","message":"Done","commit_id":"53a760050c0ad0ff2899ab5b73b6d900d6b2f81b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3bb3553fef43b1847ba389de9f9cb1736b4c3cd5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - We only support `genisoimage` command for config option"},{"line_number":4,"context_line":"    mkisofs_cmd, and hardcode its argument in code, so we don\u0027t"},{"line_number":5,"context_line":"    support to customize the command which creates ISO image and"},{"line_number":6,"context_line":"    remove the config option in N release."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9a061dce_1d1dd30f","line":6,"range":{"start_line":3,"start_character":4,"end_line":6,"end_character":42},"updated":"2016-04-04 08:33:11.000000000","message":"I don\u0027t understand what this means when viewed in isolation. Say it in a simpler way, like \"The `genisoimage` value is deprecated: this value is now hardcoded\" or similar.","commit_id":"603cdd5c86bd715b5aa336f9109514d664ff2bb9"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"2721352f993fe0cc5956fb9d89d33f827c758310","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - We only support `genisoimage` command for config option"},{"line_number":4,"context_line":"    mkisofs_cmd, and hardcode its argument in code, so we don\u0027t"},{"line_number":5,"context_line":"    support to customize the command which creates ISO image and"},{"line_number":6,"context_line":"    remove the config option in N release."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7a1b2928_f6b8f5e7","line":6,"range":{"start_line":3,"start_character":4,"end_line":6,"end_character":42},"in_reply_to":"9a061dce_1d1dd30f","updated":"2016-04-11 07:40:10.000000000","message":"No, we are deprecated config option for mkisofs_cmd . not its value.","commit_id":"603cdd5c86bd715b5aa336f9109514d664ff2bb9"}]}