)]}'
{"nova/cmd/baremetal_deploy_helper.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"b663ec971eccbe1873171315ffd1f9ac4b5e09b1","unresolved":false,"context_lines":[{"line_number":314,"context_line":"    config.parse_args(sys.argv)"},{"line_number":315,"context_line":"    logging.setup(\"nova\")"},{"line_number":316,"context_line":"    global LOG"},{"line_number":317,"context_line":"    LOG \u003d logging.getLogger(\u0027nova.virt.baremetal.deploy_helper\u0027)"},{"line_number":318,"context_line":"    app \u003d BareMetalDeploy()"},{"line_number":319,"context_line":"    srv \u003d simple_server.make_server(\u0027\u0027, 10000, app)"},{"line_number":320,"context_line":"    srv.serve_forever()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2F5u8%3D","line":317,"updated":"2013-04-12 06:13:02.000000000","message":"Why not just move this to after line 42, and remove  316?","commit_id":"152e460a004e55dd02e6e8363401302da3bd43b4"},{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"b09f7f4c7263bddab73a8d46f21f2bf8bb4a8abf","unresolved":false,"context_lines":[{"line_number":314,"context_line":"    config.parse_args(sys.argv)"},{"line_number":315,"context_line":"    logging.setup(\"nova\")"},{"line_number":316,"context_line":"    global LOG"},{"line_number":317,"context_line":"    LOG \u003d logging.getLogger(\u0027nova.virt.baremetal.deploy_helper\u0027)"},{"line_number":318,"context_line":"    app \u003d BareMetalDeploy()"},{"line_number":319,"context_line":"    srv \u003d simple_server.make_server(\u0027\u0027, 10000, app)"},{"line_number":320,"context_line":"    srv.serve_forever()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2F5uc%3D","line":317,"in_reply_to":"AAAAOn%2F%2F5u8%3D","updated":"2013-04-12 06:34:21.000000000","message":"As said in https://review.openstack.org/#/c/25553, we should call logging.getLogger() after logging.setup(). I\u0027m following the way used in dhcpbridge.\n\nhttps://review.openstack.org/#/c/25553/13/nova/cmd/dhcpbridge.py","commit_id":"152e460a004e55dd02e6e8363401302da3bd43b4"}]}