)]}'
{"id":"openstack%2Fnova~26287","triplet_id":"openstack%2Fnova~master~I2607802dcbed64135f75011a02ebce95519e4ea1","project":"openstack/nova","branch":"master","topic":"bug/1165262","hashtags":[],"change_id":"I2607802dcbed64135f75011a02ebce95519e4ea1","subject":"Define LOG globally in baremetal_deploy_helper","status":"MERGED","created":"2013-04-06 01:09:50.000000000","updated":"2013-04-12 18:57:16.000000000","submitted":"2013-04-12 18:57:13.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"702a191148d5a1139fa34a7ab5baa5aad0a3c8f5","_number":26287,"virtual_id_number":26287,"owner":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"value":0,"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},{"value":1,"date":"2013-04-06 01:28:52.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":2,"date":"2013-04-12 18:57:13.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"all":[{"value":0,"date":"2013-04-12 05:03:10.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},{"value":2,"date":"2013-04-12 17:05:32.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":2,"date":"2013-04-12 14:37:07.000000000","_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"value":0,"date":"2013-04-12 06:13:02.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":1,"date":"2013-04-07 23:51:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":1,"date":"2013-04-12 16:47:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"all":[{"value":0,"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},{"value":1,"date":"2013-04-12 17:05:32.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"date":"2013-04-11 19:05:19.000000000","_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"value":0,"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"value":0,"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-04-06 01:28:52.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2013-04-07 23:51:46.000000000","updated_by":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"reviewer":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"state":"REVIEWER"},{"updated":"2013-04-11 19:05:19.000000000","updated_by":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"reviewer":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"state":"REVIEWER"},{"updated":"2013-04-12 06:13:02.000000000","updated_by":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"reviewer":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"state":"REVIEWER"},{"updated":"2013-04-12 16:47:05.000000000","updated_by":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"reviewer":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"state":"REVIEWER"},{"updated":"2013-04-12 17:05:32.000000000","updated_by":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"reviewer":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"state":"REVIEWER"},{"updated":"2013-04-12 18:57:13.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"a3291398870e8ddb1056be43b386a55abc7c6671","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-04-06 01:28:52.000000000","message":"Patch Set 1: Works for me\n\nSmokeStack Results (patch set 1):\n\tLibvirt (Fedora 18) Success: http://smokestack.openstack.org/?go\u003d/jobs/81795\n\tXenServer 5.6 (F18 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/81796\n","accounts_in_message":[],"_revision_number":1},{"id":"78da871bd27dcc698e41f1b8aced9c11a2426341","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-06 01:52:41.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/26287/1/check/gate-nova-pep8/24158 : SUCCESS\n- http://logs.openstack.org/26287/1/check/gate-nova-docs/18403 : SUCCESS\n- http://logs.openstack.org/26287/1/check/gate-nova-python26/19811 : SUCCESS\n- http://logs.openstack.org/26287/1/check/gate-nova-python26-rhel6/489 : SUCCESS (non-voting)\n- http://logs.openstack.org/26287/1/check/gate-nova-python27/19899 : SUCCESS\n- http://logs.openstack.org/26287/1/check/gate-tempest-devstack-vm-full/11771 : SUCCESS\n- http://logs.openstack.org/26287/1/check/gate-tempest-devstack-vm-postgres-full/11486 : SUCCESS\n- http://logs.openstack.org/26287/1/check/gate-tempest-devstack-vm-quantum/17526 : SUCCESS\n- http://logs.openstack.org/26287/1/check/gate-nova-pylint/10193 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"b83f1445c66ddd886ac82b7531a9e8562ae66427","author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"date":"2013-04-07 23:51:46.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nlgtm","accounts_in_message":[],"_revision_number":1},{"id":"714bcfc6221b3e0fb28aa968f01c3c0c0050e74c","author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"date":"2013-04-11 19:05:19.000000000","message":"Patch Set 1:\n\nThis global LOG seems to have been rejected when it was previously suggested by dims, here:\n\nhttps://review.openstack.org/#/c/25553/6/bin/nova-baremetal-deploy-helper\n\nWas that comment in error?\n\nIt appears to be necessary to set it at the module scope here precisely to fix the bug that Arata reported, and this patch LGTM. I\u0027m just trying to understand the history of this change","accounts_in_message":[],"_revision_number":1},{"id":"ecbf937b7305bb64260502f681e1e28a3ea20ef4","author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"date":"2013-04-12 05:03:10.000000000","message":"Patch Set 1:\n\n@Devananda: global was not needed until the PatchSet 10, where if-block was altered to \"def main()\".","accounts_in_message":[],"_revision_number":1},{"id":"b663ec971eccbe1873171315ffd1f9ac4b5e09b1","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-04-12 06:13:02.000000000","message":"Patch Set 1: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"b09f7f4c7263bddab73a8d46f21f2bf8bb4a8abf","author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"date":"2013-04-12 06:34:21.000000000","message":"Patch Set 1: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"8ff68a04dd1012b0ffedfd5a021bb7a5c28c5f83","author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"date":"2013-04-12 14:37:07.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n@Arata, ah, I see. Thanks for pointing that out :)","accounts_in_message":[],"_revision_number":1},{"id":"9136aa1406d48b0138fc63810ac5f7ab70b4fe04","author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"date":"2013-04-12 16:47:05.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"140ae0dd9557cd8ae534713bbc7169a199c85f86","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2013-04-12 17:05:32.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"d20ed96b7270bf1be00b41759c7cda312d5f3196","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-12 17:05:37.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"2b780baf009ca6c3dde343f3458338dd7008447c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-12 18:57:13.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/26287/1/gate/gate-nova-docs/18720/doc/build/html/ : SUCCESS\n- http://logs.openstack.org/26287/1/gate/gate-nova-pep8/24502 : SUCCESS\n- http://logs.openstack.org/26287/1/gate/gate-nova-python26/20128 : SUCCESS\n- http://logs.openstack.org/26287/1/gate/gate-nova-python27/20216 : SUCCESS\n- http://logs.openstack.org/26287/1/gate/gate-tempest-devstack-vm-full/12529 : SUCCESS\n- http://logs.openstack.org/26287/1/gate/gate-tempest-devstack-vm-postgres-full/12244 : SUCCESS\n- http://logs.openstack.org/26287/1/gate/gate-tempest-devstack-vm-quantum/18376 : SUCCESS\n- http://logs.openstack.org/26287/1/gate/gate-grenade-devstack-vm/476 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"9a39b8ba6d49bc1e6280f374f332ebcdd23f0079","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-12 18:57:16.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"152e460a004e55dd02e6e8363401302da3bd43b4","revisions":{"152e460a004e55dd02e6e8363401302da3bd43b4":{"kind":"REWORK","_number":1,"created":"2013-04-06 01:09:50.000000000","uploader":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"ref":"refs/changes/87/26287/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/87/26287/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/26287/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/26287/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/26287/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/87/26287/1"}}},"commit":{"parents":[{"commit":"24582abf82842cbb922e38c78e281eda56f981e2","subject":"Allow describe_instances to use tags for searches","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/24582abf82842cbb922e38c78e281eda56f981e2"}]}],"author":{"name":"Arata Notsu","email":"notsu@virtualtech.jp","date":"2013-04-06 00:57:33.000000000","tz":540},"committer":{"name":"Arata Notsu","email":"notsu@virtualtech.jp","date":"2013-04-06 00:57:33.000000000","tz":540},"subject":"Define LOG globally in baremetal_deploy_helper","message":"Define LOG globally in baremetal_deploy_helper\n\nSince LOG \u003d getLogger() has been moved from the global scope\nto the function scope (main), the rest of the module could\nnot find LOG. This patch makes LOG global again.\n\nFixes bug 1165262\n\nChange-Id: I2607802dcbed64135f75011a02ebce95519e4ea1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/152e460a004e55dd02e6e8363401302da3bd43b4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/152e460a004e55dd02e6e8363401302da3bd43b4"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"24582abf82842cbb922e38c78e281eda56f981e2","is_merged_in_target_branch":true,"change_id":"If2622c4dacbdd3a53fd6d49242225692da8b741a","change_number":23258,"patch_set_number":14,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}