)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"14bcd8e9499fe13823008b4b2d17a893cdda9839","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch adds option in nova.conf to ignore the"},{"line_number":10,"context_line":"user input for instance name and set the display_name"},{"line_number":11,"context_line":"same as the instance_name. It also add the relevant"},{"line_number":12,"context_line":"code to set instace display_name to instance_name."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: blueprint instance-display-name"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa69d971_d40c0bef","line":12,"updated":"2016-01-05 13:45:42.000000000","message":"typo: instance","commit_id":"a48312f5606aeacfe5a8d2dcf7177966d416c9fb"},{"author":{"_account_id":9178,"name":"Sayali Lunkad","email":"sayali.lunkad@suse.com","username":"sayalilunkad"},"change_message_id":"544cb98520fbed4760157bfba005c79742fdca47","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch adds option in nova.conf to ignore the"},{"line_number":10,"context_line":"user input for instance name and set the display_name"},{"line_number":11,"context_line":"same as the instance_name. It also add the relevant"},{"line_number":12,"context_line":"code to set instace display_name to instance_name."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: blueprint instance-display-name"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa69d971_34cd6766","line":12,"in_reply_to":"fa69d971_d40c0bef","updated":"2016-01-05 13:51:37.000000000","message":"Done","commit_id":"a48312f5606aeacfe5a8d2dcf7177966d416c9fb"}],"nova/compute/api.py":[{"author":{"_account_id":16016,"name":"Fahri Cihan Demirci","email":"cihand@skyatlas.com","username":"cihand"},"change_message_id":"010ff27864efa85b8e569770e6c814fd2266739b","unresolved":false,"context_lines":[{"line_number":1423,"context_line":"            # the UUID from the instance."},{"line_number":1424,"context_line":"            instance \u003d self._apply_instance_name_template(context, instance,"},{"line_number":1425,"context_line":"                                                          index)"},{"line_number":1426,"context_line":"        elif CONF.instance_display_name \u003d\u003d 1:"},{"line_number":1427,"context_line":"            # instance_name_template is used to assign instance_name as"},{"line_number":1428,"context_line":"            # display_name for instance if set in config file."},{"line_number":1429,"context_line":"            instance \u003d self._apply_instance_name_template_for_display_name("}],"source_content_type":"text/x-python","patch_set":8,"id":"da6ed579_e9385af1","line":1426,"updated":"2016-01-14 09:47:39.000000000","message":"Since this value is expected to be a boolean now, I think it may be better you only make a boolean comparison.","commit_id":"39a3d6a4efd6c67eac091921da4f52dbe268cd74"},{"author":{"_account_id":9178,"name":"Sayali Lunkad","email":"sayali.lunkad@suse.com","username":"sayalilunkad"},"change_message_id":"c14748f319f5eed27716f45552e9d47a317445f8","unresolved":false,"context_lines":[{"line_number":1423,"context_line":"            # the UUID from the instance."},{"line_number":1424,"context_line":"            instance \u003d self._apply_instance_name_template(context, instance,"},{"line_number":1425,"context_line":"                                                          index)"},{"line_number":1426,"context_line":"        elif CONF.instance_display_name \u003d\u003d 1:"},{"line_number":1427,"context_line":"            # instance_name_template is used to assign instance_name as"},{"line_number":1428,"context_line":"            # display_name for instance if set in config file."},{"line_number":1429,"context_line":"            instance \u003d self._apply_instance_name_template_for_display_name("}],"source_content_type":"text/x-python","patch_set":8,"id":"da6ed579_8442e566","line":1426,"in_reply_to":"da6ed579_e9385af1","updated":"2016-01-14 10:03:14.000000000","message":"Done","commit_id":"39a3d6a4efd6c67eac091921da4f52dbe268cd74"},{"author":{"_account_id":16016,"name":"Fahri Cihan Demirci","email":"cihand@skyatlas.com","username":"cihand"},"change_message_id":"c73275b518a1cd15c83c8d59f77a5f807bdc278c","unresolved":false,"context_lines":[{"line_number":1423,"context_line":"            # the UUID from the instance."},{"line_number":1424,"context_line":"            instance \u003d self._apply_instance_name_template(context, instance,"},{"line_number":1425,"context_line":"                                                          index)"},{"line_number":1426,"context_line":"        elif CONF.set_instance_display_name_as_instance_name is True:"},{"line_number":1427,"context_line":"            # instance_name_template is used to assign instance_name as"},{"line_number":1428,"context_line":"            # display_name for instance if set in config file."},{"line_number":1429,"context_line":"            instance \u003d self._apply_instance_name_template_for_display_name("}],"source_content_type":"text/x-python","patch_set":9,"id":"da6ed579_ff6a4c80","line":1426,"updated":"2016-01-14 10:13:24.000000000","message":"\u0027is True\u0027 is not needed here;\n\nelif CONF.set_instance_display_name_as_instance_name:\n\nshould do the same thing.","commit_id":"f7b7a2a7770105712a78693c71435c8af78fda27"},{"author":{"_account_id":9178,"name":"Sayali Lunkad","email":"sayali.lunkad@suse.com","username":"sayalilunkad"},"change_message_id":"1c161e3afb98c7e4e9d1c3508bb32970737d1483","unresolved":false,"context_lines":[{"line_number":1423,"context_line":"            # the UUID from the instance."},{"line_number":1424,"context_line":"            instance \u003d self._apply_instance_name_template(context, instance,"},{"line_number":1425,"context_line":"                                                          index)"},{"line_number":1426,"context_line":"        elif CONF.set_instance_display_name_as_instance_name is True:"},{"line_number":1427,"context_line":"            # instance_name_template is used to assign instance_name as"},{"line_number":1428,"context_line":"            # display_name for instance if set in config file."},{"line_number":1429,"context_line":"            instance \u003d self._apply_instance_name_template_for_display_name("}],"source_content_type":"text/x-python","patch_set":9,"id":"da6ed579_1fee40b4","line":1426,"in_reply_to":"da6ed579_ff6a4c80","updated":"2016-01-14 10:27:07.000000000","message":"Done","commit_id":"f7b7a2a7770105712a78693c71435c8af78fda27"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"70524a1f7764889b1e1c413def56031ceb1f3790","unresolved":false,"context_lines":[{"line_number":574,"context_line":"            self, context, instance):"},{"line_number":575,"context_line":"        try:"},{"line_number":576,"context_line":"            new_name \u003d (CONF.instance_name_template %"},{"line_number":577,"context_line":"                        instance[\u0027id\u0027])"},{"line_number":578,"context_line":"        except (ValueError, TypeError):"},{"line_number":579,"context_line":"            LOG.exception(_LE(\u0027Failed to set instance name using \u0027"},{"line_number":580,"context_line":"                              \u0027instance_name_template.\u0027))"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_baeb8212","line":577,"updated":"2016-01-14 10:32:12.000000000","message":"Now an \u0027instance\u0027 is an object.\nSo instance.id would be better instead of instance[\u0027id\u0027].","commit_id":"c52ae29c1c6d0206042dccb62303f3d12ee5f4b1"},{"author":{"_account_id":9178,"name":"Sayali Lunkad","email":"sayali.lunkad@suse.com","username":"sayalilunkad"},"change_message_id":"9b5cdfd6e0504bb97cb6247213ddea165ee68a8d","unresolved":false,"context_lines":[{"line_number":574,"context_line":"            self, context, instance):"},{"line_number":575,"context_line":"        try:"},{"line_number":576,"context_line":"            new_name \u003d (CONF.instance_name_template %"},{"line_number":577,"context_line":"                        instance[\u0027id\u0027])"},{"line_number":578,"context_line":"        except (ValueError, TypeError):"},{"line_number":579,"context_line":"            LOG.exception(_LE(\u0027Failed to set instance name using \u0027"},{"line_number":580,"context_line":"                              \u0027instance_name_template.\u0027))"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_feefa984","line":577,"in_reply_to":"da6ed579_baeb8212","updated":"2016-01-14 12:05:40.000000000","message":"Done","commit_id":"c52ae29c1c6d0206042dccb62303f3d12ee5f4b1"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"70524a1f7764889b1e1c413def56031ceb1f3790","unresolved":false,"context_lines":[{"line_number":578,"context_line":"        except (ValueError, TypeError):"},{"line_number":579,"context_line":"            LOG.exception(_LE(\u0027Failed to set instance name using \u0027"},{"line_number":580,"context_line":"                              \u0027instance_name_template.\u0027))"},{"line_number":581,"context_line":"            new_name \u003d instance[\u0027display_name\u0027]"},{"line_number":582,"context_line":"        instance.display_name \u003d new_name"},{"line_number":583,"context_line":"        instance.save()"},{"line_number":584,"context_line":"        return instance"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_daf0b600","line":581,"updated":"2016-01-14 10:32:12.000000000","message":"ditto","commit_id":"c52ae29c1c6d0206042dccb62303f3d12ee5f4b1"},{"author":{"_account_id":9178,"name":"Sayali Lunkad","email":"sayali.lunkad@suse.com","username":"sayalilunkad"},"change_message_id":"9b5cdfd6e0504bb97cb6247213ddea165ee68a8d","unresolved":false,"context_lines":[{"line_number":578,"context_line":"        except (ValueError, TypeError):"},{"line_number":579,"context_line":"            LOG.exception(_LE(\u0027Failed to set instance name using \u0027"},{"line_number":580,"context_line":"                              \u0027instance_name_template.\u0027))"},{"line_number":581,"context_line":"            new_name \u003d instance[\u0027display_name\u0027]"},{"line_number":582,"context_line":"        instance.display_name \u003d new_name"},{"line_number":583,"context_line":"        instance.save()"},{"line_number":584,"context_line":"        return instance"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_fe96c9ee","line":581,"in_reply_to":"da6ed579_daf0b600","updated":"2016-01-14 12:05:40.000000000","message":"Done","commit_id":"c52ae29c1c6d0206042dccb62303f3d12ee5f4b1"}],"nova/db/api.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"9b5e2ef5f8b744423409f0dcceed444e104c3ef6","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    cfg.StrOpt(\u0027snapshot_name_template\u0027,"},{"line_number":46,"context_line":"               default\u003d\u0027snapshot-%s\u0027,"},{"line_number":47,"context_line":"               help\u003d\u0027Template string to be used to generate snapshot names\u0027),"},{"line_number":48,"context_line":"    cfg.IntOpt(\u0027instance_display_name\u0027,"},{"line_number":49,"context_line":"               default\u003d0,"},{"line_number":50,"context_line":"               help\u003d\u0027To set instance display_name as instance_name\u0027),"},{"line_number":51,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_47ae3d82","line":48,"updated":"2016-01-14 04:22:57.000000000","message":"BoolOpt would be better instead of IntOpt.","commit_id":"ffe13457f68934d736c2d4f471515673f478b7b9"},{"author":{"_account_id":9178,"name":"Sayali Lunkad","email":"sayali.lunkad@suse.com","username":"sayalilunkad"},"change_message_id":"b42340db711eefd89d5a6cffcdbc3a9c0e11b98f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    cfg.StrOpt(\u0027snapshot_name_template\u0027,"},{"line_number":46,"context_line":"               default\u003d\u0027snapshot-%s\u0027,"},{"line_number":47,"context_line":"               help\u003d\u0027Template string to be used to generate snapshot names\u0027),"},{"line_number":48,"context_line":"    cfg.IntOpt(\u0027instance_display_name\u0027,"},{"line_number":49,"context_line":"               default\u003d0,"},{"line_number":50,"context_line":"               help\u003d\u0027To set instance display_name as instance_name\u0027),"},{"line_number":51,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_298c327e","line":48,"in_reply_to":"da6ed579_47ae3d82","updated":"2016-01-14 09:37:52.000000000","message":"Done","commit_id":"ffe13457f68934d736c2d4f471515673f478b7b9"},{"author":{"_account_id":16016,"name":"Fahri Cihan Demirci","email":"cihand@skyatlas.com","username":"cihand"},"change_message_id":"010ff27864efa85b8e569770e6c814fd2266739b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    cfg.StrOpt(\u0027snapshot_name_template\u0027,"},{"line_number":46,"context_line":"               default\u003d\u0027snapshot-%s\u0027,"},{"line_number":47,"context_line":"               help\u003d\u0027Template string to be used to generate snapshot names\u0027),"},{"line_number":48,"context_line":"    cfg.BoolOpt(\u0027instance_display_name\u0027,"},{"line_number":49,"context_line":"               default\u003d0,"},{"line_number":50,"context_line":"               help\u003d\u0027To set instance display_name as instance_name\u0027),"},{"line_number":51,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":8,"id":"da6ed579_c9beb664","line":48,"updated":"2016-01-14 09:47:39.000000000","message":"The name of the config key could be more descriptive, like \u0027instance_display_name_same_as_instance_name\u0027 for example.","commit_id":"39a3d6a4efd6c67eac091921da4f52dbe268cd74"},{"author":{"_account_id":9178,"name":"Sayali Lunkad","email":"sayali.lunkad@suse.com","username":"sayalilunkad"},"change_message_id":"c14748f319f5eed27716f45552e9d47a317445f8","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    cfg.StrOpt(\u0027snapshot_name_template\u0027,"},{"line_number":46,"context_line":"               default\u003d\u0027snapshot-%s\u0027,"},{"line_number":47,"context_line":"               help\u003d\u0027Template string to be used to generate snapshot names\u0027),"},{"line_number":48,"context_line":"    cfg.BoolOpt(\u0027instance_display_name\u0027,"},{"line_number":49,"context_line":"               default\u003d0,"},{"line_number":50,"context_line":"               help\u003d\u0027To set instance display_name as instance_name\u0027),"},{"line_number":51,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":8,"id":"da6ed579_2454591f","line":48,"in_reply_to":"da6ed579_c9beb664","updated":"2016-01-14 10:03:14.000000000","message":"Done","commit_id":"39a3d6a4efd6c67eac091921da4f52dbe268cd74"},{"author":{"_account_id":16016,"name":"Fahri Cihan Demirci","email":"cihand@skyatlas.com","username":"cihand"},"change_message_id":"010ff27864efa85b8e569770e6c814fd2266739b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"               default\u003d\u0027snapshot-%s\u0027,"},{"line_number":47,"context_line":"               help\u003d\u0027Template string to be used to generate snapshot names\u0027),"},{"line_number":48,"context_line":"    cfg.BoolOpt(\u0027instance_display_name\u0027,"},{"line_number":49,"context_line":"               default\u003d0,"},{"line_number":50,"context_line":"               help\u003d\u0027To set instance display_name as instance_name\u0027),"},{"line_number":51,"context_line":"]"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"da6ed579_4942c6af","line":49,"updated":"2016-01-14 09:47:39.000000000","message":"Since you switched this option to a BoolOpt, it would be better if its default value is a boolean.","commit_id":"39a3d6a4efd6c67eac091921da4f52dbe268cd74"},{"author":{"_account_id":9178,"name":"Sayali Lunkad","email":"sayali.lunkad@suse.com","username":"sayalilunkad"},"change_message_id":"c14748f319f5eed27716f45552e9d47a317445f8","unresolved":false,"context_lines":[{"line_number":46,"context_line":"               default\u003d\u0027snapshot-%s\u0027,"},{"line_number":47,"context_line":"               help\u003d\u0027Template string to be used to generate snapshot names\u0027),"},{"line_number":48,"context_line":"    cfg.BoolOpt(\u0027instance_display_name\u0027,"},{"line_number":49,"context_line":"               default\u003d0,"},{"line_number":50,"context_line":"               help\u003d\u0027To set instance display_name as instance_name\u0027),"},{"line_number":51,"context_line":"]"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"da6ed579_642571bf","line":49,"in_reply_to":"da6ed579_4942c6af","updated":"2016-01-14 10:03:14.000000000","message":"Done. thanks!","commit_id":"39a3d6a4efd6c67eac091921da4f52dbe268cd74"}]}