)]}'
{"nova/service.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"63e3302c5ba7823ad95a300817c8a5f3f2e304c1","unresolved":false,"context_lines":[{"line_number":73,"context_line":"               help\u003d\u0027The port on which the EC2 API will listen.\u0027),"},{"line_number":74,"context_line":"    cfg.IntOpt(\u0027ec2_workers\u0027,"},{"line_number":75,"context_line":"               help\u003d\u0027Number of workers for EC2 API service. The default will \u0027"},{"line_number":76,"context_line":"                    \u0027be equal to the number of CPUs available.\u0027),"},{"line_number":77,"context_line":"    cfg.StrOpt(\u0027osapi_compute_listen\u0027,"},{"line_number":78,"context_line":"               default\u003d\"0.0.0.0\","},{"line_number":79,"context_line":"               help\u003d\u0027The IP address on which the OpenStack API will listen.\u0027),"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa69d971_2251e2d8","side":"PARENT","line":76,"updated":"2016-01-08 14:19:55.000000000","message":"oh dear, these were not technically deprecated... I am going to ignore that.","commit_id":"b3879bd199036a9327a32d7c7cacdff3a9c9807d"}],"nova/tests/unit/api/test_validator.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"0fb4237e51594e04d021e0870723851e91cf0358","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            \u0027attribute\u0027: \u0027foobar\u0027"},{"line_number":96,"context_line":"        }"},{"line_number":97,"context_line":"        self.assertTrue(validator.validate(expect_pass,"},{"line_number":98,"context_line":"                                           validator.DEFAULT_VALIDATOR))"},{"line_number":99,"context_line":"        expect_fail \u003d {"},{"line_number":100,"context_line":"            \u0027attribute\u0027: 0"},{"line_number":101,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_04d495ba","side":"PARENT","line":98,"range":{"start_line":98,"start_character":53,"end_line":98,"end_character":70},"updated":"2016-01-06 01:06:48.000000000","message":"DEFAULT_VALIDATOR was only for ec2, the name is tricky..\n\nThis removal itself is good for me, anyways.","commit_id":"bdae7ff95a0f6d4c2ed721f1bece908c14a80e7e"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"988c3af6b6298d75b4481f15deb87c0e711fc5ce","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            \u0027attribute\u0027: \u0027foobar\u0027"},{"line_number":96,"context_line":"        }"},{"line_number":97,"context_line":"        self.assertTrue(validator.validate(expect_pass,"},{"line_number":98,"context_line":"                                           validator.DEFAULT_VALIDATOR))"},{"line_number":99,"context_line":"        expect_fail \u003d {"},{"line_number":100,"context_line":"            \u0027attribute\u0027: 0"},{"line_number":101,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_1f2e2243","side":"PARENT","line":98,"range":{"start_line":98,"start_character":53,"end_line":98,"end_character":70},"in_reply_to":"fa69d971_04d495ba","updated":"2016-01-06 01:30:25.000000000","message":"right. since we don\u0027t use it anywhere else, removed this test.","commit_id":"bdae7ff95a0f6d4c2ed721f1bece908c14a80e7e"}],"nova/tests/unit/image/test_glance.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"0fb4237e51594e04d021e0870723851e91cf0358","unresolved":false,"context_lines":[{"line_number":386,"context_line":"    @mock.patch(\u0027glanceclient.Client\u0027)"},{"line_number":387,"context_line":"    def test_create_glance_client_with_ssl(self, client_mock,"},{"line_number":388,"context_line":"                                           ssl_enable_mock):"},{"line_number":389,"context_line":"        sslutils.register_opts(CONF)"},{"line_number":390,"context_line":"        self.flags(ca_file\u003d\u0027foo.cert\u0027, cert_file\u003d\u0027bar.cert\u0027,"},{"line_number":391,"context_line":"                   key_file\u003d\u0027wut.key\u0027, group\u003d\u0027ssl\u0027)"},{"line_number":392,"context_line":"        ctxt \u003d mock.sentinel.ctx"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_2465191d","line":389,"range":{"start_line":389,"start_character":8,"end_line":389,"end_character":36},"updated":"2016-01-06 01:06:48.000000000","message":"Why do we need to add this here?","commit_id":"532d66eacedf578bb5706d821bbaa792cd324fb9"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"988c3af6b6298d75b4481f15deb87c0e711fc5ce","unresolved":false,"context_lines":[{"line_number":386,"context_line":"    @mock.patch(\u0027glanceclient.Client\u0027)"},{"line_number":387,"context_line":"    def test_create_glance_client_with_ssl(self, client_mock,"},{"line_number":388,"context_line":"                                           ssl_enable_mock):"},{"line_number":389,"context_line":"        sslutils.register_opts(CONF)"},{"line_number":390,"context_line":"        self.flags(ca_file\u003d\u0027foo.cert\u0027, cert_file\u003d\u0027bar.cert\u0027,"},{"line_number":391,"context_line":"                   key_file\u003d\u0027wut.key\u0027, group\u003d\u0027ssl\u0027)"},{"line_number":392,"context_line":"        ctxt \u003d mock.sentinel.ctx"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_9fd0d220","line":389,"range":{"start_line":389,"start_character":8,"end_line":389,"end_character":36},"in_reply_to":"fa69d971_2465191d","updated":"2016-01-06 01:30:25.000000000","message":"If you see https://review.openstack.org/#/c/263368/11/nova/api/ec2/__init__.py line 84 in the old file, sslutils.is_enabled is called there. which in turn calls sslutils.register_opts and hence we did not need this line earlier.\n\nIf i don\u0027t add sslutils.register_opts the self.flags call will fail as oslo.config will throw an error saying those things are not registered (ca_file etc).\n\nAlso note that _glanceclient_from_endpoint calls oslo_service.sslutils.is_enabled (which we explicitly mock in this test!). So we need the explicit register_opts","commit_id":"532d66eacedf578bb5706d821bbaa792cd324fb9"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f5d99e9e8df50e31f2af226a6c7f8dd53f980af2","unresolved":false,"context_lines":[{"line_number":386,"context_line":"    @mock.patch(\u0027glanceclient.Client\u0027)"},{"line_number":387,"context_line":"    def test_create_glance_client_with_ssl(self, client_mock,"},{"line_number":388,"context_line":"                                           ssl_enable_mock):"},{"line_number":389,"context_line":"        sslutils.register_opts(CONF)"},{"line_number":390,"context_line":"        self.flags(ca_file\u003d\u0027foo.cert\u0027, cert_file\u003d\u0027bar.cert\u0027,"},{"line_number":391,"context_line":"                   key_file\u003d\u0027wut.key\u0027, group\u003d\u0027ssl\u0027)"},{"line_number":392,"context_line":"        ctxt \u003d mock.sentinel.ctx"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_bfa27697","line":389,"range":{"start_line":389,"start_character":8,"end_line":389,"end_character":36},"in_reply_to":"fa69d971_9fd0d220","updated":"2016-01-06 01:32:21.000000000","message":"Ok, thanks for your explanation.","commit_id":"532d66eacedf578bb5706d821bbaa792cd324fb9"}]}