)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"2935c0e83406bccfe6b041ee67cfdd3eecc54a43","unresolved":false,"context_lines":[{"line_number":647,"context_line":"                            \u0027from the live_migration_flag config option \u0027"},{"line_number":648,"context_line":"                            \u0027because it will cause all live-migrations to be \u0027"},{"line_number":649,"context_line":"                            \u0027block-migrations instead.\u0027))"},{"line_number":650,"context_line":"            live_migration_flags \u0026\u003d ~libvirt.VIR_MIGRATE_NON_SHARED_INC"},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"        if (block_migration_flags \u0026 libvirt.VIR_MIGRATE_NON_SHARED_INC) \u003d\u003d 0:"},{"line_number":653,"context_line":"            LOG.warning(_LW(\u0027Adding the VIR_MIGRATE_NON_SHARED_INC flag to \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_75093231","line":650,"updated":"2016-01-27 11:40:28.000000000","message":"nit: since we know the flag is there, it feels like -\u003d would be simpler? It avoids any width problems with ~","commit_id":"3b63f8e32fd223b62f9035a5659679d9542fb6ac"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"a0b8d9ab034015fa851c43639f8283ec031e7814","unresolved":false,"context_lines":[{"line_number":647,"context_line":"                            \u0027from the live_migration_flag config option \u0027"},{"line_number":648,"context_line":"                            \u0027because it will cause all live-migrations to be \u0027"},{"line_number":649,"context_line":"                            \u0027block-migrations instead.\u0027))"},{"line_number":650,"context_line":"            live_migration_flags \u0026\u003d ~libvirt.VIR_MIGRATE_NON_SHARED_INC"},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"        if (block_migration_flags \u0026 libvirt.VIR_MIGRATE_NON_SHARED_INC) \u003d\u003d 0:"},{"line_number":653,"context_line":"            LOG.warning(_LW(\u0027Adding the VIR_MIGRATE_NON_SHARED_INC flag to \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_ad6c3e09","line":650,"in_reply_to":"7a5de9d1_75093231","updated":"2016-01-27 12:25:34.000000000","message":"Thanks for the comment.\n\nI dunno, maybe it\u0027s the C programmer in me, but I feel like this way is a more idiomatic way of dealing with bitwise flags.","commit_id":"3b63f8e32fd223b62f9035a5659679d9542fb6ac"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"5afe2acf0ea8391c9246c3f95ff801240e413f08","unresolved":false,"context_lines":[{"line_number":647,"context_line":"                            \u0027from the live_migration_flag config option \u0027"},{"line_number":648,"context_line":"                            \u0027because it will cause all live-migrations to be \u0027"},{"line_number":649,"context_line":"                            \u0027block-migrations instead.\u0027))"},{"line_number":650,"context_line":"            live_migration_flags \u0026\u003d ~libvirt.VIR_MIGRATE_NON_SHARED_INC"},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"        if (block_migration_flags \u0026 libvirt.VIR_MIGRATE_NON_SHARED_INC) \u003d\u003d 0:"},{"line_number":653,"context_line":"            LOG.warning(_LW(\u0027Adding the VIR_MIGRATE_NON_SHARED_INC flag to \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_d00d9138","line":650,"in_reply_to":"7a5de9d1_ad6c3e09","updated":"2016-01-27 12:28:21.000000000","message":"I agree, this syntax you\u0027ve used is just fine as is. -\u003d is just a different coloured bikeshed/ There\u0027s no problems with ~","commit_id":"3b63f8e32fd223b62f9035a5659679d9542fb6ac"}],"releasenotes/notes/libvirt-live-migration-flags-mangling-a2407a31ddf17427.yaml":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"31f6559cc5596183519f88f1ffa38cc45ee68a97","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The libvirt driver will now correct some safe or invalid"},{"line_number":4,"context_line":"    values for the live_migration_flag and block_migration_flag"},{"line_number":5,"context_line":"    configuration options. The live_migration_flag must not"},{"line_number":6,"context_line":"    contain VIR_MIGRATE_SHARED_INC but block_migration_flag"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa69d971_d4b9017b","line":3,"range":{"start_line":3,"start_character":40,"end_line":3,"end_character":49},"updated":"2016-01-07 13:50:18.000000000","message":"* Don\u0027t you mean \"unsafe\" here?\n* Maybe remove \"some\". There is only one change you name below. Otherwise it could be confusing if there are other changes which are not listed below.","commit_id":"caf9035323c7f357cc122893143a3a4e645da85f"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"4c9a9de392ba2974a4b74ba3dab69e99f93301a4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The libvirt driver will now correct some safe or invalid"},{"line_number":4,"context_line":"    values for the live_migration_flag and block_migration_flag"},{"line_number":5,"context_line":"    configuration options. The live_migration_flag must not"},{"line_number":6,"context_line":"    contain VIR_MIGRATE_SHARED_INC but block_migration_flag"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa69d971_09ec4c8e","line":3,"range":{"start_line":3,"start_character":40,"end_line":3,"end_character":49},"in_reply_to":"fa69d971_d4b9017b","updated":"2016-01-07 21:14:24.000000000","message":"Good catch. Pushed as I6648359be1049f01dce60654402c7a950347433d for now to avoid rebasing the entire series","commit_id":"caf9035323c7f357cc122893143a3a4e645da85f"}]}