)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"30b3eb887f8ed33885f1533be8238a11956b3ce2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"config options: Centralise \u0027vnc\u0027 options"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add options from \u0027vnc\u0027. This includes some typo fixes for the help"},{"line_number":10,"context_line":"strings along with removing some unnecessary \u0027DEFAULT_NAME\u0027 args."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5da0ad8cd42ef8b969ec05c07c497238e92f1f41"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"da6ed579_f33adbe6","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":23},"updated":"2016-01-18 15:09:08.000000000","message":"A bit more context is necessary if one has only this commit to figure out what\u0027s happening. Maybe:\n\n    Move \"vnc\" config options to the central\n    location \"nova/conf/\".","commit_id":"702dd8ff551bed83df2157761d4cef0880ddb62a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2c2a5513dbb7324fef59850648e51c021e409cc5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"config options: Centralise \u0027vnc\u0027 options"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add options from \u0027vnc\u0027. This includes some typo fixes for the help"},{"line_number":10,"context_line":"strings along with removing some unnecessary \u0027DEFAULT_NAME\u0027 args."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5da0ad8cd42ef8b969ec05c07c497238e92f1f41"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba63e191_1a6d5e04","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":23},"in_reply_to":"da6ed579_f33adbe6","updated":"2016-01-19 11:30:41.000000000","message":"Done","commit_id":"702dd8ff551bed83df2157761d4cef0880ddb62a"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"30b3eb887f8ed33885f1533be8238a11956b3ce2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"config options: Centralise \u0027vnc\u0027 options"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add options from \u0027vnc\u0027. This includes some typo fixes for the help"},{"line_number":10,"context_line":"strings along with removing some unnecessary \u0027DEFAULT_NAME\u0027 args."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5da0ad8cd42ef8b969ec05c07c497238e92f1f41"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"da6ed579_2e0fa689","line":10,"range":{"start_line":10,"start_character":19,"end_line":10,"end_character":64},"updated":"2016-01-18 15:09:08.000000000","message":"I don\u0027t get this. I\u0027ve searched for \"DEFAULT_NAME\" in your change but I don\u0027t find anything. What got changed?","commit_id":"702dd8ff551bed83df2157761d4cef0880ddb62a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2c2a5513dbb7324fef59850648e51c021e409cc5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"config options: Centralise \u0027vnc\u0027 options"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add options from \u0027vnc\u0027. This includes some typo fixes for the help"},{"line_number":10,"context_line":"strings along with removing some unnecessary \u0027DEFAULT_NAME\u0027 args."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5da0ad8cd42ef8b969ec05c07c497238e92f1f41"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba63e191_3a72a2e6","line":10,"range":{"start_line":10,"start_character":19,"end_line":10,"end_character":64},"in_reply_to":"da6ed579_2e0fa689","updated":"2016-01-19 11:30:41.000000000","message":"Done","commit_id":"702dd8ff551bed83df2157761d4cef0880ddb62a"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"30b3eb887f8ed33885f1533be8238a11956b3ce2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add options from \u0027vnc\u0027. This includes some typo fixes for the help"},{"line_number":10,"context_line":"strings along with removing some unnecessary \u0027DEFAULT_NAME\u0027 args."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5da0ad8cd42ef8b969ec05c07c497238e92f1f41"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"da6ed579_d3d6b7c2","line":11,"updated":"2016-01-18 15:09:08.000000000","message":"implements bp centralize-config-options","commit_id":"702dd8ff551bed83df2157761d4cef0880ddb62a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2c2a5513dbb7324fef59850648e51c021e409cc5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add options from \u0027vnc\u0027. This includes some typo fixes for the help"},{"line_number":10,"context_line":"strings along with removing some unnecessary \u0027DEFAULT_NAME\u0027 args."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5da0ad8cd42ef8b969ec05c07c497238e92f1f41"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba63e191_fa740ad0","line":11,"in_reply_to":"da6ed579_d3d6b7c2","updated":"2016-01-19 11:30:41.000000000","message":"Done","commit_id":"702dd8ff551bed83df2157761d4cef0880ddb62a"}],"nova/conf/vnc.py":[{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"7da125c19643e78c4af4e5331c6b9f3e2b783c56","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Intel Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_1b79cffc","line":1,"updated":"2016-01-08 06:24:28.000000000","message":"I\u0027m uncomfortable with this. The majority of this code is copied from pre-existing files. Intel shouldn\u0027t be claiming ownership of it by virtue of a move.","commit_id":"2ae7be25ce828f6a59bb129ee9be6d609484ea75"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d7824a863242d8f84fe5d60ba4d05bca24f4b529","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Intel Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_63bff560","line":1,"in_reply_to":"fa69d971_1b79cffc","updated":"2016-01-08 08:57:04.000000000","message":"I figured there were enough significant changes and new code to justify the header, but it doesn\u0027t matter that much so I\u0027m happy to change if required.\n\nIn general, are there any guidelines on when it would be correct to change the license?","commit_id":"2ae7be25ce828f6a59bb129ee9be6d609484ea75"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"539b1b03fa930d236ca9a037720f0f573a6b6c51","unresolved":false,"context_lines":[{"line_number":22,"context_line":"novncproxy_base_url \u003d cfg.StrOpt("},{"line_number":23,"context_line":"    \u0027novncproxy_base_url\u0027,"},{"line_number":24,"context_line":"    default\u003d\u0027http://127.0.0.1:6080/vnc_auto.html\u0027,"},{"line_number":25,"context_line":"    help\u003d\u0027Location of VNC console proxy, in the form \u0027"},{"line_number":26,"context_line":"         \u0027\"http://127.0.0.1:6080/vnc_auto.html\"\u0027,"},{"line_number":27,"context_line":"    deprecated_group\u003d\u0027DEFAULT\u0027)"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_677a3e8a","line":25,"updated":"2016-01-11 15:26:48.000000000","message":"I did the spice changes.  I think the help text for the spice options https://review.openstack.org/#/c/264271/\n\nPlease take a look at my text and comment if needed.  We should have similar help text.","commit_id":"184302f1ce0853c173ff57cdb5cc6a7e23a07392"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"a41d42e70b7ee5cf6de3a354b5f31775507c1bbb","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    xvpvncproxy_host,"},{"line_number":84,"context_line":"    xvpvncproxy_port,"},{"line_number":85,"context_line":"    novncproxy_base_url,"},{"line_number":86,"context_line":"    xvpvncproxy_base_url]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_df4f96bc","line":86,"updated":"2016-01-18 15:51:14.000000000","message":"The two options \"novncproxy_host\" and \"novncproxy_port\" from [1] are missing here. You will see that these are registered as CLI options! You can have a look at \"nova/conf/serial_console.py\" and \"nova/cmd/serialproxy.py\" how I did it there.\n\n[1] https://github.com/openstack/nova/blob/master/nova/cmd/novncproxy.py","commit_id":"702dd8ff551bed83df2157761d4cef0880ddb62a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2c2a5513dbb7324fef59850648e51c021e409cc5","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    xvpvncproxy_host,"},{"line_number":84,"context_line":"    xvpvncproxy_port,"},{"line_number":85,"context_line":"    novncproxy_base_url,"},{"line_number":86,"context_line":"    xvpvncproxy_base_url]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba63e191_5a4af684","line":86,"in_reply_to":"da6ed579_df4f96bc","updated":"2016-01-19 11:30:41.000000000","message":"Done","commit_id":"702dd8ff551bed83df2157761d4cef0880ddb62a"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"30b3eb887f8ed33885f1533be8238a11956b3ce2","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"def list_opts():"},{"line_number":95,"context_line":"    # Because of bug 1395819 in oslo.config we cannot pass in the OptGroup."},{"line_number":96,"context_line":"    # As soon as this bug is fixed is oslo.config and Nova uses the"},{"line_number":97,"context_line":"    # version which contains this fix, we can pass in the OptGroup instead"},{"line_number":98,"context_line":"    # of its name. This allows the generation of the group help too."},{"line_number":99,"context_line":"    return {vnc_group.name: ALL_OPTS}"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_eed8ae81","line":98,"range":{"start_line":95,"start_character":0,"end_line":98,"end_character":68},"updated":"2016-01-18 15:09:08.000000000","message":"This bug is fixed in the mean time.","commit_id":"702dd8ff551bed83df2157761d4cef0880ddb62a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2c2a5513dbb7324fef59850648e51c021e409cc5","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"def list_opts():"},{"line_number":95,"context_line":"    # Because of bug 1395819 in oslo.config we cannot pass in the OptGroup."},{"line_number":96,"context_line":"    # As soon as this bug is fixed is oslo.config and Nova uses the"},{"line_number":97,"context_line":"    # version which contains this fix, we can pass in the OptGroup instead"},{"line_number":98,"context_line":"    # of its name. This allows the generation of the group help too."},{"line_number":99,"context_line":"    return {vnc_group.name: ALL_OPTS}"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba63e191_1a447e72","line":98,"range":{"start_line":95,"start_character":0,"end_line":98,"end_character":68},"in_reply_to":"da6ed579_eed8ae81","updated":"2016-01-19 11:30:41.000000000","message":"Done","commit_id":"702dd8ff551bed83df2157761d4cef0880ddb62a"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"30b3eb887f8ed33885f1533be8238a11956b3ce2","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    # As soon as this bug is fixed is oslo.config and Nova uses the"},{"line_number":97,"context_line":"    # version which contains this fix, we can pass in the OptGroup instead"},{"line_number":98,"context_line":"    # of its name. This allows the generation of the group help too."},{"line_number":99,"context_line":"    return {vnc_group.name: ALL_OPTS}"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_ae8b9667","line":99,"range":{"start_line":99,"start_character":21,"end_line":99,"end_character":26},"updated":"2016-01-18 15:09:08.000000000","message":"that can be removed now","commit_id":"702dd8ff551bed83df2157761d4cef0880ddb62a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2c2a5513dbb7324fef59850648e51c021e409cc5","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    # As soon as this bug is fixed is oslo.config and Nova uses the"},{"line_number":97,"context_line":"    # version which contains this fix, we can pass in the OptGroup instead"},{"line_number":98,"context_line":"    # of its name. This allows the generation of the group help too."},{"line_number":99,"context_line":"    return {vnc_group.name: ALL_OPTS}"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba63e191_3a49428c","line":99,"range":{"start_line":99,"start_character":21,"end_line":99,"end_character":26},"in_reply_to":"da6ed579_ae8b9667","updated":"2016-01-19 11:30:41.000000000","message":"Done","commit_id":"702dd8ff551bed83df2157761d4cef0880ddb62a"}]}