)]}'
{"nova/conf/api_database.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e7199bde1923af4afbf97ff3dfd6f64d1b2d8386","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"api_db_opts \u003d ["},{"line_number":19,"context_line":"    cfg.StrOpt(\u0027connection\u0027,"},{"line_number":20,"context_line":"               help\u003d\u0027The SQLAlchemy connection string to use to connect to \u0027"},{"line_number":21,"context_line":"                    \u0027the Nova API database.\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a061dce_05204747","line":18,"updated":"2016-04-06 15:33:56.000000000","message":"we should add a TODO in here, this is all because we can\u0027t do: conf.register_opts(oslo_db_options.database_opts, \u0027api_database\u0027)","commit_id":"d2c8a7ef4f3ab0989b87b660850e8cbe039968fd"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"a0d9dfd5c53b7924117d9a03ed4de3a55db87331","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"api_db_opts \u003d ["},{"line_number":19,"context_line":"    cfg.StrOpt(\u0027connection\u0027,"},{"line_number":20,"context_line":"               help\u003d\u0027The SQLAlchemy connection string to use to connect to \u0027"},{"line_number":21,"context_line":"                    \u0027the Nova API database.\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a061dce_2cb4227e","line":18,"in_reply_to":"9a061dce_05204747","updated":"2016-04-07 12:11:24.000000000","message":"Yeah, I\u0027ve found the original change which explaind why a re-use was not reasonable. I\u0027m still thinking about a possible solution here.","commit_id":"d2c8a7ef4f3ab0989b87b660850e8cbe039968fd"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e7199bde1923af4afbf97ff3dfd6f64d1b2d8386","unresolved":false,"context_lines":[{"line_number":69,"context_line":"#                 the group \"api_database\". That todo OptGroup should also"},{"line_number":70,"context_line":"#                 have a help text which explains the scope of the"},{"line_number":71,"context_line":"#                 \"api_database\" a little."},{"line_number":72,"context_line":"db_api_opts \u003d ["},{"line_number":73,"context_line":"    cfg.BoolOpt(\u0027enable_new_services\u0027,"},{"line_number":74,"context_line":"                default\u003dTrue,"},{"line_number":75,"context_line":"                help\u003d\u0027Services to be added to the available pool on create\u0027),"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a061dce_ba25400a","line":72,"updated":"2016-04-06 15:33:56.000000000","message":"these feel more like options that should live elsewhere, they are more like compute options really.","commit_id":"d2c8a7ef4f3ab0989b87b660850e8cbe039968fd"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"a0d9dfd5c53b7924117d9a03ed4de3a55db87331","unresolved":false,"context_lines":[{"line_number":69,"context_line":"#                 the group \"api_database\". That todo OptGroup should also"},{"line_number":70,"context_line":"#                 have a help text which explains the scope of the"},{"line_number":71,"context_line":"#                 \"api_database\" a little."},{"line_number":72,"context_line":"db_api_opts \u003d ["},{"line_number":73,"context_line":"    cfg.BoolOpt(\u0027enable_new_services\u0027,"},{"line_number":74,"context_line":"                default\u003dTrue,"},{"line_number":75,"context_line":"                help\u003d\u0027Services to be added to the available pool on create\u0027),"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a061dce_6c773a02","line":72,"in_reply_to":"9a061dce_ba25400a","updated":"2016-04-07 12:11:24.000000000","message":"OK, I\u0027ll find a better place for them.","commit_id":"d2c8a7ef4f3ab0989b87b660850e8cbe039968fd"}],"nova/conf/compute.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e7e745b27ca78e9c5b89a9a09d563412fb40b12e","unresolved":false,"context_lines":[{"line_number":317,"context_line":"                    \u0027Should be empty, \"project\" or \"global\".\u0027),"},{"line_number":318,"context_line":"    cfg.BoolOpt(\u0027enable_new_services\u0027,"},{"line_number":319,"context_line":"                default\u003dTrue,"},{"line_number":320,"context_line":"                help\u003d\u0027Services to be added to the available pool on create\u0027),"},{"line_number":321,"context_line":"    cfg.StrOpt(\u0027instance_name_template\u0027,"},{"line_number":322,"context_line":"               default\u003d\u0027instance-%08x\u0027,"},{"line_number":323,"context_line":"               help\u003d\u0027Template string to be used to generate instance names\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"dab17558_3f23c5a8","line":320,"updated":"2016-05-10 20:19:14.000000000","message":"Ugh, what a stupid option the above is. :( It should DIAF. Also, it has nothing to do with database configuration. Setting this to False causes new service records to be marked disabled upon their creation.","commit_id":"4d6b3cb007e78a6df07e71ab582e005289e4e45f"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"d6d0d310d3ce7f79ac4c85de5f1d0575978da61f","unresolved":false,"context_lines":[{"line_number":317,"context_line":"                    \u0027Should be empty, \"project\" or \"global\".\u0027),"},{"line_number":318,"context_line":"    cfg.BoolOpt(\u0027enable_new_services\u0027,"},{"line_number":319,"context_line":"                default\u003dTrue,"},{"line_number":320,"context_line":"                help\u003d\u0027Services to be added to the available pool on create\u0027),"},{"line_number":321,"context_line":"    cfg.StrOpt(\u0027instance_name_template\u0027,"},{"line_number":322,"context_line":"               default\u003d\u0027instance-%08x\u0027,"},{"line_number":323,"context_line":"               help\u003d\u0027Template string to be used to generate instance names\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"dab17558_91956f34","line":320,"in_reply_to":"dab17558_3f23c5a8","updated":"2016-05-11 10:28:00.000000000","message":"@Jay: IIRC, some people are actively using this, but I don\u0027t have the use case off the top of my head.","commit_id":"4d6b3cb007e78a6df07e71ab582e005289e4e45f"}],"nova/conf/database.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a54e686013f94367b81e9f297ddeacd6b94649b8","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"def list_opts():"},{"line_number":96,"context_line":"    # NOTE(markus_z): 2016-04-04: If we list the oslo_db_options here, they"},{"line_number":97,"context_line":"    #                 get emitted twice(!) in the \"sample.conf\" file. First"},{"line_number":98,"context_line":"    #                 under the namespace \"nova.conf\" and second under the"},{"line_number":99,"context_line":"    #                 namespace \"oslo.db\". This is due to the setting in file"},{"line_number":100,"context_line":"    #                 \"etc/nova/nova-config-generator.conf\". As I think it"},{"line_number":101,"context_line":"    #                 is useful to have the \"oslo.db\" namespace information"},{"line_number":102,"context_line":"    #                 in the \"sample.conf\" file, I omit the listing of the"},{"line_number":103,"context_line":"    #                 \"oslo_db_options\" here."},{"line_number":104,"context_line":"    return {\u0027DEFAULT\u0027: [db_driver_opt],"},{"line_number":105,"context_line":"            \u0027api_database\u0027: api_db_opts,"},{"line_number":106,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":13,"id":"dab17558_95bbd6e4","line":103,"range":{"start_line":96,"start_character":0,"end_line":103,"end_character":45},"updated":"2016-05-16 09:55:03.000000000","message":"Is there a reason you\u0027ve switched to this style of NOTE/TODOs, or is it just preference. Speaking of preference, I would prefer (:)) that we remain consistent with existing NOTE/TODOs in this file...","commit_id":"add3726607ab90cde7425e037a71a0a318af5302"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"e5b1432f30a896150186ad3c4686912415b262d1","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"def list_opts():"},{"line_number":96,"context_line":"    # NOTE(markus_z): 2016-04-04: If we list the oslo_db_options here, they"},{"line_number":97,"context_line":"    #                 get emitted twice(!) in the \"sample.conf\" file. First"},{"line_number":98,"context_line":"    #                 under the namespace \"nova.conf\" and second under the"},{"line_number":99,"context_line":"    #                 namespace \"oslo.db\". This is due to the setting in file"},{"line_number":100,"context_line":"    #                 \"etc/nova/nova-config-generator.conf\". As I think it"},{"line_number":101,"context_line":"    #                 is useful to have the \"oslo.db\" namespace information"},{"line_number":102,"context_line":"    #                 in the \"sample.conf\" file, I omit the listing of the"},{"line_number":103,"context_line":"    #                 \"oslo_db_options\" here."},{"line_number":104,"context_line":"    return {\u0027DEFAULT\u0027: [db_driver_opt],"},{"line_number":105,"context_line":"            \u0027api_database\u0027: api_db_opts,"},{"line_number":106,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":13,"id":"dab17558_f1e67bae","line":103,"range":{"start_line":96,"start_character":0,"end_line":103,"end_character":45},"in_reply_to":"dab17558_95bbd6e4","updated":"2016-05-17 09:03:50.000000000","message":"It\u0027s easier to spot and distinguish from \"normal\" inline comments, that was my only argument. Maybe being consistent is more important. I\u0027ll use the usual style in future patch sets.","commit_id":"add3726607ab90cde7425e037a71a0a318af5302"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"252e18b2971081f6770c95908b10eac3ca51fa21","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"def list_opts():"},{"line_number":96,"context_line":"    # NOTE(markus_z): 2016-04-04: If we list the oslo_db_options here, they"},{"line_number":97,"context_line":"    #                 get emitted twice(!) in the \"sample.conf\" file. First"},{"line_number":98,"context_line":"    #                 under the namespace \"nova.conf\" and second under the"},{"line_number":99,"context_line":"    #                 namespace \"oslo.db\". This is due to the setting in file"},{"line_number":100,"context_line":"    #                 \"etc/nova/nova-config-generator.conf\". As I think it"},{"line_number":101,"context_line":"    #                 is useful to have the \"oslo.db\" namespace information"},{"line_number":102,"context_line":"    #                 in the \"sample.conf\" file, I omit the listing of the"},{"line_number":103,"context_line":"    #                 \"oslo_db_options\" here."},{"line_number":104,"context_line":"    return {\u0027DEFAULT\u0027: [db_driver_opt],"},{"line_number":105,"context_line":"            \u0027api_database\u0027: api_db_opts,"},{"line_number":106,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":13,"id":"dab17558_d832b35d","line":103,"range":{"start_line":96,"start_character":0,"end_line":103,"end_character":45},"in_reply_to":"dab17558_95bbd6e4","updated":"2016-05-16 10:19:17.000000000","message":"this should be a TODO, as we want to remove this soon ish, but it doesn\u0027t block us merging this, as we need to review all these files for consistency soon anyways.","commit_id":"add3726607ab90cde7425e037a71a0a318af5302"}]}